On 03/06/09 15:10, Basant Kukreja wrote:
> On Fri, Mar 06, 2009 at 02:51:37PM +0530, Seema Alevoor wrote:
>> But that still looks incomplete.
>> LIBS is set to nil, then why pass LIBS to apxs ?
>
> Fixed and updated the webrev.
>
>> usr/src/pkgdefs/SUNWapch22r-sed/Makefile still has ident line
On 03/06/09 14:01, Basant Kukreja wrote:
> Thanks Seema for providing the comments.
>
> On Fri, Mar 06, 2009 at 12:13:27PM +0530, Seema Alevoor wrote:
>> Hi Basant,
>>
>> Here are my comments.
>>
>> usr/src/cmd/apache2/modules/apxs-sed.ksh93 :
>> What is "LIBP" used for ?
> Fixed and updated
On 03/06/09 14:31, Basant Kukreja wrote:
> On Fri, Mar 06, 2009 at 02:26:00PM +0530, Seema Alevoor wrote:
>>
usr/src/pkgdefs/SUNWapch22r-sed/Makefile ,
usr/src/pkgdefs/SUNWapch22r-sed/prototype_com :
"renamenew" class action script is used only for configurations in
conf
No, please revert this change.
See CRs 6782602, 6812225
-- Seema.
On 03/06/09 14:16, Basant Kukreja wrote:
> Changed 64 to ::MACH64:: in sed.conf similar to jk.conf. Revised the webrev.
>
> Thanks for reviewing,
> Basant.
>
> On Fri, Mar 06, 2009 at 02:14:40PM +0530, rahul wrote:
>> | Thanks fo
On 03/06/09 14:01, Basant Kukreja wrote:
> Thanks Seema for providing the comments.
>
> On Fri, Mar 06, 2009 at 12:13:27PM +0530, Seema Alevoor wrote:
>> Hi Basant,
>>
>> Here are my comments.
>>
>> usr/src/cmd/apache2/modules/apxs-sed.ksh93 :
>> What is "LIBP" used for ?
> Fixed and updated
| Changed 64 to ::MACH64:: in sed.conf similar to jk.conf. Revised the webrev.
oops, see seema's response.
| Thanks for reviewing,
| Basant.
|
| On Fri, Mar 06, 2009 at 02:14:40PM +0530, rahul wrote:
| > | Thanks for reviewing :
| > |
| > | On Fri, Mar 06, 2009 at 12:20:12PM +0530, rahul wrote:
On 03/06/09 14:14, rahul wrote:
> | Thanks for reviewing :
> |
> | On Fri, Mar 06, 2009 at 12:20:12PM +0530, rahul wrote:
> | > - sed module.conf says
> | > +++ new/usr/src/cmd/apache2/modules/sed.confThu Mar 5 18:31:19 2009
> | * security2.conf, fcgid.conf all takes the same approach :
> |
On 03/06/09 13:36, Basant Kukreja wrote:
> Thanks for reviewing :
>
> On Fri, Mar 06, 2009 at 12:20:12PM +0530, rahul wrote:
>> - sed module.conf says
>> +++ new/usr/src/cmd/apache2/modules/sed.confThu Mar 5 18:31:19 2009
> * security2.conf, fcgid.conf all takes the same approach :
> * Sinc
| Thanks for reviewing :
|
| On Fri, Mar 06, 2009 at 12:20:12PM +0530, rahul wrote:
| > - sed module.conf says
| > +++ new/usr/src/cmd/apache2/modules/sed.confThu Mar 5 18:31:19 2009
| * security2.conf, fcgid.conf all takes the same approach :
| * Since sed.conf is architechture independent,
[Sriram Natarajan:]
> looks good to me
- Actually depends need to list only apache, all others are required by
apache.
- sed module.conf says
+++ new/usr/src/cmd/apache2/modules/sed.confThu Mar 5 18:31:19 2009
@@ -0,0 +1,7 @@
+
+LoadModule sed_module libexec/64/mod_sed.so
+
but the prot
Hi Basant,
Here are my comments.
usr/src/cmd/apache2/modules/apxs-sed.ksh93 :
What is "LIBP" used for ?
usr/src/cmd/apache2/modules/sed.mk :
Do you really need this line ?
find $(SED_VER)-$* -type d -exec chmod go+rx {} +
I don't see any directories within mod_sed-
On Fri, Mar 06, 2009 at 02:51:37PM +0530, Seema Alevoor wrote:
> But that still looks incomplete.
> LIBS is set to nil, then why pass LIBS to apxs ?
Fixed and updated the webrev.
> usr/src/pkgdefs/SUNWapch22r-sed/Makefile still has ident line above copyright
> info.
>
Fixed and updated the webr
Fixed following issues and revised the webrev.
* Reverted ::MACH64:: to 64
* Fixed copyright format in both depend file as suggested by link:
http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/prototypes/prototype.Makefile
Seema's concern of i.renamenew issue is pending, waiting for he
On Fri, Mar 06, 2009 at 02:26:00PM +0530, Seema Alevoor wrote:
>
>
>>> usr/src/pkgdefs/SUNWapch22r-sed/Makefile ,
>>> usr/src/pkgdefs/SUNWapch22r-sed/prototype_com :
>>> "renamenew" class action script is used only for configurations in
>>> conf.d directory.
>> Can you elaborate? I took the
Changed 64 to ::MACH64:: in sed.conf similar to jk.conf. Revised the webrev.
Thanks for reviewing,
Basant.
On Fri, Mar 06, 2009 at 02:14:40PM +0530, rahul wrote:
> | Thanks for reviewing :
> |
> | On Fri, Mar 06, 2009 at 12:20:12PM +0530, rahul wrote:
> | > - sed module.conf says
> | > +++ new/u
Thanks Seema for providing the comments.
On Fri, Mar 06, 2009 at 12:13:27PM +0530, Seema Alevoor wrote:
> Hi Basant,
>
> Here are my comments.
>
> usr/src/cmd/apache2/modules/apxs-sed.ksh93 :
> What is "LIBP" used for ?
Fixed and updated the webrev.
>
> usr/src/cmd/apache2/modules/sed.mk :
>
Thanks for reviewing :
On Fri, Mar 06, 2009 at 12:20:12PM +0530, rahul wrote:
> - sed module.conf says
> +++ new/usr/src/cmd/apache2/modules/sed.confThu Mar 5 18:31:19 2009
* security2.conf, fcgid.conf all takes the same approach :
* Since sed.conf is architechture independent, it has two ch
17 matches
Mail list logo
