Re: Wicket site v2.0

2006-12-11 Thread Paolo Di Tommaso
Very nice +1 - Paolo On 12/11/06, Martijn Dashorst <[EMAIL PROTECTED]> wrote: Vincent delivered, and came up with a nice follow up to the previous design. http://issues.apache.org/jira/secure/attachment/12346927/wicket_v2.png Any feedback on this one? Can we move forward and rework http://

Re: Wicket site v2.0

2006-12-11 Thread Matej Knopp
Martijn Dashorst wrote: Vincent delivered, and came up with a nice follow up to the previous design. http://issues.apache.org/jira/secure/attachment/12346927/wicket_v2.png Any feedback on this one? Can we move forward and rework http://cwiki.apache.org/WICKETxSITE using this design? Martijn

Re: Wicket site v2.0

2006-12-11 Thread Gwyn Evans
Nice - go for it. /Gwyn On 11/12/06, Martijn Dashorst <[EMAIL PROTECTED]> wrote: Vincent delivered, and came up with a nice follow up to the previous design. http://issues.apache.org/jira/secure/attachment/12346927/wicket_v2.png Any feedback on this one? Can we move forward and rework http://

Re: Wicket site v2.0

2006-12-11 Thread Eelco Hillenius
Yeah, very nice, very big improvement. +1 Eelco On 12/11/06, Martijn Dashorst <[EMAIL PROTECTED]> wrote: Vincent delivered, and came up with a nice follow up to the previous design. http://issues.apache.org/jira/secure/attachment/12346927/wicket_v2.png Any feedback on this one? Can we move

Re: Last change required for reloading classes

2006-12-11 Thread Eelco Hillenius
BTW, is the reloading filter portable to Wicket-2.0? do you see any problem in using it with w-2.0? I first wanted the implementation stable enough before we port the changes to 2.0. There need to be a couple of tweaks before that filter can be used, but not big things. Eelco

Re: Wicket site v2.0

2006-12-11 Thread Justin Lee
-BEGIN PGP SIGNED MESSAGE- Hash: RIPEMD160 sexy. +1 fwiw Igor Vaynberg wrote: > +1 hell yeah > > (notice how i didnt write +10 or 1) /me ducks > > -igor > > > On 12/11/06, Martijn Dashorst <[EMAIL PROTECTED]> wrote: >> >> Vincent delivered, and came up with a nice follow up t

Re: Wicket site v2.0

2006-12-11 Thread Frank Bille
Uhh the previous was nice but this one is really cool. +1 from me :) Frank On 12/11/06, Martijn Dashorst <[EMAIL PROTECTED]> wrote: Vincent delivered, and came up with a nice follow up to the previous design. http://issues.apache.org/jira/secure/attachment/12346927/wicket_v2.png Any feedbac

Re: Wicket site v2.0

2006-12-11 Thread Igor Vaynberg
+1 hell yeah (notice how i didnt write +10 or 1) /me ducks -igor On 12/11/06, Martijn Dashorst <[EMAIL PROTECTED]> wrote: Vincent delivered, and came up with a nice follow up to the previous design. http://issues.apache.org/jira/secure/attachment/12346927/wicket_v2.png Any feedback

Wicket site v2.0

2006-12-11 Thread Martijn Dashorst
Vincent delivered, and came up with a nice follow up to the previous design. http://issues.apache.org/jira/secure/attachment/12346927/wicket_v2.png Any feedback on this one? Can we move forward and rework http://cwiki.apache.org/WICKETxSITE using this design? Martijn -- Vote for Wicket at the

Re: AjaxFormComponentUpdatingBehavior.onEvent behaviour

2006-12-11 Thread Igor Vaynberg
i think that was legacy behavior because onError() did not always exist. feel free to fix it, in 1.3 we can make the break -igor On 12/11/06, Johan Compagner <[EMAIL PROTECTED]> wrote: We now have this: protected final void onEvent(final AjaxRequestTarget target) { final FormCom

Re: Last change required for reloading classes

2006-12-11 Thread Igor Vaynberg
if it doesnt work 100% of the time then imho it shouldnt be in the core, i think it should go into a separate module or extensions. -igor On 12/11/06, Eelco Hillenius <[EMAIL PROTECTED]> wrote: Sure, done. The issue is still open. I'm still not convinced we should ship the reloading filter t

AjaxFormComponentUpdatingBehavior.onEvent behaviour

2006-12-11 Thread Johan Compagner
We now have this: protected final void onEvent(final AjaxRequestTarget target) { final FormComponent formComponent = getFormComponent(); boolean callOnUpdate = true; try { formComponent.inputChanged(); formComponent.validate(); if (

Re: Re: VOTE: focus on popups by default in Wicket 1.2.x

2006-12-11 Thread Martijn Dashorst
+0 I think discussing the benefits of not applying this patch to 1.2.4 will cost more than the actual act. Eelco thinks it is worth his time to apply the patch, otherwise he wouldn't have proposed the vote. The whole point of requiring a vote is to remove the automatic knee jerk to apply backpor

Re: VOTE: focus on popups by default in Wicket 1.2.x

2006-12-11 Thread Gwyn Evans
On 11/12/06, Eelco Hillenius <[EMAIL PROTECTED]> wrote: [ ] sure put it in 1.2.x [ X] nah, people can do it themselves, let's not worry about it My feeling is that at this point, we should be actively avoiding a new 1.2 release and not adding things. On this specific point, surely existing de

Re: Last change required for reloading classes

2006-12-11 Thread Filippo Diotalevi
On 12/11/06, Eelco Hillenius <[EMAIL PROTECTED]> wrote: Sure, done. The issue is still open. I'm still not convinced we should ship the reloading filter tbh. As it only works with quite a few ifs and buts, I'd rather see the reloading filter (and class locator) to be part of wicket-extensions or

Re: Last change required for reloading classes

2006-12-11 Thread Jean-Baptiste Quenot
* Eelco Hillenius: > As it only works with quite a few ifs and buts, It works great with the wicket-examples and all Wicket applications, but it's true that things get more complicated when using a component manager like Spring, because then you need to have proper separation be

Re: svn commit: r485536 - /incubator/wicket/trunk/wicket/src/main/java/wicket/Resource.java

2006-12-11 Thread Eelco Hillenius
That code won't work for Jetty 6 (on a unix like platform at least), as it throws a SocketException with message "Broken pipe". In fact, it throws a EofException (extends IOException), with a SocketException nested. I take it that you loop through the nested exceptions as well in Cocoon? Eelco

Re: svn commit: r485536 - /incubator/wicket/trunk/wicket/src/main/java/wicket/Resource.java

2006-12-11 Thread Eelco Hillenius
Hi Eelco, I didn't necessarily follow the whole debate, but I wonder why you have to catch an SQLException in Wicket code! Do you assume the Wicket application retrieves data from an SQL database? It's actually the opposite: we *don't* want to catch SQL exceptions, *but* SQL exceptions is on

Re: Last change required for reloading classes

2006-12-11 Thread Eelco Hillenius
Sure, done. The issue is still open. I'm still not convinced we should ship the reloading filter tbh. As it only works with quite a few ifs and buts, I'd rather see the reloading filter (and class locator) to be part of wicket-extensions or maybe as a WIKI article or such. Though I'm fine with th

Last change required for reloading classes

2006-12-11 Thread Jean-Baptiste Quenot
Hi, The code to reload classes is already in Wicket branch 1.x, but there's a (hopefully) last fix to apply. Could one of you please have a look at: https://issues.apache.org/jira/secure/attachment/12346428/20061205-wicket-1.x-ReloadingClassLoader * Use ArrayList instead of HashSet for the pa

Re: svn commit: r485536 - /incubator/wicket/trunk/wicket/src/main/java/wicket/Resource.java

2006-12-11 Thread Jean-Baptiste Quenot
* [EMAIL PROTECTED]: > Author: ehillenius > Date: Sun Dec 10 23:19:58 2006 > New Revision: 485536 > > URL: http://svn.apache.org/viewvc?view=rev&rev=485536 > Log: > WICKET-155 > > Modified: > incubator/wicket/trunk/wicket/src/main/java/wicket/Resource.java > > Modified: incubator/wicket/trun