Re: Re: [Vote] Should submit of outer forms process inner forms?

2006-11-23 Thread Martijn Dashorst
Vote summary: 4 times C (of which 2 with a default for false) 1 times B Martijn On 11/7/06, Johan Compagner <[EMAIL PROTECTED]> wrote: C: default return false. johan On 11/6/06, Matej Knopp <[EMAIL PROTECTED]> wrote: > > Hi. > > As you may have noticed, we have nested forms support in Wicke

Re: [Vote] Should submit of outer forms process inner forms?

2006-11-07 Thread Johan Compagner
C: default return false. johan On 11/6/06, Matej Knopp <[EMAIL PROTECTED]> wrote: Hi. As you may have noticed, we have nested forms support in Wicket 2.0. (Please, this is not about whether we should/should not support nested forms, so don't discuss it in this thread). The question is, wha

Re: Re: [Vote] Should submit of outer forms process inner forms?

2006-11-06 Thread Dirk Markert
I like the simple solution: b) Inner forms should not be processed, just preserving user input is fine. Dirk

Re: Re: [Vote] Should submit of outer forms process inner forms?

2006-11-06 Thread Frank Bille
well, and in our application we *mostly* uses the button.onsubmit but for a search field we use the form.onsubmit. Frank On 11/6/06, Martijn Dashorst <[EMAIL PROTECTED]> wrote: Typically I never have more than one button on a form that matters: save. This is then the submit button (no wicket

Re: Re: [Vote] Should submit of outer forms process inner forms?

2006-11-06 Thread Martijn Dashorst
Typically I never have more than one button on a form that matters: save. This is then the submit button (no wicket component), and the cancel is just a link. So I've probably never implemented button.onSubmit() other then for examples. Martijn On 11/6/06, Igor Vaynberg <[EMAIL PROTECTED]> wrot

Re: [Vote] Should submit of outer forms process inner forms?

2006-11-06 Thread Igor Vaynberg
fwiw, in my time as a wicket dev/user i dont think ive ever overridden form.onsubmit(), i always put that behavior into the button's onsubmit(). -igor On 11/6/06, Martijn Dashorst <[EMAIL PROTECTED]> wrote: C with default value 'false' -> default does not process inner form. IMO a form in a pa

Re: [Vote] Should submit of outer forms process inner forms?

2006-11-06 Thread Martijn Dashorst
C with default value 'false' -> default does not process inner form. IMO a form in a panel is not *typically* designed for processing in an outer form. Take for instance: Form outer = new Form(this, "outer") { protected void onSubmit() { session.save(getModelObject()); } } Form inn

Re: [Vote] Should submit of outer forms process inner forms?

2006-11-06 Thread Matej Knopp
Frank Bille wrote: I think for completeness we should have: d) Throw a RuntimeException when nested forms are detected, because it's not allowed in HTML. No we shouldn't. If you want to discuss this, go ahead, but in a different thread. :) -Matej But personally I vote for (C) Frank On 11/

Re: [Vote] Should submit of outer forms process inner forms?

2006-11-06 Thread Frank Bille
I think for completeness we should have: d) Throw a RuntimeException when nested forms are detected, because it's not allowed in HTML. But personally I vote for (C) Frank On 11/6/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote: imho it is the inner forms that knowsif they were designed to be embe

Re: [Vote] Should submit of outer forms process inner forms?

2006-11-06 Thread Igor Vaynberg
imho it is the inner forms that knowsif they were designed to be embeddable or not, so i am for (c) -igor On 11/6/06, Matej Knopp <[EMAIL PROTECTED]> wrote: Hi. As you may have noticed, we have nested forms support in Wicket 2.0. (Please, this is not about whether we should/should not suppo

Re: [Vote] Should submit of outer forms process inner forms?

2006-11-06 Thread Eelco Hillenius
I vote for C Eelco On 11/6/06, Matej Knopp <[EMAIL PROTECTED]> wrote: Hi. As you may have noticed, we have nested forms support in Wicket 2.0. (Please, this is not about whether we should/should not support nested forms, so don't discuss it in this thread). The question is, what should happ