Re: [Wikitech-l] I'm in ur trunk, reviewing pre-1.18 branch code

2011-06-07 Thread Ashar Voultoiz
On 07/06/11 20:56, Brion Vibber wrote: > Currently working (mostly backwards) to fill in the Code Review holes from > before 1.18 branch point: Since ci.tesla is almost stable since last week, I have switched to reviewing 1.18. I might have added some bugs in the 1.17 backport queue. Is there an

[MediaWiki-CodeReview] [MediaWiki r85323]: New comment added

2011-06-07 Thread MediaWiki Mail
User "Hashar" posted a comment on MediaWiki.r85323. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85323#c17856 Commit summary: Type hints to substring used in integer addition Comment: I got your point. Maybe use meaningful variables instead? $hour = substr( $now, 8, 2 ) $m

[MediaWiki-CodeReview] [MediaWiki r89713]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User "Hashar" changed the status of MediaWiki.r89713. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89713#c0 Commit summary: Revert r87145, bug 28752: Xcache doesn't work in cli mode. As pointed out on CR, this didn't fix it, it just hid the issue

[MediaWiki-CodeReview] [MediaWiki r89676]: New comment added

2011-06-07 Thread MediaWiki Mail
User "Tim Starling" posted a comment on MediaWiki.r89676. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89676#c17855 Commit summary: 1.17: MFT r82247, r87203, r87265, r87494, r87497, r87711, r87840, r88076, r89615 Comment: Did you mean to backport r87711? I thought we weren't g

[MediaWiki-CodeReview] [MediaWiki r89316]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User "Tim Starling" changed the status of MediaWiki.r89316. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89316#c0 Commit summary: MFT r89311 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@li

[MediaWiki-CodeReview] [MediaWiki r89252]: New comment added, and revision status changed

2011-06-07 Thread MediaWiki Mail
User "Tim Starling" changed the status of MediaWiki.r89252. Old Status: ok New Status: fixme User "Tim Starling" also posted a comment on MediaWiki.r89252. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89252#c17854 Commit summary: * MFT r89250. only the tableExists function ad

[MediaWiki-CodeReview] [MediaWiki r87870]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User "MaxSem" changed the status of MediaWiki.r87870. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87870#c0 Commit summary: readding generic public domain option per comments at r87862 ___ MediaWiki-Cod

[MediaWiki-CodeReview] [MediaWiki r88475]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User "MaxSem" changed the status of MediaWiki.r88475. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88475#c0 Commit summary: Patch for Bug #28669, “Scream bloody murder when user chooses MyISAM and InnoDB is available” From William Demchick

[MediaWiki-CodeReview] [MediaWiki r89037]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User "MaxSem" changed the status of MediaWiki.r89037. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89037#c0 Commit summary: More parameter documentation!! ___ MediaWiki-CodeReview mailing list mediawiki

[MediaWiki-CodeReview] [MediaWiki r89586]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User "MaxSem" changed the status of MediaWiki.r89586. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89586#c0 Commit summary: Revert r89263, r89297, r89347: unclear whether this is needed; DatabaseUpdater actions list is already extensible and it m

[MediaWiki-CodeReview] [MediaWiki r88201]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User "Tim Starling" changed the status of MediaWiki.r88201. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88201#c0 Commit summary: MFT r87512 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@li

[MediaWiki-CodeReview] [MediaWiki r88946]: New comment added, and revision status changed

2011-06-07 Thread MediaWiki Mail
User "Tim Starling" changed the status of MediaWiki.r88946. Old Status: ok New Status: fixme User "Tim Starling" also posted a comment on MediaWiki.r88946. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88946#c17853 Commit summary: Fix Bug #28829 - “Failure to subscribe to media

[MediaWiki-CodeReview] [MediaWiki r89637]: New comment added

2011-06-07 Thread MediaWiki Mail
User "Patrick Nagel" posted a comment on MediaWiki.r89637. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89637#c17852 Commit summary: Initial commit of new extension Notificator Comment: Thanks for your advice, Nikerabbit. I gave it some more work now: * r89714: Removed wfLoa

[MediaWiki-CodeReview] [MediaWiki r88936]: New comment added

2011-06-07 Thread MediaWiki Mail
User "MarkAHershberger" posted a comment on MediaWiki.r88936. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88936#c17851 Commit summary: This needs to be forward-ported to trunk. Fix for Bug #28172 - wfGetDB called when it shouldn't be Avoid an ominous error (“Mediawiki tried t

[MediaWiki-CodeReview] [MediaWiki r89374]: New comment added, and revision status changed

2011-06-07 Thread MediaWiki Mail
User "Tim Starling" changed the status of MediaWiki.r89374. Old Status: new New Status: fixme User "Tim Starling" also posted a comment on MediaWiki.r89374. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89374#c17850 Commit summary: Finish fix for bug #28172 (“wfGetDB called whe

[MediaWiki-CodeReview] [MediaWiki r88936]: New comment added, and revision status changed

2011-06-07 Thread MediaWiki Mail
User "Tim Starling" changed the status of MediaWiki.r88936. Old Status: new New Status: fixme User "Tim Starling" also posted a comment on MediaWiki.r88936. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88936#c17849 Commit summary: This needs to be forward-ported to trunk. Fix

[MediaWiki-CodeReview] [MediaWiki r88929]: New comment added, and revision status changed

2011-06-07 Thread MediaWiki Mail
User "Tim Starling" changed the status of MediaWiki.r88929. Old Status: new New Status: fixme User "Tim Starling" also posted a comment on MediaWiki.r88929. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88929#c17848 Commit summary: Commiting here, because other problems exist o

[MediaWiki-CodeReview] [MediaWiki r89717]: New comment added

2011-06-07 Thread MediaWiki Mail
User "MZMcBride" posted a comment on MediaWiki.r89717. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89717#c17847 Commit summary: Fix Bug #18831 (“Wikibugs should use real name instead of e-mail prefix when reporting on IRC“) with a patch adapted from MZ's patch to fix. Comment:

[MediaWiki-CodeReview] [MediaWiki r88929]: New comment added

2011-06-07 Thread MediaWiki Mail
User "Tim Starling" posted a comment on MediaWiki.r88929. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88929#c17846 Commit summary: Commiting here, because other problems exist on trunk. This needs to be forward-ported to trunk. * Make Pg installation work for lesser privilege

Re: [Wikitech-l] [Foundation-l] YouTube and Creative Commons

2011-06-07 Thread Michael Dale
On 06/04/2011 06:43 PM, David Gerard wrote: > A question that wasn't clear from reading the bug: why is reading a > file format (WebM) blocked on the entire Timed Media Handler? It would be complicated to support WebM without an improved player and transcoding support. All the IE users for example

[MediaWiki-CodeReview] [MediaWiki r88575]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r88575. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88575#c0 Commit summary: Code tweaks, show filtering by tag Improve comments ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r88550]: New comment added

2011-06-07 Thread MediaWiki Mail
User "^demon" posted a comment on MediaWiki.r88550. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88550#c17845 Commit summary: * (bug 29033) Filter is lost when I'm submitting the search form Comment: Have I mentioned how much Pager sucks? _

[MediaWiki-CodeReview] [MediaWiki r88550]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r88550. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88550#c0 Commit summary: * (bug 29033) Filter is lost when I'm submitting the search form ___ MediaWiki

[MediaWiki-CodeReview] [MediaWiki r89377]: New comment added, and revision status changed

2011-06-07 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r89377. Old Status: deferred New Status: new User "^demon" also posted a comment on MediaWiki.r89377. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89377#c17844 Commit summary: * Rewrite optionToTable to be like a modern maintenance

[MediaWiki-CodeReview] [MediaWiki r89619]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r89619. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89619#c0 Commit summary: Current version of CommonSettings.php that lives in /home/wikipedia/common/php-1.17/wmf-config. This may get out of sync b

[MediaWiki-CodeReview] [MediaWiki r89707]: New comment added

2011-06-07 Thread MediaWiki Mail
User "^demon" posted a comment on MediaWiki.r89707. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89707#c17843 Commit summary: quick fix for bug28983 . Do not use $path in the loop. Even the remaining $e is dangerous subject to change from the require-once-loaded extensions. Thi

[MediaWiki-CodeReview] [MediaWiki r89638]: New comment added

2011-06-07 Thread MediaWiki Mail
User "^demon" posted a comment on MediaWiki.r89638. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89638#c17842 Commit summary: Use preg_replace_callback() instead of preg_repace() with /e, also some style fixes Comment: Could've moved it all into a class :) __

[MediaWiki-CodeReview] [MediaWiki r89638]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r89638. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89638#c0 Commit summary: Use preg_replace_callback() instead of preg_repace() with /e, also some style fixes ___

[MediaWiki-CodeReview] [MediaWiki r89710]: New comment added, and revision status changed

2011-06-07 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r89710. Old Status: new New Status: fixme User "^demon" also posted a comment on MediaWiki.r89710. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89710#c17841 Commit summary: add back json support Comment: * Please do not use $_GET

[MediaWiki-CodeReview] [MediaWiki r89026]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r89026. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89026#c0 Commit summary: MFT r89025 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wi

[MediaWiki-CodeReview] [MediaWiki r89025]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r89025. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89025#c0 Commit summary: Fix silly bug covered up by using newer PHP than the cluster ___ MediaWiki-Cod

[MediaWiki-CodeReview] [MediaWiki r88294]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r88294. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88294#c0 Commit summary: * (bug 29022) Link to disable email notifications should be in the email notification Adds a line linking to Special:Pref

[MediaWiki-CodeReview] [MediaWiki r88057]: New comment added

2011-06-07 Thread MediaWiki Mail
User "Helder.wiki" posted a comment on MediaWiki.r88057. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88057#c17840 Commit summary: Reorganizing directories Comment: For some reason the page [[Special:Version]] is showing "" instead of the correct text which is in the localiza

[MediaWiki-CodeReview] [MediaWiki r87867]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r87867. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87867#c0 Commit summary: fix bug 28918 -- errant commas caused undefined regexes, which cause match() to return empty array in IE, which == true!!

[MediaWiki-CodeReview] [MediaWiki r68904]: New comment added

2011-06-07 Thread MediaWiki Mail
User "Peachey88" posted a comment on MediaWiki.r68904. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/68904#c17839 Commit summary: (bug 24212) Added MediaWiki:ImagePage.css which is also included on foreign client wikis. Comment: We should probably have a switch to enable this,

[MediaWiki-CodeReview] [MediaWiki r68904]: New comment added

2011-06-07 Thread MediaWiki Mail
User "Peachey88" posted a comment on MediaWiki.r68904. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/68904#c17838 Commit summary: (bug 24212) Added MediaWiki:ImagePage.css which is also included on foreign client wikis. Comment: There is a tad of a difference between "oh hey,

[MediaWiki-CodeReview] [MediaWiki r87448]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r87448. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87448#c0 Commit summary: 1.17wmf1: Partially revert r87353, which per CR messed up GNSM ___ MediaWiki-C

[MediaWiki-CodeReview] [MediaWiki r87353]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r87353. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87353#c0 Commit summary: 1.17wmf1: MFT r85546, r86409, r86450, r86625, r86788, r86805, r86841, r86904, r87030, r87153 __

[MediaWiki-CodeReview] [MediaWiki r87234]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r87234. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87234#c0 Commit summary: Re-adding the logging hack from r83994 since bug 27891 has been reopened ___ M

[MediaWiki-CodeReview] [MediaWiki r87162]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r87162. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87162#c0 Commit summary: 1.17wmf1: Fix bug in auprop=blockinfo, presumably caused by a botched merge. _

[MediaWiki-CodeReview] [MediaWiki r87000]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r87000. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87000#c0 Commit summary: changing cookie expiry to 90 days as per request, will be backported to trunk later _

[MediaWiki-CodeReview] [MediaWiki r87145]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r87145. Old Status: fixme New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87145#c0 Commit summary: (bug 28752) XCache doesn't work in CLI mode ___ MediaWiki-CodeReview m

[MediaWiki-CodeReview] [MediaWiki r87144]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r87144. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87144#c0 Commit summary: Fix group by for Special:MostLinkedTemplates ___ MediaWiki-CodeReview ma

[MediaWiki-CodeReview] [MediaWiki r87143]: New comment added, and revision status changed

2011-06-07 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r87143. Old Status: fixme New Status: ok User "Brion VIBBER" also posted a comment on MediaWiki.r87143. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87143#c17837 Commit summary: Followup to r85907, correctly quote table names

[MediaWiki-CodeReview] [MediaWiki r87143]: New comment added, and revision status changed

2011-06-07 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r87143. Old Status: new New Status: fixme User "Brion VIBBER" also posted a comment on MediaWiki.r87143. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87143#c17836 Commit summary: Followup to r85907, correctly quote table name

[MediaWiki-CodeReview] [MediaWiki r87145]: New comment added, and revision status changed

2011-06-07 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r87145. Old Status: new New Status: fixme User "Brion VIBBER" also posted a comment on MediaWiki.r87145. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87145#c17835 Commit summary: (bug 28752) XCache doesn't work in CLI mode C

[MediaWiki-CodeReview] [MediaWiki r87163]: New comment added, and revision status changed

2011-06-07 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r87163. Old Status: fixme New Status: ok User "Brion VIBBER" also posted a comment on MediaWiki.r87163. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87163#c17830 Commit summary: Use a reversed magnify image for framed image t

[MediaWiki-CodeReview] [MediaWiki r87164]: New comment added

2011-06-07 Thread MediaWiki Mail
User "Brion VIBBER" posted a comment on MediaWiki.r87164. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87164#c17834 Commit summary: Recommit r87129 and follow-ups but with a fix for the bug Brion found (sorry) Comment: Does all this stuff for partial rows have anything to do w

[MediaWiki-CodeReview] [MediaWiki r87212]: New comment added

2011-06-07 Thread MediaWiki Mail
User "Krinkle" posted a comment on MediaWiki.r87212. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87212#c17833 Commit summary: Added wgIsMainPage (Title->isMainPage) to mw.config * Instead of ugly javascript construction to compare href-attributes or re-constructing proper page

[MediaWiki-CodeReview] [MediaWiki r87212]: New comment added

2011-06-07 Thread MediaWiki Mail
User "Krinkle" posted a comment on MediaWiki.r87212. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87212#c17832 Commit summary: Added wgIsMainPage (Title->isMainPage) to mw.config * Instead of ugly javascript construction to compare href-attributes or re-constructing proper page

[MediaWiki-CodeReview] [MediaWiki r87212]: New comment added

2011-06-07 Thread MediaWiki Mail
User "Brion VIBBER" posted a comment on MediaWiki.r87212. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87212#c17831 Commit summary: Added wgIsMainPage (Title->isMainPage) to mw.config * Instead of ugly javascript construction to compare href-attributes or re-constructing proper

[MediaWiki-CodeReview] [MediaWiki r87166]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r87166. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87166#c0 Commit summary: I have no idea where that count() pass in r87165 ___ MediaWiki-CodeRevie

[MediaWiki-CodeReview] [MediaWiki r87165]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r87165. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87165#c0 Commit summary: Properly escape the ouput in action=credits (and in page footer), using wfMessage() to be able to replace some

Re: [Wikitech-l] Showing stub links by default - is it possible in a Wikimedia project?

2011-06-07 Thread Happy-melon
"Platonides" wrote in message news:isjjo3$dmq$1...@dough.gmane.org... > Ashar Voultoiz wrote: >> On 06/06/11 00:56, K. Peachey wrote: >> Since it skips cache, can not we disable that stub highlighter once for all? >>> Logged in users don't get cached versions of the page... >> >> I a

[MediaWiki-CodeReview] [MediaWiki r89712]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r89712. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89712#c0 Commit summary: Revert r87173: adds 'wrap: break-word' which seems opposite to what pre blocks are meant to do. _

[MediaWiki-CodeReview] [MediaWiki r87173]: New comment added, and revision status changed

2011-06-07 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r87173. Old Status: new New Status: reverted User "Brion VIBBER" also posted a comment on MediaWiki.r87173. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87173#c17829 Commit summary: Bug 27047: Nicer design for pre elements in

[MediaWiki-CodeReview] [MediaWiki r85918]: New comment added

2011-06-07 Thread MediaWiki Mail
User "Brion VIBBER" posted a comment on MediaWiki.r85918. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85918#c17828 Commit summary: Improvements to handling of 'catastrophic' errors, like unsupported PHP versions, no MySQL functions, no LocalSettings, etc. * Fix parsing of the

[MediaWiki-CodeReview] [MediaWiki r88145]: New comment added, and revision status changed

2011-06-07 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r88145. Old Status: new New Status: fixme User "Brion VIBBER" also posted a comment on MediaWiki.r88145. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88145#c17827 Commit summary: Follow-up r87176: Make importDump.php import f

[MediaWiki-CodeReview] [MediaWiki r85918]: New comment added

2011-06-07 Thread MediaWiki Mail
User "Happy-melon" posted a comment on MediaWiki.r85918. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85918#c17826 Commit summary: Improvements to handling of 'catastrophic' errors, like unsupported PHP versions, no MySQL functions, no LocalSettings, etc. * Fix parsing of the t

[MediaWiki-CodeReview] [MediaWiki r81536]: New comment added

2011-06-07 Thread MediaWiki Mail
User "RobLa-WMF" posted a comment on MediaWiki.r81536. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81536#c17825 Commit summary: (bug 19751) Filesystem is now checked during image undeletion * FSRepo::storeBatch() now does an sha1 check unless SKIP_VALIDATION flag is set * Intro

[MediaWiki-CodeReview] [MediaWiki r88148]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r88148. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88148#c0 Commit summary: Follow-up r87176 use wfLocalFile instead of wfFindFile ___ MediaWiki-Cod

[MediaWiki-CodeReview] [MediaWiki r85911]: New comment added, and revision status changed

2011-06-07 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r85911. Old Status: new New Status: ok User "Brion VIBBER" also posted a comment on MediaWiki.r85911. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85911#c17824 Commit summary: Add support for importing/exporting files. This c

[MediaWiki-CodeReview] [MediaWiki r86131]: New comment added

2011-06-07 Thread MediaWiki Mail
User "Aaron Schulz" posted a comment on MediaWiki.r86131. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86131#c17823 Commit summary: * Pass around parser options instead of users and made some parser options consistency fixes * Moved makeParserOptions to Article.php * Renamed cu

[MediaWiki-CodeReview] [MediaWiki r87176]: New comment added, and revision status changed

2011-06-07 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r87176. Old Status: new New Status: ok User "Brion VIBBER" also posted a comment on MediaWiki.r87176. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87176#c17822 Commit summary: Add --include-files option to dumpBackup.php to i

[MediaWiki-CodeReview] [MediaWiki r87243]: New comment added, and revision status changed

2011-06-07 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r87243. Old Status: new New Status: fixme User "Brion VIBBER" also posted a comment on MediaWiki.r87243. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87243#c17821 Commit summary: Make jquery.tablesorter more resilient by chec

[MediaWiki-CodeReview] [MediaWiki r87212]: New comment added

2011-06-07 Thread MediaWiki Mail
User "Brion VIBBER" posted a comment on MediaWiki.r87212. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87212#c17820 Commit summary: Added wgIsMainPage (Title->isMainPage) to mw.config * Instead of ugly javascript construction to compare href-attributes or re-constructing proper

[MediaWiki-CodeReview] [MediaWiki r85918]: New comment added

2011-06-07 Thread MediaWiki Mail
User "Tim Starling" posted a comment on MediaWiki.r85918. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85918#c17819 Commit summary: Improvements to handling of 'catastrophic' errors, like unsupported PHP versions, no MySQL functions, no LocalSettings, etc. * Fix parsing of the

[MediaWiki-CodeReview] [MediaWiki r89707]: New comment added, and revision status changed

2011-06-07 Thread MediaWiki Mail
User "Platonides" changed the status of MediaWiki.r89707. Old Status: fixme New Status: ok User "Platonides" also posted a comment on MediaWiki.r89707. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89707#c17812 Commit summary: quick fix for bug28983 . Do not use $path in the lo

[MediaWiki-CodeReview] [MediaWiki r87217]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r87217. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87217#c0 Commit summary: Refactor out common code ___ MediaWiki-CodeReview mailing list mediawiki

[MediaWiki-CodeReview] [MediaWiki r87232]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r87232. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87232#c0 Commit summary: Make a method static per the comment, update the only non static usage (in Parser) itself _

[MediaWiki-CodeReview] [MediaWiki r85918]: New comment added

2011-06-07 Thread MediaWiki Mail
User "Platonides" posted a comment on MediaWiki.r85918. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85918#c17818 Commit summary: Improvements to handling of 'catastrophic' errors, like unsupported PHP versions, no MySQL functions, no LocalSettings, etc. * Fix parsing of the th

[MediaWiki-CodeReview] [MediaWiki r85918]: New comment added

2011-06-07 Thread MediaWiki Mail
User "Brion VIBBER" posted a comment on MediaWiki.r85918. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85918#c17817 Commit summary: Improvements to handling of 'catastrophic' errors, like unsupported PHP versions, no MySQL functions, no LocalSettings, etc. * Fix parsing of the

[MediaWiki-CodeReview] [MediaWiki r85918]: New comment added

2011-06-07 Thread MediaWiki Mail
User "Platonides" posted a comment on MediaWiki.r85918. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85918#c17816 Commit summary: Improvements to handling of 'catastrophic' errors, like unsupported PHP versions, no MySQL functions, no LocalSettings, etc. * Fix parsing of the th

[MediaWiki-CodeReview] [MediaWiki r85918]: New comment added

2011-06-07 Thread MediaWiki Mail
User "Tim Starling" posted a comment on MediaWiki.r85918. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85918#c17815 Commit summary: Improvements to handling of 'catastrophic' errors, like unsupported PHP versions, no MySQL functions, no LocalSettings, etc. * Fix parsing of the

[MediaWiki-CodeReview] [MediaWiki r87243]: New comment added

2011-06-07 Thread MediaWiki Mail
User "Brion VIBBER" posted a comment on MediaWiki.r87243. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87243#c17814 Commit summary: Make jquery.tablesorter more resilient by checking multiple cells before assuming a type. Fixes Bug 28775 Comment: Looks ok offhand, but especia

[MediaWiki-CodeReview] [MediaWiki r89707]: New comment added

2011-06-07 Thread MediaWiki Mail
User "Wikinaut" posted a comment on MediaWiki.r89707. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89707#c17813 Commit summary: quick fix for bug28983 . Do not use $path in the loop. Even the remaining $e is dangerous subject to change from the require-once-loaded extensions. T

[MediaWiki-CodeReview] [MediaWiki r89708]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User "Wikinaut" changed the status of MediaWiki.r89708. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89708#c0 Commit summary: Follow up r89707. No need for the explicit concatenations. ___ MediaWiki-Cod

[MediaWiki-CodeReview] [MediaWiki r89707]: New comment added, and revision status changed

2011-06-07 Thread MediaWiki Mail
User "Wikinaut" changed the status of MediaWiki.r89707. Old Status: ok New Status: fixme User "Wikinaut" also posted a comment on MediaWiki.r89707. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89707#c17811 Commit summary: quick fix for bug28983 . Do not use $path in the loop.

[MediaWiki-CodeReview] [MediaWiki r89707]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User "Platonides" changed the status of MediaWiki.r89707. Old Status: fixme New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89707#c0 Commit summary: quick fix for bug28983 . Do not use $path in the loop. Even the remaining $e is dangerous subject to change from the

[MediaWiki-CodeReview] [MediaWiki r89707]: New comment added

2011-06-07 Thread MediaWiki Mail
User "Wikinaut" posted a comment on MediaWiki.r89707. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89707#c17810 Commit summary: quick fix for bug28983 . Do not use $path in the loop. Even the remaining $e is dangerous subject to change from the require-once-loaded extensions. T

[MediaWiki-CodeReview] [MediaWiki r89707]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User "Wikinaut" changed the status of MediaWiki.r89707. Old Status: new New Status: fixme Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89707#c0 Commit summary: quick fix for bug28983 . Do not use $path in the loop. Even the remaining $e is dangerous subject to change from the

[MediaWiki-CodeReview] [MediaWiki r89707]: New comment added

2011-06-07 Thread MediaWiki Mail
User "Wikinaut" posted a comment on MediaWiki.r89707. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89707#c17809 Commit summary: quick fix for bug28983 . Do not use $path in the loop. Even the remaining $e is dangerous subject to change from the require-once-loaded extensions. T

[MediaWiki-CodeReview] [MediaWiki r82102]: New comment added

2011-06-07 Thread MediaWiki Mail
User "Brion VIBBER" posted a comment on MediaWiki.r82102. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82102#c17808 Commit summary: * (bug 26298) Throw warning instead of silently saving blank page when php-suhosin removes wpTextbox1 for being 'too long' or some such To resolv

[MediaWiki-CodeReview] [MediaWiki r87322]: New comment added, and revision status changed

2011-06-07 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r87322. Old Status: fixme New Status: ok User "Brion VIBBER" also posted a comment on MediaWiki.r87322. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87322#c17807 Commit summary: Tablesorter: Add a title attribute to sort arro

[MediaWiki-CodeReview] [MediaWiki r87326]: New comment added, and revision status changed

2011-06-07 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r87326. Old Status: fixme New Status: ok User "Brion VIBBER" also posted a comment on MediaWiki.r87326. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87326#c17806 Commit summary: Fix Bug 28354: Edit tab is shown as "view sourc

[MediaWiki-CodeReview] [MediaWiki r87347]: New comment added, and revision status changed

2011-06-07 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r87347. Old Status: fixme New Status: resolved User "Brion VIBBER" also posted a comment on MediaWiki.r87347. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87347#c17805 Commit summary: (bug 7) Special:Listfiles no longer t

[MediaWiki-CodeReview] [MediaWiki r89674]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r89674. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89674#c0 Commit summary: Followup r87347, bug 7, use makeTitleSafe. ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r87231]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r87231. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87231#c0 Commit summary: Documentation tweaks, additions and updates ___ MediaWiki-CodeReview mai

[MediaWiki-CodeReview] [MediaWiki r86131]: New comment added

2011-06-07 Thread MediaWiki Mail
User "Platonides" posted a comment on MediaWiki.r86131. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86131#c17804 Commit summary: * Pass around parser options instead of users and made some parser options consistency fixes * Moved makeParserOptions to Article.php * Renamed curr

[MediaWiki-CodeReview] [MediaWiki r86131]: New comment added

2011-06-07 Thread MediaWiki Mail
User "Platonides" posted a comment on MediaWiki.r86131. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86131#c17803 Commit summary: * Pass around parser options instead of users and made some parser options consistency fixes * Moved makeParserOptions to Article.php * Renamed curr

[MediaWiki-CodeReview] [MediaWiki r87222]: New comment added, and revision status changed

2011-06-07 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r87222. Old Status: new New Status: ok User "Brion VIBBER" also posted a comment on MediaWiki.r87222. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87222#c17802 Commit summary: When we failed to detect a DB driver, put the hel

[MediaWiki-CodeReview] [MediaWiki r87326]: New comment added

2011-06-07 Thread MediaWiki Mail
User "P.Copp" posted a comment on MediaWiki.r87326. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87326#c17801 Commit summary: Fix Bug 28354: Edit tab is shown as "view source" for blocked users, which breaks squid caching * Skip user block checks for Title::quickUserCan(). Thi

[MediaWiki-CodeReview] [MediaWiki r89648]: New comment added

2011-06-07 Thread MediaWiki Mail
User "P.Copp" posted a comment on MediaWiki.r89648. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89648#c17800 Commit summary: Another try at fixing bug 93 "tilde signatures inside nowiki tags sometimes get expanded ()" * Change the preprocessor to insert strip items for n

[MediaWiki-CodeReview] [MediaWiki r89696]: New comment added

2011-06-07 Thread MediaWiki Mail
User "Platonides" posted a comment on MediaWiki.r89696. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89696#c17799 Commit summary: Translate extension wants to keep 1.16 compatible. Use GAID_FOR_UPDATE and keep the define there so that it won't break in 1.18 Follow up r74035. Co

[MediaWiki-CodeReview] [MediaWiki r89696]: New comment added

2011-06-07 Thread MediaWiki Mail
User "Nikerabbit" posted a comment on MediaWiki.r89696. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89696#c17798 Commit summary: Translate extension wants to keep 1.16 compatible. Use GAID_FOR_UPDATE and keep the define there so that it won't break in 1.18 Follow up r74035. Co

[MediaWiki-CodeReview] [MediaWiki r87250]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r87250. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87250#c0 Commit summary: Moved Skin::$mWatchLinkNum to SkinLegacy since it's only used there and made it protected per documentation (nothing

[MediaWiki-CodeReview] [MediaWiki r87249]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r87249. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87249#c0 Commit summary: Get the revision ID from the OutputPage object instead of making a copy

[MediaWiki-CodeReview] [MediaWiki r89621]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r89621. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89621#c0 Commit summary: When detecting $wgServer, do not fall back to $_SERVER['HTTP_HOST']. It's unlikely that this is used by anything, since SE

[MediaWiki-CodeReview] [MediaWiki r89696]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r89696. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89696#c0 Commit summary: Translate extension wants to keep 1.16 compatible. Use GAID_FOR_UPDATE and keep the define there so that it won't break in

[MediaWiki-CodeReview] [MediaWiki r87260]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r87260. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87260#c0 Commit summary: * Removed Skin::reallyGenerateUserStylesheet() nothing uses it and nothing overrides it * Corrected Skin::generateUs

  1   2   3   4   >