[MediaWiki-CodeReview] [MediaWiki r90585]: New comment added

2011-07-05 Thread MediaWiki Mail
User "Freakolowsky" posted a comment on MediaWiki.r90585. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90585#c19241 Commit summary: * removed DEFAULT '' NOT NULL constraints as '' is internaly converted to NULL in Oracle and throws an error * fixed tableName handling doSchemaUp

[MediaWiki-CodeReview] [MediaWiki r91506]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r91506. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91506#c0 Commit summary: code readability is everything ___ MediaWiki-CodeReview mailing list med

[MediaWiki-CodeReview] [MediaWiki r91496]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r91496. Old Status: fixme New Status: new Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91496#c0 Commit summary: DumpHTML fixes: * Made SkinOffline use getTitle() instead of non-existing mTitle * Made g

[MediaWiki-CodeReview] [MediaWiki r88134]: New comment added

2011-07-05 Thread MediaWiki Mail
User "Tim Starling" posted a comment on MediaWiki.r88134. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88134#c19240 Commit summary: Fixed a bug in transformation where previous language could leak into later transformations in UI language. Not sure what do with userlang. Comme

[MediaWiki-CodeReview] [MediaWiki r79272]: New comment added, and revision status changed

2011-07-05 Thread MediaWiki Mail
User "Tim Starling" changed the status of MediaWiki.r79272. Old Status: resolved New Status: fixme User "Tim Starling" also posted a comment on MediaWiki.r79272. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79272#c19239 Commit summary: -Destroy the DB automatically when initti

[MediaWiki-CodeReview] [MediaWiki r90767]: New comment added

2011-07-05 Thread MediaWiki Mail
User "SPQRobin" posted a comment on MediaWiki.r90767. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90767#c19238 Commit summary: Correct alignment for RevisionDelete button Comment: I added .mw-float-start & .mw-float-end in r91518.

[MediaWiki-CodeReview] [MediaWiki r91153]: New comment added

2011-07-05 Thread MediaWiki Mail
User "Tim Starling" posted a comment on MediaWiki.r91153. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91153#c19237 Commit summary: * (bug 29531) r89628 breaks img_auth.php Apply Tims strpos -> strrpos fix, confirmed to work by bug reporter Comment: Never mind. _

[MediaWiki-CodeReview] [MediaWiki r91153]: New comment added, and revision status changed

2011-07-05 Thread MediaWiki Mail
User "Tim Starling" changed the status of MediaWiki.r91153. Old Status: new New Status: ok User "Tim Starling" also posted a comment on MediaWiki.r91153. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91153#c19236 Commit summary: * (bug 29531) r89628 breaks img_auth.php Apply T

[MediaWiki-CodeReview] [MediaWiki r90586]: New comment added

2011-07-05 Thread MediaWiki Mail
User "Tim Starling" posted a comment on MediaWiki.r90586. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90586#c19235 Commit summary: * MFT r90585 (i know it's late ... ready for 1.17.1 :D) * *this* is why i need testing pplz on oracle Comment: Missing release notes. __

[MediaWiki-CodeReview] [MediaWiki r90599]: New comment added

2011-07-05 Thread MediaWiki Mail
User "Tim Starling" posted a comment on MediaWiki.r90599. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90599#c19234 Commit summary: * (bug 29535) CC0 logo doesn't exist Comment: Missing release notes. ___ MediaWiki-CodeReview mailin

[MediaWiki-CodeReview] [MediaWiki r91504]: New comment added

2011-07-05 Thread MediaWiki Mail
User "Tim Starling" posted a comment on MediaWiki.r91504. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91504#c19233 Commit summary: Partial backport of r80572 per bug 29726: failure in map.exists in WebKit browsers for multiple keys or if a global 'keys' object exists Comment:

[MediaWiki-CodeReview] [MediaWiki r91521]: New comment added

2011-07-05 Thread MediaWiki Mail
User "Reedy" posted a comment on MediaWiki.r91521. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91521#c19232 Commit summary: Boo for coding when tired Yay for getting it done etc etc Comment: TODO

[Wikitech-l] [Selenium] IDE test for regressing bug https://bugzilla.wikimedia.org/show_bug.cgi?id=29310

2011-07-05 Thread Michelle Knight
Hi Benedikt and Marcus, I had some time and was reading about current issues around MediaWiki. I saw an issue about tab names - Bug 29310 Namespace tab doesn't handle fallback the same way as core (breaks nstab) - and created a Selenium regression test to verify when it is fixed. It is called jav

[MediaWiki-CodeReview] [MediaWiki r91496]: New comment added, and revision status changed

2011-07-05 Thread MediaWiki Mail
User "Dantman" changed the status of MediaWiki.r91496. Old Status: new New Status: fixme User "Dantman" also posted a comment on MediaWiki.r91496. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91496#c19231 Commit summary: DumpHTML fixes: * Made SkinOffl

[MediaWiki-CodeReview] [MediaWiki r91519]: New comment added

2011-07-05 Thread MediaWiki Mail
User "SPQRobin" posted a comment on MediaWiki.r91519. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91519#c19230 Commit summary: (follow-up r91518; bug 29658 et al.) Improving RTL support for several extensions: AbuseFilter: aligning rules edit box as LTR, since they are essenti

[MediaWiki-CodeReview] [MediaWiki r91518]: New comment added

2011-07-05 Thread MediaWiki Mail
User "SPQRobin" posted a comment on MediaWiki.r91518. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91518#c19229 Commit summary: (bug 6100; follow-up to r91315) Being bold and removing $wgBetterDirectionality (and dependent wfUILang) in core, as most or all work is finished. Als

[MediaWiki-CodeReview] [MediaWiki r91500]: New comment added

2011-07-05 Thread MediaWiki Mail
User "Helder.wiki" posted a comment on MediaWiki.r91500. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91500#c19228 Commit summary: mw.util.wikiGetlink default to wgPageName * (bug 29723) mw.util.wikiGetlink() should default to wgPageName * Solution by mybugs.mail * Adding unit

[MediaWiki-CodeReview] [MediaWiki r80572]: New comment added, and revision status changed

2011-07-05 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r80572. Old Status: new New Status: ok User "Brion VIBBER" also posted a comment on MediaWiki.r80572. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80572#c19227 Commit summary: Fix bug in mw.Map + fix bug 26801 + wrapper media

[MediaWiki-CodeReview] [MediaWiki r91505]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Krinkle" changed the status of MediaWiki.r91505. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91505#c0 Commit summary: Partial backport of r80572 per bug 29726: failure in map.exists in WebKit browsers for multiple keys or if a global 'key

[MediaWiki-CodeReview] [MediaWiki r91504]: New comment added, and revision status changed

2011-07-05 Thread MediaWiki Mail
User "Krinkle" changed the status of MediaWiki.r91504. Old Status: new New Status: ok User "Krinkle" also posted a comment on MediaWiki.r91504. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91504#c19226 Commit summary: Partial backport of r80572 per bug 29726: failure in map.ex

[MediaWiki-CodeReview] [MediaWiki r91471]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r91471. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91471#c0 Commit summary: Fixing typo in r91468. ___ MediaWiki-CodeReview mailing list mediawiki-coderev

[MediaWiki-CodeReview] [MediaWiki r80572]: New comment added

2011-07-05 Thread MediaWiki Mail
User "Krinkle" posted a comment on MediaWiki.r80572. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80572#c19225 Commit summary: Fix bug in mw.Map + fix bug 26801 + wrapper mediawiki.special.upload.js * Map.prototype.exists was checking the type of the wrong variable. Fixed now,

[MediaWiki-CodeReview] [MediaWiki r80572]: New comment added

2011-07-05 Thread MediaWiki Mail
User "Brion VIBBER" posted a comment on MediaWiki.r80572. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80572#c19224 Commit summary: Fix bug in mw.Map + fix bug 26801 + wrapper mediawiki.special.upload.js * Map.prototype.exists was checking the type of the wrong variable. Fixed n

[MediaWiki-CodeReview] [MediaWiki r91482]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r91482. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91482#c0 Commit summary: added "takes report language" param for comscore reporting ___ MediaWiki-CodeRe

[MediaWiki-CodeReview] [MediaWiki r91480]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r91480. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91480#c0 Commit summary: support for reportlanguage, and typo fix ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r90585]: New comment added, and revision status changed

2011-07-05 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r90585. Old Status: new New Status: ok User "Aaron Schulz" also posted a comment on MediaWiki.r90585. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90585#c19223 Commit summary: * removed DEFAULT '' NOT NULL constraints as '' i

[MediaWiki-CodeReview] [MediaWiki r89221]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r89221. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89221#c0 Commit summary: Follow up r89220. Misleading comment left from r88971 ___ MediaWiki-Code

[MediaWiki-CodeReview] [MediaWiki r91500]: New comment added

2011-07-05 Thread MediaWiki Mail
User "Helder.wiki" posted a comment on MediaWiki.r91500. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91500#c19222 Commit summary: mw.util.wikiGetlink default to wgPageName * (bug 29723) mw.util.wikiGetlink() should default to wgPageName * Solution by mybugs.mail * Adding unit

[MediaWiki-CodeReview] [MediaWiki r89165]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r89165. Old Status: new New Status: fixme Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89165#c0 Commit summary: Added entry for alias file ___ MediaWiki-CodeReview mailing list medi

[MediaWiki-CodeReview] [MediaWiki r88886]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r6. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/6#c0 Commit summary: r5: Change message as well ___ MediaWiki-CodeReview mailing list med

[MediaWiki-CodeReview] [MediaWiki r88885]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r5. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/5#c0 Commit summary: Remove reset button from Special:Undelete. It does more harm than good _

[MediaWiki-CodeReview] [MediaWiki r89205]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r89205. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89205#c0 Commit summary: Make $wgDebugRawPage=false also ignore load.php, so that debug logs can be readable again.

[MediaWiki-CodeReview] [MediaWiki r88594]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r88594. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88594#c0 Commit summary: Moved MediaWiki::articleFromTitle() to Article::newFromTitle(), this has nothing to do in the MediaWiki class _

Re: [Wikitech-l] A different API problem

2011-07-05 Thread Ryan Kaldari
Tim has fixed the issue on the live wikis. I imagine he just pushed up the fix that was already on trunk, so we probably still need to fix it for the case mentioned by Neil. Ryan Kaldari On 7/3/11 11:41 PM, Neil Kandalgaonkar wrote: > On 7/3/11 2:55 PM, Roan Kattouw wrote: > >> Well as I just p

[MediaWiki-CodeReview] [MediaWiki r88595]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r88595. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88595#c0 Commit summary: * (bug 28272) Special:Allmessages should have only one "Go" button Patch by MZMcBride _

[MediaWiki-CodeReview] [MediaWiki r88392]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r88392. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88392#c0 Commit summary: Changing console.log(e) to a throw. console.log makes it go toString() which is pretty much the same as the e.messag

[MediaWiki-CodeReview] [MediaWiki r88568]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r88568. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88568#c0 Commit summary: Adding fixme note for bug 29088. ___ MediaWiki-CodeReview mailing list m

[MediaWiki-CodeReview] [MediaWiki r88555]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r88555. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88555#c0 Commit summary: Report importDump to subclass Maintenance ___ MediaWiki-CodeReview maili

[MediaWiki-CodeReview] [MediaWiki r91432]: New comment added

2011-07-05 Thread MediaWiki Mail
User "SPQRobin" posted a comment on MediaWiki.r91432. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91432#c19221 Commit summary: (see bug 29712) Removing the defaultUserOptionOverrides in MessagesXx.php because it is broken (and has been for a long time) and secondly, it is only

[MediaWiki-CodeReview] [MediaWiki r78156]: New comment added

2011-07-05 Thread MediaWiki Mail
User "Krinkle" posted a comment on MediaWiki.r78156. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/78156#c19220 Commit summary: Ported jsMsg to mw.util; Fixing bugs and modernising mediawiki.action.watch.ajax.js a little more * Using the raw element instead of jQuery object to

[MediaWiki-CodeReview] [MediaWiki r88730]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r88730. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88730#c0 Commit summary: JS fixes & a little cleanup/modernization on CheckUser Was throwing errors due to trying to use addOnloadHook() from

[MediaWiki-CodeReview] [MediaWiki r87837]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r87837. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87837#c0 Commit summary: Simplify code by using OutputPage::wrapWikiMsg() ___ MediaWiki-CodeRevie

[MediaWiki-CodeReview] [MediaWiki r87997]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r87997. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87997#c0 Commit summary: * (bug 15461) Make IE8 turn off content sniffing. Everbody else should ignore this Adding X-Content-Type-Options: n

[MediaWiki-CodeReview] [MediaWiki r85244]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r85244. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85244#c0 Commit summary: Drop connetion between Skin and Linker and turn Linker into a staticly usable class.

[MediaWiki-CodeReview] [MediaWiki r85247]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r85247. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85247#c0 Commit summary: Followup r85244; Define all methods as static, implement a DummyLinker to forward calls for passing to hooks a

[MediaWiki-CodeReview] [MediaWiki r78156]: New comment added

2011-07-05 Thread MediaWiki Mail
User "Helder.wiki" posted a comment on MediaWiki.r78156. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/78156#c19219 Commit summary: Ported jsMsg to mw.util; Fixing bugs and modernising mediawiki.action.watch.ajax.js a little more * Using the raw element instead of jQuery object

[MediaWiki-CodeReview] [MediaWiki r85250]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r85250. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85250#c0 Commit summary: Continue with r85240; Move getSkin from User to RequestContext, do it without globals, strip out the non-funct

[MediaWiki-CodeReview] [MediaWiki r90934]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r90934. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90934#c0 Commit summary: (follow-up to some RequestContext revision) When Special:userlogin creates a new user, not only replace $wgUser, but

[MediaWiki-CodeReview] [MediaWiki r85438]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r85438. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85438#c0 Commit summary: Make hours smaller! r84782 follow-up. ___ MediaWiki-CodeReview mailing l

[MediaWiki-CodeReview] [MediaWiki r91449]: New comment added

2011-07-05 Thread MediaWiki Mail
User "Raymond" posted a comment on MediaWiki.r91449. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91449#c19218 Commit summary: rewritten code related to encoding/storage/retrieval of containers using internal objects; internal objects now represented by DIWikiPages, no more spe

[MediaWiki-CodeReview] [MediaWiki r91449]: New comment added, and revision status changed

2011-07-05 Thread MediaWiki Mail
User "Raymond" changed the status of MediaWiki.r91449. Old Status: fixme New Status: deferred User "Raymond" also posted a comment on MediaWiki.r91449. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91449#c19217 Commit summary: rewritten code related to encoding/storage/retrieva

[MediaWiki-CodeReview] [MediaWiki r85252]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r85252. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85252#c0 Commit summary: Followup r85250; Revert a static method back to use of $wgRequest... :/ damnit resourceloader... __

[MediaWiki-CodeReview] [MediaWiki r91083]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Kaldari" changed the status of MediaWiki.r91083. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91083#c0 Commit summary: WikiLove minor fixes: * Trailing comma's in object literals brakes IE (in rememberInputData and currentRememberData

[MediaWiki-CodeReview] [MediaWiki r91389]: New comment added, and revision status changed

2011-07-05 Thread MediaWiki Mail
User "Kaldari" changed the status of MediaWiki.r91389. Old Status: new New Status: ok User "Kaldari" also posted a comment on MediaWiki.r91389. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91389#c19216 Commit summary: WikiLove fixes: * Follow-up r91083 CR: Make sure input like

[MediaWiki-CodeReview] [MediaWiki r91330]: New comment added, and revision status changed

2011-07-05 Thread MediaWiki Mail
User "Raymond" changed the status of MediaWiki.r91330. Old Status: fixme New Status: new User "Raymond" also posted a comment on MediaWiki.r91330. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91330#c19215 Commit summary: Move prefs-beta and prefs-labs messages from WikiEditor

Re: [Wikitech-l] IRC Triage of “easy” bugs

2011-07-05 Thread Matias
I've been waiting for this but unfortunately I can't be at that time. Would there be a log about the result? On Tue, Jul 5, 2011 at 4:11 PM, Mark A. Hershberger < mhershber...@wikimedia.org> wrote: > > Tomorrow (July 6th, Wednesday) at 2100UTC, I will hold a triage on IRC > of “easy” bugs. The p

[MediaWiki-CodeReview] [MediaWiki r91487]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r91487. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91487#c0 Commit summary: Needs $IP, to accomodate wikis with different directory structure ___ MediaWiki

[MediaWiki-CodeReview] [MediaWiki r91317]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "NeilK" changed the status of MediaWiki.r91317. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91317#c0 Commit summary: * rename SpecialModifyBlacklist to SpecialModifyArchiveBlacklist to avoid confusion with other blacklists in mediawiki

[MediaWiki-CodeReview] [MediaWiki r91449]: New comment added, and revision status changed

2011-07-05 Thread MediaWiki Mail
User "Raymond" changed the status of MediaWiki.r91449. Old Status: deferred New Status: fixme User "Raymond" also posted a comment on MediaWiki.r91449. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91449#c19214 Commit summary: rewritten code related to encoding/storage/retrieva

[MediaWiki-CodeReview] [MediaWiki r85240]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r85240. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85240#c0 Commit summary: Implement the RequestContext class. Some credit to IAlex, ;) other credit for me and that plethora of bugs and

[MediaWiki-CodeReview] [MediaWiki r85242]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r85242. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85242#c0 Commit summary: Followup r85240; Commit the additional file that was part of that change. ;) this wouldn't have happened if we were

[MediaWiki-CodeReview] [MediaWiki r85021]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r85021. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85021#c0 Commit summary: (bug 28237) Installer doesn't create extension tables ___ MediaWik

[MediaWiki-CodeReview] [MediaWiki r86047]: New comment added

2011-07-05 Thread MediaWiki Mail
User "Helder.wiki" posted a comment on MediaWiki.r86047. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86047#c19213 Commit summary: History: Adding JS that converts buttons to links for better UX. Patch based on one by Matthew Flaschen. Fixes Bug 16165 Comment: For the record

[MediaWiki-CodeReview] [MediaWiki r91481]: New comment added

2011-07-05 Thread MediaWiki Mail
User "Nikerabbit" posted a comment on MediaWiki.r91481. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91481#c19212 Commit summary: MediaWiki:Viewcount does not need PLURAL in French Comment: I'd prefer just using dummy {{PLURAL:$1}} in the message.

[MediaWiki-CodeReview] [MediaWiki r91479]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Krinkle" changed the status of MediaWiki.r91479. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91479#c0 Commit summary: Merge r89523 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists

[MediaWiki-CodeReview] [MediaWiki r84283]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r84283. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84283#c0 Commit summary: Extract bit depth and color type for PNG images ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r84320]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r84320. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84320#c0 Commit summary: * Increased file descriptor limit * Wait 1 second for start-stop-daemon to do its thing before checking if the daemo

[MediaWiki-CodeReview] [MediaWiki r91432]: New comment added

2011-07-05 Thread MediaWiki Mail
User "Raymond" posted a comment on MediaWiki.r91432. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91432#c19211 Commit summary: (see bug 29712) Removing the defaultUserOptionOverrides in MessagesXx.php because it is broken (and has been for a long time) and secondly, it is only

[MediaWiki-CodeReview] [MediaWiki r83245]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r83245. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83245#c0 Commit summary: Fix and make file moving better resilient against errors by first copying the files, then doing the db updates and f

[MediaWiki-CodeReview] [MediaWiki r91326]: New comment added

2011-07-05 Thread MediaWiki Mail
User "Krinkle" posted a comment on MediaWiki.r91326. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91326#c19210 Commit summary: A style fix for old skins Comment: The desired behaviour is for the textarea to be as wide as it can be in the parent element. Should indeed not depe

[MediaWiki-CodeReview] [MediaWiki r91326]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Krinkle" changed the status of MediaWiki.r91326. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91326#c0 Commit summary: A style fix for old skins ___ MediaWiki-CodeReview mailing list mediawiki-cod

[MediaWiki-CodeReview] [MediaWiki r91473]: New comment added

2011-07-05 Thread MediaWiki Mail
User "Jack Phoenix" posted a comment on MediaWiki.r91473. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91473#c19209 Commit summary: More comments Change DumpActiveEditors100Metric to subclass DumpActiveEditors5Metric Comment: - return 'Percentage of total uniqu

[MediaWiki-CodeReview] [MediaWiki r91326]: New comment added

2011-07-05 Thread MediaWiki Mail
User "Kaldari" posted a comment on MediaWiki.r91326. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91326#c19208 Commit summary: A style fix for old skins Comment: Monobook and Vector (and maybe others) include the style: textarea { width: 100%; } No idea why, but they do. __

[MediaWiki-CodeReview] [MediaWiki r89523]: New comment added

2011-07-05 Thread MediaWiki Mail
User "Reedy" posted a comment on MediaWiki.r89523. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89523#c19207 Commit summary: * (bug 28002) Internal error in ApiFormatRaw::getMimeType If we just return when no titles, we don't format anything, and everything breaks Might aswel

[MediaWiki-CodeReview] [MediaWiki r91478]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Krinkle" changed the status of MediaWiki.r91478. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91478#c0 Commit summary: killing a space invader, I mean character ___ MediaWiki-CodeReview mailing li

[MediaWiki-CodeReview] [MediaWiki r91476]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Krinkle" changed the status of MediaWiki.r91476. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91476#c0 Commit summary: 1.17wmf1: Properly alias $ to jQuery in all ext.vector.*.js files. Already done in trunk. Needed to unbreak SimpleSearch

[MediaWiki-CodeReview] [MediaWiki r91287]: New comment added

2011-07-05 Thread MediaWiki Mail
User "Krinkle" posted a comment on MediaWiki.r91287. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91287#c19206 Commit summary: fixing double encoding - bug 29668 Comment: Okay, cool. ___ MediaWiki-CodeReview mailing list mediawiki-c

[MediaWiki-CodeReview] [MediaWiki r91472]: New comment added, and revision status changed

2011-07-05 Thread MediaWiki Mail
User "Kaldari" changed the status of MediaWiki.r91472. Old Status: new New Status: ok User "Kaldari" also posted a comment on MediaWiki.r91472. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91472#c19205 Commit summary: using mw.util.wikiGetlink + minors and w/s Comment: Every

[MediaWiki-CodeReview] [MediaWiki r91474]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r91474. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91474#c0 Commit summary: fixed typo ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wik

[MediaWiki-CodeReview] [MediaWiki r91326]: New comment added

2011-07-05 Thread MediaWiki Mail
User "Krinkle" posted a comment on MediaWiki.r91326. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91326#c19201 Commit summary: A style fix for old skins Comment: Which style, that is by default in some skins, is this covering for ?

[MediaWiki-CodeReview] [MediaWiki r88197]: New comment added

2011-07-05 Thread MediaWiki Mail
User "Krinkle" posted a comment on MediaWiki.r88197. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88197#c19204 Commit summary: Better gallery Comment: Marking old as most if not all of this has been changed by later revisions. ___ M

[MediaWiki-CodeReview] [MediaWiki r91287]: New comment added

2011-07-05 Thread MediaWiki Mail
User "Kaldari" posted a comment on MediaWiki.r91287. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91287#c19203 Commit summary: fixing double encoding - bug 29668 Comment: Oops, this actually fixed bug 29670. ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r82905]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r82905. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82905#c0 Commit summary: Use a true minus in wikidiff. just like in WikiDiff.php Fixes bug 26038 ___

[MediaWiki-CodeReview] [MediaWiki r82546]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r82546. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82546#c0 Commit summary: revert r82544, and fix similar problem with preceding query ___ MediaWik

[MediaWiki-CodeReview] [MediaWiki r82748]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r82748. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82748#c0 Commit summary: Removed white-background from ul.gallery; Updated commonPrint gallery styles Since a while now proper margins and ov

[MediaWiki-CodeReview] [MediaWiki r91287]: New comment added

2011-07-05 Thread MediaWiki Mail
User "Krinkle" posted a comment on MediaWiki.r91287. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91287#c19202 Commit summary: fixing double encoding - bug 29668 Comment: The commit looks good, so marking ok. Which bug did you mean though ?- bug 29668 seems a different one.

[MediaWiki-CodeReview] [MediaWiki r91287]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Krinkle" changed the status of MediaWiki.r91287. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91287#c0 Commit summary: fixing double encoding - bug 29668 ___ MediaWiki-CodeReview mailing list medi

[Wikitech-l] IRC Triage of “easy” bugs

2011-07-05 Thread Mark A. Hershberger
Tomorrow (July 6th, Wednesday) at 2100UTC, I will hold a triage on IRC of “easy” bugs. The purpose of this Triage will be to go through all the bugs with this tag and make sure they're actually something that a new MW developer could do. We would like people who what to become involved with Medi

[MediaWiki-CodeReview] [MediaWiki r91320]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Krinkle" changed the status of MediaWiki.r91320. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91320#c0 Commit summary: fixing bug 29668 - WikiLove tab broken in Classic skin ___ MediaWiki-

[MediaWiki-CodeReview] [MediaWiki r82895]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r82895. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82895#c0 Commit summary: Return sooner if there's nothing to replace ___ MediaWiki-CodeReview mai

[MediaWiki-CodeReview] [MediaWiki r83110]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r83110. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83110#c0 Commit summary: Bug 2429 allow selection of associated namespace in recent changes Done by adding yet another checkbox in Spec

[MediaWiki-CodeReview] [MediaWiki r91280]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Krinkle" changed the status of MediaWiki.r91280. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91280#c0 Commit summary: better default styling ___ MediaWiki-CodeReview mailing list mediawiki-codere

[MediaWiki-CodeReview] [MediaWiki r91272]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Krinkle" changed the status of MediaWiki.r91272. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91272#c0 Commit summary: Adding black heart for the goth encyclopedia writers ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r91323]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Krinkle" changed the status of MediaWiki.r91323. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91323#c0 Commit summary: follow-up to r91320, better fix for bug 29668 - WikiLove tab broken in Classic skin

[MediaWiki-CodeReview] [MediaWiki r82837]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r82837. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82837#c0 Commit summary: Fix erroneous html generation in language boxes. ___ MediaWiki-CodeRevie

[MediaWiki-CodeReview] [MediaWiki r81456]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r81456. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81456#c0 Commit summary: * Use wfMessage() instead of wfMsgGetKey() and wfEmptyMsg() * Factorise common code

[MediaWiki-CodeReview] [MediaWiki r86047]: New comment added

2011-07-05 Thread MediaWiki Mail
User "Krinkle" posted a comment on MediaWiki.r86047. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86047#c19200 Commit summary: History: Adding JS that converts buttons to links for better UX. Patch based on one by Matthew Flaschen. Fixes Bug 16165 Comment: The first one can

[MediaWiki-CodeReview] [MediaWiki r80764]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r80764. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80764#c0 Commit summary: Add automatic formatting of numeric parameters to Message ___ Medi

[MediaWiki-CodeReview] [MediaWiki r80407]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r80407. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80407#c0 Commit summary: (bug 2585) Image pages should send 404 if no image, no shared image and no description page (To be consistant with h

[MediaWiki-CodeReview] [MediaWiki r79706]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r79706. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79706#c0 Commit summary: (Bug 25254) cl_timestamp gets updated on null edit where it shouldn't. Caused by two things: *after the new cat

  1   2   >