[MediaWiki-CodeReview] [MediaWiki r92112]: New comment added, and revision status changed

2011-07-30 Thread MediaWiki Mail
User "Krinkle" changed the status of MediaWiki.r92112. Old Status: fixme New Status: ok User "Krinkle" also posted a comment on MediaWiki.r92112. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92112#c20296 Commit summary: Rewrite ajaxCategories for ResourceLoader. Add some missi

[MediaWiki-CodeReview] [MediaWiki r93515]: New comment added

2011-07-30 Thread MediaWiki Mail
User "Nikerabbit" posted a comment on MediaWiki.r93515. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93515#c20297 Commit summary: mediawiki.js request() caching deep level object member access. - Instead of requesting index 0 of dependancies-argument, and the value of that of t

[MediaWiki-CodeReview] [MediaWiki r93515]: New comment added

2011-07-30 Thread MediaWiki Mail
User "Dantman" posted a comment on MediaWiki.r93515. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93515#c20298 Commit summary: mediawiki.js request() caching deep level object member access. - Instead of requesting index 0 of dependancies-argument, and t

[MediaWiki-CodeReview] [MediaWiki r93520]: New comment added

2011-07-30 Thread MediaWiki Mail
User "Nikerabbit" posted a comment on MediaWiki.r93520. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93520#c20299 Commit summary: :facepalm: Installer checked for magic_quotes_runtime instead of register_globals Comment: Release notes are misleading (a bit), it still checks f

[MediaWiki-CodeReview] [MediaWiki r93520]: New comment added

2011-07-30 Thread MediaWiki Mail
User "MaxSem" posted a comment on MediaWiki.r93520. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93520#c20300 Commit summary: :facepalm: Installer checked for magic_quotes_runtime instead of register_globals Comment: Where do they say that it doesn't check for magic_quotes_ru

[MediaWiki-CodeReview] [MediaWiki r93520]: New comment added

2011-07-30 Thread MediaWiki Mail
User "Nikerabbit" posted a comment on MediaWiki.r93520. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93520#c20301 Commit summary: :facepalm: Installer checked for magic_quotes_runtime instead of register_globals Comment: "The check for register_globals in installer was errone

[MediaWiki-CodeReview] [MediaWiki r93343]: New comment added

2011-07-30 Thread MediaWiki Mail
User "Platonides" posted a comment on MediaWiki.r93343. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93343#c20302 Commit summary: make sure sockets are enabled Comment: Shouldn't it log that it was configured to profile but it was not able to?

[MediaWiki-CodeReview] [MediaWiki r93291]: New comment added

2011-07-30 Thread MediaWiki Mail
User "Platonides" posted a comment on MediaWiki.r93291. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93291#c20303 Commit summary: Unicode space separator characters (Zs) now terminates links Fix 19052 which was only reporting the issue for U+3000 IDEOGRAPHIC SPACE. Covers both

[MediaWiki-CodeReview] [MediaWiki r93507]: Revision status changed

2011-07-30 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r93507. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93507#c0 Commit summary: Adding tag dir for Semantic Watchlist extension ___ MediaWiki-CodeReview mailin

[MediaWiki-CodeReview] [MediaWiki r93503]: Revision status changed

2011-07-30 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r93503. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93503#c0 Commit summary: Tag for version 0.4.9. ___ MediaWiki-CodeReview mailing list mediawiki-co

[MediaWiki-CodeReview] [MediaWiki r93523]: New comment added

2011-07-30 Thread MediaWiki Mail
User "Nikerabbit" posted a comment on MediaWiki.r93523. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93523#c20304 Commit summary: Automatic Board Welcome extension -- automatically posts a welcome message on new users' user boards on account creation. The message is sent by a r

[MediaWiki-CodeReview] [MediaWiki r93523]: New comment added

2011-07-30 Thread MediaWiki Mail
User "IAlex" posted a comment on MediaWiki.r93523. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93523#c20305 Commit summary: Automatic Board Welcome extension -- automatically posts a welcome message on new users' user boards on account creation. The me

Re: [Wikitech-l] Please don't commit broken code

2011-07-30 Thread Platonides
Ashar Voultoiz wrote: > On 29/07/11 02:05, MZMcBride wrote: > >> Sometimes the only way people can get their code reviewed is to commit it. > > In a BRANCH! :-) > > Although, you will have to find out someone to review your changes, but > at least it saves you the hassle of being reverted on sight

Re: [Wikitech-l] On refactorings and huge changes

2011-07-30 Thread Platonides
> PS: sorry for TLDR-ness... :-( It was worth reading! You make very good points. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r93528]: New comment added

2011-07-30 Thread MediaWiki Mail
User "Siebrand" posted a comment on MediaWiki.r93528. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93528#c20306 Commit summary: Added TitleBlacklist::singleton() to get an instance of the TitleBlacklist instead of having to use $wgTitleBlacklist and call efInitTitleBlacklist()

[MediaWiki-CodeReview] [MediaWiki r93528]: New comment added

2011-07-30 Thread MediaWiki Mail
User "IAlex" posted a comment on MediaWiki.r93528. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93528#c20307 Commit summary: Added TitleBlacklist::singleton() to get an instance of the TitleBlacklist instead of having to use $wgTitleBlacklist and call e

[MediaWiki-CodeReview] [MediaWiki r93536]: New comment added, and revision status changed

2011-07-30 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r93536. Old Status: new New Status: fixme User "Reedy" also posted a comment on MediaWiki.r93536. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93536#c20308 Commit summary: Make Back, Continue translatable. Comment: 'mobile-fronte

[MediaWiki-CodeReview] [MediaWiki r93536]: Revision status changed

2011-07-30 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r93536. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93536#c0 Commit summary: Make Back, Continue translatable. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r93536]: New comment added

2011-07-30 Thread MediaWiki Mail
User "TheDJ" posted a comment on MediaWiki.r93536. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93536#c20309 Commit summary: Make Back, Continue translatable. Comment: thx ! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...

[MediaWiki-CodeReview] [MediaWiki r93523]: New comment added

2011-07-30 Thread MediaWiki Mail
User "Jack Phoenix" posted a comment on MediaWiki.r93523. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93523#c20310 Commit summary: Automatic Board Welcome extension -- automatically posts a welcome message on new users' user boards on account creation. The message is sent by a

[MediaWiki-CodeReview] [MediaWiki r93523]: New comment added

2011-07-30 Thread MediaWiki Mail
User "Jack Phoenix" posted a comment on MediaWiki.r93523. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93523#c20311 Commit summary: Automatic Board Welcome extension -- automatically posts a welcome message on new users' user boards on account creation. The message is sent by a

[MediaWiki-CodeReview] [MediaWiki r93535]: Revision status changed

2011-07-30 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r93535. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93535#c0 Commit summary: Rebranching iwtransclusion from r93533 in trunk Gives stable working point for working from Breaks unit tests as bel

[Wikitech-l] "Ask the Developers" panel at Wikimania

2011-07-30 Thread Daniel Kinzler
Hi all! Ask you may know, there will be an "Ask the Developers" panel at Wikimania. However, there are no developers to ask, yet :) To make this work, we need a few lead WMF developers on the stage, ready to answer questions. So please let me know if you would be willing to do that, or tell me wh

[MediaWiki-CodeReview] [MediaWiki r93539]: Revision status changed

2011-07-30 Thread MediaWiki Mail
User "Platonides" changed the status of MediaWiki.r93539. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93539#c0 Commit summary: That branch isn't doing what I thought it might let me, typical Kill it _

[Wikitech-l] mysql_* functions and MediaWiki

2011-07-30 Thread John Du Hart
Earlier this month, the PHP developer team moved to start soft deprecating the mysql.so extension via documentation, with a intent to fully E_DEPRECATED in a later release. [1] Therefore, I thought it would be appropriate to start a small discussion as to how this should be handled. At the current

[MediaWiki-CodeReview] [MediaWiki r93343]: New comment added

2011-07-30 Thread MediaWiki Mail
User "Kaldari" posted a comment on MediaWiki.r93343. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93343#c20312 Commit summary: make sure sockets are enabled Comment: How do you do that? ___ MediaWiki-CodeReview mailing list mediawik

[MediaWiki-CodeReview] [MediaWiki r93557]: New comment added

2011-07-30 Thread MediaWiki Mail
User "Siebrand" posted a comment on MediaWiki.r93557. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93557#c20313 Commit summary: * Made OutputPage extend ContextSource instead of duplicating its code; this also adds getLang() that was missing * Use getLang() instead of $wgLang

Re: [Wikitech-l] mysql_* functions and MediaWiki

2011-07-30 Thread Ryan Schmidt
On 7/30/2011 1:07 PM, John Du Hart wrote: > Earlier this month, the PHP developer team moved to start soft deprecating > the mysql.so extension via documentation, with a intent to fully > E_DEPRECATED in a later release. [1] Therefore, I thought it would be > appropriate to start a small discussion

[MediaWiki-CodeReview] [MediaWiki r93343]: New comment added

2011-07-30 Thread MediaWiki Mail
User "Platonides" posted a comment on MediaWiki.r93343. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93343#c20314 Commit summary: make sure sockets are enabled Comment: I was thinking in just sticking a wfDebug() call there. ___ Med

Re: [Wikitech-l] mysql_* functions and MediaWiki

2011-07-30 Thread Platonides
John Du Hart wrote: > Earlier this month, the PHP developer team moved to start soft deprecating > the mysql.so extension via documentation, with a intent to fully > E_DEPRECATED in a later release. [1] Therefore, I thought it would be > appropriate to start a small discussion as to how this should

Re: [Wikitech-l] mysql_* functions and MediaWiki

2011-07-30 Thread Domas Mituzas
> c) Both PDO and MySQLi support "prepared" statements, which could let us > introduce a form of statement cache so that if we need to execute the > same query multiple times except with different parameters, there is > less overhead involved since the statement is already prepared and just > n

[Wikitech-l] FW: [SMW-devel] SMW Selenium system tests available

2011-07-30 Thread Benedikt Kämpgen
Thanks, Sumana, for giving me this hint, that I now finally follow: We have made available Selenium tests for Semantic MediaWiki (see email below). Regards, Benedikt -- AIFB, Karlsruhe Institute of Technology (KIT) Phone: +49 721 608-47946 Email: benedikt.kaemp...@kit.edu Web: http://www.aifb.

[MediaWiki-CodeReview] [MediaWiki r93563]: New comment added

2011-07-30 Thread MediaWiki Mail
User "Brion VIBBER" posted a comment on MediaWiki.r93563. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93563#c20315 Commit summary: * (bug 30131) XCache with variable caching disabled no longer used for variable caching (CACHE_ACCEL) Patch from John Du Hart: https://bugzilla.

[MediaWiki-CodeReview] [MediaWiki r93563]: New comment added

2011-07-30 Thread MediaWiki Mail
User "Brion VIBBER" posted a comment on MediaWiki.r93563. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93563#c20316 Commit summary: * (bug 30131) XCache with variable caching disabled no longer used for variable caching (CACHE_ACCEL) Patch from John Du Hart: https://bugzilla.

[MediaWiki-CodeReview] [MediaWiki r93397]: Revision status changed

2011-07-30 Thread MediaWiki Mail
User "MarkAHershberger" changed the status of MediaWiki.r93397. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93397#c0 Commit summary: Reduce mail header differences by moving all the header creation code to one place. _

[MediaWiki-CodeReview] [MediaWiki r93566]: New comment added

2011-07-30 Thread MediaWiki Mail
User "Kaldari" posted a comment on MediaWiki.r93566. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93566#c20317 Commit summary: fix for Bug 30139 - JS error in Chrome Comment: Actually, I just realized someone might set landingPages equal to 'false' or '0' or something (as unl

[MediaWiki-CodeReview] [MediaWiki r93563]: Revision status changed

2011-07-30 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r93563. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93563#c0 Commit summary: * (bug 30131) XCache with variable caching disabled no longer used for variable caching (CACHE_ACCEL) Patch from John Du

[MediaWiki-CodeReview] [MediaWiki r93564]: Revision status changed

2011-07-30 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r93564. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93564#c0 Commit summary: MFT r93563: (bug 30131) XCache with variable caching disabled no longer used for variable caching (CACHE_ACCEL) _

[MediaWiki-CodeReview] [MediaWiki r93174]: New comment added

2011-07-30 Thread MediaWiki Mail
User "Jlemley" posted a comment on MediaWiki.r93174. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93174#c20318 Commit summary: Followup r93154: Tweak extension credits and message files for consisteny Add extension to Translatewiki Comment: Can this be marked as resolved? See

[MediaWiki-CodeReview] [MediaWiki r93573]: New comment added

2011-07-30 Thread MediaWiki Mail
User "Peachey88" posted a comment on MediaWiki.r93573. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93573#c20319 Commit summary: Added README file. Comment: Probably be better if you wrapped your text at either 72 or 80 characters per line. __

[Wikitech-l] Haifa Hackathon schedule / Lightning talks proposals

2011-07-30 Thread Amir E. Aharoni
Shalom all, A draft schedule for the Haifa Hackathon has been published: http://wikimania2011.wikimedia.org/wiki/Developer_Days Some last details are being worked out. In particular, there are still many slots for 5-minute lightning talks every hour. Many of the topics listed under the "Topics" h