[MediaWiki-CodeReview] [MediaWiki r97329]: New comment added, and revision status changed

2011-09-19 Thread MediaWiki Mail
User Raymond changed the status of MediaWiki.r97329. Old Status: fixme New Status: new User Raymond also posted a comment on MediaWiki.r97329. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97329#c22757 Commit summary: Remove the pseudo TOC, part of file descripton pages, from

[MediaWiki-CodeReview] [MediaWiki r97449]: Revision status changed

2011-09-19 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r97449. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97449 Commit summary: Add IranianSans font support for Persian script. ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r97446]: Revision status changed

2011-09-19 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r97446. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97446 Commit summary: Tweak messages. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r97445]: Revision status changed

2011-09-19 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r97445. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97445 Commit summary: Minor whitespace fixes in GlobalFunctions.php * And some adjustments to documentation (sentence ended with use the wikis,

[MediaWiki-CodeReview] [MediaWiki r97441]: New comment added

2011-09-19 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r97441. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97441#c22758 Commit summary: Normalise out registrants languages Comment: Is 4 the maximum length of the language code? That's not enough for any variant, and it one too much

[MediaWiki-CodeReview] [MediaWiki r96797]: Revision status changed

2011-09-19 Thread MediaWiki Mail
User Santhosh.thottingal changed the status of MediaWiki.r96797. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96797 Commit summary: Reverting r96783 r96787 and r96788; adding IranianSans font, which is not GPL based but is a free font; including

[MediaWiki-CodeReview] [MediaWiki r97441]: New comment added

2011-09-19 Thread MediaWiki Mail
User Tim Starling posted a comment on MediaWiki.r97441. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97441#c22759 Commit summary: Normalise out registrants languages Comment: Note that varchar(4) uses the same amount of space as varchar(255), the only difference is whether

[MediaWiki-CodeReview] [MediaWiki r97328]: New comment added

2011-09-19 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r97328. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97328#c22760 Commit summary: Noticed in apache error logs (see below). If the length of the message is longer than the maximum length, only send what will fit Sep 16 20:07:28

Re: [Wikitech-l] Repository directory [mediawiki]/trunk clean up

2011-09-19 Thread Tim Starling
On 19/09/11 11:18, Krinkle wrote: Hi, When browsing through [mediawiki]/trunk [1] I see a lot of things that have piled up over the years. Now that we have /trunk/tools [2] Most of these things were created after /trunk/tools. and the separate [wikimedia] repository, perhaps some things

[MediaWiki-CodeReview] [MediaWiki r97022]: New comment added

2011-09-19 Thread MediaWiki Mail
User Midom posted a comment on MediaWiki.r97022. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97022#c22761 Commit summary: Possible fix for issue reported in r83762. I had a hard time confirming the problem/fix with profiling. Committing this now to get more attention.

Re: [Wikitech-l] Brown bag - Selenium Testing

2011-09-19 Thread Benedikt Kämpgen
Hello Jeremy, Great that you organised a brown bag lunch on Selenium Testing. We use Selenium Testing for an extension and I would like to keep up with the status of Selenium Testing for MediaWiki. I am wondering whether there are information about discussions during this lunch available,

[MediaWiki-CodeReview] [MediaWiki r97441]: New comment added

2011-09-19 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r97441. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97441#c22762 Commit summary: Normalise out registrants languages Comment: And lang(n) We could push native language back into the registrants table, as everyone is going to have

[MediaWiki-CodeReview] [MediaWiki r95562]: Revision status changed

2011-09-19 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r95562. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95562 Commit summary: (bug 29246) Edit API occasionally throws unknown error 231. Per comment #1 on the bug and a comment in ApiEditPage, I

[MediaWiki-CodeReview] [MediaWiki r97459]: New comment added

2011-09-19 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r97459. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97459#c22763 Commit summary: REL1_18 MFT r97145, r97150, r97378 Need to verify parser tests - Shall do that in a few minutes Comment: pre

[MediaWiki-CodeReview] [MediaWiki r97454]: New comment added

2011-09-19 Thread MediaWiki Mail
User Siebrand posted a comment on MediaWiki.r97454. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97454#c22764 Commit summary: Added messages for use by 'edit schema' page of Page Schemas extension Comment: Yaron, can you please add [[I18n#Message_documentation|message

[MediaWiki-CodeReview] [MediaWiki r97456]: New comment added

2011-09-19 Thread MediaWiki Mail
User Siebrand posted a comment on MediaWiki.r97456. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97456#c22765 Commit summary: Added 'sf-pageschemas-inputtype' message Comment: Please add [[I18n#Message_documentation|message documentation]]. Thanks.

[MediaWiki-CodeReview] [MediaWiki r97022]: New comment added

2011-09-19 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r97022. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97022#c22766 Commit summary: Possible fix for issue reported in r83762. I had a hard time confirming the problem/fix with profiling. Committing this now to get more attention.

Re: [Wikitech-l] Fwd: Adding MD5 / SHA1 column to revision table (discussing r94289)

2011-09-19 Thread Neil Harris
On 18/09/11 23:38, Roan Kattouw wrote: On Mon, Sep 19, 2011 at 12:12 AM, Anthonywikim...@inbox.org wrote: Did you try any of the non-secure hash functions? If you're going to go with MD5, might as well go with the significantly faster CRC-64. I included MD5 because MediaWiki currently uses

[MediaWiki-CodeReview] [MediaWiki r97461]: New comment added

2011-09-19 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r97461. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97461#c22767 Commit summary: * (bug 27398) Add $wgExtraGenderNamespaces for configured gendered namespaces Comment: Oops, the commit message is wrong. Here is the correct one:

Re: [Wikitech-l] Opera Mini on iOS Webkit

2011-09-19 Thread Håkon Wium Lie
Also sprach Tomasz Finc: Do we have anyone on this list who develops for Opera Mini and iOS Webkit? If so come help us with Operas client side folding architecture https://bugzilla.wikimedia.org/show_bug.cgi?id=29517. Android and others work great but just not iOS. Confirmed, Opera

[MediaWiki-CodeReview] [MediaWiki r86853]: New comment added

2011-09-19 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r86853. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86853#c22768 Commit summary: Fixes bug 24088: WikiEditor toolbar RTL icons Comment: Untagging 1.18, it is well before the 1.18 branch point of r94275 on 18/07/2011

[MediaWiki-CodeReview] [MediaWiki r86853]: New comment added

2011-09-19 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r86853. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86853#c22769 Commit summary: Fixes bug 24088: WikiEditor toolbar RTL icons Comment: Untagging 1.18, it is well before the 1.18 branch point of r94275 on 18/07/2011

[MediaWiki-CodeReview] [MediaWiki r97473]: Revision status changed

2011-09-19 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r97473. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97473 Commit summary: Remove extension WebFonts form 1.18 for rebranch from trunk. ___

[MediaWiki-CodeReview] [MediaWiki r97474]: Revision status changed

2011-09-19 Thread MediaWiki Mail
User Meno25 changed the status of MediaWiki.r97474. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97474 Commit summary: Rebranch WebFonts from trunk/HEAD to REL1_18. ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r97470]: Revision status changed

2011-09-19 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r97470. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97470 Commit summary: Remove comment from r97469 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r97469]: Revision status changed

2011-09-19 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r97469. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97469 Commit summary: Fix typo from r97461, was breaking unit tests ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r97475]: Revision status changed

2011-09-19 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r97475. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97475 Commit summary: Fixing bug 30973. Strip off subpages when determining the username who the current page belongs to.

[MediaWiki-CodeReview] [MediaWiki r97460]: Revision status changed

2011-09-19 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r97460. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97460 Commit summary: Partial solution for bug 30972 to avoid query flood. There is still some, because the Parser doesn't use LinkBatch but does it

[MediaWiki-CodeReview] [MediaWiki r97461]: Revision status changed

2011-09-19 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r97461. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97461 Commit summary: * (bug 27398) Add $wgExtraGenderNamespaces for configured gendered namespaces ___

[MediaWiki-CodeReview] [MediaWiki r97385]: New comment added

2011-09-19 Thread MediaWiki Mail
User Santhosh.thottingal posted a comment on MediaWiki.r97385. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97385#c22770 Commit summary: Narayam: Initialize key buffer only once. Also to overcome problems with focus losing while typing in FF. Comment: I got the point of

[MediaWiki-CodeReview] [MediaWiki r88057]: New comment added

2011-09-19 Thread MediaWiki Mail
User Helder.wiki posted a comment on MediaWiki.r88057. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88057#c22771 Commit summary: Reorganizing directories Comment: See [[bugzilla:30585]]. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r87849]: New comment added

2011-09-19 Thread MediaWiki Mail
User Helder.wiki posted a comment on MediaWiki.r87849. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87849#c22772 Commit summary: Add random chapter on sidebar (with help of Krinke), but it isn't ultimate code. Comment: If I update my copy of BookManager extension from r87713

Re: [Wikitech-l] automated testing with Sikuli?

2011-09-19 Thread Markus Glaser
Hi, while I don't like the idea of introducing more and more testing tools, I can still see an interesting use case here: as of now, we have no way to test whether a given layout (HTML, JS, CSS) is really rendered the way we want it to be, since both Selenium and QUnit make their tests based

[MediaWiki-CodeReview] [MediaWiki r85238]: New comment added

2011-09-19 Thread MediaWiki Mail
User Helder.wiki posted a comment on MediaWiki.r85238. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85238#c22773 Commit summary: fix of last commit Comment: There is a typo on camDisplayNavBar. It should be '''can'''DisplayNavBar.

[MediaWiki-CodeReview] [MediaWiki r97501]: New comment added

2011-09-19 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r97501. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97501#c22774 Commit summary: svn:eol-style native Comment: Hmm. Did the originals not have it set in WikimediaMaintenance? Maybe I suppose...

[MediaWiki-CodeReview] [MediaWiki r97369]: New comment added

2011-09-19 Thread MediaWiki Mail
User Jeroen De Dauw posted a comment on MediaWiki.r97369. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97369#c22775 Commit summary: reverted r96988 Comment: *Poke* ___ MediaWiki-CodeReview mailing list

Re: [Wikitech-l] Brown bag - Selenium Testing

2011-09-19 Thread Jeremy Postlethwaite
Hi Benedikt. I do not know anything about the new QA Lead position status. I only know the job has been posted. The Selenium work I did was for extensions only, since the core code is on hold. The work I have done has not been committed to core yet. I will post to the mailing list when it does

[MediaWiki-CodeReview] [MediaWiki r81460]: New comment added

2011-09-19 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r81460. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81460#c22777 Commit summary: Applied local patches for new WMF branch Comment: Rarrgh. Bad Roan, this is a really noisy merge :( ___

[MediaWiki-CodeReview] [MediaWiki r90691]: New comment added, and revision status changed

2011-09-19 Thread MediaWiki Mail
User Kevin Brown changed the status of MediaWiki.r90691. Old Status: fixme New Status: new User Kevin Brown also posted a comment on MediaWiki.r90691. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90691#c22778 Commit summary: Fix problems in r90526. Started adding proper i18n

[MediaWiki-CodeReview] [MediaWiki r97502]: New comment added

2011-09-19 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r97502. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97502#c22779 Commit summary: Creating new WMF branch Comment: svn checkout pre Checked out revision 97512. real0m14.172s user0m3.990s sys 0m2.650s /pre

[MediaWiki-CodeReview] [MediaWiki r87849]: New comment added

2011-09-19 Thread MediaWiki Mail
User Helder.wiki posted a comment on MediaWiki.r87849. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87849#c22780 Commit summary: Add random chapter on sidebar (with help of Krinke), but it isn't ultimate code. Comment: [[bugzilla:30997|Bug 30997]] - Rename (also)

[MediaWiki-CodeReview] [MediaWiki r97502]: New comment added

2011-09-19 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r97502. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97502#c22781 Commit summary: Creating new WMF branch Comment: pre reedy@fenari:/tmp$ time cp -R php-1.18/ /home/wikipedia/common/php-1.18 real45m55.731s user0m0.150s sys

[MediaWiki-CodeReview] [MediaWiki r97513]: New comment added

2011-09-19 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r97513. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97513#c22782 Commit summary: [ResourceLoader2] Merge SpecialGadgets w/ SpecialGadgetManager * Starting by correcting module names, file names and references * Fix bug from r96309.

[Wikitech-l] Status Update on Archive Links Extension

2011-09-19 Thread Kevin Brown
ArchiveLinks was created as a GSoC project to address the problem of linkrot on Wikipedia. In articles we often cite or link to external URLs, but anything could happen to content on other sites -- if they move, change, or simply vanish, the value of the citation is lost. ArchiveLinks rewrites

[MediaWiki-CodeReview] [MediaWiki r81460]: New comment added

2011-09-19 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r81460. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81460#c22783 Commit summary: Applied local patches for new WMF branch Comment: I'm sorry. If only there were a revision control system that let you rewrite history in such a case,

Re: [Wikitech-l] Status Update on Archive Links Extension

2011-09-19 Thread Kevin Brown
As an addendum I'd like to say that I plan on having the feed available on the toolserver by the end of this week. The feed will be produced by copying stuff using the external link table via a cronjob. From: Kevin Brown Sent: Monday, September 19, 2011 1:02 PM To:

[MediaWiki-CodeReview] [MediaWiki r97499]: Revision status changed

2011-09-19 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r97499. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97499 Commit summary: fix bug 30768 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r97500]: Revision status changed

2011-09-19 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r97500. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97500 Commit summary: up rel notes and increment version to 1.6.2 RC ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r97501]: Revision status changed

2011-09-19 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r97501. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97501 Commit summary: svn:eol-style native ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r97506]: Revision status changed

2011-09-19 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r97506. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97506 Commit summary: deleted incorrect eol-style property ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r97516]: New comment added

2011-09-19 Thread MediaWiki Mail
User Preilly posted a comment on MediaWiki.r97516. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97516#c22784 Commit summary: fix for bug 30943 - mobile view link should not be shown when no sensible mobile view is available For now, it Comment: This commit has a fix for

[MediaWiki-CodeReview] [MediaWiki r97369]: New comment added

2011-09-19 Thread MediaWiki Mail
User NeilK posted a comment on MediaWiki.r97369. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97369#c22785 Commit summary: reverted r96988 Comment: Pulling wikitext out of configuration seems (IMO) a bad idea. Templates are stored in the wiki db. It's bad enough that we do

[MediaWiki-CodeReview] [MediaWiki r97466]: Revision status changed

2011-09-19 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r97466. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97466 Commit summary: Remove webkit specific slow code with generic approach with the help of jquery.textselection encapsulateSelection method with

[MediaWiki-CodeReview] [MediaWiki r97385]: Revision status changed

2011-09-19 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r97385. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97385 Commit summary: Narayam: Initialize key buffer only once. Also to overcome problems with focus losing while typing in FF.

[MediaWiki-CodeReview] [MediaWiki r97250]: Revision status changed

2011-09-19 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r97250. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97250 Commit summary: Adds Assamese support in Narayam. Adds four schemes: transliteration, Avro, Bornona and Inscript.

[MediaWiki-CodeReview] [MediaWiki r97466]: New comment added

2011-09-19 Thread MediaWiki Mail
User Junaidpv posted a comment on MediaWiki.r97466. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97466#c22786 Commit summary: Remove webkit specific slow code with generic approach with the help of jquery.textselection encapsulateSelection method with optional selectionStart

[MediaWiki-CodeReview] [MediaWiki r96944]: New comment added, and revision status changed

2011-09-19 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r96944. Old Status: new New Status: ok User Catrope also posted a comment on MediaWiki.r96944. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96944#c22787 Commit summary: (bug 20919) Search Replace: Change Replace Next functionality

Re: [Wikitech-l] Repository directory [mediawiki]/trunk clean up

2011-09-19 Thread Brion Vibber
On Sun, Sep 18, 2011 at 6:18 PM, Krinkle krinklem...@gmail.com wrote: When browsing through [mediawiki]/trunk [1] I see a lot of things that have piled up over the years. Now that we have /trunk/tools [2] and the separate [wikimedia] repository, perhaps some things should be re-organized.

[MediaWiki-CodeReview] [MediaWiki r97369]: New comment added

2011-09-19 Thread MediaWiki Mail
User Jeroen De Dauw posted a comment on MediaWiki.r97369. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97369#c22788 Commit summary: reverted r96988 Comment: and obtain such config from wiki pages (perhaps with defaults in code). Well, sure, this makes sense for config in

[MediaWiki-CodeReview] [MediaWiki r97510]: Revision status changed

2011-09-19 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r97510. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97510 Commit summary: keyBufferLength needs to be 2 to get ['कh','c','च'] working. ___

[MediaWiki-CodeReview] [MediaWiki r97510]: New comment added

2011-09-19 Thread MediaWiki Mail
User Junaidpv posted a comment on MediaWiki.r97510. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97510#c22789 Commit summary: keyBufferLength needs to be 2 to get ['कh','c','च'] working. Comment: Length 1 is sufficient and having length 2 is not a harm but this change is not

[MediaWiki-CodeReview] [MediaWiki r96944]: New comment added

2011-09-19 Thread MediaWiki Mail
User Amire80 posted a comment on MediaWiki.r96944. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96944#c22790 Commit summary: (bug 20919) Search Replace: Change Replace Next functionality to Replace functionality. Patch by Amir E. Aharoni. Submitter's comment: Replace next

[MediaWiki-CodeReview] [MediaWiki r97121]: Revision status changed

2011-09-19 Thread MediaWiki Mail
User Jeroen De Dauw changed the status of MediaWiki.r97121. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97121 Commit summary: describing Upload Campaign deletion API as mostly internal, not to be relied on by 3rd parties

Re: [Wikitech-l] Repository directory [mediawiki]/trunk clean up

2011-09-19 Thread Platonides
Just try to not produce conflicts for people when updating. And keep subversion history, obviously. I'm not sure if moving in two steps would be good (svn mv, but first commit the additions, then the deletes), as it would allow for an intermediate step, where you could move things in that

Re: [Wikitech-l] Adding MD5 / SHA1 column to revision table

2011-09-19 Thread Greg Sabino Mullane
I ran some benchmarks on one of the WMF machines. The input I used is a 137.5 MB (144,220,582 bytes) OGV file that someone asked me to upload to Commons recently. For each benchmark, I hashed the file 25 times and computed the average running time. MD5: 393 ms SHA-1: 404 ms

Re: [Wikitech-l] Adding MD5 / SHA1 column to revision table

2011-09-19 Thread Conrad Irwin
On Mon, Sep 19, 2011 at 11:11 AM, Greg Sabino Mullane g...@endpoint.com wrote: I'm also of the opinion that we should just store things as CHAR(32), unless someone thinks space is really at that much of a premium. The big advantage of 32 chars (i.e. 0-9a-f aka hexadecimal ) is that it's a

Re: [Wikitech-l] Adding MD5 / SHA1 column to revision table

2011-09-19 Thread Chad
On Mon, Sep 19, 2011 at 2:11 PM, Greg Sabino Mullane g...@endpoint.com wrote: * When reverting, do a select count(*) where md5=? and then do something more advanced when more than one match is found That sounds very painful :( -Chad ___ Wikitech-l

[Wikitech-l] Python Code Review for Fundraiser Analytics

2011-09-19 Thread Ryan Faulkner
Hi All, This is my first post to wikitech-l! The 2011 Fundraiser draws near and we're trying to setup efficient code review for the analytics source which has a fairly high throughput. I have one code review volunteer already, but I was seeing if anyone else would be interested in helping to

Re: [Wikitech-l] automated testing with Sikuli?

2011-09-19 Thread Trevor Parscal
I've been aware of this tool for quite a while, and shown it to some other devs around here. I think it's awesome, but I have not had a need for it yet. I think the visual editor may present some cases where this makes sense - but generally it seems the most useful for writing tests that involved

[MediaWiki-CodeReview] [MediaWiki r81460]: New comment added

2011-09-19 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r81460. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81460#c22791 Commit summary: Applied local patches for new WMF branch Comment: Heh. Well, I know you don't commit this sort of revisions now, or at least, not intentionally Yay for

[MediaWiki-CodeReview] [MediaWiki r97385]: New comment added

2011-09-19 Thread MediaWiki Mail
User Junaidpv posted a comment on MediaWiki.r97385. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97385#c22792 Commit summary: Narayam: Initialize key buffer only once. Also to overcome problems with focus losing while typing in FF. Comment: Actually I was to fix a problem in

[MediaWiki-CodeReview] [MediaWiki r97368]: Revision status changed

2011-09-19 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r97368. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97368 Commit summary: fix bug 30676 - Foo.jpg.jpg silently fixed to Foo.jpg ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r43471]: New comment added

2011-09-19 Thread MediaWiki Mail
User Brion VIBBER posted a comment on MediaWiki.r43471. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/43471#c22793 Commit summary: Fix incorrect use of Title::newFromText(). That function lets the user choose the namespace using a title with colons, to force the namespace you

[MediaWiki-CodeReview] [MediaWiki r74966]: New comment added

2011-09-19 Thread MediaWiki Mail
User Trevor Parscal posted a comment on MediaWiki.r74966. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/74966#c22794 Commit summary: First shot at porting Monobook to Vector. The only non-straightforward part is moving from a separate rtl.css file to a main.css file we can

[MediaWiki-CodeReview] [MediaWiki r74966]: Revision status changed

2011-09-19 Thread MediaWiki Mail
User Trevor Parscal changed the status of MediaWiki.r74966. Old Status: new New Status: fixme Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/74966 Commit summary: First shot at porting Monobook to Vector. The only non-straightforward part is moving from a separate rtl.css file

[MediaWiki-CodeReview] [MediaWiki r96941]: Revision status changed

2011-09-19 Thread MediaWiki Mail
User Trevor Parscal changed the status of MediaWiki.r96941. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96941 Commit summary: make parser more robust to errors, do not halt script execution - bug #30707

[MediaWiki-CodeReview] [MediaWiki r97540]: Revision status changed

2011-09-19 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r97540. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97540 Commit summary: hack - version_compare statement broken for 1.18wmf ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r97539]: New comment added

2011-09-19 Thread MediaWiki Mail
User Brion VIBBER posted a comment on MediaWiki.r97539. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97539#c22795 Commit summary: Enable Server side searching on Doxygen * (bug 31004) Class reference (Doxygen docs) should have a search Comment: Warning: either your editor is

[MediaWiki-CodeReview] [MediaWiki r97519]: Revision status changed

2011-09-19 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r97519. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97519 Commit summary: schema migration for wmf 1.18 release ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r97525]: Revision status changed

2011-09-19 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r97525. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97525 Commit summary: customized patch-fr_page_rev-index.sql for wmf ___ MediaWiki-CodeReview

Re: [Wikitech-l] Adding MD5 / SHA1 column to revision table

2011-09-19 Thread Brion Vibber
[snip] So just FYI -- the only *actual* controversy that needs to be discussed in this thread is how do we make this update applicable in a way that doesn't disrupt live sites with many millions of pages? We're pretty fixed on SHA-1 as a checksum sig (already using it elsewhere) and have no

[MediaWiki-CodeReview] [MediaWiki r97520]: Revision status changed

2011-09-19 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r97520. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97520 Commit summary: change updatelog version to 1.18wmf1-1 from -final ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r97542]: New comment added

2011-09-19 Thread MediaWiki Mail
User MaxSem posted a comment on MediaWiki.r97542. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97542#c22797 Commit summary: Rewrote tokenizer so that it can actually be understood by mortal humans. All previous tokenizer's glitches are kept intact FOR NOW, except for: *

Re: [Wikitech-l] Adding MD5 / SHA1 column to revision table

2011-09-19 Thread Asher Feldman
Since the primary use case here seems to be offline analysis and it may not be of much interest to mediawiki users outside of wmf, can we store the checksums in new tables (i.e. revision_sha1) instead of running large alters, and implement the code to generate checksums on new edits via an

[MediaWiki-CodeReview] [MediaWiki r77778]: New comment added, and revision status changed

2011-09-19 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r8. Old Status: resolved New Status: fixme User Brion VIBBER also posted a comment on MediaWiki.r8. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/8#c22798 Commit summary: One less $wgTitle, and use dbw-update()

[MediaWiki-CodeReview] [MediaWiki r97490]: Revision status changed

2011-09-19 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r97490. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97490 Commit summary: Commenting out r81460, there's too much merge info rubbish and stuff ___

[MediaWiki-CodeReview] [MediaWiki r97502]: Revision status changed

2011-09-19 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r97502. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97502 Commit summary: Creating new WMF branch ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r97503]: Revision status changed

2011-09-19 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r97503. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97503 Commit summary: Applied local patches for new WMF branch ___ MediaWiki-CodeReview mailing

Re: [Wikitech-l] Adding MD5 / SHA1 column to revision table

2011-09-19 Thread Brion Vibber
On Mon, Sep 19, 2011 at 12:53 PM, Asher Feldman afeld...@wikimedia.orgwrote: Since the primary use case here seems to be offline analysis and it may not be of much interest to mediawiki users outside of wmf, can we store the checksums in new tables (i.e. revision_sha1) instead of running large

[MediaWiki-CodeReview] [MediaWiki r97504]: Revision status changed

2011-09-19 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r97504. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97504 Commit summary: Followup r97502, 1.18-i[sz]e StartProfiler.php ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r93686]: New comment added

2011-09-19 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r93686. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93686#c22799 Commit summary: Merge live hacks - Tim's fixes for canary mismatches from back around the 1.17 deploy. Don't want to push this to trunk, but don't want it lost

[MediaWiki-CodeReview] [MediaWiki r97505]: Revision status changed

2011-09-19 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r97505. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97505 Commit summary: 1.18wmf1 Merge r83867, r93686, r93807, r93971, r93972 (some manually do to location changes)

[MediaWiki-CodeReview] [MediaWiki r77778]: New comment added, and revision status changed

2011-09-19 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r8. Old Status: fixme New Status: resolved User Brion VIBBER also posted a comment on MediaWiki.r8. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/8#c22800 Commit summary: One less $wgTitle, and use dbw-update()

[MediaWiki-CodeReview] [MediaWiki r97531]: New comment added, and revision status changed

2011-09-19 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r97531. Old Status: new New Status: fixme User Reedy also posted a comment on MediaWiki.r97531. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97531#c22801 Commit summary: Merged in a fix from Wikia to make sure to call the

[MediaWiki-CodeReview] [MediaWiki r96552]: Revision status changed

2011-09-19 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r96552. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96552 Commit summary: Committing 2 live hacks swapping cache type (needs reapplying to 1.18wmf1)

[MediaWiki-CodeReview] [MediaWiki r93686]: New comment added

2011-09-19 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r93686. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93686#c22802 Commit summary: Merge live hacks - Tim's fixes for canary mismatches from back around the 1.17 deploy. Don't want to push this to trunk, but don't want it lost easier :)

[MediaWiki-CodeReview] [MediaWiki r96835]: Revision status changed

2011-09-19 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r96835. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96835 Commit summary: Live hacks: * Reduce the load on the statistics server by removing the per-request counters * Fix Parser call stack

[MediaWiki-CodeReview] [MediaWiki r97508]: Revision status changed

2011-09-19 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r97508. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97508 Commit summary: 1.18wmf1, Merge r96552, r96835 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r96552]: New comment added

2011-09-19 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r96552. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96552#c22803 Commit summary: Committing 2 live hacks swapping cache type (needs reapplying to 1.18wmf1) Comment: Can this go in /trunk?

[MediaWiki-CodeReview] [MediaWiki r96552]: New comment added

2011-09-19 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r96552. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96552#c22804 Commit summary: Committing 2 live hacks swapping cache type (needs reapplying to 1.18wmf1) Comment: Can this go in /trunk?

  1   2   >