[MediaWiki-CodeReview] [MediaWiki r100947]: Revision status changed

2011-10-27 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r100947. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100947 Commit summary: Followup to r86053 - fix special page cases [27-Oct-2011 05:51:24] PHP Notice: Found alias defined for Listadmins

[MediaWiki-CodeReview] [MediaWiki r100830]: Revision status changed

2011-10-27 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r100830. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100830 Commit summary: (follow-up r100603) re-use variable ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r100603]: New comment added

2011-10-27 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r100603. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100603#c24959 Commit summary: (bug 31915) Narayam help page should be in content language Comment: Just realised that narayam-help-page should probably also be dropped from

[MediaWiki-CodeReview] [MediaWiki r100831]: Revision status changed

2011-10-27 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r100831. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100831 Commit summary: Fix typo in r100806 that broke i18n for tale headers on Special:ArticleFeedback

[MediaWiki-CodeReview] [MediaWiki r100835]: New comment added

2011-10-27 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r100835. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100835#c24960 Commit summary: user configuration fixed db Comment: pre+ array( 'username' = strtolower($wgUser-getID()) ), /pre Why are you lower casing user

[MediaWiki-CodeReview] [MediaWiki r100844]: Revision status changed

2011-10-27 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r100844. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100844 Commit summary: Formatting code per MediaWiki coding conventions ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r100849]: Revision status changed

2011-10-27 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r100849. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100849 Commit summary: fixed picture names ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r100865]: New comment added, and revision status changed

2011-10-27 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r100865. Old Status: new New Status: fixme User Nikerabbit also posted a comment on MediaWiki.r100865. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100865#c24961 Commit summary: better way to get page owner Comment: Um.

[MediaWiki-CodeReview] [MediaWiki r100823]: New comment added

2011-10-27 Thread MediaWiki Mail
User Jpostlethwaite posted a comment on MediaWiki.r100823. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100823#c24962 Commit summary: Setup unit test for Real Time Bank Transfer: NordeaSweeden Comment: That is what I thought to. I will have to ask. I was asked to create a

[MediaWiki-CodeReview] [MediaWiki r100876]: New comment added

2011-10-27 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r100876. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100876#c24963 Commit summary: fix fail Comment: Should you also fix the commented code above? ;) ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r100823]: New comment added, and revision status changed

2011-10-27 Thread MediaWiki Mail
User Jpostlethwaite changed the status of MediaWiki.r100823. Old Status: new New Status: fixme User Jpostlethwaite also posted a comment on MediaWiki.r100823. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100823#c24964 Commit summary: Setup unit test for Real Time Bank

[MediaWiki-CodeReview] [MediaWiki r100940]: Revision status changed

2011-10-27 Thread MediaWiki Mail
User MaxSem changed the status of MediaWiki.r100940. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100940 Commit summary: REVERT ME LATER. Define zh-* message explicitly ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r100881]: Revision status changed

2011-10-27 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r100881. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100881 Commit summary: fix fail ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r100884]: New comment added

2011-10-27 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r100884. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100884#c24965 Commit summary: [RL2] Turn getAllGadgets() into a versatile helper function that supports getting all gadgets with and without local gadgets, as either ID strings

[MediaWiki-CodeReview] [MediaWiki r100932]: New comment added

2011-10-27 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r100932. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100932#c24968 Commit summary: Disabled bad image tests which made totally broken assumptions about how/when the bad_image_list message is loaded. This caused failures with

[MediaWiki-CodeReview] [MediaWiki r100941]: Revision status changed

2011-10-27 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r100941. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100941 Commit summary: Revert r100940 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r100952]: Revision status changed

2011-10-27 Thread MediaWiki Mail
User Awjrichards changed the status of MediaWiki.r100952. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100952 Commit summary: Fixed punctuation in comments. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [Wikimedia r667]: New comment added

2011-10-27 Thread MediaWiki Mail
User Pgehres (WMF) posted a comment on Wikimedia.r667. Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/667#c24969 Commit summary: Adding translated thank-you email functionality as well as en defaults Comment: I added error checking to all API calls in r679 as well as error

[MediaWiki-CodeReview] [Wikimedia r667]: Revision status changed

2011-10-27 Thread MediaWiki Mail
User Pgehres (WMF) changed the status of Wikimedia.r667. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/667 Commit summary: Adding translated thank-you email functionality as well as en defaults ___

[MediaWiki-CodeReview] [Wikimedia r679]: Revision status changed

2011-10-27 Thread MediaWiki Mail
User Awjrichards changed the status of Wikimedia.r679. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/679 Commit summary: while(true){ addErrorChecking('thank_you'); } ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [Wikimedia r667]: Revision status changed

2011-10-27 Thread MediaWiki Mail
User Awjrichards changed the status of Wikimedia.r667. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/667 Commit summary: Adding translated thank-you email functionality as well as en defaults ___

[MediaWiki-CodeReview] [Wikimedia r675]: New comment added

2011-10-27 Thread MediaWiki Mail
User Pgehres (WMF) posted a comment on Wikimedia.r675. Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/675#c24970 Commit summary: Adding TY email unsubscribe functionality plus minor stuff Comment: Added to Bugzilla https://bugzilla.wikimedia.org/show_bug.cgi?id=31985

[MediaWiki-CodeReview] [Wikimedia r668]: Revision status changed

2011-10-27 Thread MediaWiki Mail
User Pgehres (WMF) changed the status of Wikimedia.r668. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/668 Commit summary: Adding files dir and WMF logo to CiviCRM ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r99905]: New comment added

2011-10-27 Thread MediaWiki Mail
User Raymond posted a comment on MediaWiki.r99905. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99905#c24971 Commit summary: Bug 31681 - Special:Cite displays protocol relative URLs if $wgServer is relative Per Brion (comment# 3): Seems sensible enough to use the canonical

Re: [Wikitech-l] Please review: MediaWiki architecture document

2011-10-27 Thread Denny Vrandečić
Hi Guillaume, I just started reading the chapter, and I am really enjoying it. Your intro reminded me of an article Mathias Schindler and I wrote a few years back, maybe you want to skim it, and even find something interesting in it. http://journal.webscience.org/213/ Cheers, Denny 2011/10/24

[MediaWiki-CodeReview] [MediaWiki r100884]: New comment added

2011-10-27 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r100884. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100884#c24972 Commit summary: [RL2] Turn getAllGadgets() into a versatile helper function that supports getting all gadgets with and without local gadgets, as either ID strings or

[MediaWiki-CodeReview] [MediaWiki r100927]: Revision status changed

2011-10-27 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r100927. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100927 Commit summary: Followup r100905, cleanup per CR and fixes the overriding of the main RequestContext

[MediaWiki-CodeReview] [MediaWiki r100910]: Revision status changed

2011-10-27 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r100910. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100910 Commit summary: Fix user links ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r100904]: Revision status changed

2011-10-27 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r100904. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100904 Commit summary: MoodBar: Hide hidden results from non-admin users ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r100359]: New comment added

2011-10-27 Thread MediaWiki Mail
User Yair rand posted a comment on MediaWiki.r100359. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100359#c24974 Commit summary: add search suggestions to MF Comment: I think it would be much better to use JSON for the search suggestions instead of XML. Also, creating the

[MediaWiki-CodeReview] [MediaWiki r100813]: Revision status changed

2011-10-27 Thread MediaWiki Mail
User Johnduhart changed the status of MediaWiki.r100813. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100813 Commit summary: Bug 31609 - Option to change reCAPTCHA theme Patch by Nx.devnull ___

[MediaWiki-CodeReview] [MediaWiki r99354]: Revision status changed

2011-10-27 Thread MediaWiki Mail
User Johnduhart changed the status of MediaWiki.r99354. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99354 Commit summary: CategoryViewer now requires a Context ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r100352]: New comment added, and revision status changed

2011-10-27 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r100352. Old Status: new New Status: ok User Hashar also posted a comment on MediaWiki.r100352. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100352#c24975 Commit summary: Removed deprecated getFullPath(); no callers Comment: I

[MediaWiki-CodeReview] [MediaWiki r100175]: Revision status changed

2011-10-27 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r100175. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100175 Commit summary: Use spaces around × for consistency. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r100183]: New comment added, and revision status changed

2011-10-27 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r100183. Old Status: new New Status: ok User Hashar also posted a comment on MediaWiki.r100183. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100183#c24976 Commit summary: Clarify proxyblockreason per suggestion of Amir. Comment:

[MediaWiki-CodeReview] [MediaWiki r100128]: New comment added, and revision status changed

2011-10-27 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r100128. Old Status: new New Status: ok User Hashar also posted a comment on MediaWiki.r100128. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100128#c24977 Commit summary: Kill dead/rotting importUseModWiki(pedia)? maintenance

[MediaWiki-CodeReview] [MediaWiki r99993]: Revision status changed

2011-10-27 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r3. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/3 Commit summary: Adding missing test for isEmpty ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r99990]: Revision status changed

2011-10-27 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r0. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/0 Commit summary: Do a test for 1K ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r99991]: Revision status changed

2011-10-27 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r1. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/1 Commit summary: Forgot lowercase again, arrggg ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r99960]: Revision status changed

2011-10-27 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r99960. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99960 Commit summary: Initial tests for wfShorthandToInteger(). Definitely needs more ___

[MediaWiki-CodeReview] [MediaWiki r99988]: Revision status changed

2011-10-27 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r99988. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99988 Commit summary: Add another test case for shorthand to integer (lowercase too) ___

[Wikitech-l] So how does WMF set up its Apaches?

2011-10-27 Thread David Gerard
As I understand it, WMF has (a) hundreds of Apaches (b) running Ubuntu. How do you set up the Apaches to a substantially-identical configuration? I looked on the wikitech wiki and couldn't see it. (I ask only for my own interest - I currently want to take the Debian/Ubuntu apache2 out and have it

[MediaWiki-CodeReview] [MediaWiki r99523]: Revision status changed

2011-10-27 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r99523. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99523 Commit summary: Fix comment blocks that start /* to /** ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r99334]: Revision status changed

2011-10-27 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r99334. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99334 Commit summary: Document return types ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r99308]: Revision status changed

2011-10-27 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r99308. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99308 Commit summary: Update Chinese conversion tables. ___ MediaWiki-CodeReview mailing list

Re: [Wikitech-l] So how does WMF set up its Apaches?

2011-10-27 Thread David Gerard
On 27 October 2011 13:34, Chad innocentkil...@gmail.com wrote: On Thu, Oct 27, 2011 at 8:30 AM, David Gerard dger...@gmail.com wrote: As I understand it, WMF has (a) hundreds of Apaches (b) running Ubuntu. How do you set up the Apaches to a substantially-identical configuration? I looked on

Re: [Wikitech-l] So how does WMF set up its Apaches?

2011-10-27 Thread Roan Kattouw
On Thu, Oct 27, 2011 at 2:40 PM, David Gerard dger...@gmail.com wrote: I was afraid of that. (Someone else I asked says the same.) /me queues another yak up for the shaving Most of our puppet config was recently made public in a git repository, see

[MediaWiki-CodeReview] [MediaWiki r99304]: New comment added

2011-10-27 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r99304. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99304#c24978 Commit summary: Fix Bug 27643. Update Chinese conversion tables. Comment: tagging 1.18, 1.18wmf1 for deployment ___

[MediaWiki-CodeReview] [MediaWiki r99304]: Revision status changed

2011-10-27 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r99304. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99304 Commit summary: Fix Bug 27643. Update Chinese conversion tables. ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r100219]: Revision status changed

2011-10-27 Thread MediaWiki Mail
User Liangent changed the status of MediaWiki.r100219. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100219 Commit summary: Update Chinese conversion table: follow r90409, fix an incorrect rule. ___

[MediaWiki-CodeReview] [MediaWiki r100226]: Revision status changed

2011-10-27 Thread MediaWiki Mail
User Liangent changed the status of MediaWiki.r100226. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100226 Commit summary: Revert unihan.zip's version to 5.2.0. ___ MediaWiki-CodeReview mailing list

Re: [Wikitech-l] So how does WMF set up its Apaches?

2011-10-27 Thread David Gerard
On 27 October 2011 13:42, Roan Kattouw roan.katt...@gmail.com wrote: On Thu, Oct 27, 2011 at 2:40 PM, David Gerard dger...@gmail.com wrote: I was afraid of that. (Someone else I asked says the same.) /me queues another yak up for the shaving Most of our puppet config was recently made public

[MediaWiki-CodeReview] [MediaWiki r100835]: New comment added

2011-10-27 Thread MediaWiki Mail
User Petrb posted a comment on MediaWiki.r100835. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100835#c24979 Commit summary: user configuration fixed db Comment: why is this fixme? I lowercase it because when someone login as bob while his name is Bob it's possible that

[MediaWiki-CodeReview] [MediaWiki r100835]: New comment added

2011-10-27 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r100835. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100835#c24980 Commit summary: user configuration fixed db Comment: User object is guaranteed to return the user name in correct capitalization. Now you cannot for example do a

[MediaWiki-CodeReview] [MediaWiki r100835]: New comment added

2011-10-27 Thread MediaWiki Mail
User Petrb posted a comment on MediaWiki.r100835. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100835#c24981 Commit summary: user configuration fixed db Comment: also lowercase should be only in mediawiki hooks which work in db, otherwise it isn't necessary on User:bob it

[MediaWiki-CodeReview] [MediaWiki r100835]: New comment added

2011-10-27 Thread MediaWiki Mail
User Petrb posted a comment on MediaWiki.r100835. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100835#c24982 Commit summary: user configuration fixed db Comment: I don't see a reason to do join, anyway, user object may return correct name, but there are other ways used than

[MediaWiki-CodeReview] [MediaWiki r94158]: Revision status changed

2011-10-27 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r94158. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94158 Commit summary: Various profiler tweaks: * Add some debugging output to bad profiler config * Make member variables all protected, nothing uses

[MediaWiki-CodeReview] [MediaWiki r94158]: Revision status changed

2011-10-27 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r94158. Old Status: ok New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94158 Commit summary: Various profiler tweaks: * Add some debugging output to bad profiler config * Make member variables all protected, nothing

[MediaWiki-CodeReview] [MediaWiki r96305]: Revision status changed

2011-10-27 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r96305. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96305 Commit summary: mediawiki.html: Add broken tests for numbers and booleans * The following are broken right now: mw.html.element( 'p', {}, 500

[MediaWiki-CodeReview] [MediaWiki r100835]: New comment added

2011-10-27 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r100835. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100835#c24983 Commit summary: user configuration fixed db Comment: If the user name comes from some other source, I would pass it through the user object to get the correct

[MediaWiki-CodeReview] [MediaWiki r96298]: Revision status changed

2011-10-27 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r96298. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96298 Commit summary: Another thing that's been bothering me, skins shouldn't have to access $wgSitenotice directly when we have a logopath.

[MediaWiki-CodeReview] [MediaWiki r95728]: Revision status changed

2011-10-27 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r95728. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95728 Commit summary: Make file names match module names. * See [[Coding conventions#File naming]] * This pretty much undos r94325.

[MediaWiki-CodeReview] [MediaWiki r100835]: New comment added

2011-10-27 Thread MediaWiki Mail
User Petrb posted a comment on MediaWiki.r100835. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100835#c24984 Commit summary: user configuration fixed db Comment: I removed tolower now I hope it never fail because of that... ___

[MediaWiki-CodeReview] [MediaWiki r100863]: New comment added

2011-10-27 Thread MediaWiki Mail
User Cryptocoryne posted a comment on MediaWiki.r100863. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100863#c24985 Commit summary: Adding beta-version of extension 'AutoProxyBlock' to repo Comment: See r100972. Core function LogPage::addEntry is broken for this extension

[MediaWiki-CodeReview] [MediaWiki r99919]: Revision status changed

2011-10-27 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r99919. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99919 Commit summary: Rudimentary hook benchmarks ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r99921]: Revision status changed

2011-10-27 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r99921. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99921 Commit summary: Refactor out duplicate code Add 10 subscribers. Can we have 10 of the same? ___

[MediaWiki-CodeReview] [MediaWiki r99922]: Revision status changed

2011-10-27 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r99922. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99922 Commit summary: And 100 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r100972]: New comment added

2011-10-27 Thread MediaWiki Mail
User Siebrand posted a comment on MediaWiki.r100972. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100972#c24986 Commit summary: Followup r100863, some improves and fixes Comment: {{messagedocumentation}} ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r100865]: New comment added

2011-10-27 Thread MediaWiki Mail
User Petrb posted a comment on MediaWiki.r100865. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100865#c24987 Commit summary: better way to get page owner Comment: it's already replaced with new function ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r100972]: New comment added

2011-10-27 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r100972. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100972#c24988 Commit summary: Followup r100863, some improves and fixes Comment: Good, you removed those nasty BOM characters from the files. You might want to consider using

[MediaWiki-CodeReview] [MediaWiki r100976]: New comment added

2011-10-27 Thread MediaWiki Mail
User Johnduhart posted a comment on MediaWiki.r100976. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100976#c24989 Commit summary: fixed some parts of code Comment: Hey if you can get in IRC I can do that code review with you :) ___

[MediaWiki-CodeReview] [MediaWiki r100976]: New comment added

2011-10-27 Thread MediaWiki Mail
User Petrb posted a comment on MediaWiki.r100976. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100976#c24990 Commit summary: fixed some parts of code Comment: I will try ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r100912]: New comment added, and revision status changed

2011-10-27 Thread MediaWiki Mail
User Jeroen De Dauw changed the status of MediaWiki.r100912. Old Status: deferred New Status: fixme User Jeroen De Dauw also posted a comment on MediaWiki.r100912. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100912#c24991 Commit summary: kill obsolete bc code Comment:

[MediaWiki-CodeReview] [MediaWiki r100876]: New comment added

2011-10-27 Thread MediaWiki Mail
User Jeroen De Dauw posted a comment on MediaWiki.r100876. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100876#c24992 Commit summary: fix fail Comment: Huh? It's commented out, since it's not supported for now. How would I fix that?

Re: [Wikitech-l] So how does WMF set up its Apaches?

2011-10-27 Thread Jay Ashworth
- Original Message - From: David Gerard dger...@gmail.com As I understand it, WMF has (a) hundreds of Apaches (b) running Ubuntu. How do you set up the Apaches to a substantially-identical configuration? I looked on the wikitech wiki and couldn't see it. (I ask only for my own

[MediaWiki-CodeReview] [MediaWiki r100876]: New comment added

2011-10-27 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r100876. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100876#c24993 Commit summary: fix fail Comment: I mean, you could make the same change, assuming the code would have the same bug if uncommented.

[MediaWiki-CodeReview] [MediaWiki r100915]: Revision status changed

2011-10-27 Thread MediaWiki Mail
User Platonides changed the status of MediaWiki.r100915. Old Status: new New Status: fixme Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100915 Commit summary: * Allow passing in a blacklist into wfIsBadImage() * Added wfIsBadImage() unit tests

[MediaWiki-CodeReview] [MediaWiki r100915]: New comment added

2011-10-27 Thread MediaWiki Mail
User Platonides posted a comment on MediaWiki.r100915. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100915#c24994 Commit summary: * Allow passing in a blacklist into wfIsBadImage() * Added wfIsBadImage() unit tests Comment: The RepoGroup::singleton()-checkRedirect of

[MediaWiki-CodeReview] [MediaWiki r100981]: Revision status changed

2011-10-27 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r100981. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100981 Commit summary: Using empty array instead of false for no elements can be nested, using 2 falsey magic values was looking too scary

[MediaWiki-CodeReview] [MediaWiki r100535]: New comment added

2011-10-27 Thread MediaWiki Mail
User Platonides posted a comment on MediaWiki.r100535. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100535#c24995 Commit summary: Added a basic thumb-handler.php file, configured via thumb.config.php. The code is based on the wmf thumb handler, but simplified. It is disabled

[MediaWiki-CodeReview] [MediaWiki r100983]: Revision status changed

2011-10-27 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r100983. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100983 Commit summary: Change the name back to dumpHook (r96336). That makes obvious that the use of var_dump is intended.

[MediaWiki-CodeReview] [MediaWiki r100986]: Revision status changed

2011-10-27 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r100986. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100986 Commit summary: Fixed typo in comment ___ MediaWiki-CodeReview mailing list

Re: [Wikitech-l] So how does WMF set up its Apaches?

2011-10-27 Thread Jon Davis
wm.org referring to which site? Wikimedia.org? Mediawiki.org? Granted not everything is up to date, but there is a fair amount on Wikitech [1] that is being updated. A lot of the live configs are also on NOC [2]. Between sites like NOC and access to Puppet (via Git), you've got a majority of

[MediaWiki-CodeReview] [MediaWiki r100990]: Revision status changed

2011-10-27 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r100990. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100990 Commit summary: Fixed code that checks edges - data.length is the edge, not data.length - 1 ___

[MediaWiki-CodeReview] [MediaWiki r100905]: New comment added, and revision status changed

2011-10-27 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r100905. Old Status: new New Status: fixme User Hashar also posted a comment on MediaWiki.r100905. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100905#c24996 Commit summary: Adding context to the API This will probably break

[MediaWiki-CodeReview] [MediaWiki r100535]: New comment added

2011-10-27 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r100535. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100535#c24997 Commit summary: Added a basic thumb-handler.php file, configured via thumb.config.php. The code is based on the wmf thumb handler, but simplified. It is disabled

[MediaWiki-CodeReview] [MediaWiki r100912]: Revision status changed

2011-10-27 Thread MediaWiki Mail
User Jeroen De Dauw changed the status of MediaWiki.r100912. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100912 Commit summary: kill obsolete bc code ___ MediaWiki-CodeReview mailing list

Re: [Wikitech-l] So how does WMF set up its Apaches?

2011-10-27 Thread Jay Ashworth
- Original Message - From: Jon Davis w...@konsoletek.com I keep getting a sort of twisted Garfield reference out of your name, Jon. :-) wm.org referring to which site? Wikimedia.org? Mediawiki.org? On wikimedia/wikitech, about mediawiki. Granted not everything is up to date, but

Re: [Wikitech-l] Please review: MediaWiki architecture document

2011-10-27 Thread Jay Ashworth
We'll submit the final draft to the book's editors in about a week, but before that I'd like to ask you guys to review the document. Mostly for accuracy (we don't want to publish something that contains factual errors), but other comments are encouraged as well. Guilliaume: Are you interested

[MediaWiki-CodeReview] [MediaWiki r100942]: New comment added

2011-10-27 Thread MediaWiki Mail
User Khorn (WMF) posted a comment on MediaWiki.r100942. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100942#c24998 Commit summary: Added GlobalCollectTestAdapter for testing the GlobalCollect adapter. Comment: Awesome. You may want to consider adding back in some of the

[MediaWiki-CodeReview] [MediaWiki r100942]: New comment added

2011-10-27 Thread MediaWiki Mail
User Khorn (WMF) posted a comment on MediaWiki.r100942. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100942#c24999 Commit summary: Added GlobalCollectTestAdapter for testing the GlobalCollect adapter. Comment: Also: Is this object being used anywhere yet? I see the last time

[MediaWiki-CodeReview] [MediaWiki r100915]: New comment added

2011-10-27 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r100915. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100915#c25000 Commit summary: * Allow passing in a blacklist into wfIsBadImage() * Added wfIsBadImage() unit tests Comment: What test parameters are you running to get that.

[MediaWiki-CodeReview] [MediaWiki r100625]: New comment added, and revision status changed

2011-10-27 Thread MediaWiki Mail
User Khorn (WMF) changed the status of MediaWiki.r100625. Old Status: new New Status: deferred User Khorn (WMF) also posted a comment on MediaWiki.r100625. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100625#c25001 Commit summary: Developing unit tests for the GatewayAdapter.

[MediaWiki-CodeReview] [MediaWiki r100942]: Revision status changed

2011-10-27 Thread MediaWiki Mail
User Khorn (WMF) changed the status of MediaWiki.r100942. Old Status: new New Status: fixme Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100942 Commit summary: Added GlobalCollectTestAdapter for testing the GlobalCollect adapter.

[MediaWiki-CodeReview] [MediaWiki r101002]: Revision status changed

2011-10-27 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r101002. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101002 Commit summary: parsertest now destroy virtual table under SQLite Fix: Bug 29912 - Unit tests break if parsertest tables are still

[MediaWiki-CodeReview] [MediaWiki r100995]: Revision status changed

2011-10-27 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r100995. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100995 Commit summary: Remove todo, it's public now ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r101001]: Revision status changed

2011-10-27 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r101001. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101001 Commit summary: stylize.php ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r100128]: New comment added

2011-10-27 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r100128. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100128#c25002 Commit summary: Kill dead/rotting importUseModWiki(pedia)? maintenance scripts Comment: Could do. Wouldn't do any harm being left (though, I'd be suprised if it

[MediaWiki-CodeReview] [MediaWiki r100942]: New comment added

2011-10-27 Thread MediaWiki Mail
User Jpostlethwaite posted a comment on MediaWiki.r100942. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100942#c25003 Commit summary: Added GlobalCollectTestAdapter for testing the GlobalCollect adapter. Comment: Yes it is being used to signal which adapter to test.

Re: [Wikitech-l] Please review: MediaWiki architecture document

2011-10-27 Thread Guillaume Paumier
Hi, On Thu, Oct 27, 2011 at 6:54 PM, Jay Ashworth j...@baylink.com wrote: We'll submit the final draft to the book's editors in about a week, but before that I'd like to ask you guys to review the document. Mostly for accuracy (we don't want to publish something that contains factual errors),

  1   2   3   >