Re: [Wikitech-l] [testing] TitleBlacklist now tested under Jenkins

2012-08-30 Thread Antoine Musso
Le 29/08/12 16:27, Chad a écrit : Question: why does the config for non-extension tests attempt to load extensions? -Parser and -Misc both seem to be failing due to a broken inclusion of Wikibase. The -Parser and -Misc jobs are triggered by both the MediaWiki core job and the one testing the

Re: [Wikitech-l] 5 tips to get your code reviewed faster

2012-08-30 Thread Antoine Musso
Le 30/08/12 00:05, Thomas Gries a écrit : Something which needs so much text, is broken is some respect. Mies van der Rohe: Less is more. Well we probably nickname the community team too long did not read for a reason, their job is indeed to write full reports which I myself find enjoying. Tip

Re: [Wikitech-l] 5 tips to get your code reviewed faster

2012-08-30 Thread Antoine Musso
Le 29/08/12 23:55, Sumana Harihareswara wrote: 1) Write small commits. I cant stress how important this is. git has several ways to split a commit: - git rebase --interactive parent commit sha1 - reset to master and git cherry-pick --no-commit sha1 then use git add --patch to select the hunk to

Re: [Wikitech-l] [testing] TitleBlacklist now tested under Jenkins

2012-08-30 Thread Oren Bochman
I've tried to do this for translate ext last week - so here are a couple of questions: 1. is successfully runnig the test a requirement to successfully score on gerrit? (i.e. how is gerrit integrated) 2. does the extension need to include php unit? On Thu, Aug 30, 2012 at 9:43 AM, Antoine Musso

Re: [Wikitech-l] $( 'div' ) vs. $( 'div /') in coding conventions (and methods for building DOMs with jQuery)

2012-08-30 Thread Daniel Werner
In that case, perhaps we should just say that all of the options are fine: $( 'div' ) $( 'div/' ) $( 'div/div' ) but emphasize not to use attributes in the tag creation. +1 All three will return the same, and this is not HTML, it's JavaScript. It really is just a matter of personal flavor

Re: [Wikitech-l] AJAX sharing of Commons data/metadata

2012-08-30 Thread Alex Brollo
2012/8/30 Brion Vibber br...@pobox.com Luckily, if you're using jQuery much of the low-level stuff can be taken care of for you. Something like this should work for API calls, automatically using the callback behind the scenes: Thanks! really I tested some interproject AJAX API call with

[Wikitech-l] Please help MediaWiki I18n/L10n improve

2012-08-30 Thread Niklas Laxström
tl;dr: Please help in getting https://bugzilla.wikimedia.org/38638 resolved and ensure that your code doesn't cause additional issues for translators. At translatewiki.net we have an [ask question] button for translators, and they have really used it to report various kinds of issues with the

Re: [Wikitech-l] Disabling direct pushing to master for extensions

2012-08-30 Thread Chad
On Wed, Aug 29, 2012 at 10:12 PM, Ryan Lane rlan...@gmail.com wrote: For a bunch of reasons, we need to look at disabling direct pushing on the master branch for all extensions in Gerrit […] Before I make the change though, I wanted to ask about it publicly to make sure there's no major

[Wikitech-l] quality at Google, 2006-2011

2012-08-30 Thread Chris McMahon
This crossed my desk this morning, it is a long and detailed (and honest!) account by an insider of Google's efforts to increase code quality and product quality. I think it's relevant to what we're doing at WMF, and what we might do in the future.

Re: [Wikitech-l] $( 'div' ) vs. $( 'div /') in coding conventions (and methods for building DOMs with jQuery)

2012-08-30 Thread Trevor Parscal
On Thu, Aug 30, 2012 at 3:24 AM, Daniel Werner daniel.wer...@wikimedia.dewrote: By the way, you can also use $( 'div/', { 'class': 'foo', 'title': 'myTitle', ... } ); Just be aware this also allows you to use things like 'html' and 'text' which are not attributes at all, but call .html() or

Re: [Wikitech-l] Work offer inside

2012-08-30 Thread Akshay Agarwal
This is definitely a fraud message, checked it on various scamming sites On Thu, Aug 30, 2012 at 8:45 PM, bo...@wikimedia.org wrote: I would like to take this time to welcome you to our hiring process and give you a brief synopsis of the position's benefits and requirements. If you are

Re: [Wikitech-l] Work offer inside

2012-08-30 Thread Daniel Friesen
This brings up the question. Why does wikimedia.org not have a SPF record? We should be rejecting wikimedia.org emails that we know do not come from Wikimedia. -- ~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://daniel.friesen.name] On Thu, 30 Aug 2012 10:19:52 -0700, Akshay Agarwal

Re: [Wikitech-l] [testing] TitleBlacklist now tested under Jenkins

2012-08-30 Thread Antoine Musso
Le 30/08/12 10:11, Oren Bochman a écrit : 1. is successfully runnig the test a requirement to successfully score on gerrit? (i.e. how is gerrit integrated) When a change is submitted in Gerrit a notification is sent to Jenkins. If a job is setup for the repository, it will be triggered. For

[Wikitech-l] upgrades to search cluster

2012-08-30 Thread Peter Youngmeister
Hi All, I have moved all search traffic to hosts now running ubuntu 12.04 (precise). This should be a no-op, as the search software itself has not changed, and all automated tests looked good, but I wanted to make you all aware as I neither the time nor languages skills to manually test every

Re: [Wikitech-l] [testing] TitleBlacklist now tested under Jenkins

2012-08-30 Thread Roan Kattouw
On Thu, Aug 30, 2012 at 1:11 AM, Oren Bochman orenboch...@gmail.com wrote: I've tried to do this for translate ext last week - so here are a couple of questions: 1. is successfully runnig the test a requirement to successfully score on gerrit? (i.e. how is gerrit integrated) Jenkins sets a

Re: [Wikitech-l] [testing] TitleBlacklist now tested under Jenkins

2012-08-30 Thread Jon Robson
Excellent! Can't wait to get MobileFrontend using this. Great work Antoine. On Thu, Aug 30, 2012 at 12:59 PM, Roan Kattouw roan.katt...@gmail.com wrote: On Thu, Aug 30, 2012 at 1:11 AM, Oren Bochman orenboch...@gmail.com wrote: I've tried to do this for translate ext last week - so here are a

Re: [Wikitech-l] 5 tips to get your code reviewed faster

2012-08-30 Thread Krinkle
On Aug 30, 2012, at 9:59 AM, Antoine Musso hashar+...@free.fr wrote: It is also a good practice to add a cover message on the new patchset to explain what it changes compared to the previous one. Yes, very important. If you submit a patch set, please do leave a quick comment explaining what

Re: [Wikitech-l] Work offer inside

2012-08-30 Thread Tim Starling
On 31/08/12 04:15, Daniel Friesen wrote: This brings up the question. Why does wikimedia.org not have a SPF record? We should be rejecting wikimedia.org emails that we know do not come from Wikimedia. In May, Jeff Green proposed deploying it with softfail, but it wasn't ever actually done.

Re: [Wikitech-l] AJAX sharing of Commons data/metadata

2012-08-30 Thread Alex Brollo
Thanks again Brion, it runs perfectly and - strange to say - I got no hard difficulty, just a little bit of review of API calls and of structure of resulting formidable objects. It's really much simpler to parse original template contents than resulting html from their expansion ;-) and AJAX

[Wikitech-l] MediaWiki security release: 1.19.2 and 1.18.5

2012-08-30 Thread Chris Steipp
I would like to announce the release of MediaWiki 1.19.2 and 1.18.5. These releases fix 6 security related bugs that could affect users of MediaWiki. Download links are given at the end of this email. * Wikipedia administrator Writ Keeper discovered a stored XSS (HTML injection) vulnerability.

Re: [Wikitech-l] Flagged Reviews default by quality levels

2012-08-30 Thread Dovi Jacobs
When a page reaches X level of quality, that version becomes the default. When creating all the interface message for editing, viewing, and history, this is definitely not easy to get right and keep simple for new users. Anyway, to be clear, you can make the latest version the default for all