Le 04/12/12 22:22, Jon Robson a écrit :
This is now running on MobileFrontend [1] but needs some tweaking!
It's awesome! Kudos to whoever enabled that.
snip
[1]
https://integration.mediawiki.org/ci/job/mwext-MobileFrontend-jslint/6/console
Hello Jon,
I did enable it but most of the credits
Thanks Antoine!
Currently JSHint doesn't get a vote on MobileFrontend
(http://integration.mediawiki.org/ci/job/mwext-MobileFrontend-jslint/10/console
: SUCCESS (non-voting)). Is it possible to make it vote and -1
anything which disobeys jshint? This would be extremely useful.
I'm really excited
Can we set 'browser: true' in the jshint config so that it won't
complain about window being undefined?
Ryan Kaldari
On 12/5/12 10:16 AM, Jon Robson wrote:
Thanks Antoine!
Currently JSHint doesn't get a vote on MobileFrontend
That's weird, it looks like browser is already set to true in .jshintrc,
but I still get errors for window being undefined from Jenkins. Is
Jenkins using the .jshintrc file?
Ryan Kaldari
On 12/5/12 10:48 AM, Ryan Kaldari wrote:
Can we set 'browser: true' in the jshint config so that it won't
Are you setting this as a global variable?
I had the same issue and realised it needed to be defined as an option
See https://gerrit.wikimedia.org/r/#/c/36919/3/.jshintrc for reference.
On Wed, Dec 5, 2012 at 10:51 AM, Ryan Kaldari rkald...@wikimedia.org wrote:
That's weird, it looks like
If the 'browser' option is set to true, it's supposed to automatically
accept globals like window and document without having to explicitly
exempt them. Not sure why that isn't working on Jenkins, though.
Ryan Kaldari
On 12/5/12 10:57 AM, Jon Robson wrote:
Are you setting this as a global
Le 05/12/12 19:16, Jon Robson a écrit :
Thanks Antoine!
Currently JSHint doesn't get a vote on MobileFrontend
(http://integration.mediawiki.org/ci/job/mwext-MobileFrontend-jslint/10/console
: SUCCESS (non-voting)).
Is it possible to make it vote and -1 anything which disobeys jshint?
This
Le 20/11/12 23:27, Krinkle a écrit :
TL;DR: jshint is now running from Jenkins on mediawiki/core
(joining the linting sequence for php and puppet files).
I have also enabled it on a few extensions, will add more of them over
the next days.
The list of linted extensions is listed in
On Wed, Dec 5, 2012 at 11:18 AM, Ryan Kaldari rkald...@wikimedia.org wrote:
If the 'browser' option is set to true, it's supposed to automatically
accept globals like window and document without having to explicitly exempt
them. Not sure why that isn't working on Jenkins, though.
and it does..
This is now running on MobileFrontend [1] but needs some tweaking!
It's awesome! Kudos to whoever enabled that.
Is it possible to blacklist certain files? For instance we have an
external javascript file we pull in from another project
(javascripts/externals/eventlog.js ) that I'd rather not run
I worked this out myself:
I created a .jshintignore file
\o/
https://gerrit.wikimedia.org/r/#/c/36919/2/.jshintignore
On Tue, Dec 4, 2012 at 1:22 PM, Jon Robson jdlrob...@gmail.com wrote:
This is now running on MobileFrontend [1] but needs some tweaking!
It's awesome! Kudos to whoever enabled
Krinkle
This is awesome.
In honour of this awesome development I made integrating this with
MobileFrontend my first task [1] on return from vacation:
MobileFrontend now has much cleaner code [2]. Great work! :)
[1] https://gerrit.wikimedia.org/r/#/c/35788/
[2]
On Nov 21, 2012, at 7:23 PM, S Page sp...@wikimedia.org wrote:
I have vim set up [..]
That's great. If you're using a different editor, here's a list if all kinds of
platforms and editors and how to use jshint in them:
http://jshint.com/platforms/
On Nov 21, 2012, at 7:23 PM, S Page
We're not planning on creating a job specifically for some extensions that just
lint javascript.
However, what we are doing is this: The javascript lint check is currently the
first component in the new Grunt build tasks system.
Once we've migrated all crucial tasks from Ant build.xml to
I have vim set up so pressing
:Jtabenter
runs jshint within vim, and I can step through the error lines. It's a
huge time saver.
The relevant lines from my ~/.vimrc:
Use pathogen in order to use vim-jshint
per https://github.com/tpope/vim-pathogen :
call pathogen#infect()
The above means
Le 20/11/12 23:27, Krinkle a écrit :
TL;DR: jshint is now running from Jenkins on mediawiki/core
(joining the linting sequence for php and puppet files).
Congratulations Timo :-] Can't wait to get the other linters in!
--
Antoine hashar Musso
___
Hey all,
For a while now we have .jshintrc rules in the repository and are able
to run node-jshint locally.
TL;DR: jshint is now running from Jenkins on mediawiki/core
(joining the linting sequence for php and puppet files).
I cleaned up the last old lint failures in the repo yesterday in
Is there a plan to enabled this for MediaWiki extensions? For some of
our extensions, we do jshnt check manually in local machines. It would
be great if they also can be configured with Jenkins to run jshint.
Thanks
Santhosh
___
Wikitech-l mailing
18 matches
Mail list logo
