Re: [setupapi/tests] Fix a failure on Windows 2000

2008-09-11 Thread Paul Vriens
James Hawkins wrote: On Wed, Sep 10, 2008 at 10:03 AM, Paul Vriens [EMAIL PROTECTED] wrote: Hi, W2K doesn't fail with ERROR_INVALID_NAME but with ERROR_GENERAL_SYNTAX (setupapi error). That error was added for a reason; it was seen on a win2k box. Please don't remove it. Ok, don't

Drawprim.c patchwatcher failure

2008-09-11 Thread Chris Ahrendt
patching file dlls/wined3d/drawprim.c Hunk #2 FAILED at 448. 1 out of 2 hunks FAILED -- saving rejects to file dlls/wined3d/drawprim.c.rej Dan what does this mean on a patch I submitted tonight How do I fix it? Chris

Re: Debugging Wine thoughts

2008-09-11 Thread Chris Robinson
On Wednesday 10 September 2008 10:44:09 pm Damjan Jovanovic wrote: For example applications don't expect to see pointers into the upper 1-2 GB of the 4 GB virtual memory address space because on Windows the kernel's memory is mapped there. But, ld-linux.so.2 could load libraries there,

Re: Drawprim.c patchwatcher failure

2008-09-11 Thread Dmitry Timoshkov
Chris Ahrendt [EMAIL PROTECTED] wrote: patching file dlls/wined3d/drawprim.c Hunk #2 FAILED at 448. 1 out of 2 hunks FAILED -- saving rejects to file dlls/wined3d/drawprim.c.rej Dan what does this mean on a patch I submitted tonight That means that the source you have used to

Re: Drawprim.c patchwatcher failure

2008-09-11 Thread Chris Ahrendt
Dmitry Timoshkov wrote: Chris Ahrendt [EMAIL PROTECTED] wrote: patching file dlls/wined3d/drawprim.c Hunk #2 FAILED at 448. 1 out of 2 hunks FAILED -- saving rejects to file dlls/wined3d/drawprim.c.rej Dan what does this mean on a patch I submitted tonight That means that the

Re: crypt32: Fix a failing test in win9x

2008-09-11 Thread Paul Vriens
James Hawkins wrote: Hi, Changelog: * Fix a failing test in win9x. dlls/crypt32/tests/ctl.c | 15 +++ 1 files changed, 11 insertions(+), 4 deletions(-) The !ret in: +else +{ +

Re: d3dx9_36: Fix the tests for native Windows.

2008-09-11 Thread Tony Wasserka
On Mi, 2008-09-10 at 18:16 +0200, Tony wrote: Hi, At least for all Windows versions below Vista, the d3dx9 importlib does exist (and d3dx9_36 does not), I installed a recent dx9-runtime on my w2k test system, but a d3dx9.dll is not present (d3dx9_36.dll exist). I get always a

Re: crypt32: Fix a failing test in win9x

2008-09-11 Thread James Hawkins
On Thu, Sep 11, 2008 at 1:42 AM, Paul Vriens [EMAIL PROTECTED] wrote: The !ret in: +else +{ +ok(!ret GetLastError() == CRYPT_E_EXISTS, + expected CRYPT_E_EXISTS, got %d %08x\n, ret, GetLastError()); +} is superfluous. It is, but I'm sticking with

Re: crypt32: Fix a failing test in win9x

2008-09-11 Thread Paul Vriens
James Hawkins wrote: On Thu, Sep 11, 2008 at 1:42 AM, Paul Vriens [EMAIL PROTECTED] wrote: The !ret in: +else +{ +ok(!ret GetLastError() == CRYPT_E_EXISTS, + expected CRYPT_E_EXISTS, got %d %08x\n, ret, GetLastError()); +} is superfluous. It is, but I'm

Re: [PATCH 02/14] inetcomm: Add a stub MimeInternational object.

2008-09-11 Thread Alexandre Julliard
Huw Davies [EMAIL PROTECTED] writes: @@ -8,6 +8,7 @@ IMPORTS = uuid ole32 ws2_32 user32 advapi32 kernel32 C_SRCS = \ inetcomm_main.c \ + internat.c \ internettransport.c \ mimeole.c \ regsvr.c I find that abbreviating 'international' as 'internat' is a

Re: Wine mouse input: Fwd: [RFC] Preliminary XI 2 feature list

2008-09-11 Thread Roderick Colenbrander
Hi, I forwarded your concerns to the xorg list and got the following response from Daniel Stone: Stopping the pointer from moving is easily done by temporarily detaching the device. Getting unclipped relative events will also be catered for. Roderick Roderick Colenbrander wrote: Hi all,

Re: Debugging Wine thoughts

2008-09-11 Thread Markus Hitter
Am 10.09.2008 um 17:32 schrieb Stefan Dösinger: You can attach any debugger to a Win32 process running in Wine. This includes Linux debuggers like gdb, [...] As I didn't find hints on how to do this I tried myself: ** First, start gdb in the C: directory [EMAIL

Re: winemenubuilder: eliminate wineshelllink (try 3)

2008-09-11 Thread Alexandre Julliard
Damjan Jovanovic [EMAIL PROTECTED] writes: +/* winemenubuilder_semaphore ensures mutual exclusion for the temp file */ +tempfilename = heap_printf(%s/next-wine-menu.temp, xdg_config_dir); That's not good enough, the config dir is global to all Wine instances. You really need safe

Re: winex11.drv: Add support for _NET_WORKAREA

2008-09-11 Thread Alexandre Julliard
Dmitry Timoshkov [EMAIL PROTECTED] writes: SetRect( rect, 0, 0, width, height ); +rc_work = rect; -if (root_window != DefaultRootWindow( gdi_display ) || !query_screens()) +if (!XGetWindowProperty( gdi_display, DefaultRootWindow(gdi_display), x11drv_atom(_NET_WORKAREA),

Re: richedit: Avoid acting on control words in skipped RTF groups (Bug 15227)

2008-09-11 Thread Dylan Smith
I noticed that this introduced a glitch, because I didn't have a destination callback for the \nesttableprops control word. This led to it being ignored, so nested tables would take on default properties. I will update this patch to fix this glitch and then resend it. On Wed, Sep 10, 2008 at

OT: linux market share trend data

2008-09-11 Thread Dan Kegel
I finally threw together a summary of four sources of linux market share data, see http://kegel.com/linux/marketshare.html

Re: Size of SUBHEAP in heap.c

2008-09-11 Thread Alexandre Julliard
Martin Profittlich [EMAIL PROTECTED] writes: Hello, when trying to fix an issue with Guitar Rig 3 on Wine (Bug 10129, Guitar Rig 3 crashes), I found out something odd: The crash is affected by the size of the SUBHEAP structure in dlls/ntdll/heap.c. Just by adding 8 unused bytes to

Re: Size of SUBHEAP in heap.c

2008-09-11 Thread Martin Profittlich
This sounds like a segment / Boundry issue... how far up does it repeat this action? or have you tried??? is it an even number of blocks that the error does not occur? I tried this: I added DWORD reserved[N] to SUBHEAP and tested various values of N. Odd numbers trigger an assertion due to

Re: d3dx9_36: Fix the tests for native Windows.

2008-09-11 Thread Tony Wasserka
Your latest patch is already doing it right, IMPORTS must be changed to d3dx9_36 and IMPORTLIB must stay d3dx9. any idea to fix this problem? David 2008/9/11 Tony Wasserka [EMAIL PROTECTED] mailto:[EMAIL PROTECTED] On Mi, 2008-09-10 at 18:16 +0200, Tony wrote:

Re: Size of SUBHEAP in heap.c

2008-09-11 Thread Martin Profittlich
Michael Karcher wrote: Have you tried to run with warn+heap? In that case, on each HeapAlloc/HeapFree, heap integrity will be checked. Also freed blocks are directly overwritten with dummy data. The behaviour of warn+heap might be insightful. warn+heap does not produce any additional

Re: Size of SUBHEAP in heap.c

2008-09-11 Thread Martin Profittlich
Alexandre Julliard wrote: Probably the app expects some heap block to be 16-byte aligned, and uses MMX vector functions that crash on unaligned data. I guess you need to figure out where the block comes from, and why it would always be aligned on Windows. Maybe it's large enough that Windows

Re: d3dx9_36: Fix the tests for native Windows.

2008-09-11 Thread Tony Wasserka
Ah wait, ignore my last answer to this email. I misunderstood the way the IMPORTS var influences the make process. I now see that it's actually the IMPORTS which are the libs, the executable gets linked with. (and not the dll it is run with like I though in the other mails) However, I see no

Re: richedit: Avoid acting on control words in skipped RTF groups (Bug 15227) [try 2]

2008-09-11 Thread Dylan Smith
It seems like I somehow missed the fact that patch was already accepted on the first try, however I still ended up rebasing the patch against the origin. I'll resend it anyways, since the commit message needs to be changed. On Thu, Sep 11, 2008 at 10:34 AM, Dylan Smith [EMAIL PROTECTED]wrote:

Re: xinput implementation

2008-09-11 Thread Andrew Fenn
Hi, I was wondering how you were coming with your implementation of xinput1_3.dll ? It sounds quite interesting although I would personally prefer the wine implementation to be able to use all joysticks and not just Xbox 360 controllers. Perhaps another configuration screen could be added to

Re: Size of SUBHEAP in heap.c

2008-09-11 Thread Michael Karcher
Am Donnerstag, den 11.09.2008, 18:21 +0200 schrieb Martin Profittlich: In this particular case, I think the crash log does not really indicate an alignment problem, but a x/i $eip in winedbg on the crash might help to check further. I suspect a [edx-1] address while edx contains a NULL

Re: Wine mouse input: Fwd: [RFC] Preliminary XI 2 feature list

2008-09-11 Thread Roderick Colenbrander
Hi Vitaliy, For the record here another reply but this time from Peter Hutterer the guy who wrote the XI 2 specification. Is this all enough for Wine? Roderick On Thu, Sep 11, 2008 at 09:29:45AM +0200, Roderick Colenbrander wrote: I'm still not clear which one will provide the exact events

Re: xinput implementation

2008-09-11 Thread Andrew Fenn
On Fri, Sep 12, 2008 at 1:04 AM, chourmovs vs [EMAIL PROTECTED] wrote: No sorry No time and no skill for that, but maybe i could help doing some tests In that case I will have a try at implementing it. Can someone have a look at this patch I made and offer any advice on where I may be going

Buffer overrun in dlls/riched20/editor.c

2008-09-11 Thread Juan Lang
Hi Dylan, commit 11c80396995065701205f2facb3dba10a6f8170f[1] introduced a buffer overrun in riched20's editor.c. Here's the hunk that did it: @@ -666,35 +661,83 @@ static void ME_RTFParAttrHook(RTF_Info *info) static void ME_RTFTblAttrHook(RTF_Info *info) { - ME_DisplayItem *para; -

Buffer overrun in dlls/riched20/editor.c

2008-09-11 Thread Juan Lang
Hi Dylan, commit 11c80396995065701205f2facb3dba10a6f8170f[1] introduced a buffer overrun in riched20's editor.c. Here's the hunk that did it: @@ -666,35 +661,83 @@ static void ME_RTFParAttrHook(RTF_Info *info) static void ME_RTFTblAttrHook(RTF_Info *info) { - ME_DisplayItem *para; -

Re: Patchwatcher: patchwatcher bug: Try number 2 drawprim.c drawStridedSlow

2008-09-11 Thread Henri Verbeet
2008/9/11 Chris Ahrendt [EMAIL PROTECTED]: Ok what now I did a git to get the latest tree... I generated the patch off the latest tree.. and submitted it again... what I am failing. so I can fix it =).. the code compiles just fine and runs on my machine so not sure... chris The patch is

Re: Patchwatcher: patchwatcher bug: Try number 2 drawprim.c drawStridedSlow

2008-09-11 Thread Chris Ahrendt
Henri Verbeet wrote: 2008/9/11 Chris Ahrendt [EMAIL PROTECTED]: Ok what now I did a git to get the latest tree... I generated the patch off the latest tree.. and submitted it again... what I am failing. so I can fix it =).. the code compiles just fine and runs on my machine so not sure...

Re: dplayx: Fix static overrun of pDP array in test. (Coverity)

2008-09-11 Thread Kai Blin
On Thursday 11 September 2008 20:50:58 Ismael Barros wrote: On 9/10/08, Kai Blin [EMAIL PROTECTED] wrote: --- dlls/dplayx/tests/dplayx.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Sorry for the delay, I should have checked this before. I hadn't even read the coverity

Re: Patchwatcher: patchwatcher bug: Try number 2 drawprim.c drawStridedSlow

2008-09-11 Thread Henri Verbeet
2008/9/11 Chris Ahrendt [EMAIL PROTECTED]: Henri Verbeet wrote: 2008/9/11 Chris Ahrendt [EMAIL PROTECTED]: Ok what now I did a git to get the latest tree... I generated the patch off the latest tree.. and submitted it again... what I am failing. so I can fix it =).. the code compiles

Re: d3dx8 [patch 1/2]: Implement D3DXGetFVFVertexSize

2008-09-11 Thread Henri Verbeet
+switch (FVF 0xe) You should use D3DFVF_POSITION_MASK instead of 0xe here. +texture = FVF 16; + +for (i = 0; i ((FVFD3DFVF_TEXCOUNT_MASK) D3DFVF_TEXCOUNT_SHIFT); i++) +{ + switch (texture 3) + { + case D3DFVF_TEXTUREFORMAT1: + size = size +

Re: Buffer overrun in dlls/riched20/editor.c

2008-09-11 Thread Dylan Smith
On Thu, Sep 11, 2008 at 4:30 PM, Juan Lang [EMAIL PROTECTED] wrote: Hi Dylan, commit 11c80396995065701205f2facb3dba10a6f8170f[1] introduced a buffer overrun in riched20's editor.c. Thanks for pointing out the problem. I sent a patch to wine-patches that fixes the problem.

Re: xinput implementation

2008-09-11 Thread Henri Verbeet
2008/9/11 Andrew Fenn [EMAIL PROTECTED]: In that case I will have a try at implementing it. Can someone have a look at this patch I made and offer any advice on where I may be going wrong (incorrect syntax, etc). The directory should be called after the dll. Ie, xinput1_3 instead of xinput.

Re: Wine mouse input: Fwd: [RFC] Preliminary XI 2 feature list

2008-09-11 Thread Vitaliy Margolen
Roderick Colenbrander wrote: Hi Vitaliy, For the record here another reply but this time from Peter Hutterer the guy who wrote the XI 2 specification. Is this all enough for Wine? Roderick On Thu, Sep 11, 2008 at 09:29:45AM +0200, Roderick Colenbrander wrote: I'm still not clear which

Re: Drawprim.c patchwatcher failure

2008-09-11 Thread Vitaliy Margolen
Chris Ahrendt wrote: Dmitry Timoshkov wrote: Chris Ahrendt [EMAIL PROTECTED] wrote: patching file dlls/wined3d/drawprim.c Hunk #2 FAILED at 448. 1 out of 2 hunks FAILED -- saving rejects to file dlls/wined3d/drawprim.c.rej Dan what does this mean on a patch I submitted tonight That

Re: Patchwatcher: patchwatcher bug: Try number 2 drawprim.c drawStridedSlow

2008-09-11 Thread Chris Ahrendt
Henri Verbeet wrote: 2008/9/11 Chris Ahrendt [EMAIL PROTECTED]: Henri Verbeet wrote: 2008/9/11 Chris Ahrendt [EMAIL PROTECTED]: Ok what now I did a git to get the latest tree... I generated the patch off the latest tree.. and submitted it again... what I am failing. so I can fix it =)..

Re: Drawprim.c patchwatcher failure

2008-09-11 Thread Chris Ahrendt
Vitaliy Margolen wrote: Chris Ahrendt wrote: Dmitry Timoshkov wrote: Chris Ahrendt [EMAIL PROTECTED] wrote: patching file dlls/wined3d/drawprim.c Hunk #2 FAILED at 448. 1 out of 2 hunks FAILED -- saving rejects to file dlls/wined3d/drawprim.c.rej Dan what does this mean on a patch I

RE: Patchwatcher: patchwatcher bug: Try number 2 drawprim.c drawStridedSlow

2008-09-11 Thread Stefan Dösinger
Because the original code was set up with the numbers originally.. And this is wrong. So the original code is wrong here. The assumption the code makes just happens to work for FLOAT1 to FLOAT4 D3DDECL types, and not for higher ones