Re: gdi32: Add more font substitution tests, make them pass under Wine

2008-10-08 Thread Dmitry Timoshkov
"Jeremy White" <[EMAIL PROTECTED]> wrote: > This patch has triggered a bug in make test for me; I only notice it > when I put a Windows flavor of arial.ttf into my windows/fonts directory. > > The specific failure is in get_glyph_indices when we're passing in a > symbol charset (i.e. the 3rd loop

Re: Resend patch for 15494

2008-10-08 Thread Chris Ahrendt
James Hawkins wrote: > On Wed, Oct 8, 2008 at 10:17 PM, Chris Ahrendt <[EMAIL PROTECTED]> wrote: >> James Hawkins wrote: >>> On Wed, Oct 8, 2008 at 10:12 PM, Chris Ahrendt <[EMAIL PROTECTED]> wrote: Actually it was rejected because Dan's network went down and crashed patchwatcher.. >

Re: Resend patch for 15494

2008-10-08 Thread James Hawkins
On Wed, Oct 8, 2008 at 10:17 PM, Chris Ahrendt <[EMAIL PROTECTED]> wrote: > James Hawkins wrote: >> >> On Wed, Oct 8, 2008 at 10:12 PM, Chris Ahrendt <[EMAIL PROTECTED]> wrote: >>> >>> Actually it was rejected because Dan's network went down and crashed >>> patchwatcher.. >>> >> >> Alexandre does n

Re: Resend patch for 15494

2008-10-08 Thread Chris Ahrendt
James Hawkins wrote: > On Wed, Oct 8, 2008 at 10:12 PM, Chris Ahrendt <[EMAIL PROTECTED]> wrote: >> Actually it was rejected because Dan's network went down and crashed >> patchwatcher.. >> > > Alexandre does not receive notices from patchwatcher, nor does he rely > on the patchwatcher results whe

Re: Resend patch for 15494

2008-10-08 Thread James Hawkins
On Wed, Oct 8, 2008 at 10:12 PM, Chris Ahrendt <[EMAIL PROTECTED]> wrote: >> > Actually it was rejected because Dan's network went down and crashed > patchwatcher.. > Alexandre does not receive notices from patchwatcher, nor does he rely on the patchwatcher results when reviewing patches... -- J

Re: Resend patch for 15494

2008-10-08 Thread Chris Ahrendt
James Hawkins wrote: > On Wed, Oct 8, 2008 at 10:05 PM, Chris Ahrendt <[EMAIL PROTECTED]> wrote: >> It was not a broad sweep... I know where it crashed and am checking there. >> However, I noticed there were several other places were at sometimes it >> checked for null and other places it did not..

Re: Resend patch for 15494

2008-10-08 Thread James Hawkins
On Wed, Oct 8, 2008 at 10:05 PM, Chris Ahrendt <[EMAIL PROTECTED]> wrote: >> > It was not a broad sweep... I know where it crashed and am checking there. > However, I noticed there were several other places were at sometimes it > checked for null and other places it did not.. so I went > through an

Re: Resend patch for 15494

2008-10-08 Thread Chris Ahrendt
James Hawkins wrote: > 2008/10/8 Chris Ahrendt <[EMAIL PROTECTED]>: >> per dan resending >> >> >> chris >> >> From e8ec03471e1206ea93fa6224d7c6b8b61422d80e Mon Sep 17 00:00:00 2001 >> From: Chris Ahrendt <[EMAIL PROTECTED]> >> Date: Tue, 7 Oct 2008 21:02:36 -0400 >> Subject: [PATCH] Checked all the

Winetricks

2008-10-08 Thread Chris Ahrendt
Dan, noticed something missing with winetricks... when you install Vj# libraries.. it requires installer 3 and there is only installer 2 in the list... chris

Re: (try 2) gdi32: if a font substitution is given then only match tothat substitution not to the original family name.

2008-10-08 Thread Dmitry Timoshkov
"Aric Stewart" <[EMAIL PROTECTED]> wrote: > diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c > index 145be9b..c427694 100644 > --- a/dlls/gdi32/freetype.c > +++ b/dlls/gdi32/freetype.c > @@ -3408,8 +3408,8 @@ GdiFont *WineEngCreateFontInstance(DC *dc, HFONT hfont) > */ > LIST_FO

Re: Resend patch for 15494

2008-10-08 Thread James Hawkins
2008/10/8 Chris Ahrendt <[EMAIL PROTECTED]>: > per dan resending > > > chris > > From e8ec03471e1206ea93fa6224d7c6b8b61422d80e Mon Sep 17 00:00:00 2001 > From: Chris Ahrendt <[EMAIL PROTECTED]> > Date: Tue, 7 Oct 2008 21:02:36 -0400 > Subject: [PATCH] Checked all the states of variables in test to

Re: Jacek Caban : mshtml: Added IHTMLElement3 stub implementation.

2008-10-08 Thread Jacek Caban
Ops, sorry, you were not commenting my today patch. There's too much of them lately... Anyway, I will send a fix tomorrow. Jacek

Re: Jacek Caban : mshtml: Added IHTMLElement3 stub implementation.

2008-10-08 Thread Jacek Caban
Michael Stefaniuc wrote: > > I would say to remove the S_OK return but I really don't know what is > the best here. Thanks, I that's my temporary hack that I've missed then I was preparing the patch. I will send put_disable implementation in next series of patches. Otherwise I'd have to resend

Re: Wineconf follow up: Wine Usage Data Collection

2008-10-08 Thread Henri Verbeet
2008/10/9 Zachary Goldberg <[EMAIL PROTECTED]>: > And yes I do think this data would be valuable. Especially for the > d3d people who have a very rough idea of what to focus on (from what > they've told us at wineconf). > That's not quite what Stefan said, actually. The issue is that while there a

RE: GLee library (Was: Re: [5/6] WineD3D: Remove some #ifdefs)

2008-10-08 Thread Stefan Dösinger
> | GLee provides a simple interface for using extensions and core OpenGL > | functionality beyond OpenGL version 1.1, and automates the otherwise > | tedious process of linking function pointers. GLee works with both C > and > | C++ compilers. > | > | Because the code is automatically generated, t

Re: Wineconf follow up: Wine Usage Data Collection

2008-10-08 Thread Zachary Goldberg
On Wed, Oct 8, 2008 at 4:42 PM, Austin English <[EMAIL PROTECTED]> wrote: > On Wed, Oct 8, 2008 at 3:34 PM, James Hawkins <[EMAIL PROTECTED]> wrote:>> >> Ok, then you need to clarify what your plan with this 'option' is. Is >> this an option passed to configure that is disabled by default? If >>

Re: Wineconf follow up: Wine Usage Data Collection

2008-10-08 Thread Henri Verbeet
2008/10/8 Austin English <[EMAIL PROTECTED]>: > Currently, we've got two problems: > 1) We want to collect Wine usage data, so we know where to concentrate > our efforts. Just curious, but do any actual developers really care about this? My feeling is that bugzilla gives a pretty good idea of what

Adding timestamps to log output

2008-10-08 Thread Michael Karcher
Hello developers, In http://www.winehq.org/pipermail/wine-patches/2008-June/056508.html Peter Urbanec sent a patch I like, that adds timing information to the log. It has been critized for having the wrong indentation style. As I would like to give that patch a second chance, I reindented the code

Re: gdi32: Add more font substitution tests, make them pass under Wine

2008-10-08 Thread Jeremy White
Dmitry, This patch has triggered a bug in make test for me; I only notice it when I put a Windows flavor of arial.ttf into my windows/fonts directory. The specific failure is in get_glyph_indices when we're passing in a symbol charset (i.e. the 3rd loop). I've tracked it to line 3461 of gdi32/fr

Re: Wineconf follow up: Wine Usage Data Collection

2008-10-08 Thread Austin English
On Wed, Oct 8, 2008 at 3:38 PM, Mark Wagner <[EMAIL PROTECTED]> wrote: > On Wed, Oct 8, 2008 at 13:20, Austin English <[EMAIL PROTECTED]> wrote: >> If someone only uses Wine periodically/infrequently, we're unlikely to see >> it. >> >> Currently, we've got two problems: >> 1) We want to collect Wi

Re: Usability: WineCfg Part 1 -- Desktop Integration tab

2008-10-08 Thread Owen Rudge
> I was thinking of creating a control panel applet that invokes winecfg > to only display the appearance/theme tab. This is to allow the theme > selection command-line to share the code with the displaying of the > configuration UI. That would be harder to do using a control panel. Well, this is

Re: Wineconf follow up: Wine Usage Data Collection

2008-10-08 Thread Mark Wagner
On Wed, Oct 8, 2008 at 13:20, Austin English <[EMAIL PROTECTED]> wrote: > If someone only uses Wine periodically/infrequently, we're unlikely to see it. > > Currently, we've got two problems: > 1) We want to collect Wine usage data, so we know where to concentrate > our efforts. Will the number of

Re: Wineconf follow up: Wine Usage Data Collection

2008-10-08 Thread Austin English
On Wed, Oct 8, 2008 at 3:34 PM, James Hawkins <[EMAIL PROTECTED]> wrote: > On Wed, Oct 8, 2008 at 3:31 PM, Austin English <[EMAIL PROTECTED]> wrote: >> >> If developers are building from git and not enabling that option, we >> wouldn't be bugged by it, only end users would. >> > > Ok, then you need

Re: Wineconf follow up: Wine Usage Data Collection

2008-10-08 Thread James Hawkins
On Wed, Oct 8, 2008 at 3:31 PM, Austin English <[EMAIL PROTECTED]> wrote: > > If developers are building from git and not enabling that option, we > wouldn't be bugged by it, only end users would. > Ok, then you need to clarify what your plan with this 'option' is. Is this an option passed to con

Re: Wineconf follow up: Wine Usage Data Collection

2008-10-08 Thread Austin English
On Wed, Oct 8, 2008 at 3:28 PM, James Hawkins <[EMAIL PROTECTED]> wrote: > On Wed, Oct 8, 2008 at 3:20 PM, Austin English <[EMAIL PROTECTED]> wrote: >> >> If someone only uses Wine periodically/infrequently, we're unlikely to see >> it. >> >> Currently, we've got two problems: >> 1) We want to col

Re: Wineconf follow up: Wine Usage Data Collection

2008-10-08 Thread James Hawkins
On Wed, Oct 8, 2008 at 3:20 PM, Austin English <[EMAIL PROTECTED]> wrote: > > If someone only uses Wine periodically/infrequently, we're unlikely to see it. > > Currently, we've got two problems: > 1) We want to collect Wine usage data, so we know where to concentrate > our efforts. > 2) We don't w

Re: Wineconf follow up: Wine Usage Data Collection

2008-10-08 Thread Austin English
On Wed, Oct 8, 2008 at 2:34 PM, Chris Ahrendt <[EMAIL PROTECTED]> wrote: > Juan Lang wrote: >>> >>> I think we do Juan.. >>> reason being is that information is not always captured when people put >>> things into bugzilla.. if we had a way that its entered initially (if we >>> could gather it auto

Re: mapi32: initialize session pointer to zero in MAPILogonEx (2nd resend)

2008-10-08 Thread James Hawkins
On Wed, Oct 8, 2008 at 3:07 PM, Louis. Lenders <[EMAIL PROTECTED]> wrote: > > > > diff --git a/dlls/mapi32/mapi32_main.c b/dlls/mapi32/mapi32_main.c > index 936d435..5aace9a 100644 > --- a/dlls/mapi32/mapi32_main.c > +++ b/dlls/mapi32/mapi32_main.c > @@ -109,6 +109,7 @@ HRESULT WINAPI MAPILogonEx(U

Re: mapi32: initialize session pointer to zero in MAPILogonEx (2nd resend)

2008-10-08 Thread Juan Lang
>>Are you guaranteed that session is not NULL? > > No, no garantueed, but i looked up some code-samples by google, and as far > as i can tell, the current stub for MAPILogonEx will pass back garbage > anyway to the application, so my thought was this patch would be rather > harmless anyway. Harmle

Re: mapi32: initialize session pointer to zero in MAPILogonEx (2nd resend)

2008-10-08 Thread Louis. Lenders
diff --git a/dlls/mapi32/mapi32_main.c b/dlls/mapi32/mapi32_main.c index 936d435..5aace9a 100644 --- a/dlls/mapi32/mapi32_main.c +++ b/dlls/mapi32/mapi32_main.c @@ -109,6 +109,7 @@ HRESULT WINAPI MAPILogonEx(ULONG_PTR uiparam, LPWSTR profile, { FIXME("(0x%08lx %s %p 0x%08x %p) Stub\n", uip

Re: Wineconf follow up: Wine Usage Data Collection

2008-10-08 Thread James Hawkins
On Wed, Oct 8, 2008 at 2:02 PM, Zachary Goldberg <[EMAIL PROTECTED]> wrote: > On Wed, Oct 8, 2008 at 2:59 PM, James Hawkins <[EMAIL PROTECTED]> wrote: >> >> You guys need to realize that in any given day we, as developers, >> destroy and recreate wineprefixes several times. Having a popup for >> e

Re: Wineconf follow up: Wine Usage Data Collection

2008-10-08 Thread Chris Ahrendt
Juan Lang wrote: >> I think we do Juan.. >> reason being is that information is not always captured when people put >> things into bugzilla.. if we had a way that its entered initially (if we >> could gather it automagically) then have them attach the file when they do >> a bugzilla that might w

Re: Usability: WineCfg Part 1 -- Desktop Integration tab

2008-10-08 Thread Reece Dunn
2008/10/8 Owen Rudge <[EMAIL PROTECTED]>: > Hi all, > >> Reading up on the wineconf WWN issue, I noticed that it mentions >> usability and winecfg. Therefore, I decided to dig up my RFC relating >> to some ideas I had about winecfg that I sent to the list. > > Ah, lovely. This is something I'm plan

Re: Wineconf follow up: Wine Usage Data Collection

2008-10-08 Thread Juan Lang
> I think we do Juan.. > reason being is that information is not always captured when people put > things into bugzilla.. if we had a way that its entered initially (if we > could gather it automagically) then have them attach the file when they do > a bugzilla that might work a little better...

Re: Wineconf follow up: Wine Usage Data Collection

2008-10-08 Thread James Hawkins
On Wed, Oct 8, 2008 at 2:12 PM, Zachary Goldberg <[EMAIL PROTECTED]> wrote: > > so make it default not show, but allow distros to reverse that. > That doesn't solve the problem. We want usage statistics; therefore, in this hypothetical situation we want the distros to enable it. We're back to the

Re: Wineconf follow up: Wine Usage Data Collection

2008-10-08 Thread Chris Ahrendt
Juan Lang wrote: >> Off hand: >> distribution name/version >> kernel version >> lspci >> graphics driver >> gcc version > > Those strike me as a pretty large set, and perhaps more than people > want to divulge. If they're having problems, with, say, graphics > drivers or kernels, hopefully bugzil

Re: Wineconf follow up: Wine Usage Data Collection

2008-10-08 Thread Zachary Goldberg
On Wed, Oct 8, 2008 at 3:14 PM, Austin English <[EMAIL PROTECTED]> wrote: > On Wed, Oct 8, 2008 at 2:06 PM, James Hawkins <[EMAIL PROTECTED]> wrote: >> On Wed, Oct 8, 2008 at 2:02 PM, Zachary Goldberg <[EMAIL PROTECTED]> wrote: >>> On Wed, Oct 8, 2008 at 2:59 PM, James Hawkins <[EMAIL PROTECTED]> w

Re: Wineconf follow up: Wine Usage Data Collection

2008-10-08 Thread Austin English
On Wed, Oct 8, 2008 at 2:06 PM, James Hawkins <[EMAIL PROTECTED]> wrote: > On Wed, Oct 8, 2008 at 2:02 PM, Zachary Goldberg <[EMAIL PROTECTED]> wrote: >> On Wed, Oct 8, 2008 at 2:59 PM, James Hawkins <[EMAIL PROTECTED]> wrote: >>> >>> You guys need to realize that in any given day we, as developers

Re: Wineconf follow up: Wine Usage Data Collection

2008-10-08 Thread Zachary Goldberg
On Wed, Oct 8, 2008 at 3:06 PM, James Hawkins <[EMAIL PROTECTED]> wrote: > On Wed, Oct 8, 2008 at 2:02 PM, Zachary Goldberg <[EMAIL PROTECTED]> wrote: >> On Wed, Oct 8, 2008 at 2:59 PM, James Hawkins <[EMAIL PROTECTED]> wrote: >>> >>> You guys need to realize that in any given day we, as developers

Re: Wineconf follow up: Wine Usage Data Collection

2008-10-08 Thread Austin English
On Wed, Oct 8, 2008 at 2:07 PM, Juan Lang <[EMAIL PROTECTED]> wrote: >> Off hand: >> distribution name/version >> kernel version >> lspci >> graphics driver >> gcc version > > Those strike me as a pretty large set, and perhaps more than people > want to divulge. If they're having problems, with, s

Re: Wineconf follow up: Wine Usage Data Collection

2008-10-08 Thread Juan Lang
> Off hand: > distribution name/version > kernel version > lspci > graphics driver > gcc version Those strike me as a pretty large set, and perhaps more than people want to divulge. If they're having problems, with, say, graphics drivers or kernels, hopefully bugzilla will tell us that. I think

Re: Wineconf follow up: Wine Usage Data Collection

2008-10-08 Thread Zachary Goldberg
On Wed, Oct 8, 2008 at 3:04 PM, Austin English <[EMAIL PROTECTED]> wrote: > On Wed, Oct 8, 2008 at 1:50 PM, Zachary Goldberg <[EMAIL PROTECTED]> wrote: >>> I don't see why we need to ignore other prefixes. My concern was >>> simply do we run this for every prefix creation and store it within >>> th

Re: Wineconf follow up: Wine Usage Data Collection

2008-10-08 Thread Austin English
On Wed, Oct 8, 2008 at 1:50 PM, Zachary Goldberg <[EMAIL PROTECTED]> wrote: >> I don't see why we need to ignore other prefixes. My concern was >> simply do we run this for every prefix creation and store it within >> the prefix, or are we going to store it elsewhere, under for example: >> '~/.loca

Re: Wineconf follow up: Wine Usage Data Collection

2008-10-08 Thread Zachary Goldberg
On Wed, Oct 8, 2008 at 2:59 PM, James Hawkins <[EMAIL PROTECTED]> wrote: > > You guys need to realize that in any given day we, as developers, > destroy and recreate wineprefixes several times. Having a popup for > every wineprefix creation will be extremely annoying. If this can't > be done behi

Re: Wineconf follow up: Wine Usage Data Collection

2008-10-08 Thread James Hawkins
On Wed, Oct 8, 2008 at 1:50 PM, Zachary Goldberg <[EMAIL PROTECTED]> wrote: > > I agree.. and im curious: are there any other information bits we > would like to collect or display at firstrun / wineprefixcreate? If > people see other needs for it I think it might be appropriate for Wine > to have

Re: Wineconf follow up: Wine Usage Data Collection

2008-10-08 Thread Zachary Goldberg
> I don't see why we need to ignore other prefixes. My concern was > simply do we run this for every prefix creation and store it within > the prefix, or are we going to store it elsewhere, under for example: > '~/.local/wine/survey-status'. > > Either way, I'd love to see this done, I'm moreso jus

Re: Jacek Caban : mshtml: Added IHTMLElement3 stub implementation.

2008-10-08 Thread Michael Stefaniuc
Hello Jacek, Smatch complains about unreachable code introduced by this patch: Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 536fac7c1b4ef7f6f124d7f3100d3284313f3018 > URL: > http://source.winehq.org/git/wine.git/?a=commit;h=536fac7c1b4ef7f6f124d7f3100d3284313f3018 > >

Re: Usability: WineCfg Part 1 -- Desktop Integration tab

2008-10-08 Thread Owen Rudge
Hi all, > Reading up on the wineconf WWN issue, I noticed that it mentions > usability and winecfg. Therefore, I decided to dig up my RFC relating > to some ideas I had about winecfg that I sent to the list. Ah, lovely. This is something I'm planning on doing some work on, once I get a bit more

Re: Wineconf follow up: Wine Usage Data Collection

2008-10-08 Thread Austin English
On Tue, Oct 7, 2008 at 10:19 PM, James McKenzie <[EMAIL PROTECTED]> wrote: > Steven Edwards wrote: >> On Mon, Oct 6, 2008 at 12:32 AM, Austin English <[EMAIL PROTECTED]> wrote: >> >>> If it's stored in WINEPREFIX, then each time a new prefix is used, >>> they'll get the prompt each time. Then again

Re: [PATCH 1/3] wininet: Validate parameters passed to RetrieveUrlCacheEntryInfoA/W.

2008-10-08 Thread Paul Vriens
Rob Shearman wrote: > Hi Paul, > > 2008/10/8 Paul Vriens <[EMAIL PROTECTED]>: >> Rob Shearman wrote: >>> Add tests for this. >>> --- >>> dlls/wininet/tests/urlcache.c | 25 + >>> dlls/wininet/urlcache.c | 14 ++ >>> 2 files changed, 39 insertions(+),

Re: [PATCH 1/3] wininet: Validate parameters passed to RetrieveUrlCacheEntryInfoA/W.

2008-10-08 Thread Rob Shearman
Hi Paul, 2008/10/8 Paul Vriens <[EMAIL PROTECTED]>: > Rob Shearman wrote: >> >> Add tests for this. >> --- >> dlls/wininet/tests/urlcache.c | 25 + >> dlls/wininet/urlcache.c | 14 ++ >> 2 files changed, 39 insertions(+), 0 deletions(-) >> >> > > Is t

Re: [PATCH 1/3] wininet: Validate parameters passed to RetrieveUrlCacheEntryInfoA/W.

2008-10-08 Thread Paul Vriens
Rob Shearman wrote: > Add tests for this. > --- > dlls/wininet/tests/urlcache.c | 25 + > dlls/wininet/urlcache.c | 14 ++ > 2 files changed, 39 insertions(+), 0 deletions(-) > > Hi Rob, Is the following test needed for an app? +ret = Retrieve

Re: [PATCH] regedit: Pass VK_DELETE messages to edit controls. (try 2)

2008-10-08 Thread Alexandre Julliard
"Lei Zhang" <[EMAIL PROTECTED]> writes: > In regedit, while renaming registry keys / values, the delete key does > not work. This should fix it. > > This version increased the len variable by 1, so comparing "Edit" to > "EditX" will fail. Testing class names is almost always the wrong thing to do