Re: try2 [1/3] kernel32/tests: Add tests for GetVolumeInformationA and QueryDosDevice

2009-04-09 Thread Paul Vriens
Guy Albertelli wrote: Enhance QueryDosDevice test for attempting to return all devices. Add tests for GetVolumeInformationA testing the different root dir formats. --- dlls/kernel32/tests/volume.c | 134 +- 1 files changed, 131 insertions(+), 3 deletions(

Re: [4/4] (Try2) msi/tests: Fix package test when run on root drive directory.

2009-04-09 Thread James Hawkins
On Thu, Apr 9, 2009 at 7:43 PM, Nicolas Le Cam wrote: > Try2: This time with the patch. > > Tested on Win2k/WinXP. Marked two tests as todo_wine. > If you're having to add todo_wine, then you're changing the current tests, which is bad if all you're trying to do is handle another case (running on

Re: i have itunes 7.60 successfully running on f10 kde 4.2

2009-04-09 Thread Ben Klein
2009/4/9 EA Durbin : > After all we don't want to vastly increase our potential customer base and > potentially get several $70 per crossover professional license or $40 per > standard license fees, but rather wait until someone writes a hefty check to > port it up front. You're confusing Wine wit

Re: i have itunes 7.60 successfully running on f10 kde 4.2

2009-04-09 Thread James Hawkins
On Wed, Apr 8, 2009 at 8:29 PM, EA Durbin wrote: > On Mon, Apr 6, 2009 at 1:05 PM, AllenDavidNiven > globalfone.biz> wrote: >> who can i pay to make this on the wine that i have >> is $100 ok ? >> > >>That's generous of you, but also humorous. I can't remember the last >>estimate we had of how m

Status of "USB device support in wine"

2009-04-09 Thread Uwe Bonnes
Hallo, I tried to run Alexander Morozov's patches against wine-git with libusb and ftd2x devices. Two remarks: - The files from ftp://ftp.etersoft.ru/pub/people/amorozov/usb/current/ miss lines in configure.ac to trigger the Makefile generation for usbd.sys and usbhub.sys. - The HardwareID in t

Re: possible NULL dereference?

2009-04-09 Thread Joris Huizer
--- On Thu, 4/9/09, Paul Vriens wrote: > From: Paul Vriens > Subject: Re: possible NULL dereference? > To: "Joris Huizer" > Cc: wine-devel@winehq.org > Date: Thursday, April 9, 2009, 7:53 AM > Joris Huizer wrote: > > Looking at git commit > dcb3e52e2dfd0d6e494164932fb2b684d463a005, it seems,

Re: i have itunes 7.60 successfully running on f10 kde 4.2

2009-04-09 Thread EA Durbin
On Mon, Apr 6, 2009 at 1:05 PM, AllenDavidNiven globalfone.biz> wrote: > who can i pay to make this on the wine that i have > is $100 ok ? > >That's generous of you, but also humorous. I can't remember the last >estimate we had of how much work it would take, but it's on the order >of tens of t

Re: Test: patch to add adva,ced d3d settings in winecfg

2009-04-09 Thread Austin English
On Thu, Apr 9, 2009 at 5:32 PM, Austin English wrote: > On Thu, Apr 9, 2009 at 4:28 AM, Warren Dumortier wrote: >> Hello everybody... >> >> My patch to add advanced d3d settings in winecfg is almost ready. >> In fact, i only have to figure out how to detect video memory size to >> display it when

Re: Test: patch to add adva,ced d3d settings in winecfg

2009-04-09 Thread Austin English
On Thu, Apr 9, 2009 at 4:28 AM, Warren Dumortier wrote: > Hello everybody... > > My patch to add advanced d3d settings in winecfg is almost ready. > In fact, i only have to figure out how to detect video memory size to > display it when no key is set to force it or to reset. Stefan D told > me to

Re: Test: patch to add adva,ced d3d settings in winecfg

2009-04-09 Thread Warren Dumortier
2009/4/9 Juan Lang : > Hi Warren, > >> Everything works well and i would like some feedback. > > +    if (!strcmp(buf, "enabled")) > +        CheckDlgButton(dialog, IDC_D3D_MULTISAMPLING, BST_CHECKED); > +    else > +        CheckDlgButton(dialog, IDC_D3D_MULTISAMPLING, BST_UNCHECKED); > +        H

Re: Sources of noise on test.winehq.org?

2009-04-09 Thread Austin English
On Thu, Apr 9, 2009 at 2:24 PM, Dan Kegel wrote: > The problem with the current arrangement is that when machines pop in and > out, any failures that are more likely on those machines also pop in and > out, so error counts fluctuate, which obscures the smaller changes due to > wine fixes or regres

FYI -- Dragon Naturally Speaking running a bit better today.

2009-04-09 Thread Susan Cragin
Dragon Naturally Speaking crashes after prolonged use, but the amount of time one can use it before it crashes crept up about 2 minutes, using today's git. Today I dictated for about 14 minutes until it crashed. That's progress. Susan

Re: Sources of noise on test.winehq.org?

2009-04-09 Thread Dan Kegel
The problem with the current arrangement is that when machines pop in and out, any failures that are more likely on those machines also pop in and out, so error counts fluctuate, which obscures the smaller changes due to wine fixes or regressions. I like the current output, and don't want to change

Re: Sources of noise on test.winehq.org?

2009-04-09 Thread Alexandre Julliard
Dan Kegel writes: > On Thu, Apr 9, 2009 at 10:17 AM, Alexandre Julliard > wrote: >> Having the 64-bit results in the same platform group as the 32-bit ones >> is actually very helpful, it makes comparing them a lot easier. I don't >> think we want to split them. > > But suppressing or splitting

Re: Sources of noise on test.winehq.org?

2009-04-09 Thread Dan Kegel
On Thu, Apr 9, 2009 at 10:50 AM, Paul Vriens wrote: >> But suppressing or splitting the results from machines >> that don't have a full set of results shouldn't hurt... >> > How many runs should have a box have before it's considered for the 'stable' > list? We have 2 months worth of data, which r

Re: Sources of noise on test.winehq.org?

2009-04-09 Thread Paul Vriens
Dan Kegel wrote: On Thu, Apr 9, 2009 at 10:17 AM, Alexandre Julliard wrote: Having the 64-bit results in the same platform group as the 32-bit ones is actually very helpful, it makes comparing them a lot easier. I don't think we want to split them. But suppressing or splitting the results fro

Re: Sources of noise on test.winehq.org?

2009-04-09 Thread Dan Kegel
On Thu, Apr 9, 2009 at 10:17 AM, Alexandre Julliard wrote: > Having the 64-bit results in the same platform group as the 32-bit ones > is actually very helpful, it makes comparing them a lot easier. I don't > think we want to split them. But suppressing or splitting the results from machines that

Re: Sources of noise on test.winehq.org?

2009-04-09 Thread Alexandre Julliard
Rob Shearman writes: > 2009/4/9 Dan Kegel : >> (This was last discussed in February, e.g. >> http://www.winehq.org/pipermail/wine-devel/2009-February/073060.html ) >> >> The results on test.winehq.org seem more variable than one >> would expect, which makes it harder to gauge wine's progress. >>

Re: Sources of noise on test.winehq.org?

2009-04-09 Thread Dan Kegel
On Thu, Apr 9, 2009 at 5:09 AM, Rob Shearman wrote: >> Removing these two sources of noise might be as simple as >> 1) omit 64 bit results, and > > Not a bad idea, but I would suggest classifying these machines as a > different category (I would suggest "other" for the moment) rather > than omitti

Re: Test: patch to add adva,ced d3d settings in winecfg

2009-04-09 Thread Juan Lang
Hi Warren, > Everything works well and i would like some feedback. +if (!strcmp(buf, "enabled")) +CheckDlgButton(dialog, IDC_D3D_MULTISAMPLING, BST_CHECKED); +else +CheckDlgButton(dialog, IDC_D3D_MULTISAMPLING, BST_UNCHECKED); +HeapFree(GetProcessHeap(), 0, buf); T

Status of TaskDialog implementation?

2009-04-09 Thread Koro
Hi, I would like to know what's the status on the TaskDialog implementation in Wine based on the code I gave to Dan Kegel months ago. Relevant threads: http://www.winehq.org/pipermail/wine-devel/2008-October/069724.html http://www.winehq.org/pipermail/wine-devel/2008-October/069800.html Than

Re: Sources of noise on test.winehq.org?

2009-04-09 Thread Rob Shearman
2009/4/9 Dan Kegel : > (This was last discussed in February, e.g. > http://www.winehq.org/pipermail/wine-devel/2009-February/073060.html ) > > The results on test.winehq.org seem more variable than one > would expect, which makes it harder to gauge wine's progress. > > I can think of two sources of

Re: Cool animated display of wine appdb stats

2009-04-09 Thread Reece Dunn
2009/4/9 Scott Ritchie : > Joel Holdsworth wrote: >>> >>> Has anyone else noticed >>> http://commons.wikimedia.org/wiki/File:History_Of_WineAppDB.gif >>> which is shown on the right side of >>> http://en.wikipedia.org/wiki/Wine_(software) ? >>> It's kind of cool.  Hats off to >>> http://en.wikipedi

Re: Sources of noise on test.winehq.org?

2009-04-09 Thread Paul Vriens
Paul Vriens wrote: Dan Kegel wrote: On Thu, Apr 9, 2009 at 3:41 AM, Paul Vriens wrote: 2) we don't have a stable stable (sic) of machines running the tests So what constitutes a stable machine? I wasn't complaining about unstable machines; I was complaining that the set of machines reportin

Re: Sources of noise on test.winehq.org?

2009-04-09 Thread Dan Kegel
On Thu, Apr 9, 2009 at 3:54 AM, Paul Vriens wrote: >> I wasn't complaining about unstable machines; >> I was complaining that the set of machines reporting test >> results varies. > > Ok, got it. So how do we come up with a stable set? My suggestion for that was: 2) omit computers for which resu

Re: Cool animated display of wine appdb stats

2009-04-09 Thread Scott Ritchie
Joel Holdsworth wrote: Has anyone else noticed http://commons.wikimedia.org/wiki/File:History_Of_WineAppDB.gif which is shown on the right side of http://en.wikipedia.org/wiki/Wine_(software) ? It's kind of cool. Hats off to http://en.wikipedia.org/wiki/User_talk:Estemi who put it together. - Da

Re: Cool animated display of wine appdb stats

2009-04-09 Thread Reece Dunn
2009/4/9 Joel Holdsworth : >> Has anyone else noticed >> http://commons.wikimedia.org/wiki/File:History_Of_WineAppDB.gif >> which is shown on the right side of >> http://en.wikipedia.org/wiki/Wine_(software) ? >> It's kind of cool.  Hats off to >> http://en.wikipedia.org/wiki/User_talk:Estemi >> wh

Re: Sources of noise on test.winehq.org?

2009-04-09 Thread Paul Vriens
Dan Kegel wrote: On Thu, Apr 9, 2009 at 3:41 AM, Paul Vriens wrote: 2) we don't have a stable stable (sic) of machines running the tests So what constitutes a stable machine? I wasn't complaining about unstable machines; I was complaining that the set of machines reporting test results varie

Re: Cool animated display of wine appdb stats

2009-04-09 Thread Joel Holdsworth
> Has anyone else noticed > http://commons.wikimedia.org/wiki/File:History_Of_WineAppDB.gif > which is shown on the right side of > http://en.wikipedia.org/wiki/Wine_(software) ? > It's kind of cool. Hats off to > http://en.wikipedia.org/wiki/User_talk:Estemi > who put it together. > - Dan Yes th

Re: Sources of noise on test.winehq.org?

2009-04-09 Thread Dan Kegel
On Thu, Apr 9, 2009 at 3:41 AM, Paul Vriens wrote: >> 2) we don't have a stable stable (sic) of machines >> running the tests > > So what constitutes a stable machine? I wasn't complaining about unstable machines; I was complaining that the set of machines reporting test results varies. - Dan

Re: Sources of noise on test.winehq.org?

2009-04-09 Thread Paul Vriens
Dan Kegel wrote: (This was last discussed in February, e.g. http://www.winehq.org/pipermail/wine-devel/2009-February/073060.html ) The results on test.winehq.org seem more variable than one would expect, which makes it harder to gauge wine's progress. I can think of two sources of noise: 1) 32

Re: SoC: DirectShow/Gstreamer

2009-04-09 Thread Detlef Riekenberg
On Di, 2009-03-17 at 15:56 +0100, Maarten Lankhorst wrote: > You will probably find graphedt.exe from the microsoft sdk useful, A GPL alternative exists, but does not work in Wine yet: http://blog.monogram.sk/janos/tools/monogram-graphstudio/ -- By by ... Detlef

Cool animated display of wine appdb stats

2009-04-09 Thread Dan Kegel
Has anyone else noticed http://commons.wikimedia.org/wiki/File:History_Of_WineAppDB.gif which is shown on the right side of http://en.wikipedia.org/wiki/Wine_(software) ? It's kind of cool. Hats off to http://en.wikipedia.org/wiki/User_talk:Estemi who put it together. - Dan

RE: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (resend)

2009-04-09 Thread Andreas Rosenberg
Thanks for the clarification about todo_wine, Paul Paul Vriens wrote: >Well I don't think it will be accepted as is. We usually don't add >functions that are not used anywhere especially when the comments say >that there is a bug elsewhere that should be fixed first. Well, I was thinking about d

RE: [2/3] secur32/tests: Add simple tests for GetUserNameExA/W() [try 2]

2009-04-09 Thread Ge van Geldorp
Hi Paul, > From: Paul Vriens [mailto:paul.vriens.w...@gmail.com] > > Ge van Geldorp wrote: > > Try 2: Add buffer overflow tests > > > > Changelog: > > secur32/tests: Add simple tests for GetUserNameExA/W() > > > > --- > > dlls/secur32/tests/secur32.c | 86 > > ++

Sources of noise on test.winehq.org?

2009-04-09 Thread Dan Kegel
(This was last discussed in February, e.g. http://www.winehq.org/pipermail/wine-devel/2009-February/073060.html ) The results on test.winehq.org seem more variable than one would expect, which makes it harder to gauge wine's progress. I can think of two sources of noise: 1) 32 and 64 bit results

Re: advapi32/tests

2009-04-09 Thread Paul Vriens
Andreas Rosenberg wrote: Paul Vriens wrote: And the subject of the mail should be a bit more than just "advapi32/tests". Oops, sry. Read the second mail after resending in the patch containing your first suggestions. But I'm a bit confused about the meaning of todo_wine. todo_wine discards ou

Re: i have itunes 7.60 successfully running on f10 kde 4.2

2009-04-09 Thread Warren Dumortier
2009/4/8 James Hawkins : > On Mon, Apr 6, 2009 at 1:05 PM, AllenDavidNiven > wrote: >> who can i pay to make this on the wine that i have >> is $100 ok ? >> > > That's generous of you, but also humorous.  I can't remember the last > estimate we had of how much work it would take, but it's on the o

Re: [2/2] [wined3d] GLSL: enable load_np2fixup_constants (fixed)

2009-04-09 Thread Stefan Dösinger
Am Donnerstag, 9. April 2009 01:47:33 schrieb Tobias Jakobi: > Fixed patch according to stefand's suggestions. > > Please disregard the old one and use this patch instead. Looks ok to me I guess

RE: advapi32/tests

2009-04-09 Thread Andreas Rosenberg
Paul Vriens wrote: >And the subject of the mail should be a bit more than just "advapi32/tests". Oops, sry. Read the second mail after resending in the patch containing your first suggestions. But I'm a bit confused about the meaning of todo_wine. todo_wine discards output from failed tests, if I

Test: patch to add adva,ced d3d settings in winecfg

2009-04-09 Thread Warren Dumortier
Hello everybody... My patch to add advanced d3d settings in winecfg is almost ready. In fact, i only have to figure out how to detect video memory size to display it when no key is set to force it or to reset. Stefan D told me to use DirectDraw, but i wouldn't find. So that is the last thing (exc

Re: advapi32/tests

2009-04-09 Thread Paul Vriens
Andreas Rosenberg wrote: Added a test to verify result of LookupAccountSid The test fails here: security.c:1599: Test failed: LookupAccountSidA() Expected account name: paul got: INTERACTIVE I guess this is the tes

Re: [3/6] d3d9: Store the FVF in the d3d9 vertex buffer

2009-04-09 Thread Stefan Dösinger
Am Donnerstag, 9. April 2009 09:34:22 schrieb Henri Verbeet: > 2009/4/9 Stefan Dösinger : > > @@ -197,7 +197,6 @@ static HRESULT WINAPI > > IDirect3DVertexBuffer9Impl_GetDesc(LPDIRECT3DVERTEXBUFFER9 pDesc->Usage = > > desc.Usage; > > pDesc->Pool = desc.Pool; > > pDesc->Size = desc

re: win87em: always return that a 8087 coprocessor is present. (try 2)

2009-04-09 Thread Christian Costa
Installed variable has always the same value. What about removing it instead ? Bye, Christian > Message du 09/04/09 07:10 > De : "Rein Klazes" > A : "wine-patches" > Copie à : > Objet : win87em: always return that a 8087 coprocessor is present. (try 2) > > > --- > dlls/win87em.dll16/win87em

Re: [2/3] secur32/tests: Add simple tests for GetUserNameExA/W() [try 2]

2009-04-09 Thread Paul Vriens
Ge van Geldorp wrote: Try 2: Add buffer overflow tests Changelog: secur32/tests: Add simple tests for GetUserNameExA/W() --- dlls/secur32/tests/secur32.c | 86 ++ 1 files changed, 86 insertions(+), 0 deletions(-) Hi Ge, The tests show a big list

Re: [3/6] d3d9: Store the FVF in the d3d9 vertex buffer

2009-04-09 Thread Henri Verbeet
2009/4/9 Stefan Dösinger : > @@ -197,7 +197,6 @@ static HRESULT WINAPI > IDirect3DVertexBuffer9Impl_GetDesc(LPDIRECT3DVERTEXBUFFER9 > pDesc->Usage = desc.Usage; > pDesc->Pool = desc.Pool; > pDesc->Size = desc.Size; > -pDesc->FVF = desc.FVF; > pDesc->Type

Re: [5/6] d3d: Remove the format from index buffers

2009-04-09 Thread Henri Verbeet
2009/4/9 Stefan Dösinger : > +hr = IWineD3DDevice_SetIndices(This->wineD3DDevice, This->indexbuffer, > + WINED3DFMT_R16_UINT /* d3d7 uses uints > */); The comment is inconsistent with the code (and probably redundant to begin with).