(no idea why my client sent this to wine-patches)
On 10/10/13 15:23, Andrew Cook wrote:
> ---
> dlls/kernel32/tests/process.c | 159
> +-
> include/winbase.h | 1 +
> include/winnt.h | 90
Ignore this, for some reason this randomly forks a huge number of rpcss
instances, and decided to not do so while i was testing it
On 03/10/13 14:00, Andrew Cook wrote:
> ---
> dlls/rpcrt4/rpc_epmap.c | 40 ---
> programs/rpcss/Makefile.in | 2 +-
> pr
Seems reasonable, but could you put together some tests to show this?
Andrew
On Sat, Sep 28, 2013 at 10:41:15AM +0200, Maarten Lankhorst wrote:
> diff --git a/dlls/dsound/capture.c b/dlls/dsound/capture.c
> index 40f1702..0fe300c 100644
> --- a/dlls/dsound/capture.c
> +++ b/dlls/dsou
On 06/09/13 17:12, Frédéric Delanoy wrote:
> On Fri, Sep 6, 2013 at 5:41 AM, Andrew Cook wrote:
>> ---
>> dlls/ntdll/tests/Makefile.in | 1 +
>> dlls/ntdll/tests/job.c | 151
>> +++
>> include/winnt.h
On 27/08/13 22:02, Dmitry Timoshkov wrote:
> Andrew Cook wrote:
>> --- a/include/wine/server_protocol.h
>> +++ b/include/wine/server_protocol.h
>
> And don't include autogenerated stuff in the patch.
>
Is there anything about this on the wiki? i wasn't sure ho
NMM wave output device. This should be changed in the
> + winmm wave output device. This should be changed in the
> future.
>
This whole paragraph can actually be removed. The dsound object it
refers to no longer exists.
Thanks for updating this,
Andrew
l.
Thanks for the fix!
Andrew
hat, too, if you want. Or I'll submit a patch myself later.
Andrew
k -- reported as
http://bugs.winehq.org/show_bug.cgi?id=22450) so I just added a comment
onto the bug.
Thanks,
--Andrew Church
achu...@achurch.org
http://achurch.org/
ws
applications from reading your entire filesystem! In addition to the
Windows share, malicious programs could detect that they are running under
Wine and execute native Linux system calls to get around any restrictions
imposed by Wine. Consider running programs you don't trust in a virtua
fore posting the
bug in a publicly visible manner.
Thanks,
--Andrew Church
achurch+wine-de...@achurch.org
http://achurch.org/
g CreateEventEx with
generic flags fails to correctly set permissions, the patch as it stands
though will likely cause regressions.
On 02/08/13 21:58, Andrew Cook wrote:
> ---
> dlls/ntdll/tests/om.c | 4 ++--
> server/event.c| 5 +
> 2 files changed, 3 insertions(+), 6 deletions(-)
>
>
e through the registry:
http://wiki.winehq.org/MIDI
I think your change is clearly an improvement.
Andrew
s to eCommunications.
So, "human voice" is the intended meaning.
Hope this clears it up!
Andrew
On Fri, Jul 05, 2013 at 11:43:23PM +0800, Qian Hong wrote:
> Hi Andrew,
>
> While discussing the translation of 'Voice output device' and 'Voice
> input devic
ing an event, the handle is allocated with
alloc_handle_no_access_check, which does not call event_map_access
this causes event_op and event_query to fail, as the handle only has
GENERIC_ALL, not the actual event permissions,
which does not match windows behaviour (or at least windows 7 anyway),
nstead of reassigning
> primary_pwfx to NULL?
>
CopyFormat will only return NULL if HeapAlloc fails (actually,
CopyFormat will probably crash). I've stopped caring about out of
memory conditions since they add way too much error handling code and
we can't reasonably recover from them anyway.
Andrew
ir corresponding Win32 codes.
>
Interesting, thanks. I'll go back and fix this.
Andrew
, too.
Whichever.
Andrew
On Wed, May 08, 2013 at 03:12:45PM -0500, Andrew Eikum wrote:
> ---
> dlls/oleaut32/typelib.c | 30 +++---
> 1 file changed, 15 insertions(+), 15 deletions(-)
>
> diff --git a/dlls/oleaut32/typelib.c b/dlls/oleaut32/typelib.c
> inde
larmbr zhan wrote:
> On Sun, Mar 10, 2013 at 5:48 AM, Andrew Talbot
> wrote:
>> msvcp60: Avoid signed-unsigned integer comparisons.
>
>
> Hi, Andrew Talbot.
>
> I find that you are working on these "Avoid signed-unsigned integer
> comparisons" things
applies with an offset and the Wine patch tracker
didn't like this:
> --- a/dlls/dsound/primary.c
> +++ a/dlls/dsound/primary.c
but git-am imported the raw mail file just fine.
Andrew
> >IMHO calling named winmm:xyz functions should be equivalent to dispatching
> >MM* messages
>
> I forgot to add that I'm still surprised that Andrew Eikum could reimplement
> waveIn/OutMessage *without* using MMDRV_Message by simply returning
> MMSYSERR_NOTSUPPORT
On Tue, Jan 22, 2013 at 11:15:59AM +0100, joerg-cyril.hoe...@t-systems.com
wrote:
> Andrew Eikum was in favour of this too and since implemented winmm
> device notification upon change. Remember the December thread:
> http://www.winehq.org/pipermail/wine-devel/2012-December/098114.html
On Tue, Jan 15, 2013 at 06:51:59PM +0100, Maarten Lankhorst wrote:
> Op 07-01-13 16:58, Andrew Eikum schreef:
> > This patch breaks the sound on Zaxxon[1] on both CoreAudio and ALSA
> > without PulseAudio. I didn't test OSS. It skips around on the ship's
> > shooting
org/SheriOci?action=recall&rev=1
I don't know if there's a way to keep Moinmoin from preserving
revision history on deleted pages, but it might be sufficient to
simply disable that. I doubt there's much useful history on deleted
pages anyway.
Andrew
0b5.
>
Maybe avoid that particular sequence of bits ;)
<http://lkml.org/lkml/2012/7/18/625>
Andrew
On Mon, Dec 31, 2012 at 07:03:31PM +0100, Maarten Lankhorst wrote:
> Op 31-12-12 17:59, Andrew Eikum schreef:
> > On Sat, Dec 29, 2012 at 01:24:03AM +0100, Maarten Lankhorst wrote:
> >> + if(!maxq){
> >> + /* nothing to do! */
> >> + L
AUDCLNT_STREAMFLAGS_EVENTCALLBACK, 80, 0, device->pwfx,
> NULL);
...
> +frames = (UINT64)device->pwfx->nSamplesPerSec * 80 / 1000;
Could you #define the 80?
Anyway, I gave it a test on ALSA+Pulse and didn't find any issues.
I'll test the other backends when you resubmit.
Andrew
Sorry, I should have labelled this patch as "Try 2".
--
Andy.
Looks good to me, no problems with any of the drivers. I think it'd be
good to get it in on Monday, as release day is tomorrow, but that's
not my call.
Andrew
On Wed, Dec 19, 2012 at 10:30:04AM +0100, Maarten Lankhorst wrote:
> Use a thread instead of a timer for greater precision.
our
synchronization methods well enough to know if this is correct. Is it
true that SetEvent() causes a context switch? I see it eventually
resolves down to a write() in ,
but I don't know what that implies.
Julliard, any thoughts?
Andrew
you planning to use this for? We could support different mix
buffer formats, but I'm not sure this use case is worth the effort.
Andrew
that into Wine after the next release?
Andrew
orts efficiently. This requires some more
intelligence in AudioClient_GetMixFormat in ,
which currently probes for capabilities and chooses the best available
format.
Andrew
Dmitry Timoshkov wrote:
> Andrew Talbot wrote:
>
>> Changelog:
>> gdi32: Indentation fix.
>
> Please keep 4 spaces indentation without tabs.
>
Thus far, I have fixed the bits of code that are misleadingly indented using
the same indentation regime as the sur
On Wed, Dec 12, 2012 at 04:45:11PM +0100, Henri Verbeet wrote:
> On 12 December 2012 16:31, Andrew Eikum wrote:
> > Even ignoring the Pulse case, we don't have an acceptable enumeration
> > API.
> Yes, I know. I just don't think it would be unreasonable to try to
>
On Wed, Dec 12, 2012 at 03:57:40PM +0100, Henri Verbeet wrote:
> On 12 December 2012 15:28, Andrew Eikum wrote:
> > It's tricky because ALSA and PulseAudio have different theories about
> > where device selection should occur -- in the application or in the
> > audio m
t yet. I don't think
lacking that interface prevents us from doing this particular
enhancement, though.
Andrew
to use "default" or allow the user
to specify their own device. That seems like a fine compromise.
So it seems reasonable to me to list only "default", but also provide
an easy way to add new devices. Forcing users like Max to go to
regedit in every new prefix to add a new audio device really sucks.
This means some sort of driver-specific dialog in winecfg (or control
panel?). That sucks too, but I think it's the least-bad solution.
Andrew
On Thu, Dec 06, 2012 at 12:14:53AM +0800, Dmitry Timoshkov wrote:
> Andrew Eikum wrote:
>
> > > > The call is only supposed to return TRUE or FALSE, so I guess it's
> > > > checking that the return value isn't 3 or something. Not very useful,
> > >
On Wed, Dec 05, 2012 at 11:21:39PM +0800, Dmitry Timoshkov wrote:
> Andrew Eikum wrote:
> > The call is only supposed to return TRUE or FALSE, so I guess it's
> > checking that the return value isn't 3 or something. Not very useful,
> > sure, but it look
On Wed, Dec 05, 2012 at 11:06:48PM +0800, Dmitry Timoshkov wrote:
> Andrew Eikum wrote:
>
> > > > +br = sndPlaySoundA((LPCSTR)SND_ALIAS_SYSTEMASTERISK,
> > > > SND_ALIAS_ID|SND_SYNC);
> > > > +ok(br == TRUE || br == FALSE, "sndPl
On Wed, Dec 05, 2012 at 11:59:01AM +0800, Dmitry Timoshkov wrote:
> Andrew Eikum wrote:
>
> > +br = sndPlaySoundA((LPCSTR)SND_ALIAS_SYSTEMASTERISK,
> > SND_ALIAS_ID|SND_SYNC);
> > +ok(br == TRUE || br == FALSE, "sndPlaySound gave strange return:
> >
plug openal in as the last step.
Andrew
On Thu, Nov 29, 2012 at 12:50:20PM +0100, Maarten Lankhorst wrote:
> Op 21-11-12 19:16, Maarten Lankhorst schreef:
> > Signed-off-by: Maarten Lankhorst
> >
> Bump, anything wrong with this patch?
>
Been spending my "Wine time" on Bug 32297 this week. I'll take a look
at this shortly.
Andrew
Perhaps I should add that the list is of caseS/defaultS that may be fallen
through to, rather than out from.
Unfortunately,because I produced it in a hurry, it does contain the odd
copy-and-paste error for case names (e.g., the case for dmusic/collection.c
line 409 should be default:, not case 8:,
Vincent Povirk wrote:
> It might be useful to post a listing of the files where unmarked
> fall-throughs (falls-through?) appear, and I could see if any of them
> are on my turf.
Here is a rough-and-ready list of where they are.
dlls/msvcp100/exception.c (line 498) case EXCEPTION:
dlls/msvcp100/
Jacek Caban wrote:
> It's probably better to change the macro to require the semicolon.
>
> Jacek
The reason I did it that way was because there are two variants of the
DEFINE_CXX_DATA macro, surrounded by an #ifndef construct: one comprising
three struct declarations, all ending in semicolons,
Frédéric Delanoy wrote:
> For every wine version, static checkers (like coverity) detect cases
> where a switch case automatically falls-through to the next case.
>
> Shouldn't be there a rule that such cases are always marked with a
> "fall-through comment"?
> With the possible exception of case
Yeah, that fixes the problem. This patch looks good to me now.
Andrew
On Fri, Nov 16, 2012 at 08:35:51PM +0100, Maarten Lankhorst wrote:
> I promised I would never touch it, but then I wanted to play skyrim
>
> V2: Limit channels to 2 in primary if not in writeprimary mode
> V
Seems reasonable to me. Thanks for working on this old code.
On Thu, Nov 08, 2012 at 10:51:08AM +0100, joerg-cyril.hoe...@t-systems.com
wrote:
>
Ran tests on all four backends and everything seems okay.
On Fri, Oct 26, 2012 at 10:31:33AM +0200, joerg-cyril.hoe...@t-systems.com
wrote:
> Hi,
>
> With the previous code in place, we can derive sane values for
> WAVE_FORMAT_QUERY.
>
> Given the amount of work and side-effects that the audio
On Sat, Oct 20, 2012 at 12:13:08AM +0200, Maarten Lankhorst wrote:
> Hey,
>
> Op 19-10-12 15:29, Andrew Eikum schreef:
> > Patches 1 and 2 in this series look fine.
> >
> > I have a series of patches similar to this one in my dsound
> > multichannel branch. This p
On Sat, Oct 20, 2012 at 12:03:55AM +0200, Maarten Lankhorst wrote:
> Op 19-10-12 15:54, Andrew Eikum schreef:
> > Mostly good cleanup in this one. Some thoughts below...
> >
> > On Tue, Oct 16, 2012 at 02:06:29PM +0200, Maarten Lankhorst wrote:
> >> diff --git a/dlls/
On Fri, Oct 19, 2012 at 11:33:22PM +0200, Maarten Lankhorst wrote:
> Op 19-10-12 15:40, Andrew Eikum schreef:
> > I'm a big fan of error checking (or at least reporting), so these
> > unchecked calls make me nervous. They'll probably never fail, but if
> > they do,
Be nice if you could split this up and squash it into the previous
patches.
Andrew
On Tue, Oct 16, 2012 at 02:06:30PM +0200, Maarten Lankhorst wrote:
> From: Maarten Lankhorst
>
> No longer influence anything, so zap them.
> ---
> dlls/dsound/dsound_main.c| 17 --
MulDiv(device->pwfx->nBlockAlign,
> device->pwfx->nSamplesPerSec, 100);
> -}else
> -ret = MulDiv(device->pwfx->nSamplesPerSec *
> device->pwfx->nBlockAlign, period, 1000);
> -
> -ret -= ret % device->pwfx->nBlockAlign;
> -return ret;
> -}
> -
...
> +device->fraglen = MulDiv(device->pwfx->nSamplesPerSec, period, 1000)
> * device->pwfx->nBlockAlign;
This should be a separate patch. I don't have an argument /against/
it, but why do you prefer 10ms over whatever the driver prefers?
Andrew
the event fires periodically */
> +IAudioClient_Start(device->client);
> +
> +IAudioClient_GetStreamLatency(device->client, &period);
I'm a big fan of error checking (or at least reporting), so these
unchecked calls make me nervous. They'll probably never fail, but if
they do, I think they should fail loudly.
Andrew
n't reviewed it lately; it might not
even work), but it should show you what I had in mind for this kind of
cleanup.
I can bump those up in priority, but I don't think this blocks patches
4-6 in this series anyway.
Andrew
ds_mc.tar.gz
Description: Binary data
ve's headers don't give us MIDI symbols,
and there are a lot to define. So maybe it's not worth it. Anyway,
something to think about cleaning up in the future.
Thanks for improving this code!
Andrew
On Sun, Sep 23, 2012 at 08:44:59PM +0200, Christian Costa wrote:
> @@ -66,6 +68,11 @@ static void test_dmusic(void)
> return;
> }
>
> +hr = IDirectMusic_GetMasterClock(dmusic, &guid_clock, &clock);
> +ok(hr == S_OK, "IDirectMusic_GetMasterClock returned: %x\n", hr);
> +o
Hello,
Please see below a function that processes WM_PAINT message. Being run
under Wine this function updates the client area (50x120 chars) about
50 times slower than under Windows XP. Could anyone please explain me
what might be wrong and suggest how to fix that?
Thank you,
Andrew Makhorin
ly well, so I
might be able to help answer questions if your problem turns up in
that area.
You may also have to look into one of the various IDispatch
implementations, like .
Anyway, hope that helps guide you towards the right source files and
log channels, at least.
Andrew
On Sat, Jul 14, 2012 at 05:00:02PM +1000, Donny Yang wrote:
> Andrew, I've removed the two driver edits. IAudioClient_GetMixFormat()
> needs an initialised client parameter which doesn't exist in
> DirectSoundDevice_Create(), so it can only be done after the client is
>
GHT;
> + else {
> + FIXME("There is no support for %u channels without an
> extensible wave format\n", channels);
> return;
> }
Before you resend, please consider testing how Windows behaves in this
condition. Does it actually refuse to apply any volume at all?
Andrew
is->ss.format = PA_SAMPLE_INVALID;
> switch(fmt->wFormatTag) {
> case WAVE_FORMAT_IEEE_FLOAT:
> -if (!fmt->nChannels || fmt->nChannels > 2 || fmt->wBitsPerSample !=
> 32)
> +if (!fmt->nChannels || fmt->nChannels > 8 || fmt->wBitsPerSample !=
> 32)
> break;
> This->ss.format = PA_SAMPLE_FLOAT32LE;
> pa_channel_map_init_auto(&This->map, fmt->nChannels,
> PA_CHANNEL_MAP_ALSA);
> break;
> case WAVE_FORMAT_PCM:
> -if (!fmt->nChannels || fmt->nChannels > 2)
> +if (!fmt->nChannels || fmt->nChannels > 8)
> break;
> if (fmt->wBitsPerSample == 8)
> This->ss.format = PA_SAMPLE_U8;
Wine doesn't have a PulseAudio driver yet, so this chunk won't apply.
Andrew
On Mon, Jun 18, 2012 at 08:49:55AM -0700, Chris Robinson wrote:
> On Monday, June 18, 2012 9:31:04 AM Andrew Eikum wrote:
> > Yeah, I experimented with ADJUST_LATENCY, as it seems to be the trick
> > to getting lower latencies. Then we have to maintain our own buffer,
> > wh
. wonderful API, isn't it?
Your mail makes me think I should go back to the pulse-independent
timer setup. That is, write to Pulse during the
CreateTimerQueueTimer() callback. I have a strong feeling I've been
down that path before, but I could give it another shot.
Thanks again,
Andrew
to reproduce it on a Debian 6 VM, as well. Now I
just need to find a better way to check if PA is running.
Andrew
On Wed, Jun 13, 2012 at 09:02:33PM +0200, Alexandre Julliard wrote:
> Andrew Eikum writes:
>
> > The configure.ac changes and parts of the driver itself were written by
> > Maarten Lankhorst.
>
> It doesn't work here, it's apparently using the driver even tho
ng. That should explain what's going on here.
We could test this on Gyb's machine by setting DefaultSampleRate=22050
and hacking to return
S_OK without actually changing the primary buffer's format. That
should give GTA:SA similar cp_fields performance to Darwinia, and I
expect it would fix the lag issue.
Andrew
On Tue, May 15, 2012 at 12:33:25PM +0600, Alexander E. Patrakov wrote:
> Andrew Eikum wrote:
> > -
> > - TRACE("Mixed at least %d from all buffers\n", minlen);
> > - return minlen;
>
> Hi. You have removed the message that could say "Mixed at least
On Thu, May 10, 2012 at 08:29:25AM +0200, Alexandre Julliard wrote:
> Andrew Eikum writes:
>
> > ---
> > This fixes bug 30631, introduced by
> > 31291cdc6ccc4c172ccf86f383c6a90f31a50ba1.
> >
> > In addition to safely exiting on process exit, we do much more
&g
hr = IStream_Read(stream, data, size, &read);
> if(FAILED(hr)){
I called it that to prevent shadowing read(3). It probably doesn't
matter since we almost never use that call in Wine, but that was the
rationale.
Andrew
On Mon, Apr 16, 2012 at 11:53:00AM -0500, Andrew Eikum wrote:
> On Mon, Apr 16, 2012 at 09:09:58AM +0200, Marcus Meissner wrote:
> > Also initialize a "may be uninitialized" value the compiler sees.
> >
Of course I quoted the wrong section of your mail :)
>
> No
verity oversight. I'd either leave it as-is, or also remove
the *num=0 from alsa_enum_devices.
Andrew
> Ciao, Marcus
> ---
> dlls/winealsa.drv/mmdevdrv.c |3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/dlls/winealsa.drv/mmdevdrv.c b/dlls/
Wine do this. We would need to build a software mixer into Wine to do
volume control, and we don't have that (yet).
Andrew
Thanks. GCC 4.7 must be smart enough to detect the same if-conditions,
and doesn't issue a warning for me. Kind of impressive, actually.
Andrew
On Fri, Apr 06, 2012 at 02:49:38AM +0200, Józef Kucia wrote:
> ---
> dlls/winealsa.drv/mmdevdrv.c |2 +-
> 1 files changed, 1 in
On Fri, Mar 30, 2012 at 12:33:51PM +0200, joerg-cyril.hoe...@t-systems.com
wrote:
> Andrew Eikum asked Christian Costa:
> >Just to be clear, which "native" do you mean? Does this match Windows
> >7's dmusic behavior, or something else? I've been trying to target
On Thu, Mar 29, 2012 at 04:18:20PM +0200, Christian Costa wrote:
> It's the original code. I decided to keep it in this patch and add error
> checking in the patch that comes just after.
> I can merge them but I prefer to do things incrementally as much as
> possible.
Ah, sure enough. I missed tha
Just to be clear, which "native" do you mean? Does this match Windows
7's dmusic behavior, or something else? I've been trying to target
Windows 7's behavior in the new audio design.
Also...
On Thu, Mar 29, 2012 at 08:53:52AM +0200, Christian Costa wrote:
> - obj->pCaps.dwEffectFlags = DMUS_E
On Thu, Mar 29, 2012 at 08:52:45AM +0200, Christian Costa wrote:
> +midiOutGetDevCapsW(index - 1, &caps, sizeof(caps));
> ...
> +CoCreateInstance(&CLSID_DirectMusicSynth, NULL,
> CLSCTX_INPROC_SERVER, &IID_IDirectMusicSynth8, (void**)&synth);
> +IDirectMusicSynth8_GetPo
It would be nice to see some tests for this. For example, how does
this IDirectSound reference relate to the one created by
IDirectMusicPerformance::InitAudio()?
On Thu, Mar 29, 2012 at 08:53:10AM +0200, Christian Costa wrote:
>
> ---
> dlls/dmusic/dmusic.c | 27 +--
it is arguably an application bug? Try to
guess at the device type, and insert names like "Speakers" and
"Microphone" into the MMDevAPI device name, even if that might be
wrong?
Thoughts?
Andrew
On Mon, Mar 12, 2012 at 07:18:39AM -0600, Vitaliy Margolen wrote:
> On 03/12/2012 06:11 AM, Andrew Eikum wrote:
> >On Sun, Mar 11, 2012 at 10:15:40AM -0600, Vitaliy Margolen wrote:
> >>That information simply does not belong on Wine wiki. It talks about
> >>making Jac
find.
There is no emergency here that could not have been better resolved
by a discussion over email.
The fact that you've been specifically called out in two threads in
one weekend might be a hint that it is _your_ behavior that is
inappropriate.
Andrew
On Tue, Feb 28, 2012 at 08:24:37AM -0600, Andrew Eikum wrote:
> I'm investigating native TimerQueue's operation now. If it turns out
> that TimerQueue isn't sufficient, we'll probably just switch over to
> using poll() like winmm's timer stuff does.
>
And, n
;ve also been burned enough times by relying on the audio backend to
work correctly that I hesitate to give the backends more
responsibility than absolutely necessary.
I'm investigating native TimerQueue's operation now. If it turns out
that TimerQueue isn't sufficient, we'll probably just switch over to
using poll() like winmm's timer stuff does.
Andrew
This patch looks sane and fixes the tests on my machine, but causes no
changes to dsound capture behavior in Audacity. I don't have much of
an opinion on if it should go in for 1.4.
On Tue, Feb 21, 2012 at 05:33:35PM +0100, Maarten Lankhorst wrote:
> ---
> I suspect a lot more AUDCLNT_E_* calls wi
On Thu, Feb 16, 2012 at 10:10:09AM +0100, joerg-cyril.hoe...@t-systems.com
wrote:
> Hi,
>
> this fixes bug #28413.
>
Thanks Jörg, looks sane to me and I can confirm it fixes the problem.
Andrew
nalysis. Here's a patch. It uses pipes to separate
device names, since I know commas are meaningful in ALSA. Perhaps
that's not enough, and we need to do quoting?
In any case, this patch ought to be enough to satisfy users for 1.4.
Any thoughts, anyone?
Andrew
>From 9fd014ff6535493cc4
istry entry would be fine with me.
Here's a stupid registry entry patch. The paths are:
HKCU\Software\Wine\Drivers\winealsa.drv\ALSAOutputDevice
HKCU\Software\Wine\Drivers\winealsa.drv\ALSAInputDevice
If we can't reach a sensible consensus about device enumeration
sometime this week,
(Jorg has a patchset that does most of this).
Unfortunately, we'd potentially be presenting broken devices to the
user, but I think it's probably better than trying to guess if a
device is broken like we do now.
Andrew
g to Follow all instructions. What is my mistake?
>
I just meant that it wasn't correct for sending to wine-patches.
Basically, just make your changes as a commit in Git, and then use
git-format-patch to create a patch file. You can attach that to your
email and send it.
Take a look at some mails here <http://source.winehq.org/patches/> for
an idea of what your mail (or attachment) should look like when you
send it.
You can also find more information here:
<http://wiki.winehq.org/GitWine>
Andrew
On Tue, Feb 07, 2012 at 11:32:34PM +0200, Нискородов Серёжа wrote:
> Perhaps the code is not so clear and beautiful, but it works for me,
> and maybe someone wants to send it to the repository, or to correct
> and send a corrected.
One more thing, this messes up the default device selection, which
It's not bad at all! After fixing the little stuff above, you can send
it to wine-patches yourself. Please read
<http://wiki.winehq.org/SubmittingPatches>; your wine-devel mail was
not formatted correctly.
Andrew
ng useful there, but I can't figure out how to
get at it.
Using the simpler case of WODM_GETNUMDEVS also failed in every case.
> If Wine does not map these, all we'll get to "hear" in AppDB is that attentive
> people miss sound or music that they remember listening to 10 years ago on
> native.
>
Well, hopefully they would also file bugs :)
Andrew
rent
time when we detect an underrun (although detecting when the queue is
empty needs some work, as Ken pointed out).
In ALSA, we use snd_pcm_recover() after underruns, but AudioQueue
doesn't seem to have an analogous function that works well.
Andrew
esn't matter?
> >if(list_count(...) == 0)
> I once wrote a patch to turn such a pattern into if(list_empty(...))
>
Oops, I forgot that existed. I'll fix that in the next version.
Andrew
patch seems fine.
Andrew
ather than put S_FALSE->BADFORMAT into the generic conversion.
Andrew
1 - 100 of 719 matches
Mail list logo
