RE: Does auto-apt work to get wine dependencies in source code?

2013-08-26 Thread Hugh McMaster
On Monday, 26 August 2013 5:20 AM, Maarten Lankhorst wrote: Op 25-08-13 14:09, Susan Cragin schreef: Was thinking of running some tests but the list of dependencies on the website seems outdated, apt-get build-dep does not work. Is that with the ubuntu-wine ppa enabled? The Wine PPA isn't

Re: ntdll: Store all 'comClass' attributes

2013-08-26 Thread Nikolay Sivov
On 8/26/2013 19:04, Alexandre Julliard wrote: Nikolay Sivov nsi...@codeweavers.com writes: +while (min = max) +{ +int n, c; + +n = (min+max)/2; + +c = strncmpW(olemisc_values[n].name, str, len); strncmp isn't enough. Right, thanks.

Does auto-apt work to get wine dependencies in source code?

2013-08-25 Thread Susan Cragin
Hello, Was thinking of running some tests but the list of dependencies on the website seems outdated, apt-get build-dep does not work.

Re: Does auto-apt work to get wine dependencies in source code?

2013-08-25 Thread André Hentschel
Am 25.08.2013 14:09, schrieb Susan Cragin: Hello, Was thinking of running some tests but the list of dependencies on the website seems outdated, apt-get build-dep does not work. running https://code.google.com/p/winezeug/source/browse/trunk/install-wine-deps.sh is a good chance Does

questions to your commit wineps.drv: Allow for vertical text printing!

2013-08-24 Thread Wolfgang Walter
Hello Aric, I read commit 745e7c93c9042f62460f181daaa1f05645560b41 (wineps.drv: Allow for vertical text printing.) and I have some questions: 1) You added the parameter vertical to PSDRV_WriteSetFont() in ps.c but it remains unused. I think it isn't needed. 2) In

Permissions bug with Acrobat X Standard

2013-08-23 Thread Neil Hellfeldt
err:msi:cabinet_copy_file failed to create LC:\\users\\Public\\Application Data\\Adobe\\Adobe PDF\\Settings\\Standard.joboptions (error 3) err:msi:extract_cabinet FDICopy failed err:msi:ACTION_InstallFiles Failed to extract cabinet: LData1.cab err:msi:ITERATE_Actions Execution halted, action

Re: server: Store full sized completion information on the server side.

2013-08-23 Thread Alexandre Julliard
Dmitry Timoshkov dmi...@baikal.ru writes: @@ -152,7 +152,7 @@ struct completion *get_completion_obj( struct process *process, obj_handle_t han } void add_completion( struct completion *completion, apc_param_t ckey, apc_param_t cvalue, - unsigned int status,

Re: comsvcs: Add dll comsvcs (try 3)

2013-08-23 Thread Nikolay Sivov
On 8/23/2013 13:18, Alistair Leslie-Hughes wrote: Hi, Fix build issue +#include rpcproxy.h I don't think you need this. +HINSTANCE COMSVCS_hInstance = NULL; This should be static (and without initializer after that).

Re: [PATCH 5/6] wined3d: Use PBOs for dynamic volumes

2013-08-23 Thread Henri Verbeet
On 22 August 2013 23:22, Stefan Dösinger ste...@codeweavers.com wrote: @@ -145,6 +158,9 @@ static DWORD volume_access_from_location(DWORD location) case WINED3D_LOCATION_TEXTURE_RGB: return WINED3D_RESOURCE_ACCESS_GPU; +case WINED3D_LOCATION_BUFFER: +

Re: Permissions bug with Acrobat X Standard

2013-08-23 Thread Alexey Loukianov
Neil, thanks for reporting. Could you please re-report this bug to a place where reports should be posted - i.e. to Wine's Bugzilla which could be found at http://bugs.winehq.com/ ? Thanks in advance. ---  Best regards, Alexey Loukianov HPC support and maintenance engineer, RSC Technologies

Re: [PATCH 5/6] wined3d: Use PBOs for dynamic volumes

2013-08-23 Thread Stefan Dösinger
Am 23.08.2013 um 11:34 schrieb Henri Verbeet hverb...@gmail.com: Why does loading into a PBO require CPU access? The only reason why we want to store a volume in a PBO is to map it, which requires CPU access. If the volume doesn't allow CPU access I don't see a reason to load it into a PBO.

Re: [PATCH 5/6] wined3d: Use PBOs for dynamic volumes

2013-08-23 Thread Henri Verbeet
On 23 August 2013 12:04, Stefan Dösinger ste...@codeweavers.com wrote: Am 23.08.2013 um 11:34 schrieb Henri Verbeet hverb...@gmail.com: Why does loading into a PBO require CPU access? The only reason why we want to store a volume in a PBO is to map it, which requires CPU access. If the

Re: [PATCH 5/6] wined3d: Use PBOs for dynamic volumes

2013-08-23 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-08-23 12:29, schrieb Henri Verbeet: On 23 August 2013 12:04, Stefan Dösinger ste...@codeweavers.com wrote: Am 23.08.2013 um 11:34 schrieb Henri Verbeet hverb...@gmail.com: Why does loading into a PBO require CPU access? The only reason

Re: [PATCH 5/6] wined3d: Use PBOs for dynamic volumes

2013-08-23 Thread Henri Verbeet
On 23 August 2013 13:54, Stefan Dösinger ste...@codeweavers.com wrote: The rules for surfaces and volumes aren't applicable to buffers anyway. A default pool buffer without D3DUSAGE_DYNAMIC is mappable for example. I don't think the differences are insurmountable, but the main point is still

Re: [PATCH 5/6] wined3d: Use PBOs for dynamic volumes

2013-08-23 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-08-23 14:01, schrieb Henri Verbeet: On 23 August 2013 13:54, Stefan Dösinger ste...@codeweavers.com wrote: The rules for surfaces and volumes aren't applicable to buffers anyway. A default pool buffer without D3DUSAGE_DYNAMIC is mappable

Wiki is down

2013-08-23 Thread Rosanne DiMesio
I'm getting an Unable to connect message from Firefox and Connection closed by remote server from Opera. -- Rosanne DiMesio dime...@earthlink.net

Re: Wiki is down

2013-08-23 Thread Michael Stefaniuc
On 08/23/2013 03:39 PM, Rosanne DiMesio wrote: I'm getting an Unable to connect message from Firefox and Connection closed by remote server from Opera. CC'ing Dimi as he might not read wine-devel so often. bye michael

Re: Wiki is down

2013-08-23 Thread Dimi Paun
Looking into it right now... On Fri, Aug 23, 2013 at 10:18 AM, Michael Stefaniuc mstef...@redhat.comwrote: On 08/23/2013 03:39 PM, Rosanne DiMesio wrote: I'm getting an Unable to connect message from Firefox and Connection closed by remote server from Opera. CC'ing Dimi as he might not

Re: Wiki is down

2013-08-23 Thread Dimi Paun
Wiki back up, sorry about that! On Fri, Aug 23, 2013 at 10:31 AM, Dimi Paun d...@lattica.com wrote: Looking into it right now... On Fri, Aug 23, 2013 at 10:18 AM, Michael Stefaniuc mstef...@redhat.comwrote: On 08/23/2013 03:39 PM, Rosanne DiMesio wrote: I'm getting an Unable to

Re: [PATCH 4/6] wined3d: Enforce volume mapping restrictions

2013-08-23 Thread Alexandre Julliard
Stefan Dösinger ste...@codeweavers.com writes: --- dlls/wined3d/volume.c | 7 +++ 1 file changed, 7 insertions(+) It breaks the tests: ../../../tools/runtest -q -P wine -M d3dx9_36.dll -T ../../.. -p d3dx9_36_test.exe.so volume.c touch volume.ok volume.c:187: Test succeeded inside

Re: gdi32: some fix of errors writing Arabic on entry boxs

2013-08-22 Thread Yaron Shahrabani
Ahlan Ya Mas3ab! How can I test it with Hebrew? Yaron Shahrabani Hebrew translator On Wed, Aug 21, 2013 at 11:19 PM, مصعب الزعبي moc...@hotmail.com wrote: Written By Aric Stewart , fix about 50 percent of Bug 33794 --- dlls/gdi32/font.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH 5/5] wined3d: Implement basic volume location management

2013-08-22 Thread Henri Verbeet
On 22 August 2013 00:30, Stefan Dösinger ste...@codeweavers.com wrote: +const char *wined3d_debug_location(DWORD location) +{ +char buf[238]; That number looks a bit arbitrary, although I suppose it's at least large enough. +if (volume-resource.pool == WINED3D_POOL_SYSTEM_MEM +

Re: [PATCH 5/5] wined3d: Implement basic volume location management

2013-08-22 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-08-22 09:11, schrieb Henri Verbeet: On 22 August 2013 00:30, Stefan Dösinger ste...@codeweavers.com wrote: +const char *wined3d_debug_location(DWORD location) +{ +char buf[238]; That number looks a bit arbitrary, although I suppose

Re: [PATCH 5/5] wined3d: Implement basic volume location management

2013-08-22 Thread Henri Verbeet
On 22 August 2013 09:58, Stefan Dösinger ste...@codeweavers.com wrote: What I'm not quite happy with is WINED3D_RESOURCE_ACCESS_SCRATCH. Scratch resources are mappable. Having the extra location just complicates things and I see no gain from it. Yeah, I'm not particularly happy about it

Re: [PATCH 5/5] wined3d: Implement basic volume location management

2013-08-22 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-08-22 10:25, schrieb Henri Verbeet: Yeah, I'm not particularly happy about it either. The issue is that scratch resources allow some extra formats over sysmem resources, but can't be used for resource uploads. The idea is to eventually

Re: [4/4] oledb32: A basic test for IRowPosition_Initialize()

2013-08-22 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26813 Your paranoid

Re: [PATCH 5/5] wined3d: Implement basic volume location management

2013-08-22 Thread Henri Verbeet
On 22 August 2013 11:53, Stefan Dösinger ste...@codeweavers.com wrote: I think it's best to check the pool in operations that accept a resource as parameter. We already do that in most places. Yes, but if pool goes away we need some other way to check for scratch resources. It's just that in

Re: [4/4] oledb32: A basic test for IRowPosition_Initialize()

2013-08-22 Thread Nikolay Sivov
On 8/22/2013 14:55, Marvin wrote: Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at

Re: [PATCH 5/5] wined3d: Implement basic volume location management

2013-08-22 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-08-22 12:58, schrieb Henri Verbeet: Yes, but if pool goes away we need some other way to check for scratch resources. It's just that in retrospect the access flags probably aren't the right place. If pool goes to d3d8/9, the checks should

Re: [PATCH 5/5] wined3d: Implement basic volume location management

2013-08-22 Thread Henri Verbeet
On 22 August 2013 13:07, Stefan Dösinger ste...@codeweavers.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-08-22 12:58, schrieb Henri Verbeet: Yes, but if pool goes away we need some other way to check for scratch resources. It's just that in retrospect the access flags

Re: [PATCH 5/5] wined3d: Implement basic volume location management

2013-08-22 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-08-22 13:14, schrieb Henri Verbeet: On 22 August 2013 13:07, Stefan Dösinger ste...@codeweavers.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-08-22 12:58, schrieb Henri Verbeet: Yes, but if pool goes away we need some

Re: [PATCH 5/5] wined3d: Implement basic volume location management

2013-08-22 Thread Henri Verbeet
On 22 August 2013 13:32, Stefan Dösinger ste...@codeweavers.com wrote: Is it ok to worry about this later and just remove WINED3D_RESOURCE_ACCESS_SCRATCH for now? Sure.

Re: oleaut32/tests: Some tests for LoadRegTypeLib() with activated context

2013-08-22 Thread Alexandre Julliard
Nikolay Sivov nsi...@codeweavers.com writes: Some tests for LoadRegTypeLib() with activated context From 1ea3d8c82dd77ac14f2cdec748c0284032958b2f Mon Sep 17 00:00:00 2001 From: Nikolay Sivov nsi...@codeweavers.com Date: Wed, 21 Aug 2013 12:34:47 +0400 Subject: [PATCH 5/6] Some tests for

Re: oleaut32/tests: Some tests for LoadRegTypeLib() with activated context

2013-08-22 Thread Nikolay Sivov
On 08/22/2013 04:08 PM, Alexandre Julliard wrote: Nikolay Sivovnsi...@codeweavers.com writes: Some tests for LoadRegTypeLib() with activated context From 1ea3d8c82dd77ac14f2cdec748c0284032958b2f Mon Sep 17 00:00:00 2001 From: Nikolay Sivovnsi...@codeweavers.com Date: Wed, 21 Aug 2013

Re: [PATCH 6/6] wined3d: Implement basic volume location management (try 2)

2013-08-22 Thread Henri Verbeet
On 22 August 2013 14:57, Stefan Dösinger ste...@codeweavers.com wrote: +if (volume-locations WINED3D_LOCATION_DISCARDED) +{ +TRACE(Volume previously discarded, nothing to do.\n); +wined3d_volume_invalidate_location(volume,

Re: [PATCH 6/6] wined3d: Implement basic volume location management (try 2)

2013-08-22 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-08-22 15:33, schrieb Henri Verbeet: On 22 August 2013 14:57, Stefan Dösinger ste...@codeweavers.com wrote: +if (volume-locations WINED3D_LOCATION_DISCARDED) +{ +TRACE(Volume previously discarded,

Re: [PATCH] winemac.drv: Support the public UTF-16 type for Unicode text.

2013-08-22 Thread Ken Thomases
On Aug 21, 2013, at 11:49 PM, Charles Davis wrote: On Aug 21, 2013, at 10:34 PM, Ken Thomases wrote: On Aug 21, 2013, at 9:42 PM, Charles Davis wrote: +static HANDLE import_utf16_to_unicodetext(CFDataRef data) +{ +const WCHAR *src; +unsigned long data_len; +unsigned long

Re: [PATCH] winemac.drv: Support the public UTF-16 type for Unicode text. (try 2)

2013-08-22 Thread Ken Thomases
On Aug 22, 2013, at 12:07 AM, Charles Davis wrote: Try 2: Eliminiate dead store. Sort export functions by name. Looks OK to me. -Ken

Re: wined3d: Recognize Nvidia GeForce GTX 770

2013-08-22 Thread Henri Verbeet
On 22 August 2013 03:31, Gediminas Jakutis gedimi...@varciai.lt wrote: +{GTX 770, CARD_NVIDIA_GEFORCE_GTX770},/* Geforce 700 - highend */ {GTX 770M,CARD_NVIDIA_GEFORCE_GTX770M}, /* Geforce 700 - midend high mobile */ That doesn't work, it will always

Request to delete some attachments

2013-08-22 Thread Ken Sharp
Could a Bugzilla admin please delete the attachments in http://bugs.winehq.org/show_bug.cgi?id=24867 ? I don't know if metatester.exe can be freely distributed.

Re: Request to delete some attachments

2013-08-22 Thread Austin English
On Thu, Aug 22, 2013 at 1:23 PM, Ken Sharp kennyb...@o2.co.uk wrote: Could a Bugzilla admin please delete the attachments in http://bugs.winehq.org/show_bug.cgi?id=24867 ? I don't know if metatester.exe can be freely distributed. Done. -- -Austin

Re: oledb32: Add IDataSourceLocator support (try 5)

2013-08-21 Thread Nikolay Sivov
On 8/21/2013 10:16, Alistair Leslie-Hughes wrote: Hi, Updated naming. You updated method names only, what's left : +typedef struct DataSourceImpl +HRESULT create_data_source(IUnknown *outer, void **obj) +static const IDataSourceLocatorVtbl DataSourceVtbl = Also you most likely don't need

Re: [4/6] kernel32: Make serial tests self-contained.

2013-08-21 Thread Saulius Krasuckas
* On Thu, 15 Aug 2013, Dmitry Timoshkov wrote: dlls/kernel32/tests/comm.c | 284 ++--- 1 file changed, 167 insertions(+), 117 deletions(-) ... --- a/dlls/kernel32/tests/comm.c +++ b/dlls/kernel32/tests/comm.c @@ -1486,7 +1588,7 @@ static void

Re: oledb32: Add IDataSourceLocator support (try 6)

2013-08-21 Thread Nikolay Sivov
On 8/21/2013 10:33, Alistair Leslie-Hughes wrote: +typedef struct DataSourceImpl +{ +IDataSourceLocator IDataSourceLocator_iface; +LONG ref; + +} DataSourceImpl; All good, except this one.

Re: [5/6] ntdll: Make NtReadFile always initialize a being returned IO_STATUS_BLOCK for regular files.

2013-08-21 Thread Alexandre Julliard
Dmitry Timoshkov dmi...@baikal.ru writes: @@ -748,6 +748,11 @@ err: } else { +if (type == FD_TYPE_FILE) +{ +io_status-u.Status = status; +io_status-Information = total; +} I don't see why this would have to be specific to

Re: [4/6] ntdll/tests: Mark the NtReadFile call which returns STATUS_SUCCESS for an overlapped IO call as broken, and don't

2013-08-21 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26789 Your paranoid

Re: [6/6] server: Store full sized completion information on the server side.

2013-08-21 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26791 Your paranoid

Re: [5/6] ntdll: Make NtReadFile always initialize a being returned IO_STATUS_BLOCK for regular files.

2013-08-21 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26790 Your paranoid

Re: [PATCH 2/2] msvcrt: Fix lookahead buffer usage on pipes

2013-08-21 Thread Alexandre Julliard
Piotr Caban pi...@codeweavers.com writes: --- dlls/msvcrt/file.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) It doesn't work: ../../../tools/runtest -q -P wine -M msvcrt.dll -T ../../.. -p msvcrt_test.exe.so file.c touch file.ok file.c:2042: Test failed: read

Re: wined3d: Add a function for allocating aligned resource, memory (try 3)

2013-08-21 Thread Alexandre Julliard
Stefan Dösinger ste...@codeweavers.com writes: This supersedes patch 98009. It renames the allocation and free functions as suggested by Henri. It doesn't work: ../../../tools/runtest -q -P wine -M d3dx9_36.dll -T ../../.. -p d3dx9_36_test.exe.so texture.c touch texture.ok texture.c:555:

Re: [5/6] ntdll: Make NtReadFile always initialize a being returned IO_STATUS_BLOCK for regular files.

2013-08-21 Thread Dmitry Timoshkov
Alexandre Julliard julli...@winehq.org wrote: +if (type == FD_TYPE_FILE) +{ +io_status-u.Status = status; +io_status-Information = total; +} I don't see why this would have to be specific to files. There is a test for pipes which fails

Re: [5/6] ntdll: Make NtReadFile always initialize a being returned IO_STATUS_BLOCK for regular files.

2013-08-21 Thread Alexandre Julliard
Dmitry Timoshkov dmi...@baikal.ru writes: Alexandre Julliard julli...@winehq.org wrote: +if (type == FD_TYPE_FILE) +{ +io_status-u.Status = status; +io_status-Information = total; +} I don't see why this would have to be specific to

Re: [PATCH 2/2] msvcrt: Fix lookahead buffer usage on pipes (try2)

2013-08-21 Thread Piotr Caban
Please ignore this patch, I'll send a better version.

Re: ieframe: Use winehq snapshot instead of the main page in tests.

2013-08-21 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26794 Your paranoid

Re: wined3d: Add a function for allocating aligned resource, memory (try 3)

2013-08-21 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-08-21 12:43, schrieb Alexandre Julliard: 8 0x68e5fba9 wined3d_texture_decref+0x48(texture=couldn't compute location) [/home/julliard/wine/wine/dlls/wined3d/texture.c:449] in wined3d (0x0032fb28) This is an existing bug, when running the

Re: mscoree: Attempt to load the assembly from the application directory (try 2)

2013-08-21 Thread Vincent Povirk
+/* Assume the namespace is the Assembly name */ Uh, what? We should only be passing an assembly name to get_file_from_strongname, not the class name. You shouldn't even have access to the class name. I think what you're actually doing here is skipping the assembly name and using

Re: [PATCH] winemac.drv: Use the public UTF-16 type for Unicode text.

2013-08-21 Thread Ken Thomases
On Aug 20, 2013, at 10:49 PM, Charles Davis wrote: In the Windows world, Unicode almost universally means UTF-16. So, use the well-known UTF-16 type instead of making up our own. I have to wonder if there was a good reason Ken didn't use this initially. Please hold this patch while I

Re: [PATCH] winemac.drv: Use the public UTF-16 type for Unicode text.

2013-08-21 Thread Ken Thomases
On Aug 21, 2013, at 10:12 AM, Ken Thomases wrote: On Aug 20, 2013, at 10:49 PM, Charles Davis wrote: In the Windows world, Unicode almost universally means UTF-16. So, use the well-known UTF-16 type instead of making up our own. I have to wonder if there was a good reason Ken didn't use

Re: [PATCH] winemac.drv: Use the public UTF-16 type for Unicode text.

2013-08-21 Thread Charles Davis
On Aug 21, 2013, at 10:11 AM, Ken Thomases wrote: On Aug 21, 2013, at 10:12 AM, Ken Thomases wrote: On Aug 20, 2013, at 10:49 PM, Charles Davis wrote: In the Windows world, Unicode almost universally means UTF-16. So, use the well-known UTF-16 type instead of making up our own. I have

Re: RFC: winedev guide multimedia chapter patch

2013-08-21 Thread Andrew Eikum
Looks good for the most part. Some thoughts below... On Sat, Aug 17, 2013 at 01:25:00PM +0200, Frédéric Delanoy wrote: + The implementation can be found in a number of directories: + itemizedlist +listitem + para +filename

Re: msvcrt: _[w]access_s returns an error code.

2013-08-21 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26809 Your paranoid

Re: [PATCH] winemac.drv: Support the public UTF-16 type for Unicode text.

2013-08-21 Thread Ken Thomases
On Aug 21, 2013, at 9:42 PM, Charles Davis wrote: @@ -90,6 +93,9 @@ static CFDataRef export_hdrop_to_filenames(HANDLE data); static CFDataRef export_oemtext_to_utf8(HANDLE data); static CFDataRef export_text_to_utf8(HANDLE data); static CFDataRef export_unicodetext_to_utf8(HANDLE data);

Re: [PATCH] winemac.drv: Support the public UTF-16 type for Unicode text.

2013-08-21 Thread Charles Davis
On Aug 21, 2013, at 10:34 PM, Ken Thomases wrote: On Aug 21, 2013, at 9:42 PM, Charles Davis wrote: +static HANDLE import_utf16_to_unicodetext(CFDataRef data) +{ +const WCHAR *src; +unsigned long data_len; +unsigned long new_lines = 0; +LPWSTR dst; +unsigned long i,

Re: riched20: Use \ulnone instead of \ul0 for no underline.

2013-08-20 Thread Huw Davies
On Mon, Aug 19, 2013 at 05:38:13PM -0500, Vincent Povirk wrote: Testing on Windows (by saving rtf documents with wordpad and viewing them with notepad) shows that it uses \ulnone instead of \ul0 to end underline. Wine and Windows are both able to read either one. I think these are symonyms and

Re: oledb32: Implement IErrorRecord AddErrorRecord

2013-08-20 Thread Nikolay Sivov
On 8/20/2013 13:21, Alistair Leslie-Hughes wrote: Hi, Yes we do just take the pointer (pErrorInfo) passed in. MSDN states that the caller responsible for this memory. It means caller could free it at any time (or it could be a stack variable), so you have to make a deep copy. Changelog:

Re: oledb32: Implement IErrorRecord AddErrorRecord

2013-08-20 Thread Alistair Leslie-Hughes
On 20/08/2013 7:29 PM, Nikolay Sivov wrote: On 8/20/2013 13:21, Alistair Leslie-Hughes wrote: Hi, Yes we do just take the pointer (pErrorInfo) passed in. MSDN states that the caller responsible for this memory. It means caller could free it at any time (or it could be a stack variable), so you

Re: kernel32: Fix required buffer length for locale values from registry

2013-08-20 Thread Alexandre Julliard
Nikolay Sivov nsi...@codeweavers.com writes: http://bugs.winehq.org/show_bug.cgi?id=32169 Locale info to override is stored as REG_SZ and supposed to be null-terminated, They are supposed to, but it's not guaranteed. The code should be able to cope with non-terminated strings. -- Alexandre

Willing to join Wine

2013-08-20 Thread Priyank Bhatt
I want to work for Wine . I'm a third year undergraduate Student , I have done my elimentary course on machine learning algorithm . I am also familiar with C/C++ and some what of Python . Please suggest what all do I need to learn or read so as to start contributing to the open source community of

Re: [PATCH 1/5] wined3d: Add a function for allocating aligned resource memory (try 2)

2013-08-20 Thread Henri Verbeet
On 20 August 2013 12:07, Stefan Dösinger ste...@codeweavers.com wrote: +void *wined3d_alloc_resource_mem(SIZE_T size) +{ +void **p; +SIZE_T align = RESOURCE_ALIGNMENT - 1 + sizeof(*p); +void *mem; + +if (!(mem = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, size + align)))

Re: [PATCH 1/5] wined3d: Add a function for allocating aligned resource memory (try 2)

2013-08-20 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-08-20 13:12, schrieb Henri Verbeet: I think this should either be called wined3d_resource_allocate_sysmem() and live in resource.c, or accept any np2 alignment and be called something along the lines of wined3d_memalign(). The former

Re: [PATCH 1/5] wined3d: Add a function for allocating aligned resource memory (try 2)

2013-08-20 Thread Henri Verbeet
On 20 August 2013 13:16, Stefan Dösinger ste...@codeweavers.com wrote: Am 2013-08-20 13:12, schrieb Henri Verbeet: Somewhat related, I don't think there's really a reason to have both allocatedMemory and heap_memory anymore. It should probably just be called sysmem. That's a cleanup that

Re: winmm: fix WOD_Open() WAVE_MAPPER no-device case.

2013-08-20 Thread Andrew Eikum
On Tue, Aug 20, 2013 at 05:57:34AM +0200, Fabrice Bauzac wrote: Hello, This patch intends to fix the bug: http://bugs.winehq.org/show_bug.cgi?id=34305 The bug: basically, when there is no sound device and the user tries to WOD_Open() the WAVE_MAPPER pseudodevice, the code calls read_map()

Re: Sort the AUTHORS file by their last names.

2013-08-20 Thread Tae Wong
Non-Dutch names like Van Buggenhaut can be placed under V instead. -- Tae Wong

Re: [PATCH 2/4] oleaut32: Implement ICreateTypeInfo::SetTypeDescAlias

2013-08-20 Thread Piotr Caban
On 08/20/13 16:57, Andrew Eikum wrote: @@ -10530,8 +10541,28 @@ static HRESULT WINAPI ICreateTypeInfo2_fnSetTypeDescAlias(ICreateTypeInfo2 *ifac +This-cbSizeInstance = VARIANT_DataSize(This-tdescAlias-vt, This-pTypeLib-ptr_size); +if(!This-cbSizeInstance){ +FIXME(Wrong size for

Re: winmm: fix WOD_Open() WAVE_MAPPER no-device case.

2013-08-20 Thread Fabrice Bauzac
Hello, Indeed, WID_Open certainly suffers from the same problem. Here is the patch for both. From 51cee06af9f5901ca7310aad1077d4b07472da1e Mon Sep 17 00:00:00 2001 From: Fabrice Bauzac libn...@gmail.com Date: Tue, 20 Aug 2013 05:37:53 +0200 Subject: winmm: fix WOD_Open() and WID_Open()

Re: winmm: fix WOD_Open() WAVE_MAPPER no-device case.

2013-08-20 Thread Andrew Eikum
On Tue, Aug 20, 2013 at 07:06:13PM +0200, Fabrice Bauzac wrote: +if (g_inmmdevices_count == 0) { +return MMSYSERR_BADDEVICEID; +} Looks like the indentation is bad here. Also please submit the patch to wine-patches. Patches aren't picked up from wine-devel. Thanks for the

Re: Willing to join Wine

2013-08-20 Thread Austin English
On Tue, Aug 20, 2013 at 3:13 AM, Priyank Bhatt priyankbhatt1...@gmail.com wrote: I want to work for Wine . I'm a third year undergraduate Student , I have done my elimentary course on machine learning algorithm . I am also familiar with C/C++ and some what of Python . Please suggest what all

Re: oledb32: Add IDataSourceLocator support (try 4)

2013-08-20 Thread Nikolay Sivov
On 8/21/2013 09:15, Alistair Leslie-Hughes wrote: Hi, Use helper functions for memory Changelog: oledb32: Add IDataSourceLocator support Best Regards Alistair Leslie-Hughes It looks okay, but I suggest to fix a naming: +typedef struct DataSourceImpl +{ +IDataSourceLocator

Re: [website] Added templates/zh-cn/cvs.template translation

2013-08-19 Thread Frédéric Delanoy
On Sat, Aug 17, 2013 at 5:31 PM, Ken Sharp kennyb...@o2.co.uk wrote: On 17/08/13 09:02, Frédéric Delanoy wrote: Hwang YunSong (황윤성) Looks like UTF-8 works fine, so you could always use your real Chinese name. Of course Ken but then you miss the point of transliteration ;) -- Frédéric

Re: [PATCH 1/5] wined3d: Keep GL_UNPACK_CLIENT_STORAGE_APPLE off by default

2013-08-19 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Henri, Matteo, When reviewing those patches, please have a look at the attached archive. It contains the rest of the volume cleanup patches and some tests. Cheers, Stefan -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.20 (GNU/Linux) Comment:

Re: [PATCH 2/5] wined3d: Wrap resource-heapMemory into a structure

2013-08-19 Thread Henri Verbeet
On 19 August 2013 10:52, Stefan Dösinger ste...@codeweavers.com wrote: +struct wined3d_heap_memory *wined3d_alloc_resource_mem(UINT size) +{ +struct wined3d_heap_memory *ret; + +ret = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*ret)); +if (!ret) +return NULL;

Re: [PATCH 3/5] wined3d: Properly allocate heap memory for volumes

2013-08-19 Thread Henri Verbeet
On 19 August 2013 10:52, Stefan Dösinger ste...@codeweavers.com wrote: @@ -184,7 +184,16 @@ HRESULT CDECL wined3d_volume_map(struct wined3d_volume *volume, volume, map_desc, box, flags); if (!volume-resource.allocatedMemory) -volume-resource.allocatedMemory =

Re: [PATCH 4/5] wined3d: Move volume booleans into a flags field

2013-08-19 Thread Henri Verbeet
On 19 August 2013 10:52, Stefan Dösinger ste...@codeweavers.com wrote: +volume-flags |= WINED3D_VFLAG_LOCKABLE; /* FIXME */ You'll probably want to fix that :-) I think you can just leave the flag out until you rename it to WINED3D_VFLAG_MAPPABLE in one of the later patches.

Re: [PATCH 5/5] wined3d: Store the mipmap level in the volume

2013-08-19 Thread Henri Verbeet
On 19 August 2013 10:52, Stefan Dösinger ste...@codeweavers.com wrote: +void wined3d_volume_set_texture_level(struct wined3d_volume *volume, GLint level) +{ +volume-texture_level = level; +} I think that's a step in the wrong direction. I think this should be set on volume creation. We

Re: [PATCH 10/11] widl: Set pointer_size according to host's pointer-size.

2013-08-19 Thread Alexandre Julliard
Kai Tietz ktiet...@googlemail.com writes: diff --git a/tools/widl/widl.c b/tools/widl/widl.c index 5df99fc..6d8ec87 100644 --- a/tools/widl/widl.c +++ b/tools/widl/widl.c @@ -139,7 +139,7 @@ int line_number = 1; static FILE *idfile; -unsigned int pointer_size = 0; +unsigned int

Re: [PATCH 2/5] wined3d: Wrap resource-heapMemory into a structure

2013-08-19 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-08-19 12:29, schrieb Henri Verbeet: I don't think this is a good idea. How about something like the following? The corresponding free function would be trivial. I guess this works for the purposes of this patchset. However, in my command

Re: [PATCH 5/5] wined3d: Store the mipmap level in the volume

2013-08-19 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-08-19 12:39, schrieb Henri Verbeet: On 19 August 2013 10:52, Stefan Dösinger ste...@codeweavers.com wrote: +void wined3d_volume_set_texture_level(struct wined3d_volume *volume, GLint level) +{ +volume-texture_level = level; +} I

Re: [PATCH 2/5] wined3d: Wrap resource-heapMemory into a structure

2013-08-19 Thread Henri Verbeet
On 19 August 2013 13:38, Stefan Dösinger ste...@codeweavers.com wrote: I guess in theory any kind of payload could be added to your implementation, but growing this larger than RESOURCE_ALIGNMENT(=16) bytes moots the point I guess. The point is mostly that I don't think we want the

Re: [PATCH 5/5] wined3d: Store the mipmap level in the volume

2013-08-19 Thread Henri Verbeet
On 19 August 2013 13:51, Stefan Dösinger ste...@codeweavers.com wrote: Am 2013-08-19 12:39, schrieb Henri Verbeet: On 19 August 2013 10:52, Stefan Dösinger ste...@codeweavers.com wrote: +void wined3d_volume_set_texture_level(struct wined3d_volume *volume, GLint level) +{ +

Re: msxml3: Defer the conversion of XPath expressions to UTF-8. (try 4)

2013-08-19 Thread Alexandre Julliard
John Chadwick johnwchadw...@gmail.com writes: This patch was posted a bit ago without any objections, but seemingly slipped through the cracks. Very slight revisions were made since try 3 to improve the conciseness of code. From 8157b8a3d347c47f7f21e74d621632b4a9f50fd6 Mon Sep 17 00:00:00

Re: [PATCH 2/5] wined3d: Wrap resource-heapMemory into a structure

2013-08-19 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-08-19 13:53, schrieb Henri Verbeet: On 19 August 2013 13:38, Stefan Dösinger ste...@codeweavers.com wrote: I guess in theory any kind of payload could be added to your implementation, but growing this larger than RESOURCE_ALIGNMENT(=16)

Re: [PATCH 2/5] wined3d: Wrap resource-heapMemory into a structure

2013-08-19 Thread Henri Verbeet
On 19 August 2013 14:20, Stefan Dösinger stefandoesin...@gmail.com wrote: Am 2013-08-19 13:53, schrieb Henri Verbeet: That's actually a bug in what I posted. What's your suggested fix? Allocating size + align + alignment, and adding alignment to mem if mem happens to be already aligned? I

re: open bugs / multi thread / recommendation on new system

2013-08-19 Thread Dan Kegel
Damian wrote: 1) ATI or nVidia for new GPU? Does SLI/Crossfire work with wine? Don't know. I just use nvidia cards I find in the trash :-) But then I don't actually play games, so I don't care about 3d performance. 2) FX 8320 or intel same price class CPU? As the AMD has far inferior single

Re: [PATCH 10/11] widl: Set pointer_size according to host's pointer-size.

2013-08-19 Thread Kai Tietz
2013/8/19 Alexandre Julliard julli...@winehq.org: Kai Tietz ktiet...@googlemail.com writes: diff --git a/tools/widl/widl.c b/tools/widl/widl.c index 5df99fc..6d8ec87 100644 --- a/tools/widl/widl.c +++ b/tools/widl/widl.c @@ -139,7 +139,7 @@ int line_number = 1; static FILE *idfile;

Re: [PATCH 10/11] widl: Set pointer_size according to host's pointer-size.

2013-08-19 Thread Alexandre Julliard
Kai Tietz ktiet...@googlemail.com writes: 2013/8/19 Alexandre Julliard julli...@winehq.org: Kai Tietz ktiet...@googlemail.com writes: diff --git a/tools/widl/widl.c b/tools/widl/widl.c index 5df99fc..6d8ec87 100644 --- a/tools/widl/widl.c +++ b/tools/widl/widl.c @@ -139,7 +139,7 @@ int

Re: [PATCH 10/11] widl: Set pointer_size according to host's pointer-size.

2013-08-19 Thread Kai Tietz
2013/8/19 Alexandre Julliard julli...@winehq.org: Kai Tietz ktiet...@googlemail.com writes: 2013/8/19 Alexandre Julliard julli...@winehq.org: Kai Tietz ktiet...@googlemail.com writes: diff --git a/tools/widl/widl.c b/tools/widl/widl.c index 5df99fc..6d8ec87 100644 --- a/tools/widl/widl.c

Re: [PATCH 2/5] wined3d: Wrap resource-heapMemory into a structure

2013-08-19 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-08-19 14:34, schrieb Henri Verbeet: On 19 August 2013 14:20, Stefan Dösinger stefandoesin...@gmail.com wrote: Am 2013-08-19 13:53, schrieb Henri Verbeet: That's actually a bug in what I posted. What's your suggested fix? Allocating size +

Re: [PATCH 2/5] wined3d: Wrap resource-heapMemory into a structure

2013-08-19 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-08-19 17:08, schrieb Stefan Dösinger: I'm not entirely sure about the SIZE_T align = RESOURCE_ALIGNMENT - 1 + sizeof(*p); line though. Msvcrt doesn't have the - 1, and allocating size + RESOURCE_ALIGNMENT bytes might be enough. msvcrt

Re: [website] Added templates/zh-cn/cvs.template translation

2013-08-19 Thread Hin-Tak Leung
-- On Sat, Aug 17, 2013 09:02 BST Frédéric Delanoy wrote: On Sat, Aug 17, 2013 at 5:57 AM, xulixin xulixin1...@gmail.com wrote: Should I change my name's spelling to Lixin Xu, or LiXin Xu, or other format? Not sure, most people (at least non-Chinese) use firstname

Re: Could you update/rerun that report on bugs without AppDB links?

2013-08-19 Thread André Hentschel
Am 19.08.2013 01:57, schrieb Dan Kegel: I don't seem to have saved the (crappy) script. There is something similar at https://code.google.com/p/winezeug/source/browse/#svn%2Ftrunk%2Fappdb-mashup and it wouldn't be too hard to whip something up again for somebody who is motivated. Please

<    3   4   5   6   7   8   9   10   11   12   >