On Friday, June 02, 2006 07:25, Mike McCormack wrote:
lack of comments in the code
+1, I think it's horrifying.
void the_function_that_adds_one_to_i(int i)
{
/* this adds one to i */
i = i + 1;
/* this returns i to the caller */
return i;
}
Horrifying, yes :)
notNeeded=0;
if (Ishack())
{
/*(hacks are not accepted)*/
notNeeded=1;
}
else if(IsFeature())
{
notNeeded=0;
}
PS
:P for the if - then constructs
On 6/26/06, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote:
On Friday, June 02, 2006 07:25, Mike McCormack wrote:
lack of comments in the code
Since my previous posting(s) were poorly written (and/or
misconceived), I'd like to try and explain my point again.
Some coders think:
If it was hard to write it should be hard to understand, so that when
people finally get it, they'll be amazed at how clever I am.
Writing good comments can
* Molle Bestefich [EMAIL PROTECTED] [05/06/06, 15:21:08]:
I'm not going to try and answer all of these questions, but this one I
think I can answer.
Honestly, I think that you just don't like me and that's why you
comprehend everything I write in an extremely prejudicious, negative
manner.
Dmitry Timoshkov wrote:
I'd suggest to return and carefully reread the whole paragraph I've
quoted and replied to. It has nothing to do with a constructive talk
about commenting the code, instead it's full of insults and hits.
It has everything to do with a constructive talk about comments.
I
I'd suggest to return and carefully reread the whole paragraph I've
quoted and replied to. It has nothing to do with a constructive talk
about commenting the code, instead it's full of insults and hits. I'm
not even talking about using the word foreigners for the contributors
to the open
Friday, June 2, 2006, 6:27:18 AM, EA Durbin wrote:
There is precious little Why in the comments of a lot of projects - Why
does this function exist, why would I call it, why does it return what it
does, etc.
BS comments like those within the function don't help, obviously - but
sometimes a
Friday, June 2, 2006, 12:20:58 PM, EA Durbin wrote:
From: Juan Lang [EMAIL PROTECTED]
To: EA Durbin [EMAIL PROTECTED]
CC: wine-devel@winehq.org
Subject: Re: How are we doing?
Date: Fri, 2 Jun 2006 10:56:15 -0700 (PDT)
Especially the code that is responded to as , I know it's a mess to
look
On 6/3/06, Vitaliy Margolen [EMAIL PROTECTED] wrote:
I don't see any problems here. If anyone needs to know _why_ some function does
X - they should look on msdn. Also it would really help look at the patch itself
that _does_ explain what the patch is for. And might even link to the bug #.
I
Vitaliy Margolen schrieb:
Friday, June 2, 2006, 6:27:18 AM, EA Durbin wrote:
There is precious little Why in the comments of a lot of projects - Why
does this function exist, why would I call it, why does it return what it
does, etc.
BS comments like those within the function don't help,
Peter Beutner [EMAIL PROTECTED] writes:
BTW Alexandre, can we preserve references to bug numbers in patch comments?
Indeed that would be nice.
I'm not opposed to having bug number in the comments, but it has to be
in addition to a proper explanation; the log must be understandable on
its own
Matt Finnicum wrote:
Also, sometimes it's not obvious why a function is called. A comment
like Call funcResetStatusVariables because the above code triggers a
redraw which can break them would save a new developer twenty minutes
of But why update them THERE?! Does my code have to do that?.
We
On Fri, 02 Jun 2006 12:33:03 +0100, Robert Shearman wrote:
The lack of comments in your email is more horrifying.
Haha :)
Maybe we should have a new janitorial task comment code, or maybe
Alexandre should reject patches that don't have enough comments?
The problem I think is that because MSDN
On Fri, 02 Jun 2006 08:03:46 -0500, Jeremy White wrote:
And I think I would agree that the Wine server is commented
about right; it is, imho, a beautiful piece of code.
+1 to that. I reckon I didn't really grok in that deep-down-in-your-soul
way what good coding style is until I took time to
On Sat, 03 Jun 2006 12:03:21 +1000, Jeff Latimer wrote:
We seem to have a policy of not accepting comments in exisiting code.
We do? I seem to recall having comment patches accepted before. Albiet a
long time ago.
If I add comments to existing code that clear up a mystery I have found
they
lack of comments in the code
+1, I think it's horrifying.
void the_function_that_adds_one_to_i(int i)
{
/* this adds one to i */
i = i + 1;
/* this returns i to the caller */
return i;
}
Horrifying, yes :)
Mike
Huw Davies wrote:
There's a bug in this code, let's try this:
/* change by Huw Davies 02-Jun-2006, to fix the return type of the function */
int the_function_that_adds_one_to_i(int i)
{
/* this adds one to i */
i = i + 1;
/* this returns i to the caller */
return i;
}
On Friday, June 02, 2006 07:25, Mike McCormack wrote:
lack of comments in the code
+1, I think it's horrifying.
void the_function_that_adds_one_to_i(int i)
{
/* this adds one to i */
i = i + 1;
/* this returns i to the caller */
return i;
}
Horrifying, yes :)
There is precious little Why in the comments of a lot of projects - Why
does this function exist, why would I call it, why does it return what it
does, etc.
BS comments like those within the function don't help, obviously - but
sometimes a comment block describing WHY a given chunk of code
David D. Hagood wrote:
ARRRG! This whole thing is just a bullshit strawman.
Indeed.
However my strawman demonstrates that it's difficult to enforce code
commenting, as you'll just end up with a bunch of bs.
You also can't comment somebody else's code properly, obvious things
don't
Mike McCormack wrote:
/* My tests reveal that it's done this way */
/* FIXME: this is broken */
/* go forward in the array */
Then you've got the whole issue of maintaining the
comments in synchronization with the code.
You've gravely misunderstood what good code commenting is?
Good
If what you really want is code that's easier to understand we're better
off scrapping all comments, then enforcing good coding style, so that
the code is readable without comments. If the functions are kept small,
things are well named, and the complexity confined (eg. no 7 level
indent),
Mike McCormack wrote:
If what you really want is code that's easier to understand we're better
off scrapping all comments...
And we can encourage safe driving by removing airbags and seatbelts, and
installing big shiny sharp metal spikes on the steering wheel, and
executing anybody who
Molle Bestefich [EMAIL PROTECTED] wrote:
Teaching people to write good comments is infinitely easier - it's a
simple case of banging 'em on the head and forcing them to write a
comment every time they've done a piece of code that they know
required cunning skill for whatever reason. You may
Mike McCormack wrote:
Add all the great comments you like, but you still actually have to read
the code and understand it to figure out how to fix it.
Often the goal is not to fix it, the goal is to understand it in order
to fix something else.
So, IMO, you're better off striving for the
grep Bestefich documentation/ChangeLog.ALPHA | wc -l
0
grep Bestefich ChangeLog | wc -l
0
And this is exactly the kind of comment and attitude
that pushes people away from being Wine developers.
This was a thread that asked the question:
What would get more developers
: Mike McCormack [EMAIL PROTECTED], wine-devel@winehq.org
Subject: Re: How are we doing?
Date: Fri, 02 Jun 2006 11:24:06 -0500
grep Bestefich documentation/ChangeLog.ALPHA | wc -l
0
grep Bestefich ChangeLog | wc -l
0
And this is exactly the kind of comment and attitude
that pushes
Especially the code that is responded to as , I know it's a mess to
look at, but I didn't write it.
Can you give us examples?
Mostly Wine attempts to follow how Windows works, so MSDN provides a lot
of the documentation. This is becoming increasingly true, with kernel32
being implemented on
style
and lack of comments in places in wine makes the learning curve steeper than
it needs to be for beginning wine developers.
Just my 2 cents as a beginning wine developer.
From: Juan Lang [EMAIL PROTECTED]
To: EA Durbin [EMAIL PROTECTED]
CC: wine-devel@winehq.org
Subject: Re: How are we
--- EA Durbin [EMAIL PROTECTED] wrote:
If I use K R style, or not enough white space,
or don't align things perfectly at work my boss will kindly print off a
copy of the companies acceptable coding standards policy and bring it
over.
Ah, so it's the lack of a defined style guideline that's
Am Freitag, den 02.06.2006, 08:03 -0500 schrieb Jeremy White:
But there are plenty of places in Wine where the code does
something screwball or out of the ordinary (hell, the API
itself is screwball), and those places deserve more comments.
IMHO, more comment's help to teach someone, who read
EA Durbin wrote:
KR style brack placements
was what i was referring to when I commented about coding style. They
are an eyesore and make things difficult to read.
Oh, NO NO NO. KR style IS the one and only true pure C style. As mutch
as GNU did good work for OSS they did very wrong with the
Michael == Michael Stefaniuc [EMAIL PROTECTED] writes:
Michael P.S.: Let the flame war begin. ;)
Isn't it already raginh ;-)
--
Uwe Bonnes[EMAIL PROTECTED]
Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt
- Tel. 06151 162516 Fax. 06151
From the viewpoint of a new developer (Summer of Code), having a few
The purpose of this function comments would have been / still would
be very useful!
It's painfully having to figure out what exactly a function does, that
calls five other functions that you have to look into, which each call
Jeremy White [EMAIL PROTECTED] wrote:
grep Bestefich documentation/ChangeLog.ALPHA | wc -l
0
grep Bestefich ChangeLog | wc -l
0
And this is exactly the kind of comment and attitude
that pushes people away from being Wine developers.
This was a thread that asked the question:
Detlef Riekenberg [EMAIL PROTECTED] writes:
During the Time, things changed and I get confused more and more times
about special Developers and other Developers, as well as special
Patches and other Patches.
(It's also Possible, that i did not see the big differences before).
There's no
Message d'origine
De: Alexandre Julliard [EMAIL PROTECTED]
A: Detlef Riekenberg [EMAIL PROTECTED]
Date: Thu, 01 Jun 2006 11:45:10 +0200
Copie à: wine-devel@winehq.com, Mike Hearn [EMAIL PROTECTED]
Sujet: Re: How are we doing?
Detlef Riekenberg [EMAIL PROTECTED] writes:
During the Time
[EMAIL PROTECTED] writes:
It's possible to see on wiki the trust points positions ? :)
And on each WWN, see the variations (seems the famous kde buzz) :)
The commit logs contain the time of the change and the time of the
commit, so you could use that to build a top-10 of the developers with
On 6/1/06, Alexandre Julliard [EMAIL PROTECTED] wrote:
It's possible to see on wiki the trust points positions ? :)
And on each WWN, see the variations (seems the famous kde buzz) :)
The commit logs contain the time of the change and the time of the
commit, so you could use that to build a
Am Donnerstag, den 01.06.2006, 11:45 +0200 schrieb Alexandre Julliard:
During the Time, things changed and I get confused more and more times
about special Developers and other Developers, as well as special
Patches and other Patches.
(It's also Possible, that i did not see the big
* Detlef Riekenberg [EMAIL PROTECTED] [01/06/06, 01:15:28]:
Big Patches went into the tree:
Juan Lang: crypt32: Implement CryptBinaryToStringA and
CryptStringToBinaryA.
When I saw the big Patch, i wanted to ask to split this in seperate
Patches:
1x Header-Changes
2x Testcase (2
Any status on what projects have been approved and
who is going to work on which project for this years SoC.
---
Vijay
On 6/1/06, Kai Blin [EMAIL PROTECTED] wrote:
* Detlef Riekenberg [EMAIL PROTECTED] [01/06/06, 01:15:28]:
Big Patches went into the tree:
Juan Lang: crypt32: Implement
Hi,
Tony Lambregts wrote:
In the interm I believe the AppDB has helped a lot. I think that the
work that we have put into it has paid off fairly well to a point. So
far we have added:
- Applications Maintantainers that can modify application entries on
an App by App basis.
- Notification
I will be working on riched20 for SoC - Initially I'll be working on
some unimplemented messages and styles, and then I'll be working on
some of the missing COM interfaces.
Details are at http://wiki.winehq.org/MatthewFinnicum
--Matt
On 6/1/06, Vijay Kiran Kamuju [EMAIL PROTECTED] wrote:
Any
On 6/1/06, KGJ [EMAIL PROTECTED] wrote:
Hi,
The AppDB is a great idea, but why is it so poorly integrated in the
main page? The same question goes to the Bugtracker and the Wiki where
the situation is even worse. On most web pages you have a navigation bar
which remains the same as long as
On Thu, Jun 01, 2006 at 03:21:52PM -0400, Vijay Kiran Kamuju wrote:
Any status on what projects have been approved and
who is going to work on which project for this years SoC.
They are listed here:
http://code.google.com/soc/wine/about.html
Ciao, Marcus
KGJ [EMAIL PROTECTED] wrote:
The AppDB is a great idea, but why is it so poorly integrated in the
main page? The same question goes to the Bugtracker and the Wiki where
the situation is even worse. On most web pages you have a navigation bar
which remains the same as long as you are on the same
Tony Lambregts wrote:
The Application Queue is not being processed in a timely fashion.
For myself I am busy with my day job, working on upgrading bugzilla, and
burnt out/frustrated trying to keep up with Application submitions (I am
too soft hearted to reject some submittions that probably
Speaking from the viewpoint of a new wine developer, the major hurdle, in my
view, to contributing to wine is the lack of comments in the code, and the
lack of whitespace. Wine is complicated enough, and the lack of comments in
the code makes it more difficult. When trying to trace existing
On Tue, 30 May 2006, Jim White wrote:
[...]
So why are you not supporting setting up a wine-macos(x) list @ WineHQ?
I think the goal is to bring the Wine on Intel Macs development efforts
into the mainline.
That means committing the Audio driver into the main tree (done), doing
the same
* James Hawkins [EMAIL PROTECTED] [30/05/06, 18:32:37]:
* Are we turning away potential developers for any reason? Could we do
more to attract new hackers?
It seems a lot of developers are frustrated by our development model
(one pathway to commit) and by the amount of effort it
On Wed, 31 May 2006 14:57:06 +0200, Hans Leidekker wrote:
At the same time we should think of exciting new possibilities that an open
source implementation of the Windows API brings to the table.
At past WineConfs the possibility of reaching out to Windows developers
was raised, by making it
Jeremy White wrote:
On a side note, there is something that worries me a bit. Specifically,
it appears that we have a dirty secret about the regression tests - that
they only work reliably on Alexandre's machine. Is that true?
Shouldn't we do something about that? Or am I on crack, and lots
Mike Hearn wrote:
As the Summer Of Code begins and new blood joins us all at once,
I thought it'd be a good time to open a discussion on how we are doing as
a project.
Questions to consider:
* Is Wine improving or is the regression rate matching the improvement
rate?
Since I have
Am Dienstag, den 30.05.2006, 00:17 +0100 schrieb Mike Hearn:
Thanks a lot for starting this. As I'm connected with wine about a Year
now, I give my comments / feeling here.
(It's large, but i'm unable to Split ...)
Questions to consider:
* Is Wine improving or is the regression rate
Mike Hearn wrote:
* Are we turning away potential developers for any reason? Could we do
more to attract new hackers?
Yes. The attitude on wine-devel could be appreciative of the progress
that Darwine has made and the hard work its developers rather than
disdain. That way developers
On Tuesday 30 May 2006 01:17, Mike Hearn wrote:
As the Summer Of Code begins and new blood joins us all at once,
I thought it'd be a good time to open a discussion on how we are doing as
a project.
Questions to consider:
* Is Wine improving or is the regression rate matching
Got a reply from somebody who would rather remain anonymous:
-
This may be just me, but the learning curve is probably much more
steep for a general purpose hacker than for a particular dll. I have
some apps I'd like to get
On Mon, 29 May 2006 23:47:26 -0700, Jim White wrote:
But I do know I set up Darwine because of the antagonistic
and dismissive tone here when I tried to discuss Darwin Mac OS X
development ideas.
I have yet to see anybody give Emmanuel and the other Darwine developers
anything but respect.
Mike Hearn [EMAIL PROTECTED] wrote:
Got a reply from somebody who would rather remain anonymous:
-
This may be just me, but the learning curve is probably much more
steep for a general purpose hacker than for a particular
Mike Hearn wrote:
Tell people they should work on a port to a platform they don't use and
you'll be told to do the work yourself. Dismissive? Maybe. Unexpected? I'd
hope not.
I never told anyone they should work on anything. I've got an idea for
a processor emulation technique to enable
Jim White wrote:
Jim White wrote in Darwine on 2006-05-24:
Jeremy White wrote:
Speaking of a better way...is there any reason we couldn't shift
the bulk of this development work over to WineHQ and to the Wine
develoment mailing lists? That's where we do all of our work.
...
On 5/30/06, Dmitry Timoshkov [EMAIL PROTECTED] wrote:
I can't believe that writing a good test case showing the bug and adding
it to the Wine test harness is such hard thing to do for a good Windows
developer who already knows what he expects from a particular Win32 API.
But most developers
Mike Hearn [EMAIL PROTECTED] wrote:
But most developers who come to Wine are not Windows developers, they
are Linux developers who want to run an app or game. Often finding the
bug is much harder than fixing it these days. It takes practice to
learn how to read a relay trace or debug a
* Is Wine improving or is the regression rate matching the improvement
rate?
* Are we producing a quality product, from the perspective of
non-technical end users? (I appreciate this isn't a goal for everyone)
Note that I intend to make another big push for the use of CxTest
On 5/30/06, Jim White [EMAIL PROTECTED] wrote:
Was there a single warm fuzzy from anyone on this list? No.
Fortunately we get them from Macfolk on a regular basis.
Press/news announcements almost never garner warm fuzzies on the devel
list. That's not to say they're not appreciated; I think
Brian Vincent wrote:
...
Now, as far as not feeling the love, I'd strongly encourage as many
Darwine developers as possible to attend Wineconf in September. I
know last year I personally invited Pierre.
Huh? Why is WineConf private? Shouldn't a conference for an Open
Source project like
Huh? Why is WineConf private? Shouldn't a conference for an Open
Source project like Wine be open to all people interested in attending,
instead of needing invitations?
Just for the record, WineConf is now and always has been
a) Open to all
b) Free of charge
c) Focused on Wine
Jeremy White wrote:
Huh? Why is WineConf private? Shouldn't a conference for an Open
Source project like Wine be open to all people interested in attending,
instead of needing invitations?
Just for the record, WineConf is now and always has been
a) Open to all
b) Free of charge
c)
Geez. Clearly I am being too subtle. Guess I needed to add a ;-)
rather than my Rodney Dangerfield But seriously.
Um, yes. I took it as an accusation of an event I have helped to plan,
not as a jest.
So why are you not supporting setting up a wine-macos(x) list @ WineHQ?
Hmm. I feel
Jim White wrote:
So why are you not supporting setting up a wine-macos(x) list @ WineHQ?
Jim
Hi,
I'm just a user, but may I suggest because :
- Wine for Mac OS X has basically the same relation to Wine for Linux as
Wine for Solaris and Wine for *BSD have, and these don't have special
On 5/29/06, Mike Hearn [EMAIL PROTECTED] wrote:
* Is Wine improving or is the regression rate matching the improvement
rate?
It's hard for me to answer this question, because I don't regularly
run many apps with Wine, but it seems like we've had reports of a lot
of regressions lately. A
As the Summer Of Code begins and new blood joins us all at once,
I thought it'd be a good time to open a discussion on how we are doing as
a project.
Questions to consider:
* Is Wine improving or is the regression rate matching the improvement
rate?
* Are we producing a quality product
73 matches
Mail list logo
