Re : Re: Re : [PATCH 01/14] New struct wks_info

2013-10-05 Thread Christophe
- Rodolfo García Peñas a écrit : > On Sat, 05 Oct 2013, Carlos R. Mafra escribió: > > > On Sat, 5 Oct 2013 at 0:53:52 +0200, Christophe wrote: > > > > > > - Rodolfo García Peñas (kix) a écrit : > > > > The new struct wks_info includes the global information > > > > for the workspaces

Re: Re : [PATCH 01/14] New struct wks_info

2013-10-05 Thread Carlos R. Mafra
On Sat, 5 Oct 2013 at 2:35:13 +0200, Rodolfo García Peñas wrote: > > > May I suggest, as this is a global variable, to place it the the > > > global structure instead? You could define something like: > > > > > > struct { > > > WMFont *font_for_name; > > > } workspace; > > > > > > and

Re: Re : [PATCH 01/14] New struct wks_info

2013-10-05 Thread Rodolfo García Peñas
On Sat, 05 Oct 2013, Christophe escribió: > > - Rodolfo García Peñas (kix) a écrit : > > The new struct wks_info includes the global information > > for the workspaces. All information related with the workspaces > > should be included here. > > > > The first variable moved is workspace_nam

Re: minimized window not rising on Alt-Tab?

2013-10-05 Thread Iain Patterson
Quoth Carlos R. Mafra, switchpanel.c: In function 'wSwitchPanelSelectFirst': switchpanel.c:673:18: warning: variable 'tmpwin' set but not used [-Wunused-but-set-variable] [...] which looks bogus. Is there any compiler food for this case? It is indeed bogus. The variable is used in WM_ITERAT

Re: minimized window not rising on Alt-Tab?

2013-10-05 Thread Rodolfo García Peñas
Hi, this is the cpp code: ---8<--- if (panel->win) { for (tmpwin = WMArrayFirst(panel->windows, &(i)); (i) != WANotFound; tmpwin = WMArrayNext(panel->windows, &(i))) { changeImage(panel, i, i == panel->current, 0, 0); } drawTitle(panel, panel->current, title); } ---8<--- The tmpwin v

Re: minimized window not rising on Alt-Tab?

2013-10-05 Thread Carlos R. Mafra
On Sat, 5 Oct 2013 at 11:36:00 +0100, Iain Patterson wrote: > Quoth Carlos R. Mafra, > > >switchpanel.c: In function 'wSwitchPanelSelectFirst': > >switchpanel.c:673:18: warning: variable 'tmpwin' set but not used > >[-Wunused-but-set-variable] > >[...] > >which looks bogus. Is there any compiler

Re: minimized window not rising on Alt-Tab?

2013-10-05 Thread kix
I am out now. Replace the variable with (void *)? "Carlos R. Mafra" escribió: >On Sat, 5 Oct 2013 at 11:36:00 +0100, Iain Patterson wrote: >> Quoth Carlos R. Mafra, >> >> >switchpanel.c: In function 'wSwitchPanelSelectFirst': >> >switchpanel.c:673:18: warning: variable 'tmpwin' set but not use

Re: minimized window not rising on Alt-Tab?

2013-10-05 Thread Iain Patterson
Quoth Rodolfo García Peñas, I am out now. Replace the variable with (void *)? Just elicits the same warning, unfortunately. -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.

Re: Re : [PATCH 01/14] New struct wks_info

2013-10-05 Thread BALATON Zoltan
On Sat, 5 Oct 2013, Rodolfo García Peñas wrote: Window Maker has some basic elements, like menus, appicons,... but these elements has relationship between them (like a database). Probably better to think about them as objects and object relationships. This was the intended design originally, a

Re: minimized window not rising on Alt-Tab?

2013-10-05 Thread Rodolfo García Peñas
On Sat, 05 Oct 2013, Iain Patterson escribió: > Quoth Rodolfo García Peñas, > > >I am out now. > > > >Replace the variable with (void *)? > > Just elicits the same warning, unfortunately. Then, why not forget the macro and include the final code? This code is the same, but without the warnin

Re: minimized window not rising on Alt-Tab?

2013-10-05 Thread SJS
begin quoting Iain Patterson as of Sat, Oct 05, 2013 at 11:36:00AM +0100: > Quoth Carlos R. Mafra, > >> switchpanel.c: In function 'wSwitchPanelSelectFirst': >> switchpanel.c:673:18: warning: variable 'tmpwin' set but not used >> [-Wunused-but-set-variable] >> [...] >> which looks bogus. Is there