>From 244671a650bae1be4d2b12d0ecc308c63b08783d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?"Rodolfo=20Garc=C3=ADa=20Pe=C3=B1as=20(kix)"?=
Date: Wed, 28 Nov 2012 23:56:19 +0100
Subject: [PATCH 3/4] 3 Save iconpath if icon will be used
This patch avoid to save the icon name in the confi
On Thu, 29 Nov 2012, Rodolfo Garc?a Pe?as wrote:
This patch avoid to save the icon name in the configuration file
if the flag "Ignore client suplied icon" is not selected.
Sorry but if the icon set by the user is not used when Ignore flag is not
set then why do we have this option at all?
+
On 2012-11-29 11:03, BALATON Zoltan wrote:
On Thu, 29 Nov 2012, Rodolfo Garc?a Pe?as wrote:
This patch avoid to save the icon name in the configuration file
if the flag "Ignore client suplied icon" is not selected.
Sorry but if the icon set by the user is not used when Ignore flag is
not set t
On Thu, 29 Nov 2012, Rodolfo Garc?a Pe?as (kix) wrote:
Yes, you are right. We have four options:
1. ignore flag + file set
2. no ignore flag + file set
3. ignore flag + no file set
4. no ignore flag + no file set
Option 1 is clear, we provide a new icon and ignore the supplied icon by the
clie
On Thu, 29 Nov 2012, BALATON Zoltan escribió:
> On Thu, 29 Nov 2012, Rodolfo Garc?a Pe?as (kix) wrote:
> >Yes, you are right. We have four options:
> >
> >1. ignore flag + file set
> >2. no ignore flag + file set
> >3. ignore flag + no file set
> >4. no ignore flag + no file set
> >
> >Option 1 is
On Fri, 25 Jan 2013 at 1:06:58 +0100, Rodolfo García Peñas wrote:
> I changed the behavior for the winspector. Can you test it now?
>
> More testers are welcome. If the patch is ok, I will write the commit info.
I'm a bit lost about which behavior is being fixed. What is the test
case to aim f
On Fri, 25 Jan 2013, Carlos R. Mafra wrote:
On Fri, 25 Jan 2013 at 1:06:58 +0100, Rodolfo García Peñas wrote:
I changed the behavior for the winspector. Can you test it now?
More testers are welcome. If the patch is ok, I will write the commit info.
I'm a bit lost about which behavior is bei
On 25/01/2013 11:53, BALATON Zoltan wrote:
> On Fri, 25 Jan 2013, Carlos R. Mafra wrote:
>> On Fri, 25 Jan 2013 at 1:06:58 +0100, Rodolfo García Peñas wrote:
>>> I changed the behavior for the winspector. Can you test it now?
>>>
>>> More testers are welcome. If the patch is ok, I will write the c
On Sat, 26 Jan 2013 at 11:12:01 +0100, "Rodolfo García Peñas (kix)" wrote:
Thanks for the detailed explanation.
> On 25/01/2013 11:53, BALATON Zoltan wrote:
> >
> > The procedure to test Ignore app icon is here:
> > http://lists.windowmaker.org/dev/msg04452.html
> I am changing the icon behavi
On Fri, 25 Jan 2013, BALATON Zoltan escribió:
> On Fri, 25 Jan 2013, Carlos R. Mafra wrote:
> >On Fri, 25 Jan 2013 at 1:06:58 +0100, Rodolfo García Peñas wrote:
> >>I changed the behavior for the winspector. Can you test it now?
> >>
> >>More testers are welcome. If the patch is ok, I will write
On Sat, 26 Jan 2013, Rodolfo kix Garcia escribió:
> On Fri, 25 Jan 2013, BALATON Zoltan escribió:
>
> > On Fri, 25 Jan 2013, Carlos R. Mafra wrote:
> > >On Fri, 25 Jan 2013 at 1:06:58 +0100, Rodolfo García Peñas wrote:
> > >>I changed the behavior for the winspector. Can you test it now?
> > >>
On Fri, 25 Jan 2013, BALATON Zoltan escribió:
> On Fri, 25 Jan 2013, Carlos R. Mafra wrote:
> >On Fri, 25 Jan 2013 at 1:06:58 +0100, Rodolfo García Peñas wrote:
> >>I changed the behavior for the winspector. Can you test it now?
> >>
> >>More testers are welcome. If the patch is ok, I will write
On Sun, 27 Jan 2013, Rodolfo kix Garcia escribió:
> On Fri, 25 Jan 2013, BALATON Zoltan escribió:
>
> > On Fri, 25 Jan 2013, Carlos R. Mafra wrote:
If you want see the code.
kix
--
||// //\\// Rodolfo "kix" Garcia
||\\// //\\ http://www.kix.es/
ptchs.tgz
Description: application/gtar-compres
Hello,
On Sun, 27 Jan 2013, Rodolfo García Peñas wrote:
better, but... I would like to know your oppinion before send the
patches.
My opinion is as before: code cleanup patches should not change behaviour
so everything should work the same after your patches as they worked
before them. (The
14 matches
Mail list logo
