Re: [PATCH] add SPDX to arch/arm/*.c

2022-08-15 Thread Juergen Gross
On 15.08.22 22:32, Stefano Stabellini wrote: + Xen maintainers and committers For context, I wrote a patch to introduce SPDX tags starting from arch/arm/*.c. Don't we want something like the kernel's LICENSES directory in order to have something the SPDX lines refer to? COPYING should maybe

[linux-linus test] 172546: regressions - FAIL

2022-08-15 Thread osstest service owner
flight 172546 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/172546/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172133

RE: [PATCH 7/7] xen/arm32: traps: Dump more information for hypervisor data abort

2022-08-15 Thread Henry Wang
Hi Julien, > -Original Message- > From: Julien Grall > Subject: Re: [PATCH 7/7] xen/arm32: traps: Dump more information for > hypervisor data abort > Hmmm... I dropped a patch from the series and it looks like I didn't > properly clean the directory before doing that. Please ignore patch

[ovmf test] 172552: regressions - FAIL

2022-08-15 Thread osstest service owner
flight 172552 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172552/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172136 build-amd64-libvirt

[PATCH v10 8/9] xen: retrieve reserved pages on populate_physmap

2022-08-15 Thread Penny Zheng
When a static domain populates memory through populate_physmap at runtime, it shall retrieve reserved pages from resv_page_list to make sure that guest RAM is still restricted in statically configured memory regions. This commit also introduces a new helper acquire_reserved_page to make it work.

[PATCH v10 7/9] xen: introduce prepare_staticmem_pages

2022-08-15 Thread Penny Zheng
Later, we want to use acquire_domstatic_pages() for populating memory for static domain on runtime, however, there are a lot of pointless work (checking mfn_valid(), scrubbing the free part, cleaning the cache...) considering we know the page is valid and belong to the guest. This commit splits

[PATCH v10 9/9] xen: rename free_staticmem_pages to unprepare_staticmem_pages

2022-08-15 Thread Penny Zheng
The name of free_staticmem_pages is inappropriate, considering it is the opposite of function prepare_staticmem_pages. Rename free_staticmem_pages to unprepare_staticmem_pages. Signed-off-by: Penny Zheng --- v10 changes: - new commit --- xen/arch/arm/setup.c| 3 ++-

[PATCH v10 6/9] xen: unpopulate memory when domain is static

2022-08-15 Thread Penny Zheng
Today when a domain unpopulates the memory on runtime, they will always hand the memory back to the heap allocator. And it will be a problem if domain is static. Pages as guest RAM for static domain shall be reserved to only this domain and not be used for any other purposes, so they shall never

[PATCH v10 5/9] xen/arm: introduce CDF_staticmem

2022-08-15 Thread Penny Zheng
In order to have an easy and quick way to find out whether this domain memory is statically configured, this commit introduces a new flag CDF_staticmem and a new helper is_domain_using_staticmem() to tell. Signed-off-by: Penny Zheng Acked-by: Julien Grall Acked-by: Jan Beulich --- v10 changes:

[PATCH v10 3/9] xen: do not merge reserved pages in free_heap_pages()

2022-08-15 Thread Penny Zheng
The code in free_heap_pages() will try to merge pages with the successor/predecessor if pages are suitably aligned. So if the pages reserved are right next to the pages given to the heap allocator, free_heap_pages() will merge them, and give the reserved pages to heap allocator accidentally as a

[PATCH v10 2/9] xen: do not free reserved memory into heap

2022-08-15 Thread Penny Zheng
Pages used as guest RAM for static domain, shall be reserved to this domain only. So in case reserved pages being used for other purpose, users shall not free them back to heap, even when last ref gets dropped. This commit introduces a new helper free_domstatic_page to free static page in

[PATCH v10 0/9] populate/unpopulate memory when domain on static allocation

2022-08-15 Thread Penny Zheng
Today when a domain unpopulates the memory on runtime, they will always hand the memory over to the heap allocator. And it will be a problem if it is a static domain. Pages used as guest RAM for static domain shall always be reserved to this domain only, and not be used for any other purposes, so

[PATCH v10 1/9] xen/arm: rename PGC_reserved to PGC_static

2022-08-15 Thread Penny Zheng
PGC_reserved could be ambiguous, and we have to tell what the pages are reserved for, so this commit intends to rename PGC_reserved to PGC_static, which clearly indicates the page is reserved for static memory. Signed-off-by: Penny Zheng Acked-by: Jan Beulich Acked-by: Julien Grall --- v10

[PATCH v10 4/9] xen: add field "flags" to cover all internal CDF_XXX

2022-08-15 Thread Penny Zheng
With more and more CDF_xxx internal flags in and to save the space, this commit introduces a new field "flags" in struct domain to store CDF_* internal flags directly. Another new CDF_xxx will be introduced in the next patch. Signed-off-by: Penny Zheng Acked-by: Julien Grall --- v10 changes: -

[xen-unstable test] 172543: tolerable FAIL - PUSHED

2022-08-15 Thread osstest service owner
flight 172543 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/172543/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1

Re: [PATCH] add SPDX to arch/arm/*.c

2022-08-15 Thread Stefano Stabellini
On Sat, 13 Aug 2022, Julien Grall wrote: > Hi Stefano, > > On 13/08/2022 01:59, Stefano Stabellini wrote: > > Add SPDX license information to all the *.c files under arch/arm. > > > > Signed-off-by: Stefano Stabellini > > --- > > > > We need to start from somewhere and I thought arch/arm/*.c

Re: [PATCH] add SPDX to arch/arm/*.c

2022-08-15 Thread Stefano Stabellini
+ Xen maintainers and committers For context, I wrote a patch to introduce SPDX tags starting from arch/arm/*.c. Julien rightfully pointed out that it should be added to our coding style. He is right. Also as I was reading his replies, I realized there are a couple of minor coding style things

[linux-5.4 test] 172538: regressions - FAIL

2022-08-15 Thread osstest service owner
flight 172538 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/172538/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172128 build-amd64-libvirt

[qemu-mainline test] 172535: regressions - FAIL

2022-08-15 Thread osstest service owner
flight 172535 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/172535/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 172123

Re: [PATCH v6 0/3] amd/msr: implement MSR_VIRT_SPEC_CTRL for HVM guests

2022-08-15 Thread Andrew Cooper
On 15/08/2022 10:14, Jan Beulich wrote: > On 15.08.2022 10:15, Andrew Cooper wrote: >> On 15/08/2022 09:01, Jan Beulich wrote: >>> On 17.05.2022 17:31, Roger Pau Monne wrote: Roger Pau Monne (3): amd/msr: implement VIRT_SPEC_CTRL for HVM guests on top of SPEC_CTRL amd/msr: allow

Re: [PATCH 0/3] x86: make pat and mtrr independent from each other

2022-08-15 Thread Chuck Zmudzinski
On 8/15/2022 2:00 PM, Thorsten Leemhuis wrote: > Hi Chuck! > > On 15.08.22 18:56, Chuck Zmudzinski wrote: > > > > I am forwarding this to you to help you cut through the noise. > > Sorry for not replying earlier, I ignored this thread and all other > non-urgent mail in the past two weeks: I was

Re: [PATCH 0/3] x86: make pat and mtrr independent from each other

2022-08-15 Thread Thorsten Leemhuis
Hi Chuck! On 15.08.22 18:56, Chuck Zmudzinski wrote: > > I am forwarding this to you to help you cut through the noise. Sorry for not replying earlier, I ignored this thread and all other non-urgent mail in the past two weeks: I was on vacation until a few days ago and when I came home I had to

Re: [PATCH 7/7] xen/arm32: traps: Dump more information for hypervisor data abort

2022-08-15 Thread Julien Grall
On 15/08/2022 17:39, Bertrand Marquis wrote: Hi Julien, Hi Bertrand, On 12 Aug 2022, at 20:24, Julien Grall wrote: From: Julien Grall Unlike arm64, on arm32 there are no extra information dumped (e.g. page table walk) for hypervisor data abort. The code in arch/arm/traps.c has

Re: [PATCH 8/8] xen/arm32: traps: Dump more information for hypervisor data abort

2022-08-15 Thread Julien Grall
Hi all, Please ignore this patch. This is a duplication of patch #7. Cheers, On 12/08/2022 20:24, Julien Grall wrote: From: Julien Grall Unlike arm64, on arm32 there are no extra information dumped (e.g. page table walk) for hypervisor data abort. For data abort, the HSR will be set

Re: [PATCH 7/7] xen/arm32: traps: Dump more information for hypervisor data abort

2022-08-15 Thread Julien Grall
On 15/08/2022 02:40, Henry Wang wrote: Hi Julien, Hi Henry, -Original Message- Subject: [PATCH 7/7] xen/arm32: traps: Dump more information for hypervisor data abort From: Julien Grall Unlike arm64, on arm32 there are no extra information dumped (e.g. page table walk) for

Re: [PATCH 5/7] xen/arm32: head: Move earlyprintk messages to .rodata.str

2022-08-15 Thread Julien Grall
Hi Jan, On 15/08/2022 09:21, Jan Beulich wrote: On 15.08.2022 10:17, Julien Grall wrote: On 15/08/2022 07:43, Jan Beulich wrote: On 12.08.2022 21:24, Julien Grall wrote: From: Julien Grall At the moment, the strings are in text right after each use because the instruction 'adr' has

Re: [PATCH 2/7] xen/arm64: head: Introduce get_table_slot() and use it

2022-08-15 Thread Julien Grall
On 15/08/2022 15:45, Bertrand Marquis wrote: Hi Julien, Hi Bertrand, On 12 Aug 2022, at 20:24, Julien Grall wrote: From: Julien Grall There are a few places in the code that need to find the slot at a given page-table level. So create a new macro get_table_slot() for that. This will

Re: [PATCH 7/7] xen/arm32: traps: Dump more information for hypervisor data abort

2022-08-15 Thread Bertrand Marquis
Hi Julien, > On 12 Aug 2022, at 20:24, Julien Grall wrote: > > From: Julien Grall > > Unlike arm64, on arm32 there are no extra information dumped (e.g. > page table walk) for hypervisor data abort. The code in arch/arm/traps.c has nothing arm32 specific like that so could you explain this

Re: [PATCH 5/7] xen/arm32: head: Move earlyprintk messages to .rodata.str

2022-08-15 Thread Bertrand Marquis
Hi Julien, > On 12 Aug 2022, at 20:24, Julien Grall wrote: > > From: Julien Grall > > At the moment, the strings are in text right after each use because > the instruction 'adr' has specific requirement on the location > and the compiler will forbid cross section label. > > The macro 'adr_l'

Re: Ryzen 6000 (Mobile)

2022-08-15 Thread Jan Beulich
On 15.08.2022 17:39, Dylanger Daly wrote: > Great news! I managed to get it to log the error with your cmdlines > > Please see the attached images > > The error "BUG: unable to handle page fault for address: c90040639019" > > It appears to be a memory violation error? Yes, there's an

Re: [PATCH 6/7] xen/arm: Tweak the dump page-table walk output

2022-08-15 Thread Bertrand Marquis
Hi Julien, > On 12 Aug 2022, at 20:24, Julien Grall wrote: > > From: Julien Grall > > Currently the output is looking like: > > (XEN) 1ST[0x1] = 0x4015ff7f > (XEN) 2ND[0x1f] = 0x0050bfe00f7d > > The content of the entries are not aligned making a bit trickier to > read (I

Re: [PATCH 0/3] x86: make pat and mtrr independent from each other

2022-08-15 Thread Chuck Zmudzinski
On 8/14/2022 9:01 AM, Greg KH wrote: > On Sun, Aug 14, 2022 at 08:08:30AM -0400, Chuck Zmudzinski wrote: > > On 8/14/2022 5:50 AM, Greg KH wrote: > > > On Sun, Aug 14, 2022 at 05:19:12AM -0400, Chuck Zmudzinski wrote: > > > > Well, that did not take long. Juergen responded with a message, > > > >

Re: [PATCH 4/7] xen/arm32: heap: Rework adr_l so it doesn't rely on where Xen is loaded

2022-08-15 Thread Bertrand Marquis
Hi Julien, > On 12 Aug 2022, at 20:24, Julien Grall wrote: > > From: Julien Grall > > At the moment, the macro addr_l needs to know whether the caller > is running with the MMU on. This is fine today because there are > only two possible cases: > 1) MMU off > 2) MMU on and linked to the

Re: [PATCH] x86: rework hypercall argument count table instantiation & use

2022-08-15 Thread Juergen Gross
On 15.08.22 17:20, Jan Beulich wrote: On 15.08.2022 17:13, Juergen Gross wrote: On 27.07.22 18:00, Jan Beulich wrote: The initial observation were duplicate symbols that our checking warns about. Instead of merely renaming one or both pair(s) of symbols, reduce #ifdef-ary at the same time by

Re: [PATCH v2 03/13] cpufreq: Export intel_feature_detect

2022-08-15 Thread Jan Beulich
On 15.08.2022 16:58, Jason Andryuk wrote: > On Mon, Aug 15, 2022 at 10:34 AM Jan Beulich wrote: >> >> On 10.08.2022 21:29, Jason Andryuk wrote: >>> Export feature_detect as intel_feature_detect so it can be re-used by >>> HWP. >>> >>> Signed-off-by: Jason Andryuk >>> --- >>> v2 >>> export

Re: [PATCH] x86: rework hypercall argument count table instantiation & use

2022-08-15 Thread Jan Beulich
On 15.08.2022 17:13, Juergen Gross wrote: > On 27.07.22 18:00, Jan Beulich wrote: >> The initial observation were duplicate symbols that our checking warns >> about. Instead of merely renaming one or both pair(s) of symbols, >> reduce #ifdef-ary at the same time by moving the instantiation of the

[ovmf test] 172544: regressions - FAIL

2022-08-15 Thread osstest service owner
flight 172544 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172544/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172136 build-amd64-libvirt

Re: [PATCH] x86: rework hypercall argument count table instantiation & use

2022-08-15 Thread Juergen Gross
On 27.07.22 18:00, Jan Beulich wrote: The initial observation were duplicate symbols that our checking warns about. Instead of merely renaming one or both pair(s) of symbols, reduce #ifdef-ary at the same time by moving the instantiation of the arrays into macros (a native and a 32-bit one each,

Re: [PATCH v2 03/13] cpufreq: Export intel_feature_detect

2022-08-15 Thread Jason Andryuk
On Mon, Aug 15, 2022 at 10:34 AM Jan Beulich wrote: > > On 10.08.2022 21:29, Jason Andryuk wrote: > > Export feature_detect as intel_feature_detect so it can be re-used by > > HWP. > > > > Signed-off-by: Jason Andryuk > > --- > > v2 > > export intel_feature_detect with typed pointer > > Move

Re: [PATCH 3/7] xen/arm32: head: Introduce get_table_slot() and use it

2022-08-15 Thread Bertrand Marquis
Hi Julien, > On 12 Aug 2022, at 20:24, Julien Grall wrote: > > From: Julien Grall > > There are a few places in the code that need to find the slot at a > given page-table level. > > So create a new macro get_table_slot() for that. This will reduce > the effort to figure out whether the code

[libvirt test] 172532: regressions - FAIL

2022-08-15 Thread osstest service owner
flight 172532 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/172532/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-armhf-libvirt

Re: [PATCH v2 01/13] cpufreq: Allow restricting to internal governors only

2022-08-15 Thread Jason Andryuk
On Mon, Aug 15, 2022 at 10:22 AM Jan Beulich wrote: > > On 10.08.2022 21:29, Jason Andryuk wrote: > > For hwp, the standard governors are not usable, and only the internal > > one is applicable. Add the cpufreq_governor_internal boolean to > > indicate when an internal governor, like

Re: [PATCH 2/7] xen/arm64: head: Introduce get_table_slot() and use it

2022-08-15 Thread Bertrand Marquis
Hi Julien, > On 12 Aug 2022, at 20:24, Julien Grall wrote: > > From: Julien Grall > > There are a few places in the code that need to find the slot > at a given page-table level. > > So create a new macro get_table_slot() for that. This will reduce > the effort to figure out whether the code

Re: [PATCH v2 03/13] cpufreq: Export intel_feature_detect

2022-08-15 Thread Jan Beulich
On 10.08.2022 21:29, Jason Andryuk wrote: > Export feature_detect as intel_feature_detect so it can be re-used by > HWP. > > Signed-off-by: Jason Andryuk > --- > v2 > export intel_feature_detect with typed pointer > Move intel_feature_detect to acpi/cpufreq/cpufreq.h since the > declaration now

Re: [PATCH v2 02/13] cpufreq: Add perf_freq to cpuinfo

2022-08-15 Thread Jan Beulich
On 10.08.2022 21:29, Jason Andryuk wrote: > acpi-cpufreq scales the aperf/mperf measurements by max_freq, but HWP > needs to scale by base frequency. Settings max_freq to base_freq > "works" but the code is not obvious, and returning values to userspace > is tricky. Add an additonal perf_freq

Re: [PATCH v2 2/3] xen/sched: carve out memory allocation and freeing from schedule_cpu_rm()

2022-08-15 Thread Juergen Gross
On 15.08.22 14:47, Juergen Gross wrote: On 15.08.22 14:34, Jan Beulich wrote: On 15.08.2022 14:16, Juergen Gross wrote: On 15.08.22 14:00, Jan Beulich wrote: On 15.08.2022 13:55, Juergen Gross wrote: On 15.08.22 13:52, Jan Beulich wrote: On 15.08.2022 13:04, Juergen Gross wrote: ---

Re: [PATCH v2 01/13] cpufreq: Allow restricting to internal governors only

2022-08-15 Thread Jan Beulich
On 10.08.2022 21:29, Jason Andryuk wrote: > For hwp, the standard governors are not usable, and only the internal > one is applicable. Add the cpufreq_governor_internal boolean to > indicate when an internal governor, like hwp-internal, will be used. > This is set during presmp_initcall, so that

Re: [PATCH 1/7] xen/arm64: head: Don't set x22 and update the documentation

2022-08-15 Thread Bertrand Marquis
Hi Julien, > On 12 Aug 2022, at 20:24, Julien Grall wrote: > > From: Julien Grall > > Since commit 7e14a47e7c73 ("xen/arm64: head Rework and document > launch()"), the boot code is setting x22 but not read it. > > So remove the two instructions setting x22 and update the documentation > to

[linux-linus test] 172531: regressions - FAIL

2022-08-15 Thread osstest service owner
flight 172531 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/172531/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172133

Re: [PATCH v4 06/11] IOMMU: add common API for device reserved memory

2022-08-15 Thread Jan Beulich
On 13.08.2022 03:38, Marek Marczykowski-Górecki wrote: > --- a/xen/drivers/passthrough/iommu.c > +++ b/xen/drivers/passthrough/iommu.c > @@ -669,6 +669,51 @@ bool_t iommu_has_feature(struct domain *d, enum > iommu_feature feature) > return is_iommu_enabled(d) && test_bit(feature,

Re: [PATCH v4 04/11] drivers/char: make serial_parse_handle take const argument

2022-08-15 Thread Jan Beulich
On 13.08.2022 03:38, Marek Marczykowski-Górecki wrote: > It doesn't modify it, and it will be necessary in a subsequent patch. > > Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Jan Beulich

[xen-unstable-smoke test] 172542: tolerable FAIL - PUSHED

2022-08-15 Thread osstest service owner
flight 172542 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/172542/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a build-amd64-libvirt 6

Re: [PATCH v4 01/11] drivers/char: Add support for USB3 DbC debugger

2022-08-15 Thread Jan Beulich
On 13.08.2022 03:38, Marek Marczykowski-Górecki wrote: > From: Connor Davis > > [Connor] > Xue is a cross-platform USB 3 debugger that drives the Debug > Capability (DbC) of xHCI-compliant host controllers. This patch > implements the operations needed for xue to initialize the host >

Re: [PATCH v2 2/3] xen/sched: carve out memory allocation and freeing from schedule_cpu_rm()

2022-08-15 Thread Juergen Gross
On 15.08.22 14:34, Jan Beulich wrote: On 15.08.2022 14:16, Juergen Gross wrote: On 15.08.22 14:00, Jan Beulich wrote: On 15.08.2022 13:55, Juergen Gross wrote: On 15.08.22 13:52, Jan Beulich wrote: On 15.08.2022 13:04, Juergen Gross wrote: --- a/xen/common/sched/core.c +++

Re: [PATCH v2 2/3] xen/sched: carve out memory allocation and freeing from schedule_cpu_rm()

2022-08-15 Thread Jan Beulich
On 15.08.2022 14:16, Juergen Gross wrote: > On 15.08.22 14:00, Jan Beulich wrote: >> On 15.08.2022 13:55, Juergen Gross wrote: >>> On 15.08.22 13:52, Jan Beulich wrote: On 15.08.2022 13:04, Juergen Gross wrote: > --- a/xen/common/sched/core.c > +++ b/xen/common/sched/core.c > @@

Re: [PATCH v2 3/3] xen/sched: fix cpu hotplug

2022-08-15 Thread Jan Beulich
On 15.08.2022 13:04, Juergen Gross wrote: > Cpu cpu unplugging is calling schedule_cpu_rm() via stop_machine_run() > with interrupts disabled, thus any memory allocation or freeing must > be avoided. > > Since commit 5047cd1d5dea ("xen/common: Use enhanced > ASSERT_ALLOC_CONTEXT in xmalloc()")

Re: [PATCH v2 2/3] xen/sched: carve out memory allocation and freeing from schedule_cpu_rm()

2022-08-15 Thread Juergen Gross
On 15.08.22 14:00, Jan Beulich wrote: On 15.08.2022 13:55, Juergen Gross wrote: On 15.08.22 13:52, Jan Beulich wrote: On 15.08.2022 13:04, Juergen Gross wrote: --- a/xen/common/sched/core.c +++ b/xen/common/sched/core.c @@ -3237,6 +3237,65 @@ out: return ret; } +static struct

[ovmf test] 172540: regressions - FAIL

2022-08-15 Thread osstest service owner
flight 172540 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172540/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172136 build-amd64-libvirt

Re: [PATCH v2 1/3] xen/sched: introduce cpupool_update_node_affinity()

2022-08-15 Thread Jan Beulich
On 15.08.2022 13:58, Juergen Gross wrote: > On 15.08.22 13:41, Jan Beulich wrote: >> On 15.08.2022 13:04, Juergen Gross wrote: >>> For updating the node affinities of all domains in a cpupool add a new >>> function cpupool_update_node_affinity(). >>> >>> In order to avoid multiple allocations of

Re: [PATCH v2 2/3] xen/sched: carve out memory allocation and freeing from schedule_cpu_rm()

2022-08-15 Thread Jan Beulich
On 15.08.2022 13:55, Juergen Gross wrote: > On 15.08.22 13:52, Jan Beulich wrote: >> On 15.08.2022 13:04, Juergen Gross wrote: >>> --- a/xen/common/sched/core.c >>> +++ b/xen/common/sched/core.c >>> @@ -3237,6 +3237,65 @@ out: >>> return ret; >>> } >>> >>> +static struct cpu_rm_data

Re: [PATCH v2 1/3] xen/sched: introduce cpupool_update_node_affinity()

2022-08-15 Thread Juergen Gross
On 15.08.22 13:41, Jan Beulich wrote: On 15.08.2022 13:04, Juergen Gross wrote: For updating the node affinities of all domains in a cpupool add a new function cpupool_update_node_affinity(). In order to avoid multiple allocations of cpumasks carve out memory allocation and freeing from

Re: [PATCH v2 2/3] xen/sched: carve out memory allocation and freeing from schedule_cpu_rm()

2022-08-15 Thread Juergen Gross
On 15.08.22 13:52, Jan Beulich wrote: On 15.08.2022 13:04, Juergen Gross wrote: --- a/xen/common/sched/core.c +++ b/xen/common/sched/core.c @@ -3237,6 +3237,65 @@ out: return ret; } +static struct cpu_rm_data *schedule_cpu_rm_alloc(unsigned int cpu) +{ +struct cpu_rm_data *data;

Re: Ryzen 6000 (Mobile)

2022-08-15 Thread Jan Beulich
On 15.08.2022 13:50, Dylanger Daly wrote: > Indeed adding noreboot does result in the device just hanging there after > starting a VM. > > I wonder if it's possible to have Xen write out it's log to some memory > address, hoping it's doing a warm reset the log messages should still be >

Re: [PATCH v2 2/3] xen/sched: carve out memory allocation and freeing from schedule_cpu_rm()

2022-08-15 Thread Jan Beulich
On 15.08.2022 13:04, Juergen Gross wrote: > --- a/xen/common/sched/core.c > +++ b/xen/common/sched/core.c > @@ -3237,6 +3237,65 @@ out: > return ret; > } > > +static struct cpu_rm_data *schedule_cpu_rm_alloc(unsigned int cpu) > +{ > +struct cpu_rm_data *data; > +const struct

Re: Ryzen 6000 (Mobile)

2022-08-15 Thread Dylanger Daly
Hi Jan, Indeed adding noreboot does result in the device just hanging there after starting a VM. I wonder if it's possible to have Xen write out it's log to some memory address, hoping it's doing a warm reset the log messages should still be present. Cheers

Re: [PATCH v2 1/3] xen/sched: introduce cpupool_update_node_affinity()

2022-08-15 Thread Jan Beulich
On 15.08.2022 13:04, Juergen Gross wrote: > For updating the node affinities of all domains in a cpupool add a new > function cpupool_update_node_affinity(). > > In order to avoid multiple allocations of cpumasks carve out memory > allocation and freeing from domain_update_node_affinity() into

Re: [XEN PATCH v4 21/32] tools: Remove -Werror everywhere else

2022-08-15 Thread Daniel P. Smith
On 8/11/22 12:48, Anthony PERARD wrote: Patch "tools: Add -Werror by default to all tools/" have added "-Werror" to CFLAGS in tools/Rules.mk, remove it from every other makefiles as it is now duplicated. Signed-off-by: Anthony PERARD Acked-by: Christian Lindig ---

Re: [XEN PATCH v4 11/32] tools/flask/utils: list build targets in $(TARGETS)

2022-08-15 Thread Daniel P. Smith
On 8/11/22 12:48, Anthony PERARD wrote: Signed-off-by: Anthony PERARD Reviewed-by: Henry Wang --- tools/flask/utils/Makefile | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/flask/utils/Makefile b/tools/flask/utils/Makefile index db567b13dc..6be134142a

Re: Ryzen 6000 (Mobile)

2022-08-15 Thread Jan Beulich
On 15.08.2022 13:07, Dylanger Daly wrote: > It would appear this issue isn't specific to the Lenovo Yoga Slim 7 ProX, > someone else in the Qubes community is having the same issue > (https://github.com/QubesOS/qubes-issues/issues/7620#issuecomment-1209114810) > > Can anyone shed some light on

Re: Ryzen 6000 (Mobile)

2022-08-15 Thread Dylanger Daly
Hi All, It would appear this issue isn't specific to the Lenovo Yoga Slim 7 ProX, someone else in the Qubes community is having the same issue (https://github.com/QubesOS/qubes-issues/issues/7620#issuecomment-1209114810) Can anyone shed some light on what possibly might be making a Xen 4.14

[PATCH v2 2/3] xen/sched: carve out memory allocation and freeing from schedule_cpu_rm()

2022-08-15 Thread Juergen Gross
In order to prepare not allocating or freeing memory from schedule_cpu_rm(), move this functionality to dedicated functions. For now call those functions from schedule_cpu_rm(). No change of behavior expected. Signed-off-by: Juergen Gross --- V2: - add const (Jan Beulich) - use "unsigned int"

[PATCH v2 0/3] xen/sched: fix cpu hotplug

2022-08-15 Thread Juergen Gross
A recent change in the hypervisor memory allocation framework led to crashes when unplugging host cpus. This was due to the (correct) assertion that allocating and freeing memory is allowed with enabled interrupts only. As the main cpu unplug operation is done in stop-machine context, this

[PATCH v2 1/3] xen/sched: introduce cpupool_update_node_affinity()

2022-08-15 Thread Juergen Gross
For updating the node affinities of all domains in a cpupool add a new function cpupool_update_node_affinity(). In order to avoid multiple allocations of cpumasks carve out memory allocation and freeing from domain_update_node_affinity() into new helpers, which can be used by

[PATCH v2 3/3] xen/sched: fix cpu hotplug

2022-08-15 Thread Juergen Gross
Cpu cpu unplugging is calling schedule_cpu_rm() via stop_machine_run() with interrupts disabled, thus any memory allocation or freeing must be avoided. Since commit 5047cd1d5dea ("xen/common: Use enhanced ASSERT_ALLOC_CONTEXT in xmalloc()") this restriction is being enforced via an assertion,

[xen-unstable-smoke test] 172536: tolerable FAIL - PUSHED

2022-08-15 Thread osstest service owner
flight 172536 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/172536/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a build-amd64-libvirt 6

[xen-unstable test] 172529: tolerable FAIL

2022-08-15 Thread osstest service owner
flight 172529 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/172529/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-examine 6 xen-install fail in 172502 pass in 172529 test-arm64-arm64-xl-seattle 8

Re: [PATCH] x86/spec-ctrl: Use IST RSB protection for !SVM systems

2022-08-15 Thread Jan Beulich
On 15.08.2022 11:33, Andrew Cooper wrote: > On 15/08/2022 09:26, Jan Beulich wrote: >> On 05.08.2022 12:38, Andrew Cooper wrote: >>> --- a/xen/arch/x86/spec_ctrl.c >>> +++ b/xen/arch/x86/spec_ctrl.c >>> @@ -1327,8 +1327,24 @@ void __init init_speculation_mitigations(void) >>> * mappings. >>>

Re: [PATCH] x86/spec-ctrl: Use IST RSB protection for !SVM systems

2022-08-15 Thread Andrew Cooper
On 15/08/2022 09:26, Jan Beulich wrote: > On 05.08.2022 12:38, Andrew Cooper wrote: >> --- a/xen/arch/x86/spec_ctrl.c >> +++ b/xen/arch/x86/spec_ctrl.c >> @@ -1327,8 +1327,24 @@ void __init init_speculation_mitigations(void) >> * mappings. >> */ >> if ( opt_rsb_hvm ) >> +{ >>

[ovmf test] 172537: regressions - FAIL

2022-08-15 Thread osstest service owner
flight 172537 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172537/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172136 build-amd64-libvirt

Re: [PATCH v6 0/3] amd/msr: implement MSR_VIRT_SPEC_CTRL for HVM guests

2022-08-15 Thread Jan Beulich
On 15.08.2022 10:15, Andrew Cooper wrote: > On 15/08/2022 09:01, Jan Beulich wrote: >> On 17.05.2022 17:31, Roger Pau Monne wrote: >>> Roger Pau Monne (3): >>> amd/msr: implement VIRT_SPEC_CTRL for HVM guests on top of SPEC_CTRL >>> amd/msr: allow passthrough of VIRT_SPEC_CTRL for HVM guests

RE: Xen 4.17: Current status of series floating in ML

2022-08-15 Thread Henry Wang
Hi Julien, > -Original Message- > From: Julien Grall > Subject: Re: Xen 4.17: Current status of series floating in ML > >>> ** Blocker List **: > >>> 2. tools/xenstore: add some new features to the documentation > >>> https://patchwork.kernel.org/project/xen-devel/list/?series=665064 >

Re: Xen 4.17: Current status of series floating in ML

2022-08-15 Thread Julien Grall
On 15/08/2022 09:21, Henry Wang wrote: -Original Message- From: Julien Grall Subject: Re: Xen 4.17: Current status of series floating in ML On 15/08/2022 06:46, Henry Wang wrote: Hi all, Hi Henry, Thanks for the list! No problem, always feel good if this can help the community.

Re: [PATCH] x86/spec-ctrl: Use IST RSB protection for !SVM systems

2022-08-15 Thread Jan Beulich
On 05.08.2022 12:38, Andrew Cooper wrote: > --- a/xen/arch/x86/spec_ctrl.c > +++ b/xen/arch/x86/spec_ctrl.c > @@ -1327,8 +1327,24 @@ void __init init_speculation_mitigations(void) > * mappings. > */ > if ( opt_rsb_hvm ) > +{ >

Re: [PATCH 5/7] xen/arm32: head: Move earlyprintk messages to .rodata.str

2022-08-15 Thread Jan Beulich
On 15.08.2022 10:17, Julien Grall wrote: > On 15/08/2022 07:43, Jan Beulich wrote: >> On 12.08.2022 21:24, Julien Grall wrote: >>> From: Julien Grall >>> >>> At the moment, the strings are in text right after each use because >>> the instruction 'adr' has specific requirement on the location >>>

RE: Xen 4.17: Current status of series floating in ML

2022-08-15 Thread Henry Wang
Hi Julien, > -Original Message- > From: Julien Grall > Subject: Re: Xen 4.17: Current status of series floating in ML > On 15/08/2022 06:46, Henry Wang wrote: > > Hi all, > > Hi Henry, > > Thanks for the list! No problem, always feel good if this can help the community. > > **

Re: [PATCH 5/7] xen/arm32: head: Move earlyprintk messages to .rodata.str

2022-08-15 Thread Julien Grall
Hi Jan, On 15/08/2022 07:43, Jan Beulich wrote: On 12.08.2022 21:24, Julien Grall wrote: From: Julien Grall At the moment, the strings are in text right after each use because the instruction 'adr' has specific requirement on the location and the compiler will forbid cross section label.

Re: [PATCH v6 0/3] amd/msr: implement MSR_VIRT_SPEC_CTRL for HVM guests

2022-08-15 Thread Andrew Cooper
On 15/08/2022 09:01, Jan Beulich wrote: > On 17.05.2022 17:31, Roger Pau Monne wrote: >> Roger Pau Monne (3): >> amd/msr: implement VIRT_SPEC_CTRL for HVM guests on top of SPEC_CTRL >> amd/msr: allow passthrough of VIRT_SPEC_CTRL for HVM guests >> amd/msr: implement VIRT_SPEC_CTRL for HVM

Re: Xen 4.17: Current status of series floating in ML

2022-08-15 Thread Julien Grall
On 15/08/2022 06:46, Henry Wang wrote: Hi all, Hi Henry, Thanks for the list! ** Blocker List **: 1. Patch: x86: enable interrupts around dump_execstate() https://patchwork.kernel.org/project/xen-devel/patch/e717897f-980d-ad44-31d9-39f5e7e1c...@suse.com/ Status: Waiting for review. 2.

[linux-5.4 test] 172524: regressions - FAIL

2022-08-15 Thread osstest service owner
flight 172524 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/172524/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172128 build-amd64-libvirt

Re: [PATCH v6 0/3] amd/msr: implement MSR_VIRT_SPEC_CTRL for HVM guests

2022-08-15 Thread Jan Beulich
On 17.05.2022 17:31, Roger Pau Monne wrote: > Roger Pau Monne (3): > amd/msr: implement VIRT_SPEC_CTRL for HVM guests on top of SPEC_CTRL > amd/msr: allow passthrough of VIRT_SPEC_CTRL for HVM guests > amd/msr: implement VIRT_SPEC_CTRL for HVM guests using legacy SSBD I came to realize that

RE: Xen 4.17: Current status of series floating in ML

2022-08-15 Thread Henry Wang
Hi Jan, Thanks for your patience and detailed review of the list. > -Original Message- > From: Jan Beulich > Subject: Re: Xen 4.17: Current status of series floating in ML > > On 15.08.2022 07:46, Henry Wang wrote: > > 11. vpci: first series in preparation for vpci on ARM > >

Re: Xen 4.17: Current status of series floating in ML

2022-08-15 Thread Jan Beulich
On 15.08.2022 07:46, Henry Wang wrote: > 11. vpci: first series in preparation for vpci on ARM > https://patchwork.kernel.org/project/xen-devel/list/?series=660828 > Status: Patch #1 needs actions from author. Patch #2 #3 need review. It's more than just review. I've expressed elsewhere that I'm

[ovmf test] 172533: regressions - FAIL

2022-08-15 Thread osstest service owner
flight 172533 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172533/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172136 build-amd64-libvirt

Re: [PATCH] x86/traps: Make nmi_show_execution_state() more useful

2022-08-15 Thread Jan Beulich
On 12.08.2022 19:33, Andrew Cooper wrote: > * Always emit current. It's critically important. I agree it may be relevant, yet I'm not convinced of "critically". But anyway. > --- a/xen/arch/x86/traps.c > +++ b/xen/arch/x86/traps.c > @@ -768,8 +768,14 @@ static int cf_check

Re: [XEN PATCH v4 00/32] Toolstack build system improvement, toward non-recursive makefiles

2022-08-15 Thread Jan Beulich
On 11.08.2022 18:48, Anthony PERARD wrote: > Patch series available in this git branch: > https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git > br.toolstack-build-system-v4 > > Changes in v4: > - several new patches > - some changes to other patches listed in their changelogs I've

Re: [PATCH 5/7] xen/arm32: head: Move earlyprintk messages to .rodata.str

2022-08-15 Thread Jan Beulich
On 12.08.2022 21:24, Julien Grall wrote: > From: Julien Grall > > At the moment, the strings are in text right after each use because > the instruction 'adr' has specific requirement on the location > and the compiler will forbid cross section label. > > The macro 'adr_l' was recently reworked

[qemu-mainline test] 172527: regressions - FAIL

2022-08-15 Thread osstest service owner
flight 172527 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/172527/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 172123