[xen-unstable test] 186634: tolerable FAIL - PUSHED

2024-07-02 Thread osstest service owner
flight 186634 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/186634/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 186628

[ovmf test] 186636: all pass - PUSHED

2024-07-02 Thread osstest service owner
flight 186636 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/186636/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 4f174696fd8fbd9cc29c9f172e8e83fe6da5b070 baseline version: ovmf

[linux-linus test] 186633: regressions - FAIL

2024-07-02 Thread osstest service owner
flight 186633 linux-linus real [real] flight 186635 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/186633/ http://logs.test-lab.xenproject.org/osstest/logs/186635/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be

[PATCH v4] xen/riscv: PE/COFF image header for RISC-V target

2024-07-02 Thread Milan Djokic
Added riscv image header to enable boot from second stage bootloaders (e.g. uboot. Image header defined in riscv-image-header.h) Additionally, RISC-V xen image is extended with PE/COFF headers, introducing EFI application format. PE/COFF header is optionally included (with CONFIG_RISCV_EFI) so

[PULL v2 88/88] hw/pci: Replace -1 with UINT32_MAX for romsize

2024-07-02 Thread Michael S. Tsirkin
From: Akihiko Odaki romsize is an uint32_t variable. Specifying -1 as an uint32_t value is obscure way to denote UINT32_MAX. Worse, if int is wider than 32-bit, it will change the behavior of a construct like the following: romsize = -1; if (romsize != -1) { ... } When -1 is assigned to

[xen-unstable test] 186628: tolerable FAIL

2024-07-02 Thread osstest service owner
flight 186628 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/186628/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 186622

[ovmf test] 186632: all pass - PUSHED

2024-07-02 Thread osstest service owner
flight 186632 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/186632/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 6b256cef01825fd597ce31ec9343ea280c6114c9 baseline version: ovmf

[linux-linus test] 186626: regressions - FAIL

2024-07-02 Thread osstest service owner
flight 186626 linux-linus real [real] flight 186631 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/186626/ http://logs.test-lab.xenproject.org/osstest/logs/186631/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be

[no subject]

2024-07-02 Thread Milan Djokic
Date: Tue, 2 Jul 2024 16:17:22 +0200 Subject: [PATCH v3] xen/riscv: PE/COFF image header for RISC-V target Added riscv image header to enable boot from second stage bootloaders (e.g. uboot. Image header defined in riscv-image-header.h) Additionally, RISC-V xen image is extended with PE/COFF

[xen-unstable-smoke test] 186629: tolerable all pass - PUSHED

2024-07-02 Thread osstest service owner
flight 186629 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/186629/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [PATCH v14 8/9] xen/riscv: introduce ANDN_INSN

2024-07-02 Thread Jan Beulich
On 02.07.2024 17:51, Oleksii wrote: > On Tue, 2024-07-02 at 14:08 +0200, Jan Beulich wrote: >>> --- a/xen/arch/riscv/include/asm/cmpxchg.h >>> +++ b/xen/arch/riscv/include/asm/cmpxchg.h >>> @@ -18,6 +18,19 @@ >>>   : "r" (new) \ >>>   : "memory" ); >>>   >>> +/* >>> + * To not

Re: [PATCH v14 8/9] xen/riscv: introduce ANDN_INSN

2024-07-02 Thread Oleksii
On Tue, 2024-07-02 at 14:08 +0200, Jan Beulich wrote: > > --- a/xen/arch/riscv/include/asm/cmpxchg.h > > +++ b/xen/arch/riscv/include/asm/cmpxchg.h > > @@ -18,6 +18,19 @@ > >   : "r" (new) \ > >   : "memory" ); > >   > > +/* > > + * To not face an issue that gas doesn't understand

Re: [PATCH for-4.19] xen: Fix XEN_EXTRAVERSION after 4.19-rc1

2024-07-02 Thread Oleksii
On Tue, 2024-07-02 at 15:15 +0100, Andrew Cooper wrote: > On 02/07/2024 3:14 pm, Jan Beulich wrote: > > On 02.07.2024 15:43, Andrew Cooper wrote: > > > EXTRAVERSION needs a . separator for numbers. > > Not exactly. It needs the 0 dropped, if we follow what we've done > > in the > > past. Then ...

[ovmf test] 186630: all pass - PUSHED

2024-07-02 Thread osstest service owner
flight 186630 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/186630/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf b2216427ca7b0d31a36616e2876d362629de926d baseline version: ovmf

Re: [PATCH] xen-blkfront: fix sector_size propagation to the block layer

2024-07-02 Thread Jens Axboe
On Tue, 25 Jun 2024 07:52:38 +0200, Christoph Hellwig wrote: > Ensure that info->sector_size and info->physical_sector_size are set > before the call to blkif_set_queue_limits by doing away with the > local variables and arguments that propagate them. > > Thanks to Marek Marczykowski-Górecki

Re: [PATCH v14 1/9] xen: introduce generic non-atomic test_*bit()

2024-07-02 Thread Jan Beulich
On 02.07.2024 15:11, Michal Orzel wrote: > Hi Oleksii, > > On 02/07/2024 13:01, Oleksii Kurochko wrote: >> >> >> The following generic functions were introduced: >> * test_bit >> * generic__test_and_set_bit >> * generic__test_and_clear_bit >> * generic__test_and_change_bit >> >> These functions

Re: [PATCH for-4.19] xen: Fix XEN_EXTRAVERSION after 4.19-rc1

2024-07-02 Thread Andrew Cooper
On 02/07/2024 3:14 pm, Jan Beulich wrote: > On 02.07.2024 15:43, Andrew Cooper wrote: >> EXTRAVERSION needs a . separator for numbers. > Not exactly. It needs the 0 dropped, if we follow what we've done in the > past. Then ... > >> Currently, the banner reports: >> >> __ ___ _

Re: [PATCH for-4.19] xen: Fix XEN_EXTRAVERSION after 4.19-rc1

2024-07-02 Thread Jan Beulich
On 02.07.2024 15:43, Andrew Cooper wrote: > EXTRAVERSION needs a . separator for numbers. Not exactly. It needs the 0 dropped, if we follow what we've done in the past. Then ... > Currently, the banner reports: > > __ ___ __ ___ ___ > \ \/ /___ _ __ | || | / |/ _ \

[PULL 91/91] hw/pci: Replace -1 with UINT32_MAX for romsize

2024-07-02 Thread Michael S. Tsirkin
From: Akihiko Odaki romsize is an uint32_t variable. Specifying -1 as an uint32_t value is obscure way to denote UINT32_MAX. Worse, if int is wider than 32-bit, it will change the behavior of a construct like the following: romsize = -1; if (romsize != -1) { ... } When -1 is assigned to

Re: [PATCH for-4.19] xen: Fix XEN_EXTRAVERSION after 4.19-rc1

2024-07-02 Thread Andrew Cooper
I forgot the for-4.19 in the subject. Hopefully it's obvious why... ~Andrew On 02/07/2024 2:43 pm, Andrew Cooper wrote: > EXTRAVERSION needs a . separator for numbers. Currently, the banner reports: > > __ ___ __ ___ ___ > \ \/ /___ _ __ | || | / |/ _ \ / _ \_

[PATCH] xen: Fix XEN_EXTRAVERSION after 4.19-rc1

2024-07-02 Thread Andrew Cooper
EXTRAVERSION needs a . separator for numbers. Currently, the banner reports: __ ___ __ ___ ___ \ \/ /___ _ __ | || | / |/ _ \ / _ \_ __ ___ \ // _ \ '_ \ | || |_ | | (_) | | | |__| '__/ __| / \ __/ | | | |__ _|| |\__, | |_| |__| | | (__ /_/\_\___|_|

Re: [PATCH v1] automation: add findutils to suse images

2024-07-02 Thread Andrew Cooper
On 02/07/2024 11:11 am, Olaf Hering wrote: > Tue, 2 Jul 2024 11:02:00 +0100 Andrew Cooper : > >> This patch is about keeping Gitlab CI running smoothly.  It's not >> related to Xen 4.19, except by chance. > It seems the automation/build directory needs to be purged from > non-staging branches, to

Re: [PATCH v14 1/9] xen: introduce generic non-atomic test_*bit()

2024-07-02 Thread Michal Orzel
Hi Oleksii, On 02/07/2024 13:01, Oleksii Kurochko wrote: > > > The following generic functions were introduced: > * test_bit > * generic__test_and_set_bit > * generic__test_and_clear_bit > * generic__test_and_change_bit > > These functions and macros can be useful for architectures > that

[PATCH for-4.19?] xen/vmap: Document the vmap header

2024-07-02 Thread Alejandro Vallejo
In it's current form it's rather cryptic for uninitiated, so this patch documents everything in there to make it more palatable. No functional change. Signed-off-by: Alejandro Vallejo --- xen/include/xen/vmap.h | 100 + 1 file changed, 100 insertions(+)

Re: [PATCH v14 8/9] xen/riscv: introduce ANDN_INSN

2024-07-02 Thread Jan Beulich
On 02.07.2024 13:01, Oleksii Kurochko wrote: > RISC-V does a conditional toolchain for the Zbb extension > (xen/arch/riscv/rules.mk), but unconditionally uses the > ANDN instruction in emulate_xchg_1_2(). > > Fixes: 51dabd6312c ("xen/riscv: introduce cmpxchg.h") > > Suggested-by: Andrew Cooper

Re: [XEN PATCH v2] tools/misc: xen-hvmcrash: Inject #DF instead of overwriting RIP

2024-07-02 Thread Andrew Cooper
On 01/07/2024 3:47 pm, Matthew Barnes wrote: > diff --git a/tools/misc/xen-hvmcrash.c b/tools/misc/xen-hvmcrash.c > index 1d058fa40a47..efa47c9dfec8 100644 > --- a/tools/misc/xen-hvmcrash.c > +++ b/tools/misc/xen-hvmcrash.c > @@ -77,65 +66,22 @@ main(int argc, char **argv) > exit(1); >

Re: [PATCH v14 7/9] xen/riscv: use .insn with operands to support the older gas

2024-07-02 Thread Jan Beulich
On 02.07.2024 13:01, Oleksii Kurochko wrote: > Support for specifying "raw" insns was added only in 2.38. > To support older version it would be better switch to .insn > with operands. > > The following compilation error occurs: > ./arch/riscv/include/asm/processor.h: Assembler messages: >

[xen-unstable-smoke test] 186627: tolerable all pass - PUSHED

2024-07-02 Thread osstest service owner
flight 186627 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/186627/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

[PATCH v9 5/5] xen/riscv: test basic handling stuff

2024-07-02 Thread Oleksii Kurochko
Signed-off-by: Oleksii Kurochko Acked-by: Alistair Francis --- xen/arch/riscv/setup.c | 16 1 file changed, 16 insertions(+) diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c index a6a29a1508..4f06203b46 100644 --- a/xen/arch/riscv/setup.c +++

[PATCH v9 3/5] xen/riscv: introduce trap_init()

2024-07-02 Thread Oleksii Kurochko
Signed-off-by: Oleksii Kurochko Reviewed-by: Alistair Francis --- xen/arch/riscv/include/asm/traps.h | 1 + xen/arch/riscv/setup.c | 3 +++ xen/arch/riscv/traps.c | 12 3 files changed, 16 insertions(+) diff --git a/xen/arch/riscv/include/asm/traps.h

[PATCH v9 1/5] xen/riscv: use printk() instead of early_printk()

2024-07-02 Thread Oleksii Kurochko
As common code is available it is better to use printk() instead of early_printk(). Also the printing of "Hello from RISC-V world" is dropped as it is useless and "All set up is enough". Signed-off-by: Oleksii Kurochko --- xen/arch/riscv/setup.c | 4 +--- 1 file changed, 1 insertion(+), 3

[PATCH v9 2/5] xen/riscv: introduce decode_cause() stuff

2024-07-02 Thread Oleksii Kurochko
The patch introduces stuff needed to decode a reason of an exception. Signed-off-by: Oleksii Kurochko Acked-by: Alistair Francis --- xen/arch/riscv/traps.c | 80 +- 1 file changed, 79 insertions(+), 1 deletion(-) diff --git a/xen/arch/riscv/traps.c

[PATCH v9 4/5] xen/riscv: enable GENERIC_BUG_FRAME

2024-07-02 Thread Oleksii Kurochko
Signed-off-by: Oleksii Kurochko --- xen/arch/riscv/Kconfig | 1 + xen/arch/riscv/traps.c | 31 +++ xen/common/bug.c | 1 + 3 files changed, 33 insertions(+) diff --git a/xen/arch/riscv/Kconfig b/xen/arch/riscv/Kconfig index b4b354a778..74ad019fe7 100644 ---

[PATCH for 4.20 v9 0/5] RISCV basic exception handling implementation

2024-07-02 Thread Oleksii Kurochko
The patch series is based on: Enable build of full Xen for RISC-V [1] which haven't fully been merged yet. The patch series provides a basic implementation of exception handling. It can do only basic things such as decode a cause of an exception, save/restore registers and execute "wfi"

[PATCH v14 4/9] xen/riscv: add minimal amount of stubs to build full Xen

2024-07-02 Thread Oleksii Kurochko
Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in V14: - Nothing changed. Only rebase. --- Changes in V13: - drop no_irq_type because of the patch series ( [PATCH for-4.19 0/2] arch/irq: Untangle no_irq_type ) which was merged to staging. - Drop unnessary stubs after

[PATCH v14 7/9] xen/riscv: use .insn with operands to support the older gas

2024-07-02 Thread Oleksii Kurochko
Support for specifying "raw" insns was added only in 2.38. To support older version it would be better switch to .insn with operands. The following compilation error occurs: ./arch/riscv/include/asm/processor.h: Assembler messages: ./arch/riscv/include/asm/processor.h:70: Error: unrecognized

[PATCH for 4.20 v14 0/9] Enable build of full Xen for RISC-V

2024-07-02 Thread Oleksii Kurochko
This patch series performs all of the additions necessary to drop the build overrides for RISCV and enable the full Xen build. Except in cases where compatibile implementations already exist (e.g. atomic.h and bitops.h), the newly added definitions are simple. The patch series is based on the

[PATCH v14 2/9] xen/riscv: introduce bitops.h

2024-07-02 Thread Oleksii Kurochko
Taken from Linux-6.4.0-rc1 Xen's bitops.h consists of several Linux's headers: * linux/arch/include/asm/bitops.h: * The following function were removed as they aren't used in Xen: * test_and_set_bit_lock * clear_bit_unlock * __clear_bit_unlock * The following functions

[PATCH v14 5/9] xen/riscv: enable full Xen build

2024-07-02 Thread Oleksii Kurochko
Signed-off-by: Oleksii Kurochko Reviewed-by: Jan Beulich --- Changes in V14: - Nothing changed. Only rebase. - Update the the text in "changes in v13" by dropping some changes as they were done in different patch --- Changes in V13: - drop the footer after R-by as Andrews patch series

[PATCH v14 6/9] xen/README: add compiler and binutils versions for RISC-V64

2024-07-02 Thread Oleksii Kurochko
This patch doesn't represent a strict lower bound for GCC and GNU Binutils; rather, these versions are specifically employed by the Xen RISC-V container and are anticipated to undergo continuous testing. Older GCC and GNU Binutils would work, but this is not a guarantee. While it is feasible to

[PATCH v14 9/9] xen/x86: drop constanst_test_bit() in asm/bitops.h

2024-07-02 Thread Oleksii Kurochko
constant_test_bit() is functionally the same as generic_test_bit(), so constant_test_bit() can be dropped and replaced with generic_test_bit(). Requested-by: Jan Beulich Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in V14: - Add Requested-by: Jan Beulich - Add

[PATCH v14 8/9] xen/riscv: introduce ANDN_INSN

2024-07-02 Thread Oleksii Kurochko
RISC-V does a conditional toolchain for the Zbb extension (xen/arch/riscv/rules.mk), but unconditionally uses the ANDN instruction in emulate_xchg_1_2(). Fixes: 51dabd6312c ("xen/riscv: introduce cmpxchg.h") Suggested-by: Andrew Cooper Signed-off-by: Oleksii Kurochko Suggested-By: Jan Beulich

[PATCH v14 1/9] xen: introduce generic non-atomic test_*bit()

2024-07-02 Thread Oleksii Kurochko
The following generic functions were introduced: * test_bit * generic__test_and_set_bit * generic__test_and_clear_bit * generic__test_and_change_bit These functions and macros can be useful for architectures that don't have corresponding arch-specific instructions. Also, the patch introduces the

[PATCH v14 3/9] xen/riscv: add minimal stuff to mm.h to build full Xen

2024-07-02 Thread Oleksii Kurochko
Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in V14: - drop cast in defintion of page_to_mfn(pg). - reword first change in "Changes in V13". --- Changes in V13: - redefine page_to_mfn() and mfn_to_page(). - add inclusion of after rebasing on top of staging. --- Changes

Re: [PATCH 1/2] xen: privcmd: Switch from mutex to spinlock for irqfds

2024-07-02 Thread Viresh Kumar
On 02-07-24, 12:12, Juergen Gross wrote: > On 18.06.24 11:42, Viresh Kumar wrote: > > irqfd_wakeup() gets EPOLLHUP, when it is called by > > eventfd_release() by way of wake_up_poll(>wqh, EPOLLHUP), which > > gets called under spin_lock_irqsave(). We can't use a mutex here as it > > will lead to a

Re: [PATCH 2/2] xen: privcmd: Fix possible access to a freed kirqfd instance

2024-07-02 Thread Juergen Gross
On 18.06.24 11:42, Viresh Kumar wrote: Nothing prevents simultaneous ioctl calls to privcmd_irqfd_assign() and privcmd_irqfd_deassign(). If that happens, it is possible that a kirqfd created and added to the irqfds_list by privcmd_irqfd_assign() may get removed by another thread executing

Re: [PATCH 1/2] xen: privcmd: Switch from mutex to spinlock for irqfds

2024-07-02 Thread Juergen Gross
On 18.06.24 11:42, Viresh Kumar wrote: irqfd_wakeup() gets EPOLLHUP, when it is called by eventfd_release() by way of wake_up_poll(>wqh, EPOLLHUP), which gets called under spin_lock_irqsave(). We can't use a mutex here as it will lead to a deadlock. Fix it by switching over to a spin lock.

Re: [PATCH v1] automation: add findutils to suse images

2024-07-02 Thread Olaf Hering
Tue, 2 Jul 2024 11:02:00 +0100 Andrew Cooper : > This patch is about keeping Gitlab CI running smoothly.  It's not > related to Xen 4.19, except by chance. It seems the automation/build directory needs to be purged from non-staging branches, to make it obvious that images need to be rebuilt from

[libvirt test] 186625: tolerable all pass - PUSHED

2024-07-02 Thread osstest service owner
flight 186625 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/186625/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 186565 test-amd64-amd64-libvirt 15

Re: [PATCH v1] automation: add findutils to suse images

2024-07-02 Thread Andrew Cooper
On 02/07/2024 10:56 am, Oleksii wrote: > On Mon, 2024-07-01 at 16:20 +0100, Andrew Cooper wrote: >> On 01/07/2024 4:15 pm, Olaf Hering wrote: >>> The build system uses find(1). Make sure it is available. >>> >>> Signed-off-by: Olaf Hering >> Acked-by: Andrew Cooper >> >> CC Oleksii.  This is

Re: [PATCH v1] automation: add findutils to suse images

2024-07-02 Thread Oleksii
On Mon, 2024-07-01 at 16:20 +0100, Andrew Cooper wrote: > On 01/07/2024 4:15 pm, Olaf Hering wrote: > > The build system uses find(1). Make sure it is available. > > > > Signed-off-by: Olaf Hering > > Acked-by: Andrew Cooper > > CC Oleksii.  This is probably non-optional to take. > > I

Re: [PATCH v3 for-4.19? 3/3] cmdline: document and enforce "extra_guest_irqs" upper bounds

2024-07-02 Thread Jan Beulich
On 02.07.2024 11:50, Oleksii wrote: > On Tue, 2024-07-02 at 10:26 +0200, Jan Beulich wrote: >> On 01.07.2024 17:17, Roger Pau Monné wrote: >>> I think we are in agreement about what needs doing.  I can provide: >>> >>> Acked-by: Roger Pau Monné >>> >>> With the changes we have agreed to

Re: [PATCH for-4.19] x86/entry: don't clear DF when raising #UD for lack of syscall handler

2024-07-02 Thread Oleksii
On Mon, 2024-07-01 at 16:35 +0100, Andrew Cooper wrote: > On 06/03/2024 1:44 pm, Jan Beulich wrote: > > --- a/xen/arch/x86/x86_64/entry.S > > +++ b/xen/arch/x86/x86_64/entry.S > > @@ -47,12 +55,13 @@ UNLIKELY_START(z, syscall_no_callback) / > > testb $4, X86_EXC_UD * TRAPINFO_sizeof + > >

Re: [PATCH for-4.19?] xen: avoid UB in guest handle field accessors

2024-07-02 Thread Oleksii
On Mon, 2024-07-01 at 16:36 +0100, Andrew Cooper wrote: > On 24/06/2024 1:28 pm, Jan Beulich wrote: > > Much like noted in 43d5c5d5f70b ("xen: avoid UB in guest handle > > arithmetic"), address calculations involved in accessing a struct > > field > > can overflow, too. Cast respective pointers to

[PATCH v4 for-4.19? 2/2] cmdline: "extra_guest_irqs" is inapplicable to PVH

2024-07-02 Thread Jan Beulich
PVH in particular has no (externally visible) notion of pIRQ-s. Mention that in the description of the respective command line option and have arch_hwdom_irqs() also reflect this (thus suppressing the log message there as well, as being pretty meaningless in this case anyway). Suggested-by: Roger

[PATCH v4 for-4.19? 1/2] cmdline: document and enforce "extra_guest_irqs" upper bounds

2024-07-02 Thread Jan Beulich
PHYSDEVOP_pirq_eoi_gmfn_v accepting just a single GFN implies that no more than 32k pIRQ-s can be used by a domain on x86. Document this upper bound. To also enforce the limit, (ab)use both arch_hwdom_irqs() (changing its parameter type) and setup_system_domains(). This is primarily to avoid

[PATCH v4 for-4.19? 0/2] new extra_guest_irqs adjustment

2024-07-02 Thread Jan Beulich
New patch 2 addresses a concern raised by Roger when reviewing what is now patch 1. 1: cmdline: document and enforce "extra_guest_irqs" upper bounds 2: cmdline: "extra_guest_irqs" is inapplicable to PVH Jan

Re: [PATCH v3 for-4.19? 3/3] cmdline: document and enforce "extra_guest_irqs" upper bounds

2024-07-02 Thread Oleksii
On Tue, 2024-07-02 at 10:26 +0200, Jan Beulich wrote: > On 01.07.2024 17:17, Roger Pau Monné wrote: > > I think we are in agreement about what needs doing.  I can provide: > > > > Acked-by: Roger Pau Monné > > > > With the changes we have agreed to arch_hwdom_irqs(). > > Yet another request

Re: [PATCH for-4.19 v1] automation: add python3-packaging to suse images

2024-07-02 Thread Andrew Cooper
On 02/07/2024 9:56 am, Olaf Hering wrote: > The qemu-xen build system uses gdbus-codegen, which relies on 'packaging'. > Make sure it is available. > > [188/2647] Generating ui/dbus-display gdbus-codegen with a custom command > FAILED: ui/dbus-display1.h ui/dbus-display1.c > /usr/bin/gdbus-codegen

Re: [PATCH] xen: add missing MODULE_DESCRIPTION() macros

2024-07-02 Thread Jürgen Groß
On 26.06.24 18:46, Jeff Johnson wrote: On 6/11/2024 4:54 PM, Jeff Johnson wrote: With ARCH=x86, make allmodconfig && make W=1 C=1 reports: WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/xen/xen-pciback/xen-pciback.o WARNING: modpost: missing MODULE_DESCRIPTION() in

[PATCH v1] automation: add python3-packaging to suse images

2024-07-02 Thread Olaf Hering
The qemu-xen build system uses gdbus-codegen, which relies on 'packaging'. Make sure it is available. [188/2647] Generating ui/dbus-display gdbus-codegen with a custom command FAILED: ui/dbus-display1.h ui/dbus-display1.c /usr/bin/gdbus-codegen ../qemu-xen-dir-remote/ui/dbus-display1.xml

Re: [PATCH v3 3/3] cmdline: document and enforce "extra_guest_irqs" upper bounds

2024-07-02 Thread Roger Pau Monné
On Tue, Jul 02, 2024 at 10:30:03AM +0200, Jan Beulich wrote: > On 01.07.2024 17:17, Roger Pau Monné wrote: > > On Mon, Jul 01, 2024 at 05:07:19PM +0200, Jan Beulich wrote: > >> On 01.07.2024 15:29, Roger Pau Monné wrote: > >>> On Mon, Jul 01, 2024 at 12:40:35PM +0200, Jan Beulich wrote: > On

Re: [XEN PATCH v11 2/8] x86/pvh: Allow (un)map_pirq when dom0 is PVH

2024-07-02 Thread Jan Beulich
On 02.07.2024 05:15, Chen, Jiqian wrote: > On 2024/7/1 15:44, Jan Beulich wrote: >> On 30.06.2024 14:33, Jiqian Chen wrote: >>> If run Xen with PVH dom0 and hvm domU, hvm will map a pirq for >>> a passthrough device by using gsi, see qemu code >>> xen_pt_realize->xc_physdev_map_pirq and libxl code

Re: [XEN PATCH v11 1/8] xen/vpci: Clear all vpci status of device

2024-07-02 Thread Jan Beulich
On 02.07.2024 04:59, Chen, Jiqian wrote: > On 2024/7/1 15:18, Jan Beulich wrote: >> On 30.06.2024 14:33, Jiqian Chen wrote: >>> When a device has been reset on dom0 side, the vpci on Xen >>> side won't get notification, so the cached state in vpci is >>> all out of date compare with the real

Re: [PATCH v3 3/3] cmdline: document and enforce "extra_guest_irqs" upper bounds

2024-07-02 Thread Jan Beulich
On 01.07.2024 17:17, Roger Pau Monné wrote: > On Mon, Jul 01, 2024 at 05:07:19PM +0200, Jan Beulich wrote: >> On 01.07.2024 15:29, Roger Pau Monné wrote: >>> On Mon, Jul 01, 2024 at 12:40:35PM +0200, Jan Beulich wrote: On 01.07.2024 11:55, Roger Pau Monné wrote: > On Thu, Jul 27, 2023 at

Xen 4.19 rc1

2024-07-02 Thread Oleksii
Hi all, Xen 4.19 rc1 is tagged. You can check that out from xen.git: git://xenbits.xen.org/xen.git 4.19.0-rc1 For your convenience there is also a tarball and the signature at: https://downloads.xenproject.org/release/xen/4.19.0-rc1/xen-4.19.0-rc1.tar.gz And the signature is at:

[PATCH v3 for-4.19? 3/3] cmdline: document and enforce "extra_guest_irqs" upper bounds

2024-07-02 Thread Jan Beulich
On 01.07.2024 17:17, Roger Pau Monné wrote: > I think we are in agreement about what needs doing. I can provide: > > Acked-by: Roger Pau Monné > > With the changes we have agreed to arch_hwdom_irqs(). Yet another request for considering for a release-ack. Thanks, Jan

Re: [XEN PATCH v3 08/12] x86/vpt: address a violation of MISRA C Rule 16.3

2024-07-02 Thread Federico Serafini
On 01/07/24 10:49, Jan Beulich wrote: On 26.06.2024 11:28, Federico Serafini wrote: --- a/xen/arch/x86/hvm/vpt.c +++ b/xen/arch/x86/hvm/vpt.c @@ -118,9 +118,11 @@ static int pt_irq_masked(struct periodic_time *pt) return 0; gsi = hvm_isa_irq_to_gsi(pt->irq); + +

Re: [XEN PATCH v3 07/12] x86/hvm: address violations of MISRA C Rule 16.3

2024-07-02 Thread Federico Serafini
On 01/07/24 10:47, Jan Beulich wrote: On 26.06.2024 11:28, Federico Serafini wrote: @@ -2798,11 +2800,12 @@ void hvm_emulate_one_vm_event(enum emul_kind kind, unsigned int trapnr, hvio->mmio_insn_bytes = sizeof(hvio->mmio_insn); memcpy(hvio->mmio_insn,

Re: [PATCH] xen-blkfront: fix sector_size propagation to the block layer

2024-07-02 Thread Juergen Gross
On 25.06.24 07:52, Christoph Hellwig wrote: Ensure that info->sector_size and info->physical_sector_size are set before the call to blkif_set_queue_limits by doing away with the local variables and arguments that propagate them. Thanks to Marek Marczykowski-Górecki and Jürgen Groß for root

Re: [axboe-block:for-next] [block] 1122c0c1cc: aim7.jobs-per-min 22.6% improvement

2024-07-02 Thread Christoph Hellwig
On Mon, Jul 01, 2024 at 04:22:19PM +0800, Oliver Sang wrote: > from below, it seems the patchset doesn't introduce any performance > improvement > but a regression now. is this expected? Not having the improvement at least alleviate my concerns about data integrity. I'm still curious where it

Re: [PATCH] xen: add missing MODULE_DESCRIPTION() macros

2024-07-02 Thread Juergen Gross
On 12.06.24 01:54, Jeff Johnson wrote: With ARCH=x86, make allmodconfig && make W=1 C=1 reports: WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/xen/xen-pciback/xen-pciback.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/xen/xen-evtchn.o WARNING: modpost: missing

[xen-unstable test] 186622: tolerable FAIL - PUSHED

2024-07-02 Thread osstest service owner
flight 186622 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/186622/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 186613