Re: [PATCH] randr: Add 'set' fields to SetCrtcConfigs request

On Fri, 25 Feb 2011 01:23:57 -0500, Alex Deucher wrote: > We have this commit in the most recent radeon release: > http://cgit.freedesktop.org/xorg/driver/xf86-video-ati/commit/?id=3dc28c86eb57cac819e4ed650acfe1f7df6ef565 > Which will conflict with the backout. You can switch that to #ifdef RAND

[PATCH:mkfontscale 2/2] makeList: free partially allocated list on failure

Error: Memory leak (CWE 401) Memory leak of pointer 'first' allocated with malloc(8) at line 192 of list.c in function 'makeList'. 'first' allocated at line 181 with malloc(8). first leaks when next == 0 at line 191. [ This bug was found by the Parfait 0.3.6 bug chec

[PATCH:mkfontscale 1/2] Leave room for null terminator in file & font name arrays

fscanf %s arguments don't include the trailing \0 byte in their counts. Error: Buffer overrun Buffer overflow (CWE 120): Use of fscanf(%1024[), with buffer 'font' Array size is 1024 bytes at line 707 of mkfontscale.c in function 'readFontScale'. Buffer overflow (CWE 120): Use o

Re: [PATCH] dmx: Construct paths in doxygen.conf to fix VPATH builds

On Fri, 25 Feb 2011 05:04:47 +0100, Cyril Brulebois wrote: > since RC3 is happening RSN, it'd probably be a good idea to send that > patch to Keith? I can merge various build fixes before the final release as needed. I want to get the server out for testing right away. -- keith.pack...@intel.c

Re: [PATCH] randr: Add 'set' fields to SetCrtcConfigs request

On Thu, Feb 24, 2011 at 12:42 PM, Keith Packard wrote: > On Thu, 24 Feb 2011 13:37:50 +, Daniel Stone wrote: > >> I'd be happiest with RandR 1.4 backed out until 1.11.  I just don't >> think it's had quite enough (non-rushed) review, exposure or testing, >> and it's not the best of precedents

Re: [PATCH vBrownPaperBag] dix: release all buttons and keys before reattaching a device (#34182)

Peter Hutterer wrote: > Testcase: > xinput float > > results in the keyboard's enter key being repeated as the device is detached > while the key is still physically down. To avoid this, release all keys and > buttons before reattaching the device. > > X.Org Bug 34182

Re: [PATCH setxkbmap] Eliminate limitations on path length.

On Wed, Feb 16, 2011 at 01:18:20AM +0300, Van de Bugger wrote: > Thanks for the suggestion, I did not know about asprintf. I thought it was my > invention. ;-) > > Of course, I would like to use asprintf. But rprintf is still required to > check the status returned by asprintf. > > I am not sur

Re: [PATCH setxkbmap 2/2] Removed unneeded arg name in applyConfig()

On Tue, Feb 22, 2011 at 10:18:57AM +0500, Alexandr Shadchin wrote: > Signed-off-by: Alexandr Shadchin > --- > setxkbmap.c | 11 ++- > 1 files changed, 6 insertions(+), 5 deletions(-) > > diff --git a/setxkbmap.c b/setxkbmap.c > index 1c9c89e..6c678ff 100644 > --- a/setxkbmap.c > +++ b/

[PATCH:x11proto] Support _X_INLINE in any C99-compliant compiler

Signed-off-by: Alan Coopersmith --- Xfuncproto.h.in | 19 --- 1 files changed, 12 insertions(+), 7 deletions(-) diff --git a/Xfuncproto.h.in b/Xfuncproto.h.in index fd9f29b..97e925b 100644 --- a/Xfuncproto.h.in +++ b/Xfuncproto.h.in @@ -98,15 +98,9 @@ in this Software without p

Re: [PATCH setxkbmap 1/2] Removed unused arg subdir in function findFileInPath()

On Tue, Feb 22, 2011 at 10:18:56AM +0500, Alexandr Shadchin wrote: > Signed-off-by: Alexandr Shadchin > --- > setxkbmap.c | 12 ++-- > 1 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/setxkbmap.c b/setxkbmap.c > index 0c43be5..1c9c89e 100644 > --- a/setxkbmap.c > +++ b

Re: [PATCH] test: add some tests for basic list manipulation.

On Fri, Feb 25, 2011 at 03:27:03AM +0100, Cyril Brulebois wrote: > Minor nit… > > Peter Hutterer (22/02/2011): > > This has less purpose as a test but more as documentation on how to actually > > use the differnent list calls. > ^^ >-n amended, thanks. Cheers,

Re: [PATCH] dmx: Construct paths in doxygen.conf to fix VPATH builds

Hi Dan, Dan Nicholson (20/02/2011): > The paths in doxygen.conf assumed that srcdir=builddir and broke > otherwise. Use autoconf to fill in the paths to the srcdir so that > the files can be found when users have a separate build directory > (as with distcheck). > > Signed-off-by: Dan Nicholson

[PATCH vBrownPaperBag] dix: release all buttons and keys before reattaching a device (#34182)

Testcase: xinput float results in the keyboard's enter key being repeated as the device is detached while the key is still physically down. To avoid this, release all keys and buttons before reattaching the device. X.Org Bug 34182 Signed-off

Re: [PATCH xserver] EXA/mixed: ModifyPixmapHeader pitch fixes. (bug #33929)

Keith Packard (24/02/2011): > On Thu, 24 Feb 2011 12:17:57 +0100, Michel Dänzer wrote: > > > On the other hand, the system memory copy doesn't need the pitch > > to be aligned beyond the PixmapBytePad of the width. > > Merged. Hi Jeremy, please consider 31704510f448706524b7b7085cc4ff0ada7bfe7

Re: [PULL xserver] Minor XQuartz updates

On Thu, 24 Feb 2011 19:39:18 -0800, Jeremy Huddleston wrote: > Jeremy Huddleston (2): > XQuartz: Add LSApplicationCategoryType key to Info.plist > XQuartz: Localization Updates Merged. 6178959..229b055 master -> master -- keith.pack...@intel.com pgpziAc1h9Wtd.pgp Description

Re: [PATCH xserver] EXA/mixed: ModifyPixmapHeader pitch fixes. (bug #33929)

On Thu, 24 Feb 2011 12:17:57 +0100, Michel Dänzer wrote: > On the other hand, the system memory copy doesn't need the pitch to be aligned > beyond the PixmapBytePad of the width. Merged. -- keith.pack...@intel.com pgpjOuHunZUA1.pgp Description: PGP signature _

[PULL xserver] Minor XQuartz updates

Just an update to the plist to get XQuartz to play nicely with SpringBoard. I also sync'd up some localizations while I was there. --Jeremy The following changes since commit 83861595782aaa05907f9cf7b236d50261d404d9: Merge remote branch 'kibi/master' (2011-02-24 18:59:07 -0800) are availab

Re: [PATCH] dix: release all buttons and keys before reattaching a device (#34182)

Peter Hutterer wrote: > /** > + * Generate release events for all keys/button currently down on this > + * device. > + */ > +static void > +ReleaseButtonsAndKeys(DeviceIntPtr dev) > +{ > +EventListPtreventlist = InitEventList(GetMaximumEventsNum()); Out of curiosity, where in the ca

Re: [PULL xserver] Composite ClipNotify fix and expose event elimination

On Thu, 24 Feb 2011 17:38:53 +0200, Ville Syrjälä wrote: > Ville Syrjälä (4): > composite: Call ValidateGC after ChangeGC > composite: Initialize borderClip with current values I'm good with merging these two obvious fixes. > composite: Get rid of the internal UnmapWindow+Map

Re: [PULL] xfree86: Fix undefined reference to `XNFsprintf' on sparc.

On Fri, 25 Feb 2011 01:46:00 +0100, Cyril Brulebois wrote: > xfree86: Fix undefined reference to `XNFsprintf' on sparc. Merged. a1cc0e5..8386159 master -> master -- keith.pack...@intel.com pgpfAXskshGUp.pgp Description: PGP signature ___ xorg

Re: [PATCH xserver] Removing unused code

On Tue, 30 Nov 2010 21:17:19 +0500, Alexandr Shadchin wrote: > In OpenBSD removed support PCCONS in 2002 year > http://marc.info/?l=openbsd-cvs&m=102435816424294&w=2 > > Signed-off-by: Alexandr Shadchin Merged. 365ad68..a1cc0e5 master -> master -- keith.pack...@intel.com pgpXs1oZRCKjX

Re: [PULL] 1.10: warning fixes, ABI fix, and minor Fedora merge

On Wed, 23 Feb 2011 13:43:54 -0500, a...@redhat.com wrote: > Adam Jackson (13): > glxproxy: warning fix > glxproxy: warning fix > glxproxy: warning fix > glxproxy: warning fix > glxproxy: warning fix > glxproxy: warning fix > glxproxy: warning fix >

Re: [PATCH] [xserver] record: avoid crash when calling RecordFlushReplyBuffer recursively

On Thu, 10 Feb 2011 15:35:14 +0200, Erkki Seppälä wrote: > This patch adds a counter (a flag, really) that guards against this > situation, to break out of the recursion. Merged. b833f9b..0801afb master -> master (Please check your patches for whitespace issues...) -- keith.pack...@intel

Re: [PATCH] randr: Add 'set' fields to SetCrtcConfigs request

On Fri, 25 Feb 2011 03:01:17 +0100, Cyril Brulebois wrote: > The 4th case is pretty annoying, and was detailed above. The 2nd case > worries me a bit. Shouldn't one be able to use library/binary newer > than the server, and expect those to figure out what the server can do > and how‽ The BadLeng

Re: [PATCH] test: add some tests for basic list manipulation.

Minor nit… Peter Hutterer (22/02/2011): > This has less purpose as a test but more as documentation on how to actually > use the differnent list calls. ^^ -n KiBi. signature.asc Description: Digital signature ___ xorg

Re: [PATCH] randr: Add 'set' fields to SetCrtcConfigs request

Hi, Keith Packard (24/02/2011): > As release manager, this seems like the right solution. However, > it's a larger change than adding the new fix-ups, which doesn't > exactly make me less nervous. not that I'm advocating last-minute pushes, I gave it a try anyway. > If you want to try out the R

[PATCH] dix: release all buttons and keys before reattaching a device (#34182)

Testcase: xinput float results in the keyboard's enter key being repeated as the device is detached while the key is still physically down. To avoid this, release all keys and buttons before reattaching the device. X.Org Bug 34182 Signed-off

[PULL] xfree86: Fix undefined reference to `XNFsprintf' on sparc.

Hi Keith, Cyril Brulebois (20/02/2011): > BIG FAT WARNING: Not actually tested yet. Waiting for other builds to > finish before uploading a new revision with that fix. no longer true, the build went fine until the unit tests. Keith, please pull from: git://git.debian.org/users/kibi/pkg-xorg/x

[PATCH xdm] Implement ConsoleKit support.

Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=17325 Since ConsoleKit 0.4.2, the sessions created by ck-launch-session are no longer marked as local and active. This means that distributions can't simply call ck-launch-session in Xsession.d anymore to get an active local ConsoleKit session. I

Re: [PATCH] vbe: Fix malloc size bug

On Thu, 2011-02-24 at 13:26 -0800, Alan Coopersmith wrote: > On 02/24/11 01:11 PM, Adam Jackson wrote: > > diff --git a/hw/xfree86/vbe/vbe.c b/hw/xfree86/vbe/vbe.c > > index bcda5ec..56e3ec4 100644 > > --- a/hw/xfree86/vbe/vbe.c > > +++ b/hw/xfree86/vbe/vbe.c > > @@ -395,7 +395,7 @@ VBEGetVBEInfo(v

Re: [PATCH v2] include: document list interface.

On 02/23/11 09:11 PM, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer > --- > Changes since v1: > typos pointed out by Alan > - initilise -> initialize > - "Seems like the word "in" should be deleted from that sentence." > successfully found the sentence to deleted the work "in" from and e

Re: [PATCH] vbe: Fix malloc size bug

On 02/24/11 01:11 PM, Adam Jackson wrote: > ==14882== Invalid write of size 2 > ==14882==at 0x6750267: VBEGetVBEInfo (vbe.c:400) > ==14882==by 0x6142064: ??? (in > /usr/lib64/xorg/modules/drivers/vesa_drv.so) > ==14882==by 0x471895: InitOutput (xf86Init.c:519) > ==14882==by 0x42277

Re: randr: Add 'set' fields to SetCrtcConfigs request

9.99.902+git20110223.8988f76-1~keithp.1 > > NOTE: > x11-xserver-utils contains xrandr (source) from > <http://cgit.freedesktop.org/~keithp/xrandr/log/?h=randr-1.4>. > > I have attached my Xorg.log and the output of xrandr. > > $ xrandr --verbose -q > > I hope I can

[PATCH] vbe: Fix malloc size bug

==14882== Invalid write of size 2 ==14882==at 0x6750267: VBEGetVBEInfo (vbe.c:400) ==14882==by 0x6142064: ??? (in /usr/lib64/xorg/modules/drivers/vesa_drv.so) ==14882==by 0x471895: InitOutput (xf86Init.c:519) ==14882==by 0x422778: main (main.c:205) ==14882== Address 0x4f32fa8 is 72

[PULL xserver] Removing unused code support PCCONS (OpenBSD)

The following changes since commit 93a73993708b1345c86ec3ec06b02ed236595673: test: write some event → XI1 conversion tests. (2011-02-22 08:08:55 +1000) are available in the git repository at: git://github.com/Koba/xserver.git master Alexandr Shadchin (1): Removing unused code support P

Re: [PATCH evdev] Export device node as property.

> "Peter" == Peter Hutterer writes: Hi, >> For a long time we wanted to be able to match up X input devices such as >> the HID keyboards built into USB speakers or USB headsets with their >> particular sound cards, so that pressing the volume button on the device >> actually changes the

Re: [PATCH xserver] Removing unused code

On Thu, 2011-02-24 at 21:40 +0500, Alexandr Shadchin wrote: > Push, please (yet not forgotten :-) Cc'ing Keith so he sees this. In the future, please cc the release manager on reviewed patch requests. - ajax signature.asc Description: This is a digitally signed message part ___

Re: [PATCH] randr: Add 'set' fields to SetCrtcConfigs request

On Thu, 24 Feb 2011 13:37:50 +, Daniel Stone wrote: > I'd be happiest with RandR 1.4 backed out until 1.11. I just don't > think it's had quite enough (non-rushed) review, exposure or testing, > and it's not the best of precedents to be setting for future releases. > Sorry. As release manag

Re: [PATCH xserver] Removing unused code

Push, please (yet not forgotten :-) On Wed, Dec 01, 2010 at 08:27:50AM +0100, Matthieu Herrb wrote: > On Tue, Nov 30, 2010 at 09:17:19PM +0500, Alexandr Shadchin wrote: > > In OpenBSD removed support PCCONS in 2002 year > > http://marc.info/?l=openbsd-cvs&m=102435816424294&w=2 > > > > Signed-off-

[PULL xserver] Composite ClipNotify fix and expose event elimination

There were no additional review comments for this patchset, so I think it's ready. We've been running it internally for some time now on prototype devices and I've been running it on my work laptop as well. The following changes since commit 93a73993708b1345c86ec3ec06b02ed236595673: test: writ

Re: [PULL] 1.10: warning fixes, ABI fix, and minor Fedora merge

On Wed, 2011-02-23 at 16:16 -0800, Keith Packard wrote: > On Wed, 23 Feb 2011 13:43:54 -0500, a...@redhat.com wrote: > > > are available in the git repository at: > > ssh://people.freedesktop.org/~ajax/xserver ..BRANCH.NOT.VERIFIED.. > > BRANCH.NOT.VERIFIED? o_O My request-pull script seems t

Re: [PATCH xserver] EXA/mixed: ModifyPixmapHeader pitch fixes. (bug #33929)

2011/2/24 Cyril Brulebois : >> If there's a GPU copy and a non-zero devKind was passed in, set the GPU copy >> pitch to that instead of to a possibly bogus value derived from the new >> width. >> This is e.g. used by the radeon driver's drmmode_xf86crtc_resize hook, fixes >> https://bugs.freedeskt

Re: [PATCH xserver] EXA/mixed: ModifyPixmapHeader pitch fixes. (bug #33929)

Michel Dänzer (24/02/2011): > From: Michel Dänzer > > If there's a GPU copy and a non-zero devKind was passed in, set the GPU copy > pitch to that instead of to a possibly bogus value derived from the new width. > This is e.g. used by the radeon driver's drmmode_xf86crtc_resize hook, fixes > htt

Re: [PATCH] randr: Add 'set' fields to SetCrtcConfigs request

Hi, On Wed, Feb 23, 2011 at 03:46:14PM -0800, Keith Packard wrote: > On Wed, 23 Feb 2011 10:16:46 -0800, Aaron Plattner > wrote: > > However, I do need to object strongly to such a major protocol change being > > made after RC2 of a release cycle. We're supposed to be making only > > critical b

[PATCH xserver] EXA/mixed: ModifyPixmapHeader pitch fixes. (bug #33929)

From: Michel Dänzer If there's a GPU copy and a non-zero devKind was passed in, set the GPU copy pitch to that instead of to a possibly bogus value derived from the new width. This is e.g. used by the radeon driver's drmmode_xf86crtc_resize hook, fixes https://bugs.freedesktop.org/show_bug.cgi?id