Re: [PATCH] randr: Add 'set' fields to SetCrtcConfigs request

2011-02-24 Thread Daniel Stone
Hi, On Wed, Feb 23, 2011 at 03:46:14PM -0800, Keith Packard wrote: On Wed, 23 Feb 2011 10:16:46 -0800, Aaron Plattner aplatt...@nvidia.com wrote: However, I do need to object strongly to such a major protocol change being made after RC2 of a release cycle. We're supposed to be making only

Re: [PATCH] randr: Add 'set' fields to SetCrtcConfigs request

2011-02-24 Thread Keith Packard
On Thu, 24 Feb 2011 13:37:50 +, Daniel Stone dan...@fooishbar.org wrote: I'd be happiest with RandR 1.4 backed out until 1.11. I just don't think it's had quite enough (non-rushed) review, exposure or testing, and it's not the best of precedents to be setting for future releases. Sorry.

Re: [PATCH] randr: Add 'set' fields to SetCrtcConfigs request

2011-02-24 Thread Cyril Brulebois
Hi, Keith Packard kei...@keithp.com (24/02/2011): As release manager, this seems like the right solution. However, it's a larger change than adding the new fix-ups, which doesn't exactly make me less nervous. not that I'm advocating last-minute pushes, I gave it a try anyway. If you want to

Re: [PATCH] randr: Add 'set' fields to SetCrtcConfigs request

2011-02-24 Thread Keith Packard
On Fri, 25 Feb 2011 03:01:17 +0100, Cyril Brulebois k...@debian.org wrote: The 4th case is pretty annoying, and was detailed above. The 2nd case worries me a bit. Shouldn't one be able to use library/binary newer than the server, and expect those to figure out what the server can do and how‽

Re: [PATCH] randr: Add 'set' fields to SetCrtcConfigs request

2011-02-24 Thread Alex Deucher
On Thu, Feb 24, 2011 at 12:42 PM, Keith Packard kei...@keithp.com wrote: On Thu, 24 Feb 2011 13:37:50 +, Daniel Stone dan...@fooishbar.org wrote: I'd be happiest with RandR 1.4 backed out until 1.11.  I just don't think it's had quite enough (non-rushed) review, exposure or testing, and

Re: [PATCH] randr: Add 'set' fields to SetCrtcConfigs request

2011-02-24 Thread Keith Packard
On Fri, 25 Feb 2011 01:23:57 -0500, Alex Deucher alexdeuc...@gmail.com wrote: We have this commit in the most recent radeon release: http://cgit.freedesktop.org/xorg/driver/xf86-video-ati/commit/?id=3dc28c86eb57cac819e4ed650acfe1f7df6ef565 Which will conflict with the backout. You can switch

Re: [PATCH] randr: Add 'set' fields to SetCrtcConfigs request

2011-02-23 Thread Aaron Plattner
On Wed, Feb 16, 2011 at 10:59:22PM -0800, Keith Packard wrote: This permits clients to perform incremental configuration changes instead of requiring a complete new configuration to be written. Signed-off-by: Keith Packard kei...@keithp.com --- randr/rrcrtc.c | 332

Re: [PATCH] randr: Add 'set' fields to SetCrtcConfigs request

2011-02-23 Thread Luc Verhaegen
On Wed, Feb 23, 2011 at 10:16:46AM -0800, Aaron Plattner wrote: On Wed, Feb 16, 2011 at 10:59:22PM -0800, Keith Packard wrote: Other than the protocol doc comments and the existing bug noted above, Reviewed-by: Aaron Plattner aplatt...@nvidia.com However, I do need to object strongly to

Re: [PATCH] randr: Add 'set' fields to SetCrtcConfigs request

2011-02-23 Thread Keith Packard
On Wed, 23 Feb 2011 10:16:46 -0800, Aaron Plattner aplatt...@nvidia.com wrote: randrproto.txt says nothing about SetCrtcMode. ... randrproto.txt says nothing about SetCrtcOutputs. The interplay encoded here probably ought to be described in the protocol doc. Yeah, randrproto.txt is missing

Re: [PATCH] randr: Add 'set' fields to SetCrtcConfigs request

2011-02-23 Thread Keith Packard
On Wed, 23 Feb 2011 23:12:15 +0100, Luc Verhaegen l...@skynet.be wrote: I believe this all got commited a while ago. There was even a day or so when the proto and xserver were out of sync, and there was a tinderbox complaint and at least one bug. Only a single SOB was present. I just

Re: [PATCH] randr: Add 'set' fields to SetCrtcConfigs request

2011-02-23 Thread Luc Verhaegen
On Wed, Feb 23, 2011 at 03:49:58PM -0800, Keith Packard wrote: On Wed, 23 Feb 2011 23:12:15 +0100, Luc Verhaegen l...@skynet.be wrote: I believe this all got commited a while ago. There was even a day or so when the proto and xserver were out of sync, and there was a tinderbox complaint

[PATCH] randr: Add 'set' fields to SetCrtcConfigs request

2011-02-16 Thread Keith Packard
This permits clients to perform incremental configuration changes instead of requiring a complete new configuration to be written. Signed-off-by: Keith Packard kei...@keithp.com --- randr/rrcrtc.c | 332 ++-- 1 files changed, 202