On Thu, 29 Oct 2020 16:01:19 GMT, Christoph Langer <clan...@openjdk.org> wrote:

> > Did you have a benchmark with various cache sizes (for example, from 1 to 
> > 10K) and various connections (for example from 1 to 10K) for those 
> > components (including TLS implementation) that use Cache?
> 
> Nope, we've just seen the memory regression in a certain customer use case 
> (lot's of meory retained by a finalizer) and confirmed it resolved after 
> setting javax.net.ssl.sessionCacheSize to 0.
> 
Did you have this patch checked with the customer?  I think the performance may 
be similar or improved comparing to set the cache size to 0.

> But I guess this change merits certain further benchmarking to get it right.
>
It looks good to me, but we may be more confident with it if there is a 
benchmarking.

-------------

PR: https://git.openjdk.java.net/jdk/pull/937

Reply via email to