On Wed, 10 Mar 2021 08:29:37 GMT, Yasumasa Suenaga <[email protected]> wrote:
> Most of subcommands in jhsdb supports to connect to debug server via > `--connect` command line option, however `hsdb` and `clhsdb` do not accept it. > > Both HSDB and CLHSDB support to connect to debug server, so they should have > capability to do it via command line option. > > I also filed [CSR for this > issue](https://bugs.openjdk.java.net/browse/JDK-8263345). Please review it as > well. test/hotspot/jtreg/serviceability/sa/sadebugd/ClhsdbAttachToDebugServerWithCommandLine.java line 43: > 41: */ > 42: > 43: public class ClhsdbAttachToDebugServerWithCommandLine { The test name is rather long. Since this test is already in the sadebugd directory, you could shorten it to ClhsdbAttachWithCommandLine, although I'm not so sure I like it either. How about ClhsdbAttachWithConnect or ClhsdbAttachWithConnectArgument, or ClhsdbTestConnectArgument (I think I like the last one best)? ------------- PR: https://git.openjdk.java.net/jdk/pull/2908
