On Wed, 10 Mar 2021 21:32:44 GMT, Chris Plummer <[email protected]> wrote:
>> Most of subcommands in jhsdb supports to connect to debug server via >> `--connect` command line option, however `hsdb` and `clhsdb` do not accept >> it. >> >> Both HSDB and CLHSDB support to connect to debug server, so they should have >> capability to do it via command line option. >> >> I also filed [CSR for this >> issue](https://bugs.openjdk.java.net/browse/JDK-8263345). Please review it >> as well. > > src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/CLHSDB.java line 157: > >> 155: } catch (NumberFormatException e) { >> 156: // Attempt to connect to remote debug server >> 157: debugServerName = args[0]; > > I assume this change to no longer support just specifying an execPath is not > exposed to the user, unless they are invoking the CLHSDB class directly from > the command line. Yes, but this code would be run from `SALauncher::runCLHSDB`, so we need to change. https://github.com/YaSuenag/jdk/blob/JDK-8263342/src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/SALauncher.java#L282 ------------- PR: https://git.openjdk.java.net/jdk/pull/2908
