On Thu, 11 Mar 2021 00:08:55 GMT, Yasumasa Suenaga <[email protected]> wrote:
>> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/CLHSDB.java line 157:
>>
>>> 155: } catch (NumberFormatException e) {
>>> 156: // Attempt to connect to remote debug server
>>> 157: debugServerName = args[0];
>>
>> I assume this change to no longer support just specifying an execPath is not
>> exposed to the user, unless they are invoking the CLHSDB class directly from
>> the command line.
>
> Yes, but this code would be run from `SALauncher::runCLHSDB`, so we need to
> change.
> https://github.com/YaSuenag/jdk/blob/JDK-8263342/src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/SALauncher.java#L282
Yes, I understood that part. I just wanted to make sure, for example, that we
weren't previously supporting something like `attach <exe_path>` in clhsdb, and
that would be impacted by this, but I'm pretty sure clhsdb already prevents
doing that. However, what if you used `jshdb <cmd> --exe` and don't specify a
core file. Did that ever work, and if so will it still work?
-------------
PR: https://git.openjdk.java.net/jdk/pull/2908
