On Wed, 10 Mar 2021 21:46:50 GMT, Chris Plummer <[email protected]> wrote:

>> Yasumasa Suenaga has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Update testcase name
>
> test/hotspot/jtreg/serviceability/sa/sadebugd/ClhsdbAttachToDebugServerWithCommandLine.java
>  line 43:
> 
>> 41:  */
>> 42: 
>> 43: public class ClhsdbAttachToDebugServerWithCommandLine {
> 
> The test name is rather long. Since this test is already in the sadebugd 
> directory, you could shorten it to ClhsdbAttachWithCommandLine, although I'm 
> not so sure I like it either. How about ClhsdbAttachWithConnect or 
> ClhsdbAttachWithConnectArgument, or ClhsdbTestConnectArgument (I think I like 
> the last one best)?

I renamed to `ClhsdbTestConnectArgument` in new commit.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2908

Reply via email to