On Tue, 6 Apr 2021 11:09:52 GMT, Robbin Ehn <r...@openjdk.org> wrote:
>> Hi Robbin, >> >> This is a great piece of work with a lot of code simplifications. >> Unfortunately some new complexities that need to be hidden by appropriate >> abstractions. Lots of comments, queries and suggestions below. >> >> Thanks, >> David > >> Hi Robbin, >> >> This is a great piece of work with a lot of code simplifications. >> Unfortunately some new complexities that need to be hidden by appropriate >> abstractions. Lots of comments, queries and suggestions below. >> >> Thanks, >> David > > Thanks David! Hi Robbin, I'm looking at it. I have a concern that it can significantly impact Loom implementation. There is a non-trivial update in Loom to support virtual threads in JVMTI Suspend/Resume. So we need to make sure your approach is going to work for virtual threads as well. ------------- PR: https://git.openjdk.java.net/jdk/pull/3191