On Wed, 7 Apr 2021 16:25:28 GMT, Robbin Ehn <r...@openjdk.org> wrote:
>>> Hi Robbin, >>> I'm looking at it. I have a concern that it can significantly impact Loom >>> implementation. There is a non-trivial update in Loom to support virtual >>> threads in JVMTI Suspend/Resume. So we need to make sure your approach is >>> going to work for virtual threads as well. >> >> Hi Serguei, I looked at loom implementation. >> I will help you do the merge. The main thing seem to split some logic into >> the handshake itself. >> >> Thanks > > Working on pushing a new version, it will not have addressed all comments but > many of them. > I will build and do testing before push, and start deep testing in the > background. > > I also merge with mainline. Hi Robbin, Thank you for the reply and suggestion to help with merge. I made the first pass through the webrev. The fix looks pretty good in general - nice simplifications! My estimation is that it should not be a big problem to merge it with Loom while it can require some effort to do so. I'm going for another pass to look on details. Thanks, Serguei ------------- PR: https://git.openjdk.java.net/jdk/pull/3191
