On Wed, 7 Apr 2021 16:23:08 GMT, Robbin Ehn <r...@openjdk.org> wrote:
>> Hi Robbin, >> I'm looking at it. I have a concern that it can significantly impact Loom >> implementation. There is a non-trivial update in Loom to support virtual >> threads in JVMTI Suspend/Resume. So we need to make sure your approach is >> going to work for virtual threads as well. > >> Hi Robbin, >> I'm looking at it. I have a concern that it can significantly impact Loom >> implementation. There is a non-trivial update in Loom to support virtual >> threads in JVMTI Suspend/Resume. So we need to make sure your approach is >> going to work for virtual threads as well. > > Hi Serguei, I looked at loom implementation. > I will help you do the merge. The main thing seem to split some logic into > the handshake itself. > > Thanks Working on pushing a new version, it will not have addressed all comments but many of them. I will build and do testing before push, and start deep testing in the background. I also merge with mainline. ------------- PR: https://git.openjdk.java.net/jdk/pull/3191
