On Wed, 6 Oct 2021 19:00:35 GMT, Andrey Turbanov <github.com+741251+turban...@openjdk.org> wrote:
>> There are few places in code where manual while loop is used with Iterator >> to iterate over Collection. >> Instead of manual while cycles it's preferred to use enhanced-for cycle >> instead: it's less verbose, makes code easier to read and it's less >> error-prone. >> It doesn't have any performance impact: java compiler generates similar code >> when compiling enhanced-for cycle. >> >> Similar cleanups: >> * https://bugs.openjdk.java.net/browse/JDK-8258006 >> * https://bugs.openjdk.java.net/browse/JDK-8257912 > > Andrey Turbanov has updated the pull request incrementally with one > additional commit since the last revision: > > 8274755: Replace 'while' cycles with iterator with enhanced-for in jdk.jdi > remove empty space before casts in InvokableTypeImpl too Marked as reviewed by sspitsyn (Reviewer). We had HotSpot convention about it. Not sure where it is located now. One of the important rules was to follow the file (area) local style if possible. ------------- PR: https://git.openjdk.java.net/jdk/pull/5577
