On Thu, 27 Jan 2022 11:32:18 GMT, Alex Menkov <amen...@openjdk.org> wrote:
>> Changes: >> - ClassFileReconstituter is updated to restore "MethodParameters" attribute; >> - handling of the attribute in VM_RedefineClasses is moved to be consistent >> with other code (like local variable table); >> - copied ClassTransformer class (from test/jdk/com/sun/jdi/lib/jdb) to >> /test/lib as it's used by tests from hotspot and jdk (and also by test from >> Valhalla repo); Will file a follow up issues to updates tests and remove the >> class from test/jdk/com/sun/jdi/lib/jdb > > Alex Menkov has updated the pull request incrementally with one additional > commit since the last revision: > > updated per Chris feedback Marked as reviewed by sspitsyn (Reviewer). test/jdk/java/lang/instrument/RetransformWithMethodParametersTest.java line 101: > 99: > 100: // Prints and verifies MethodParameters attribute using reflection. > 101: private void verifyMethodParams(boolean expectedPresent, String... > expectedNames) throws Throwable { Just a side comment, no intention to insist... I think, a generalization with the `expectedPresent` parameter adds a little bit of complexity. It feels that refactoring it into two methods - one for expected and another for non-expected would be more clear. ------------- PR: https://git.openjdk.java.net/jdk/pull/7180