On Tue, 1 Feb 2022 23:06:47 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> Alex Menkov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> updated per Chris feedback > > test/jdk/java/lang/instrument/RetransformWithMethodParametersTest.java line > 101: > >> 99: >> 100: // Prints and verifies MethodParameters attribute using reflection. >> 101: private void verifyMethodParams(boolean expectedPresent, String... >> expectedNames) throws Throwable { > > Just a side comment, no intention to insist... > I think, a generalization with the `expectedPresent` parameter adds a little > bit of complexity. > It feels that refactoring it into two methods - one for expected and another > for non-expected would be more clear. Fixed ------------- PR: https://git.openjdk.java.net/jdk/pull/7180