On Thu, 15 Dec 2022 22:57:31 GMT, Alexander Matveev <almat...@openjdk.org> wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix https and changed URL back > > src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/MainResources_de.properties > line 82: > >> 80: >> 81: error.foreign-app-image=Fehler: .jpackage.xml-Datei fehlt in >> app-image-Verzeichnis ({0}) >> 82: error.invalid-app-image=Fehler: app-image-Verzeichnis ({0}) wurde von >> einer anderen jpackage-Version generiert, oder .jpackage.xml ist nicht >> wohlgeformt > > error.invalid-app-image looks like old translation and missing "{1}". Also, > why () is used instead of ""? I'm not sure for the decisions of change in punctuation and for the missing {1} as I didn't do the translation myself. Would this be better to be reverted? > src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/MsiInstallerStrings_de.wxl > line 2: > >> 1: <?xml version = '1.0' encoding = 'utf-8'?> >> 2: <WixLocalization Culture="de" >> xmlns="http://schemas.microsoft.com/wix/2006/localization" Codepage="1252"> > > Why "de-de" was changed to "de"? Also not sure why this was changed in the translation. I'm reverting all instances of these language codes. ------------- PR: https://git.openjdk.org/jdk20/pull/35