On Fri, 16 Dec 2022 00:15:51 GMT, Damon Nguyen <dngu...@openjdk.org> wrote:

>> src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/MainResources_de.properties
>>  line 82:
>> 
>>> 80: 
>>> 81: error.foreign-app-image=Fehler: .jpackage.xml-Datei fehlt in 
>>> app-image-Verzeichnis ({0})
>>> 82: error.invalid-app-image=Fehler: app-image-Verzeichnis ({0}) wurde von 
>>> einer anderen jpackage-Version generiert, oder .jpackage.xml ist nicht 
>>> wohlgeformt
>> 
>> error.invalid-app-image looks like old translation and missing "{1}". Also, 
>> why () is used instead of ""?
>
> I'm not sure for the decisions of change in punctuation and for the missing 
> {1} as I didn't do the translation myself. Would this be better to be 
> reverted?

Looks like translation is done on files before JDK-8293462 was integrated 
(before Sep 26). See 
[commit](https://github.com/openjdk/jdk20/commit/1e222bccd3807c1be0d1d824e0ff9745751d8375#diff-8bfeb61c827c2bc073c65cbf4137dbf8f7baa5f4f88e5d59785e985d9510577c)
 when I changed these two strings. For now it is better to revert them to 
original English version or figure out why translation is old.

-------------

PR: https://git.openjdk.org/jdk20/pull/35

Reply via email to