On Wed, 11 Jan 2023 19:13:20 GMT, Chris Plummer <[email protected]> wrote:
>> Yi Yang has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - format
>> - Merge branch 'jdk_virtualmachienimpl' of github.com:y1yang0/jdk into
>> jdk_virtualmachienimpl
>> - -1 to vmid
>
> src/jdk.attach/share/classes/sun/tools/attach/HotSpotVirtualMachine.java line
> 455:
>
>> 453: if (fd != -1) {
>> 454: close(fd);
>> 455: }
>
> There used to be logic to set `fd` (previously called `s`) to -1 during the
> close operation. Is that no longer needed?
Hi @plummercj , sorry for late reply.
I don't see why we need it because this method is protected by synchronized. fd
is only set by ctor.
-------------
PR: https://git.openjdk.org/jdk/pull/11823
