On Tue, 10 Jan 2023 10:49:52 GMT, Yi Yang <[email protected]> wrote:
>> harmless refactor to share code across different platforms of
>> VirtualMachineImpl:
>> 1. Shared code to process command response after requesting a command
>> execution
>> 2. Read functionality in SocketInputStream can be reused
>
> Yi Yang has updated the pull request incrementally with three additional
> commits since the last revision:
>
> - format
> - Merge branch 'jdk_virtualmachienimpl' of github.com:y1yang0/jdk into
> jdk_virtualmachienimpl
> - -1 to vmid
src/jdk.attach/share/classes/sun/tools/attach/HotSpotVirtualMachine.java line
455:
> 453: if (fd != -1) {
> 454: close(fd);
> 455: }
There used to be logic to set `fd` (previously called `s`) to -1 during the
close operation. Is that no longer needed?
-------------
PR: https://git.openjdk.org/jdk/pull/11823
