On Mon, 13 Mar 2023 09:49:39 GMT, Andrew Dinn <ad...@openjdk.org> wrote:
>> src/hotspot/share/prims/agentList.cpp line 64:
>>
>>> 62: void AgentList::add_xrun(const char* name, char* options, bool
>>> absolute_path) {
>>> 63: Agent* agent = new Agent(name, options, absolute_path);
>>> 64: agent->_is_xrun = true;
>>
>> Why direct access of private field instead of having a setter like other
>> parts of the Agent API?
>
> n.b. that also applies for accesses/updates to field _next.
I wanted all accesses to use the iterator. The only access is given to the
iterator and AgentList by way of being friends. No need to expose more.
-------------
PR: https://git.openjdk.org/jdk/pull/12923
