On Tue, 14 Mar 2023 12:26:16 GMT, Markus Grönlund <mgron...@openjdk.org> wrote:
>> I've had a good look through now and have a better sense of the refactoring. >> Seems good. >> >> I'll wait for any tweaks before hitting the approve button though. >> >> Thanks > >> I've had a good look through now and have a better sense of the refactoring. >> Seems good. >> >> >> >> I'll wait for any tweaks before hitting the approve button though. >> >> >> >> Thanks > > Thanks so much for taking a look. I realized that implementation details of > loading should probably reside in agent.cpp, not agentList.cpp. > > I am currently off on vacation and will update when back. Thanks also to > Andrew Dinn for comments. @mgronlun I'm looking at the fixes but it will take some time. ------------- PR: https://git.openjdk.org/jdk/pull/12923