On Tue, 14 Mar 2023 12:26:16 GMT, Markus Grönlund <mgron...@openjdk.org> wrote:
> I've had a good look through now and have a better sense of the refactoring. > Seems good. > > I'll wait for any tweaks before hitting the approve button though. > > Thanks Moving the loading logic to the agent.cpp module was a bit harder than I initially thought. It also exposed a bug in how statically linked libraries were loaded - now fixed. Sorry for the large update. Thanks again for having a look. >> src/hotspot/share/prims/agentList.cpp line 542: >> >>> 540: >>> 541: // Invoke the Agent_OnAttach function >>> 542: JavaThread* THREAD = JavaThread::current(); // For exception macros. >> >> Nit: just use `current` rather than `THREAD` and don't use the exception >> macros. > > Ported as is but good point, will update. Updated - cheers. ------------- PR Comment: https://git.openjdk.org/jdk/pull/12923#issuecomment-1490828465 PR Review Comment: https://git.openjdk.org/jdk/pull/12923#discussion_r1153703484
