On Wed, 30 Aug 2023 22:05:53 GMT, Daniel D. Daugherty <[email protected]>
wrote:
>> Test failed because of unexpected output of version string.
>> The standard convention for tests is to skip any unexpected output (version
>> string, VM warning, vm logging) and only fail on expected error patterns.
>> Fix is tested by running with default options and with '-showversion' vm
>> option.
>
> test/hotspot/jtreg/serviceability/jdwp/DebuggeeLauncher.java line 107:
>
>> 105: @Override
>> 106: public void onStringRead(StreamHandler handler, String line) {
>> 107: processDebuggeeOutput(line);
>
> So the fix is not to terminate the debuggee and raise an error if
> there is output on stderr? The line will simply be processed just
> like any line that occurs on stdout?
>
> If my understanding is correct, then I'm good with this fix.
Not exactly, the stderr is just ignored. We don't expect anything so just
ignore it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15499#discussion_r1310888919
