On Sat, 9 Mar 2024 05:27:43 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:
>> vmtestbase nsk/jdi tests run 2 processes: debugger and debugee.
>> There is not need to start debugger in the separate process for each test.
>> Also, no need to run it with "-Xcomp" because the main goal is to test
>> debugee behavior with different VM flags.
>> This fix updates tests to run debugger as driver to optimize execution time.
>> The fix also eliminates System.exit() which is not compatible with
>> driver/agentvm mode and update shared classes to correctly add classpath
>> when running debugee.
>> There were few tests which still execute using othervm mode. They require
>> some specific classpath/settings.
>> Tested by running all tests, with '-Xcomp' and virtual thread test factory.
>
> Leonid Mesnik has updated the pull request incrementally with one additional
> commit since the last revision:
>
> reverted failing tests.
> There were few tests which still execute using othervm mode. They require
> some specific classpath/settings.
Which ones? They are hard to find among the 2000+ files changed.
test/hotspot/jtreg/vmTestbase/nsk/share/jdi/Binder.java line 757:
> 755: }
> 756:
> 757: if (classPath != null && !vmArgs.contains("-cp") &&
> !vmArgs.contains("-classpath")) {
How does this change relate to using driver instead of othervm?
test/hotspot/jtreg/vmTestbase/nsk/share/jdi/ClassExclusionFilterTest.java line
43:
> 41: if (result != 0) {
> 42: throw new RuntimeException("TEST FAILED with result " +
> result);
> 43: }
Why do we have tests under jdi/share?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/18174#issuecomment-2008097455
PR Review Comment: https://git.openjdk.org/jdk/pull/18174#discussion_r1531083329
PR Review Comment: https://git.openjdk.org/jdk/pull/18174#discussion_r1531084477
