On Fri, 29 Mar 2024 03:50:03 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
>> test/hotspot/jtreg/serviceability/jvmti/vthread/PopFrameTest/libPopFrameTest.cpp >> line 161: >> >>> 159: int attempts = 0; >>> 160: while (!bp_sync_reached) { >>> 161: LOG("Main: ensureAtBreakpoint: waitig 5 millis\n"); >> >> Suggestion: >> >> LOG("Main: ensureAtBreakpoint: waiting 10 millis\n"); >> >> >> I think this should be moved directly above the wait(10) call. > > I think you missed this suggestion. There is a typo in the log message, and > this LOG should be move to just before the wait() statement below. Sorry, missed to do this. Fixed now. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18419#discussion_r1544041108