On Fri, 29 Mar 2024 20:44:48 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> runtime/8176717/TestInheritFD.java has an example of what I'm talking about:
>>
>> public static float timeoutFactor =
>> Float.parseFloat(System.getProperty("test.timeout.factor", "1.0"));
>> public static long subProcessTimeout = (long)(15L * timeoutFactor);
>>
>> so you fetch the test.timeout.factor value and then you scale your delay
>> value.
>>
>> Also:
>>
>> nit typo: s/waitig/waiting/
>
> Thank you for the example and for catching the typo. The timeout factor also
> needs to be passed to the native side. I think, this fragment is not worth
> this kind of extra complexity. One approach would be to just make it big
> enough, eg. make it 100 seconds instead of 10. Another - to get rid of this
> trap at all. What would you prefer?
So that would mean that the native side would always wait for 100 seconds?
Or will it wait for some increment of time upto a maximum of 100 seconds?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18419#discussion_r1544915772
