On Wed, 3 Apr 2024 15:30:00 GMT, Stefan Karlsson <[email protected]> wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Removed not_used state of nmethod
>
> src/hotspot/share/compiler/compileBroker.cpp line 1379:
>
>> 1377: if (osr_bci == InvocationEntryBci) {
>> 1378: // standard compilation
>> 1379: nmethod* method_code = method->code();
>
> Isn't the `method_code->is_nmethod()` redundant now?
An other good catch! It leads me to chase all redundant `is_nmethod()` and
`as_nmethod_*()` calls.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18554#discussion_r1550187397
