On Wed, 3 Apr 2024 15:35:49 GMT, Stefan Karlsson <[email protected]> wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Removed not_used state of nmethod
>
> src/hotspot/share/gc/x/xUnload.cpp line 78:
>
>> 76: class XIsUnloadingBehaviour : public IsUnloadingBehaviour {
>> 77: public:
>> 78: virtual bool has_dead_oop(nmethod* method) const {
>
> This now takes an `nmethod` argument, but still calls as_nmethod(). I think
> that should be removed from this, and all similar functions here in the GC
> code. If you want, I can do that as a follow-up RFE.
I decided to fix it in these changes.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18554#discussion_r1550285238
