On Wed, 11 Mar 2026 11:47:45 GMT, Coleen Phillimore <[email protected]> wrote:
>> Please review this change to fix GenerateOopMap to not report an unreachable >> bytecode for async exception handling and for the first bytecode in an >> exception catch clause. The first change will generate a safepoint entry >> that doesn't allow async exceptions for bytecodes that cannot trap. The >> second change creates an exception edge for the first bytecode in an >> exception catch clause whether it can trap or not. >> This also adds a GenerateOopMapALot at safeopints to test interpreter oopmap >> generation. Tested JCKs with this option. >> Thanks to @tkrodriguez for the kill003 test. >> Also tested tier1-8. > > Coleen Phillimore has updated the pull request incrementally with two > additional commits since the last revision: > > - Update test/hotspot/jtreg/vmTestbase/nsk/jdb/kill/kill003/kill003a.java > > Co-authored-by: Joel Sikström <[email protected]> > - Sort includes. src/hotspot/share/oops/generateOopMap.cpp line 1201: > 1199: case Bytecodes::_aload_0: > 1200: // These bytecodes can trap for rewriting. We need to assume > that > 1201: // they do not throw exceptions to make the monitor analysis > work. I don't know what this means. Could the first instruction in an exception handler be an aload_0? In which case we want it to be in the exception range. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30171#discussion_r2917971798
