On Wed, 11 Mar 2026 12:11:21 GMT, Coleen Phillimore <[email protected]> wrote:

>> Coleen Phillimore has updated the pull request incrementally with two 
>> additional commits since the last revision:
>> 
>>  - Update test/hotspot/jtreg/vmTestbase/nsk/jdb/kill/kill003/kill003a.java
>>    
>>    Co-authored-by: Joel Sikström <[email protected]>
>>  - Sort includes.
>
> src/hotspot/share/oops/generateOopMap.cpp line 1201:
> 
>> 1199:       case Bytecodes::_aload_0:
>> 1200:         // These bytecodes can trap for rewriting.  We need to assume 
>> that
>> 1201:         // they do not throw exceptions to make the monitor analysis 
>> work.
> 
> I don't know what this means.  Could the first instruction in an exception 
> handler be an aload_0?  In which case we want it to be in the exception range.

The case where aload_0 is the first instruction in a handler would be covered 
by exception_can_trap(), right?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30171#discussion_r2923374509

Reply via email to