On Thu, 12 Mar 2026 15:38:09 GMT, Roman Kennke <[email protected]> wrote:
>> Thomas Stuefe has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 65 commits: >> >> - Merge branch 'master' into JDK-8363996-Obsolete-UseCompressedClassPointers >> - Replace Metaspace::using_class_space with define >> - Update src/hotspot/cpu/x86/macroAssembler_x86.hpp >> >> Co-authored-by: David Holmes >> <[email protected]> >> - Replace Klass::_metadata union with narrowKlass member >> - Ivan: fix various instances of ObjLayout::undefined should assert >> - Ivan: Update src/hotspot/share/oops/instanceKlass.cpp >> >> Co-authored-by: Ivan Walulya <[email protected]> >> - David: reduce diff in ObjectCountEventVerifier.java >> - David: minimize change in GetObjectSizeIntrinsicsTest.java >> - David: minimize diffs in TestZGCWithCDS.java >> - David: minimize diffs for >> runtime/ErrorHandling/TestVMConfigInHsErrFile.java >> - ... and 55 more: https://git.openjdk.org/jdk/compare/9a26b4af...be3a902b > > src/hotspot/share/memory/metaspace/metaspaceReporter.cpp line 279: > >> 277: >> ChunkManager::chunkmanager_nonclass()->add_to_statistics(&non_class_cm_stat); >> 278: #if INCLUDE_CLASS_SPACE >> 279: >> ChunkManager::chunkmanager_nonclass()->add_to_statistics(&non_class_cm_stat); > > This is pre-existing, but we call > ChunkManager::chunkmanager_nonclass()->add_to_statistics(&non_class_cm_stat) > twice for INCLUDE_CLASS_SPACE. Is this correct for some reason? Otherwise > might be worth fixing while we're here, or file a bug for later. No its a bug. well spotted. > test/hotspot/jtreg/gc/g1/TestSharedArchiveWithPreTouch.java line 69: > >> 67: >> 68: if (Platform.is64bit()) { >> 69: dump_args.addFirst("-XX:+UseCompressedOops" ); > > This should be load_args, right? Yep ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28366#discussion_r2952579138 PR Review Comment: https://git.openjdk.org/jdk/pull/28366#discussion_r2952596867
