On Thu, 12 Mar 2026 15:50:08 GMT, Roman Kennke <[email protected]> wrote:
>> Thomas Stuefe has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 65 commits: >> >> - Merge branch 'master' into JDK-8363996-Obsolete-UseCompressedClassPointers >> - Replace Metaspace::using_class_space with define >> - Update src/hotspot/cpu/x86/macroAssembler_x86.hpp >> >> Co-authored-by: David Holmes >> <[email protected]> >> - Replace Klass::_metadata union with narrowKlass member >> - Ivan: fix various instances of ObjLayout::undefined should assert >> - Ivan: Update src/hotspot/share/oops/instanceKlass.cpp >> >> Co-authored-by: Ivan Walulya <[email protected]> >> - David: reduce diff in ObjectCountEventVerifier.java >> - David: minimize change in GetObjectSizeIntrinsicsTest.java >> - David: minimize diffs in TestZGCWithCDS.java >> - David: minimize diffs for >> runtime/ErrorHandling/TestVMConfigInHsErrFile.java >> - ... and 55 more: https://git.openjdk.org/jdk/compare/9a26b4af...be3a902b > > src/hotspot/cpu/s390/c1_MacroAssembler_s390.cpp line 113: > >> 111: z_st(len, Address(obj, arrayOopDesc::length_offset_in_bytes())); >> 112: } else if (!UseCompactObjectHeaders) { >> 113: store_klass_gap(Rzero, obj); // Zero klass gap for compressed oops. > > The comment has been wrong before and is even more wrong now. The "compressed oops" part? Probably from before JDK15. I'll fix it. > src/hotspot/share/memory/metaspace.cpp line 255: > >> 253: >> 254: #if INCLUDE_CLASS_SPACE >> 255: // If we use compressed class pointers, verify class chunkmanager... > > The comment is a bit redundant or misleading. It should say 'If we use > class-space' but this is perhaps worse, because it only describes in words > what is written in code. So maybe remove it altogether? Comments removed > test/hotspot/jtreg/runtime/cds/appcds/TestZGCWithCDS.java line 118: > >> 116: out.shouldHaveExitValue(0); >> 117: >> 118: System.out.println("6. Run with SerialGC, +UseCompressedOops"); > > The steps numbering is off now. Maybe get rid of the numbering altogether? Or > else make it right. Done > test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/DynamicArchiveTestBase.java > line 309: > >> 307: * - the VM under test was started with a different options than >> the ones >> 308: * when the default CDS archive was built. E.g. the VM was >> started with >> 309: * -XX:+UseZGC which implicitly disables the UseCompressedOoops >> option. > > Suggestion: > > * -XX:+UseZGC which implicitly disables the UseCompressedOops option. Oops. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28366#discussion_r2958313076 PR Review Comment: https://git.openjdk.org/jdk/pull/28366#discussion_r2958325413 PR Review Comment: https://git.openjdk.org/jdk/pull/28366#discussion_r2958318475 PR Review Comment: https://git.openjdk.org/jdk/pull/28366#discussion_r2958327794
